)]}'
{"id":"openstack%2Fpython-novaclient~685983","triplet_id":"openstack%2Fpython-novaclient~stable%2Frocky~I0f9f75cba68e7582d32d4aab2f8f077b4360d386","project":"openstack/python-novaclient","branch":"stable/rocky","topic":"bug/1845322","hashtags":[],"change_id":"I0f9f75cba68e7582d32d4aab2f8f077b4360d386","subject":"Stop silently ignoring invalid \u0027nova boot --hint\u0027 options","status":"MERGED","created":"2019-10-01 14:38:13.000000000","updated":"2019-10-03 15:05:46.000000000","submitted":"2019-10-03 15:04:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"685983-1570115073769-39d839bb","meta_rev_id":"54d1066dc855785c827de857c03799e28dbbd39c","_number":685983,"virtual_id_number":685983,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-03 15:04:33.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2019-10-01 23:55:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2019-10-03 08:38:32.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-10-03 13:24:36.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2019-10-03 13:24:36.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-01 23:55:50.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-10-03 08:38:32.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-10-03 13:24:36.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-10-03 15:04:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f532865402af9cae8dd2edd4c521b538082052b4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-10-01 14:38:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7332232b484faedd22bdfd1409a4955f82e38f99","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-10-01 14:55:51.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"0564e12c8c5c14f6ec2041b1d32c4e8080ebcf7f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-10-01 15:00:10.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"46a87da12b4301366fdbb19077be310f4c1040d3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-01 16:39:55.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a73d9997612f4fc0ba8aa54ab05d0f96 : SUCCESS in 4m 34s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5365b2577f5646b588d62b8939cfc319 : SUCCESS in 5m 30s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/6b8bd9eb13e6478bbd159a353bd492bc : SUCCESS in 6m 04s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/08b3587dcf14408d87a41b9672471800 : SUCCESS in 3m 58s\n- tempest-full https://zuul.opendev.org/t/openstack/build/5df2af3fafe0463d863ffdd64f813b16 : SUCCESS in 1h 35m 57s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0e67ed751e3a4228afd6ce413bf5089a : SUCCESS in 4m 52s\n- novaclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/2794234cd2df4a2ab0af2712ba206693 : SUCCESS in 1h 00m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b8541cdb7c074b25bc82273e640726fa : SUCCESS in 4m 48s","accounts_in_message":[],"_revision_number":3},{"id":"74581ce44c0c722aadf8c84d6efe72fe077ebd02","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-10-01 23:55:50.000000000","message":"Patch Set 3: Code-Review+1\n\nClean backport. LGTM.","accounts_in_message":[],"_revision_number":3},{"id":"daea50b086f1973f952d628be064bd56c54d91c9","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-10-03 08:38:32.000000000","message":"Patch Set 3: Code-Review+2\n\nLGTM.","accounts_in_message":[],"_revision_number":3},{"id":"f061751e71f60cc8425de9b1b3018a0a74ac12b2","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-03 13:24:36.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nlgtm","accounts_in_message":[],"_revision_number":3},{"id":"6adc852a6ed2bd855cb80b2d0a20f38941e2c5ac","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 13:24:48.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"bbecc1f835c719d0ba72a9ed01a165e5622fd310","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 15:04:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"ce0a3ee5426c708e87b4a7097be8816db8b40070","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 15:04:33.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8a6513b228a648f4a806358ba6b51a1e : SUCCESS in 4m 09s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b0e2b1bc929a433dab113311501e63e1 : SUCCESS in 3m 47s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/dcad591450b84856ac60589e1a8c4857 : SUCCESS in 4m 32s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/96cd33e3341c4546af85b2bd671d632b : SUCCESS in 4m 12s\n- tempest-full https://zuul.opendev.org/t/openstack/build/aa0050564bd64b5a889830f3141a16b9 : SUCCESS in 1h 33m 47s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/171e530d0371447bb20cfe32a02dfc4e : SUCCESS in 5m 13s\n- novaclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/251348409327418f8f9c9c199384bc73 : SUCCESS in 51m 27s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cd72604f0c524655b27120e4504c846c : SUCCESS in 4m 19s","accounts_in_message":[],"_revision_number":3},{"id":"e952f241500223d6ab32158815eb1d3c17274641","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 15:05:46.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8353d0a246e343298a1dd5eb4c396309 : SUCCESS in 53s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6a38838a412f7b4f7820eb98c82a7ced5299ee44","revisions":{"36ff98f705e08a2a66e71de4a34d59704323889f":{"kind":"REWORK","_number":1,"created":"2019-10-01 14:38:13.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/83/685983/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/83/685983/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/1"}}},"commit":{"parents":[{"commit":"92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d","subject":"Use SHA256 instead of MD5 in completion cache","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-09-25 11:10:21.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-01 14:37:44.000000000","tz":60},"subject":"Stop silently ignoring invalid \u0027nova boot --hint\u0027 options","message":"Stop silently ignoring invalid \u0027nova boot --hint\u0027 options\n\nThe \u0027--hint\u0027 option for \u0027nova boot\u0027 expects a key-value pair like so:\n\n  nova boot --hint group\u003d245e1dfe-2d0e-4139-80a9-fce124948896 ...\n\nHowever, the command doesn\u0027t complain if this isn\u0027t the case, meaning\ntypos like the below aren\u0027t indicated to the user:\n\n  nova boot --hint 245e1dfe-2d0e-4139-80a9-fce124948896\n\nDue to how we\u0027d implemented this here, this ultimately results in us\nPOSTing the following as part of the body to \u0027os-servers\u0027:\n\n  {\n    ...\n    \"OS-SCH-HNT:scheduler_hints\": {\n      \"245e1dfe-2d0e-4139-80a9-fce124948896\": null\n    }\n    ...\n  }\n\nWhich is unfortunately allowed and ignored by nova due to the use of\n\u0027additionalProperties\u0027 in the schema [1]\n\nDo what we do for loads of other options and explicitly fail on invalid\nvalues.\n\n[1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146\n\nChange-Id: I0f9f75cba68e7582d32d4aab2f8f077b4360d386\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1845322\n(cherry picked from commit 6954aacd54e85859fecde22ac04db1ce7601dd35)\n(cherry picked from commit 5ab4fd1e9d84cbe40d8075682c90a12ca4865e4d)\n(cherry picked from commit 7607b85db9ea5454d35834edf2fe74e5f5368a59)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/36ff98f705e08a2a66e71de4a34d59704323889f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/36ff98f705e08a2a66e71de4a34d59704323889f"}]},"branch":"refs/heads/stable/rocky"},"b450fdc5e02a8d22900b50fac70024e48796bb08":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-10-01 14:55:51.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/83/685983/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/83/685983/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/2"}}},"commit":{"parents":[{"commit":"92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d","subject":"Use SHA256 instead of MD5 in completion cache","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-09-25 11:10:21.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-01 14:55:42.000000000","tz":60},"subject":"Stop silently ignoring invalid \u0027nova boot --hint\u0027 options","message":"Stop silently ignoring invalid \u0027nova boot --hint\u0027 options\n\nThe \u0027--hint\u0027 option for \u0027nova boot\u0027 expects a key-value pair like so:\n\n  nova boot --hint group\u003d245e1dfe-2d0e-4139-80a9-fce124948896 ...\n\nHowever, the command doesn\u0027t complain if this isn\u0027t the case, meaning\ntypos like the below aren\u0027t indicated to the user:\n\n  nova boot --hint 245e1dfe-2d0e-4139-80a9-fce124948896\n\nDue to how we\u0027d implemented this here, this ultimately results in us\nPOSTing the following as part of the body to \u0027os-servers\u0027:\n\n  {\n    ...\n    \"OS-SCH-HNT:scheduler_hints\": {\n      \"245e1dfe-2d0e-4139-80a9-fce124948896\": null\n    }\n    ...\n  }\n\nWhich is unfortunately allowed and ignored by nova due to the use of\n\u0027additionalProperties\u0027 in the schema [1]\n\nDo what we do for loads of other options and explicitly fail on invalid\nvalues.\n\nNOTE(stephenfin): This includes the release note first added separately\nin change I753e9a0cda1e118578373c519cf2fb2dd605a623.\n\n[1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146\n\nChange-Id: I0f9f75cba68e7582d32d4aab2f8f077b4360d386\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1845322\n(cherry picked from commit 6954aacd54e85859fecde22ac04db1ce7601dd35)\n(cherry picked from commit fe889e3935fd3962b4d226b8a15e8c51614a6e32)\n(cherry picked from commit c7c04dd728eaf79e1ebac7f2992d224b4c518f4f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b450fdc5e02a8d22900b50fac70024e48796bb08"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/b450fdc5e02a8d22900b50fac70024e48796bb08"}]},"branch":"refs/heads/stable/rocky"},"6a38838a412f7b4f7820eb98c82a7ced5299ee44":{"kind":"REWORK","_number":3,"created":"2019-10-01 15:00:10.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/83/685983/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/83/685983/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/83/685983/3"}}},"commit":{"parents":[{"commit":"92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d","subject":"Use SHA256 instead of MD5 in completion cache","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/92002c8046ea5f575bb8a7ed6f4e6a8a29fad22d"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-09-25 11:10:21.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-01 14:59:44.000000000","tz":60},"subject":"Stop silently ignoring invalid \u0027nova boot --hint\u0027 options","message":"Stop silently ignoring invalid \u0027nova boot --hint\u0027 options\n\nThe \u0027--hint\u0027 option for \u0027nova boot\u0027 expects a key-value pair like so:\n\n  nova boot --hint group\u003d245e1dfe-2d0e-4139-80a9-fce124948896 ...\n\nHowever, the command doesn\u0027t complain if this isn\u0027t the case, meaning\ntypos like the below aren\u0027t indicated to the user:\n\n  nova boot --hint 245e1dfe-2d0e-4139-80a9-fce124948896\n\nDue to how we\u0027d implemented this here, this ultimately results in us\nPOSTing the following as part of the body to \u0027os-servers\u0027:\n\n  {\n    ...\n    \"OS-SCH-HNT:scheduler_hints\": {\n      \"245e1dfe-2d0e-4139-80a9-fce124948896\": null\n    }\n    ...\n  }\n\nWhich is unfortunately allowed and ignored by nova due to the use of\n\u0027additionalProperties\u0027 in the schema [1]\n\nDo what we do for loads of other options and explicitly fail on invalid\nvalues.\n\nNOTE(stephenfin): This includes the release note first added separately\nin change I753e9a0cda1e118578373c519cf2fb2dd605a623.\n\n[1] https://github.com/openstack/nova/blob/19.0.0/nova/api/openstack/compute/schemas/servers.py#L142-L146\n\nChange-Id: I0f9f75cba68e7582d32d4aab2f8f077b4360d386\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1845322\n(cherry picked from commit 6954aacd54e85859fecde22ac04db1ce7601dd35)\n(cherry picked from commit 33627242e8f845934bcc5affb616108a79d28cbe)\n(cherry picked from commit c7e793c22e72d4d426a6d10e9c2cfa426fedd365)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6a38838a412f7b4f7820eb98c82a7ced5299ee44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/6a38838a412f7b4f7820eb98c82a7ced5299ee44"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
