)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"65e61b7f6db41e22eb915b32ab48b90310384e3d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brin Zhang \u003czhangbailin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-15 07:33:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional test for migration-list in v2.80"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3cfe37b412971dfff4b217fc7cc6cfdf1b118ce0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_0eebba12","line":7,"updated":"2019-10-15 14:05:11.000000000","message":"Please add a paragraph explaining the purpose of this change.","commit_id":"d8cf4be0e67372a550c1b6830ba8db9bd7ac7ce5"}],"novaclient/tests/functional/v2/test_migrations.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"65e61b7f6db41e22eb915b32ab48b90310384e3d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertNotIn(server_id, migrations)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Listing migrations with v2.80 and make sure there are the User ID"},{"line_number":104,"context_line":"        # and Project ID values in the output."},{"line_number":105,"context_line":"        migrations \u003d self.nova(\u0027migration-list\u0027,"},{"line_number":106,"context_line":"                               flags\u003d\u0027--os-compute-api-version 2.80\u0027)"},{"line_number":107,"context_line":"        user_id \u003d self._get_column_value_from_single_row_table("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ee417e0b","line":104,"updated":"2019-10-15 14:05:11.000000000","message":"Honestly, I\u0027m tempted to suggest that this be pulled out into a separate test method, rather than just adding it to an existing one.  Is there some reason you chose to add it here rather than creating another method?","commit_id":"d8cf4be0e67372a550c1b6830ba8db9bd7ac7ce5"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"f658f213042b450daa5d59345131d5b10f1833d0","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self.assertNotIn(server_id, migrations)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Listing migrations with v2.80 and make sure there are the User ID"},{"line_number":104,"context_line":"        # and Project ID values in the output."},{"line_number":105,"context_line":"        migrations \u003d self.nova(\u0027migration-list\u0027,"},{"line_number":106,"context_line":"                               flags\u003d\u0027--os-compute-api-version 2.80\u0027)"},{"line_number":107,"context_line":"        user_id \u003d self._get_column_value_from_single_row_table("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_af5124db","line":104,"in_reply_to":"3fa7e38b_ee417e0b","updated":"2019-10-17 02:16:23.000000000","message":"Obtaining the migrations of the server requires a migration action, which creates unnecessary code redundancy and is therefore added to this method.\n\nIn addition, Matt added this functional test is also a small version of the migraton api sort by microversion, followed by 2.80, I think it is ok here.","commit_id":"d8cf4be0e67372a550c1b6830ba8db9bd7ac7ce5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b535e296379f668913a4e524daf8d82ada3a9cf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fa7e38b_31612306","line":113,"updated":"2019-10-16 14:03:29.000000000","message":"How about also listing and showing the migration for the server using 2.80 so we can see the user id and project id output in those as well?","commit_id":"d8cf4be0e67372a550c1b6830ba8db9bd7ac7ce5"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b36f982942a0476063ba0a96538b0237f32f7738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fa7e38b_43aba786","line":113,"in_reply_to":"3fa7e38b_31612306","updated":"2019-10-17 10:37:54.000000000","message":"The server-migration-list/show only list or show the in-progress live migration server, and how to keep the server in-progress live migration? is there any parameter can support this in \"nova live-migration\" CLI?","commit_id":"d8cf4be0e67372a550c1b6830ba8db9bd7ac7ce5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b04c6682d7bb35345d43676cecd454876563a6c5","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_server_migration_list(self):"},{"line_number":115,"context_line":"        server_id \u003d self._create_server(flavor\u003dself.flavor.id).id"},{"line_number":116,"context_line":"        # TODO(brinzhang): How to keep the server in-progress"},{"line_number":117,"context_line":"        # live migrations?"},{"line_number":118,"context_line":"        self.nova(\u0027live-migration\u0027, params\u003dserver_id)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_c466beef","line":116,"updated":"2019-10-17 12:52:20.000000000","message":"We can\u0027t do those since (1) this doesn\u0027t run in a 2 node job for live migration and (2) they are non-deterministic so we can\u0027t reliably test those here anyway.","commit_id":"13c46035c3caf7dc9a9d5070aabb56366bb7c93d"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"624284c76459d7c6636faa0086d626b68a52750b","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_server_migration_list(self):"},{"line_number":115,"context_line":"        server_id \u003d self._create_server(flavor\u003dself.flavor.id).id"},{"line_number":116,"context_line":"        # TODO(brinzhang): How to keep the server in-progress"},{"line_number":117,"context_line":"        # live migrations?"},{"line_number":118,"context_line":"        self.nova(\u0027live-migration\u0027, params\u003dserver_id)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_2480f246","line":116,"in_reply_to":"3fa7e38b_c466beef","updated":"2019-10-17 12:55:16.000000000","message":"Yup, got it.","commit_id":"13c46035c3caf7dc9a9d5070aabb56366bb7c93d"}]}