)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5e1509cbdd70d3ad6da3aaf089830f814bc0fd67","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Note that this does not include a test for this method as it appears"},{"line_number":14,"context_line":"that the find_image() method on which it is based is not tested"},{"line_number":15,"context_line":"independently. The subsequent patch introduces a use of this that"},{"line_number":16,"context_line":"verifies the behavior."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I1c6ce27b65920356df6b7001c581a2922765ce0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_ab1c9b77","line":16,"updated":"2019-10-18 16:18:07.000000000","message":"This feels bad, of course. I\u0027m not super familiar with the practices here in client land, so if anyone has suggestions about whether or not I should write a unit test for find_images(), please let me know where.","commit_id":"558a84767f55594770b49c9ddf5ae870559b569e"}],"novaclient/v2/images.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"a75fa152ff64289c97b144ceb73aabfdf7b20f8c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            matches.extend(self._list(\u0027/v2/images?names\u003din:%s\u0027 % \u0027,\u0027.join("},{"line_number":86,"context_line":"                names_or_ids), \u0027images\u0027))"},{"line_number":87,"context_line":"            missed \u003d (set(names_or_ids) -"},{"line_number":88,"context_line":"                      set(m.name for m in matches) -"},{"line_number":89,"context_line":"                      set(m.id for m in matches))"},{"line_number":90,"context_line":"            if missed:"},{"line_number":91,"context_line":"                msg \u003d _(\"Unable to find image(s): %(images)s\") % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e0306da1","line":88,"updated":"2019-10-18 17:45:48.000000000","message":"As an FYI, you could use the set comprehension syntax here:\n\n    {m.name for m in matches}","commit_id":"558a84767f55594770b49c9ddf5ae870559b569e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8d2fc5bf9c9584d5b86fbebba6fe3e3852dc3722","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            matches.extend(self._list(\u0027/v2/images?names\u003din:%s\u0027 % \u0027,\u0027.join("},{"line_number":86,"context_line":"                names_or_ids), \u0027images\u0027))"},{"line_number":87,"context_line":"            missed \u003d (set(names_or_ids) -"},{"line_number":88,"context_line":"                      set(m.name for m in matches) -"},{"line_number":89,"context_line":"                      set(m.id for m in matches))"},{"line_number":90,"context_line":"            if missed:"},{"line_number":91,"context_line":"                msg \u003d _(\"Unable to find image(s): %(images)s\") % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_28ee67ed","line":88,"in_reply_to":"3fa7e38b_33d81def","updated":"2019-10-19 09:48:56.000000000","message":"\u003e Yeah, I\u0027m too old school and see braces as dict syntax :)\n\n+1  :)","commit_id":"558a84767f55594770b49c9ddf5ae870559b569e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1819f44e505edb51a5b5ebe3565b55cd044cee83","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            matches.extend(self._list(\u0027/v2/images?names\u003din:%s\u0027 % \u0027,\u0027.join("},{"line_number":86,"context_line":"                names_or_ids), \u0027images\u0027))"},{"line_number":87,"context_line":"            missed \u003d (set(names_or_ids) -"},{"line_number":88,"context_line":"                      set(m.name for m in matches) -"},{"line_number":89,"context_line":"                      set(m.id for m in matches))"},{"line_number":90,"context_line":"            if missed:"},{"line_number":91,"context_line":"                msg \u003d _(\"Unable to find image(s): %(images)s\") % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_33d81def","line":88,"in_reply_to":"3fa7e38b_e0306da1","updated":"2019-10-18 18:49:36.000000000","message":"Yeah, I\u0027m too old school and see braces as dict syntax :)\n\nHowever, I didn\u0027t write this, Andrey did, I just copied it in here :)","commit_id":"558a84767f55594770b49c9ddf5ae870559b569e"},{"author":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"change_message_id":"d1bd403ed7f3674787f735e710734b4a663d08e2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    additional.append(i)"},{"line_number":101,"context_line":"            if additional:"},{"line_number":102,"context_line":"                msg \u003d _(\u0027Additional images found in response\u0027)"},{"line_number":103,"context_line":"                raise exceptions.ClientException(500, msg)"},{"line_number":104,"context_line":"            return matches"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def list(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_20a765aa","line":103,"updated":"2019-10-18 18:03:55.000000000","message":"Test for this?","commit_id":"e1bb4378db1e5be85a59861c2d473388fa336da8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"df61b493dcde79260a9741a57be652907a63ec37","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    additional.append(i)"},{"line_number":101,"context_line":"            if additional:"},{"line_number":102,"context_line":"                msg \u003d _(\u0027Additional images found in response\u0027)"},{"line_number":103,"context_line":"                raise exceptions.ClientException(500, msg)"},{"line_number":104,"context_line":"            return matches"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def list(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a037d54d","line":103,"in_reply_to":"3fa7e38b_20a765aa","updated":"2019-10-18 18:05:34.000000000","message":"I don\u0027t understand why this is necessary, so I didn\u0027t write a test for it (since I\u0027d have to presumably have a different fake for the glance response which doesn\u0027t seem legit to me). So I\u0027ll let Andrey speak up for why it should be here (he wrote it, I fixed it and copied it in).","commit_id":"e1bb4378db1e5be85a59861c2d473388fa336da8"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0d1a98d960051df476ecce4ee84e579fb66f37d0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    additional.append(i)"},{"line_number":101,"context_line":"            if additional:"},{"line_number":102,"context_line":"                msg \u003d _(\u0027Additional images found in response\u0027)"},{"line_number":103,"context_line":"                raise exceptions.ClientException(500, msg)"},{"line_number":104,"context_line":"            return matches"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def list(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_08c12be5","line":103,"in_reply_to":"3fa7e38b_a037d54d","updated":"2019-10-19 14:26:31.000000000","message":"Given that Andrey gave a +2 for this, I\u0027m inclined to ignore Dustin\u0027s -1 and approve.  Feel free to propose a follow-up change to add a test to cover this case, Dustin :)","commit_id":"e1bb4378db1e5be85a59861c2d473388fa336da8"}]}