)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"2ba7c801de926345192718c642da1fc57e9cf4de","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- cinderclient - I07f04ba5357e0196fe43b510e1d2fff5afa02faa"},{"line_number":15,"context_line":"- glanceclient - I9838391cff7e450f08d27668564b02e63259186c"},{"line_number":16,"context_line":"- keystoneclient - Iedf4e5d753d4278d81751ba0f55fdef3566b56de"},{"line_number":17,"context_line":"- tuskarclient - Iacbf219168fae62d864c6594dd41e0737e848cfa"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Related to blueprint common-client-library-2"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUH%2F9gqA%3D","line":17,"updated":"2014-02-06 12:48:49.000000000","message":"- ironicclient - https://review.openstack.org/#/c/71500","commit_id":"c9892b5c36f5be8febc24dff07ad78b556f6a6df"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"fb42322ef9dc798114937498e54077273460960b","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"OpenStack clients which already use exception from common code:"},{"line_number":13,"context_line":"- ironicclient   - I784007f36dd6a63fc4c77e0d0f0f000e05eb792f"},{"line_number":14,"context_line":"- keystoneclient - Iedf4Ie5d753d4278d81751ba0f55fdef3566b56de"},{"line_number":15,"context_line":"- saharaclient"},{"line_number":16,"context_line":"- tuskarclient   - Iacbf219168fae62d864c6594dd41e0737e848cfa"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAXX%2F%2F5oo%3D","line":14,"updated":"2014-04-25 12:48:27.000000000","message":"Gerrit broke its autolinking here :(","commit_id":"00aa0b75a7edfe29f91d81c36331b2afbdd20b03"}],"novaclient/exceptions.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3198fd0549d9b23393fd708db685228bc9bca16c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"Exception definitions."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from novaclient.openstack.common.apiclient.exceptions import *  # noqa"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BLOc%3D","line":17,"updated":"2014-01-29 12:40:22.000000000","message":"this looks like it is missing import six","commit_id":"302159077619a4adf7f75b16600ce05870fa928d"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0779d9e917c468832f2ad691ca9e114adce5b061","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"Exception definitions."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from novaclient.openstack.common.apiclient.exceptions import *  # noqa"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BLG4%3D","line":17,"in_reply_to":"AAAAUH%2F%2BLOc%3D","updated":"2014-01-29 13:05:50.000000000","message":"You are right.\nFixed","commit_id":"302159077619a4adf7f75b16600ce05870fa928d"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"e95f7eb79794d74cb9e48ed89f460969fd85b439","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from novaclient.openstack.common.apiclient.exceptions import *  # noqa"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class NoTokenLookupException(ClientException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F99Rg%3D","line":24,"updated":"2014-01-31 17:26:18.000000000","message":"Is novaclient to be the first client library that uses openstack.common.apiclient.exceptions?","commit_id":"28b4ccbd2a7d9f26591e7088249b794a6940aefd"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"41ba6180972ab316ea0014673b9fe31e8b505151","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from novaclient.openstack.common.apiclient.exceptions import *  # noqa"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class NoTokenLookupException(ClientException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9uvQ%3D","line":24,"in_reply_to":"AAAAUH%2F90kI%3D","updated":"2014-02-04 15:52:23.000000000","message":"Done","commit_id":"28b4ccbd2a7d9f26591e7088249b794a6940aefd"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"4708c20dbc11a8b6bd84623dd4e8861ce692b28a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from novaclient.openstack.common.apiclient.exceptions import *  # noqa"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class NoTokenLookupException(ClientException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F90kI%3D","line":24,"in_reply_to":"AAAAUH%2F96gc%3D","updated":"2014-02-03 16:33:04.000000000","message":"Could you provide links to those patches, please?  I\u0027d like to keep an eye on them and see what comments reviewers have.  (I believe Gerrit would have converted your change IDs into search links if they were the full change ID, but you\u0027ve only included abbreviations, which it can\u0027t convert.)\n\nAnd actually, while you\u0027re at it, I would appreciate it if you could include the links in your commit message…","commit_id":"28b4ccbd2a7d9f26591e7088249b794a6940aefd"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"73e68fa5358475439e173d36e9a337d4e284580a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from novaclient.openstack.common.apiclient.exceptions import *  # noqa"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class NoTokenLookupException(ClientException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F96gc%3D","line":24,"in_reply_to":"AAAAUH%2F99Rg%3D","updated":"2014-02-01 10:40:34.000000000","message":"I think, only tuskarclient uses exceptions from oslo in this moment. But we already have patches to :\n* cinderclient - I07f04ba5\n* novaclient - this patch\n* keystoneclient - Iedf4e5d7\n\nIn near future you\u0027ll be able to find similar patches in other clients.","commit_id":"28b4ccbd2a7d9f26591e7088249b794a6940aefd"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"17a61d0eeae730b55e31feaa3389b2046666c193","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from novaclient.openstack.common.apiclient.exceptions import *  # noqa"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class NoTokenLookupException(ClientException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2BZGI%3D","line":24,"updated":"2014-02-21 13:07:46.000000000","message":"I think I\u0027d rather not add this ...","commit_id":"c9892b5c36f5be8febc24dff07ad78b556f6a6df"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b2d754c9839999c97566ea9120ef8994885876a1","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from novaclient.openstack.common.apiclient.exceptions import *  # noqa"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class NoTokenLookupException(ClientException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAU3%2F%2F4Q4%3D","line":24,"in_reply_to":"AAAAUX%2F%2BZGI%3D","updated":"2014-02-24 10:25:45.000000000","message":"This line is needed. Several project importing this module(for example, horizon [1] and tempest [2]), so if we remove it, they will be broken.\n\nActually that\u0027s why I suggested to use exceptions from external lib(webob.exc or something else)[3].\n\n[1] - https://github.com/openstack/horizon/blob/master/openstack_dashboard/exceptions.py\n\n[2] - https://github.com/openstack/tempest/blob/master/tempest/scenario/manager.py#L31\n\n[3] - https://review.openstack.org/#/c/71916","commit_id":"c9892b5c36f5be8febc24dff07ad78b556f6a6df"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"05d99326f2a013bda57c28e0d035724c33699713","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            raise exception_from_response(resp, rest.text)"},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":"    kwargs \u003d {"},{"line_number":53,"context_line":"        \u0027http_status\u0027: response.status_code,"},{"line_number":54,"context_line":"        \u0027method\u0027: method,"},{"line_number":55,"context_line":"        \u0027url\u0027: url,"},{"line_number":56,"context_line":"        \u0027request_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F3U0%3D","line":53,"updated":"2014-02-10 10:06:07.000000000","message":"Most arguments in kwargs, which we put into exceptions don\u0027t used at all. Status code of response is used only to find appropriate exceptions. In process of using exceptions from common code it would be nice if kwargs will stored in exceptions by one way with similar names in all clients.","commit_id":"c9892b5c36f5be8febc24dff07ad78b556f6a6df"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"495a9ff9887466f9e41f06c0a5d0de59fdc0a64e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            raise exception_from_response(resp, rest.text)"},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":"    kwargs \u003d {"},{"line_number":53,"context_line":"        \u0027http_status\u0027: response.status_code,"},{"line_number":54,"context_line":"        \u0027method\u0027: method,"},{"line_number":55,"context_line":"        \u0027url\u0027: url,"},{"line_number":56,"context_line":"        \u0027request_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F6ds%3D","line":53,"updated":"2014-02-09 23:58:43.000000000","message":"Why the change here?  It looks like it could break code using this library?","commit_id":"c9892b5c36f5be8febc24dff07ad78b556f6a6df"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"15002ade9585b672d8232cfbb92c6bdf22c058c4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            raise exception_from_response(resp, rest.text)"},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    kwargs \u003d {"},{"line_number":70,"context_line":"        \u0027http_status\u0027: response.status_code,"},{"line_number":71,"context_line":"        \u0027method\u0027: method,"},{"line_number":72,"context_line":"        \u0027url\u0027: url,"},{"line_number":73,"context_line":"        \u0027request_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"facab960_363770b2","line":70,"updated":"2014-04-28 22:56:36.000000000","message":"I didn\u0027t understand your earlier comment about changing this from \u0027code\u0027 to \u0027http_status\u0027 -- how would it not break people currently using the from_response function and accessing the \u0027code\u0027 attribute?","commit_id":"3bde9c3f427110dae3480644752f49b79ac66ec5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1221b9a4fc249be919c0e7ac41cc8e6422be5b20","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            raise exception_from_response(resp, rest.text)"},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    kwargs \u003d {"},{"line_number":70,"context_line":"        \u0027http_status\u0027: response.status_code,"},{"line_number":71,"context_line":"        \u0027method\u0027: method,"},{"line_number":72,"context_line":"        \u0027url\u0027: url,"},{"line_number":73,"context_line":"        \u0027request_id\u0027: None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bad4c104_d5c0f67e","line":70,"in_reply_to":"facab960_363770b2","updated":"2014-04-29 08:36:28.000000000","message":"All HTTP Exceptions from original `novaclient.exceptions` already have `http_status` attribute. `http_status` attribute is used for search desired exception class(Line 199).\n\nI can add `code` attribute to exception object, but, imo, this attribute is useless.","commit_id":"3bde9c3f427110dae3480644752f49b79ac66ec5"}]}