)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e1e71e3291f31a6b12a04c07017910d90b5b0d09","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This commit add a new CLI"},{"line_number":10,"context_line":"``nova volume-patch \u003cserver\u003e \u003cdest_volid\u003e \u003cdelete_on_termination\u003e``"},{"line_number":11,"context_line":"to re-config \u0027delete_on_termination\u0027 for an attached volume, that"},{"line_number":12,"context_line":"admin or the operator can decide whether to delete attached volumes"},{"line_number":13,"context_line":"when destroying the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1fc64fb6e6611c92c6b72265e1bf4b32e9c45f0a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_d450930d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":21},"updated":"2020-03-12 11:01:56.000000000","message":"the user","commit_id":"64fee588af5b1d25dfdf8d8dc0638a01f2a23b34"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6d9ac847b2aa7ba6a5de28d0251a194ac83534ef","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to re-config \u0027delete_on_termination\u0027 for an attached volume, that"},{"line_number":12,"context_line":"the user can decide whether to delete attached volumes"},{"line_number":13,"context_line":"when destroying the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1fc64fb6e6611c92c6b72265e1bf4b32e9c45f0a"},{"line_number":16,"context_line":"Blueprint: destroy-instance-with-datavolume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_fcf776d3","line":14,"updated":"2020-03-17 12:51:26.000000000","message":"Depends-On: https://review.opendev.org/#/c/693828/","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e93f20a34b5718f28847263ad122030d0b47ae9d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u0027delete_on_termination\u0027 for an attached volume, that the user can decide"},{"line_number":13,"context_line":"whether to delete attached volumes when destroying the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/711194/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1fc64fb6e6611c92c6b72265e1bf4b32e9c45f0a"},{"line_number":18,"context_line":"Blueprint: destroy-instance-with-datavolume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"df33271e_4eb87729","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":50},"updated":"2020-04-07 11:36:53.000000000","message":"Does this really depend on this change?\n\nThis is still usable by admins until that change lands so I\u0027d think we could just land this novaclient change ahead of these policy changes?","commit_id":"9ed3a20e752b907b2b4c74290fe11250de80f1cc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"36bd1d8c888213239c3cf37d604e163abe28f2a0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u0027delete_on_termination\u0027 for an attached volume, that the user can decide"},{"line_number":13,"context_line":"whether to delete attached volumes when destroying the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/711194/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1fc64fb6e6611c92c6b72265e1bf4b32e9c45f0a"},{"line_number":18,"context_line":"Blueprint: destroy-instance-with-datavolume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"df33271e_427b2bbd","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":50},"in_reply_to":"df33271e_4eb87729","updated":"2020-04-07 12:49:41.000000000","message":"Done","commit_id":"9ed3a20e752b907b2b4c74290fe11250de80f1cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3bef39c0c0a119d867b9ff04e76c63262a03268e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u0027delete_on_termination\u0027 for an attached volume, that the user can decide"},{"line_number":13,"context_line":"whether to delete attached volumes when destroying the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/711194/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1fc64fb6e6611c92c6b72265e1bf4b32e9c45f0a"},{"line_number":18,"context_line":"Blueprint: destroy-instance-with-datavolume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"df33271e_af212150","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":50},"updated":"2020-04-08 09:02:35.000000000","message":"It\u0027s still not clear to me if this really depends on this change or if it would just be nice to have for this be in place.","commit_id":"efa734744d63a5ad345a744a10432f6d139c0df6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"605b2d3b361b5722aa905a4b84909c7e2aac203b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u0027delete_on_termination\u0027 for an attached volume, that the user can decide"},{"line_number":13,"context_line":"whether to delete attached volumes when destroying the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/711194/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1fc64fb6e6611c92c6b72265e1bf4b32e9c45f0a"},{"line_number":18,"context_line":"Blueprint: destroy-instance-with-datavolume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"df33271e_efacc98d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":50},"in_reply_to":"df33271e_af212150","updated":"2020-04-08 09:11:16.000000000","message":"IT\u0027s not needed. We can drop this now, IMO","commit_id":"efa734744d63a5ad345a744a10432f6d139c0df6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93cfc110d5ec265038436ccf57fefdf09f8f2da2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Microversion 2.85: Change volume-update CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add a new CLI"},{"line_number":10,"context_line":"``nova volume-update [--delete-on-termination \u003cdelete-on-termination\u003e]"},{"line_number":11,"context_line":"\u003cserver\u003e \u003cvolume_id\u003e \u003cdelete_on_termination\u003e`` to update"},{"line_number":12,"context_line":"\u0027delete_on_termination\u0027 for an attached volume, that the user can decide"},{"line_number":13,"context_line":"whether to delete attached volumes when destroying the server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"df33271e_6c72744b","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":70},"updated":"2020-04-08 17:09:06.000000000","message":"This isn\u0027t true any more:\n\n  [--[no-]delete-on-termination]","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e600725d953d7bb7099274a2bf8eb3880c411411","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Microversion 2.85: Change volume-update CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit add a new CLI"},{"line_number":10,"context_line":"``nova volume-update [--delete-on-termination \u003cdelete-on-termination\u003e]"},{"line_number":11,"context_line":"\u003cserver\u003e \u003cvolume_id\u003e \u003cdelete_on_termination\u003e`` to update"},{"line_number":12,"context_line":"\u0027delete_on_termination\u0027 for an attached volume, that the user can decide"},{"line_number":13,"context_line":"whether to delete attached volumes when destroying the server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"df33271e_60bf0caa","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":70},"in_reply_to":"df33271e_6c72744b","updated":"2020-04-09 00:24:26.000000000","message":"Done","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"}],"doc/source/cli/nova.rst":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"10ea8f295339d67e587675c89701bb2c27bec799","unresolved":false,"context_lines":[{"line_number":3961,"context_line":""},{"line_number":3962,"context_line":"**Optional arguments:**"},{"line_number":3963,"context_line":""},{"line_number":3964,"context_line":"``--delete-on-termination``"},{"line_number":3965,"context_line":"  \u0027True\u0027 or \u0027False\u0027. Specify if the attached volume sholud be deleted when"},{"line_number":3966,"context_line":"  the server is destroyed. (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3967,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"df33271e_326fd9fc","line":3964,"range":{"start_line":3964,"start_character":2,"end_line":3964,"end_character":25},"updated":"2020-04-01 12:33:42.000000000","message":"s/--delete-on-termination/--delete-on-termination \u003cdelete-on-termination\u003e/","commit_id":"59a674a59794aca3652bb5f2d158c35004742a9a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f12cdf02c07a59e8452d8db6ce3060deacf3a39","unresolved":false,"context_lines":[{"line_number":3961,"context_line":""},{"line_number":3962,"context_line":"**Optional arguments:**"},{"line_number":3963,"context_line":""},{"line_number":3964,"context_line":"``--delete-on-termination \u003cdelete-on-termination\u003e``"},{"line_number":3965,"context_line":"  \u0027True\u0027 or \u0027False\u0027. Specify if the attached volume sholud be deleted when"},{"line_number":3966,"context_line":"  the server is destroyed. (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3967,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df33271e_23a885d9","line":3964,"range":{"start_line":3964,"start_character":0,"end_line":3964,"end_character":51},"updated":"2020-04-08 14:18:12.000000000","message":"Instead of doing this, can we do a boolean option?\n\n  --delete-on-termination\n  --no-delete-on-termination\n\nSee [1] for an example.\n\n[1] https://review.opendev.org/#/c/718349/","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fcb0183fca81f0e841ab1d51b5540c5054083363","unresolved":false,"context_lines":[{"line_number":3961,"context_line":""},{"line_number":3962,"context_line":"**Optional arguments:**"},{"line_number":3963,"context_line":""},{"line_number":3964,"context_line":"``--delete-on-termination \u003cdelete-on-termination\u003e``"},{"line_number":3965,"context_line":"  \u0027True\u0027 or \u0027False\u0027. Specify if the attached volume sholud be deleted when"},{"line_number":3966,"context_line":"  the server is destroyed. (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3967,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"df33271e_0ca5a804","line":3964,"range":{"start_line":3964,"start_character":0,"end_line":3964,"end_character":51},"in_reply_to":"df33271e_23a885d9","updated":"2020-04-08 16:57:16.000000000","message":"Done","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f12cdf02c07a59e8452d8db6ce3060deacf3a39","unresolved":false,"context_lines":[{"line_number":3962,"context_line":"**Optional arguments:**"},{"line_number":3963,"context_line":""},{"line_number":3964,"context_line":"``--delete-on-termination \u003cdelete-on-termination\u003e``"},{"line_number":3965,"context_line":"  \u0027True\u0027 or \u0027False\u0027. Specify if the attached volume sholud be deleted when"},{"line_number":3966,"context_line":"  the server is destroyed. (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3967,"context_line":""},{"line_number":3968,"context_line":".. _nova_bash-completion:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"df33271e_437029a6","line":3965,"range":{"start_line":3965,"start_character":52,"end_line":3965,"end_character":58},"updated":"2020-04-08 14:18:12.000000000","message":"should","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fcb0183fca81f0e841ab1d51b5540c5054083363","unresolved":false,"context_lines":[{"line_number":3962,"context_line":"**Optional arguments:**"},{"line_number":3963,"context_line":""},{"line_number":3964,"context_line":"``--delete-on-termination \u003cdelete-on-termination\u003e``"},{"line_number":3965,"context_line":"  \u0027True\u0027 or \u0027False\u0027. Specify if the attached volume sholud be deleted when"},{"line_number":3966,"context_line":"  the server is destroyed. (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3967,"context_line":""},{"line_number":3968,"context_line":".. _nova_bash-completion:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"df33271e_eca7a40a","line":3965,"range":{"start_line":3965,"start_character":52,"end_line":3965,"end_character":58},"in_reply_to":"df33271e_437029a6","updated":"2020-04-08 16:57:16.000000000","message":"Done","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93cfc110d5ec265038436ccf57fefdf09f8f2da2","unresolved":false,"context_lines":[{"line_number":3944,"context_line":""},{"line_number":3945,"context_line":".. code-block:: console"},{"line_number":3946,"context_line":""},{"line_number":3947,"context_line":"   usage: nova volume-update [--delete-on-termination \u003cdelete-on-termination\u003e]"},{"line_number":3948,"context_line":"                             \u003cserver\u003e \u003csrc_volid\u003e \u003cdest_volid\u003e"},{"line_number":3949,"context_line":""},{"line_number":3950,"context_line":"Update the attachment on the server. Migrates the data from an attached volume"}],"source_content_type":"text/x-rst","patch_set":17,"id":"df33271e_0c5c887c","line":3947,"range":{"start_line":3947,"start_character":30,"end_line":3947,"end_character":77},"updated":"2020-04-08 17:09:06.000000000","message":"Replace with\n\n  [--[no-]delete-on-termination]","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e600725d953d7bb7099274a2bf8eb3880c411411","unresolved":false,"context_lines":[{"line_number":3944,"context_line":""},{"line_number":3945,"context_line":".. code-block:: console"},{"line_number":3946,"context_line":""},{"line_number":3947,"context_line":"   usage: nova volume-update [--delete-on-termination \u003cdelete-on-termination\u003e]"},{"line_number":3948,"context_line":"                             \u003cserver\u003e \u003csrc_volid\u003e \u003cdest_volid\u003e"},{"line_number":3949,"context_line":""},{"line_number":3950,"context_line":"Update the attachment on the server. Migrates the data from an attached volume"}],"source_content_type":"text/x-rst","patch_set":17,"id":"df33271e_40a3e89e","line":3947,"range":{"start_line":3947,"start_character":30,"end_line":3947,"end_character":77},"in_reply_to":"df33271e_0c5c887c","updated":"2020-04-09 00:24:26.000000000","message":"Done","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e600725d953d7bb7099274a2bf8eb3880c411411","unresolved":false,"context_lines":[{"line_number":3945,"context_line":".. code-block:: console"},{"line_number":3946,"context_line":""},{"line_number":3947,"context_line":"   usage: nova volume-update [--delete-on-termination \u003cdelete-on-termination\u003e]"},{"line_number":3948,"context_line":"                             \u003cserver\u003e \u003csrc_volid\u003e \u003cdest_volid\u003e"},{"line_number":3949,"context_line":""},{"line_number":3950,"context_line":"Update the attachment on the server. Migrates the data from an attached volume"},{"line_number":3951,"context_line":"to the specified available volume and swaps out the active attachment to the"}],"source_content_type":"text/x-rst","patch_set":17,"id":"df33271e_00fd606d","line":3948,"range":{"start_line":3948,"start_character":56,"end_line":3948,"end_character":61},"updated":"2020-04-09 00:24:26.000000000","message":"volume","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e600725d953d7bb7099274a2bf8eb3880c411411","unresolved":false,"context_lines":[{"line_number":3945,"context_line":".. code-block:: console"},{"line_number":3946,"context_line":""},{"line_number":3947,"context_line":"   usage: nova volume-update [--delete-on-termination \u003cdelete-on-termination\u003e]"},{"line_number":3948,"context_line":"                             \u003cserver\u003e \u003csrc_volid\u003e \u003cdest_volid\u003e"},{"line_number":3949,"context_line":""},{"line_number":3950,"context_line":"Update the attachment on the server. Migrates the data from an attached volume"},{"line_number":3951,"context_line":"to the specified available volume and swaps out the active attachment to the"}],"source_content_type":"text/x-rst","patch_set":17,"id":"df33271e_a00bd48b","line":3948,"range":{"start_line":3948,"start_character":43,"end_line":3948,"end_character":48},"updated":"2020-04-09 00:24:26.000000000","message":"volume","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93cfc110d5ec265038436ccf57fefdf09f8f2da2","unresolved":false,"context_lines":[{"line_number":3964,"context_line":""},{"line_number":3965,"context_line":"**Optional arguments:**"},{"line_number":3966,"context_line":""},{"line_number":3967,"context_line":"``--delete-on-termination \u003cdelete-on-termination\u003e``"},{"line_number":3968,"context_line":"  Specify that the volume should be deleted when the server is destroyed."},{"line_number":3969,"context_line":"  (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3970,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"df33271e_2c9d0c57","line":3967,"range":{"start_line":3967,"start_character":25,"end_line":3967,"end_character":49},"updated":"2020-04-08 17:09:06.000000000","message":"drop","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e600725d953d7bb7099274a2bf8eb3880c411411","unresolved":false,"context_lines":[{"line_number":3964,"context_line":""},{"line_number":3965,"context_line":"**Optional arguments:**"},{"line_number":3966,"context_line":""},{"line_number":3967,"context_line":"``--delete-on-termination \u003cdelete-on-termination\u003e``"},{"line_number":3968,"context_line":"  Specify that the volume should be deleted when the server is destroyed."},{"line_number":3969,"context_line":"  (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3970,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"df33271e_20a06490","line":3967,"range":{"start_line":3967,"start_character":25,"end_line":3967,"end_character":49},"in_reply_to":"df33271e_2c9d0c57","updated":"2020-04-09 00:24:26.000000000","message":"Done","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93cfc110d5ec265038436ccf57fefdf09f8f2da2","unresolved":false,"context_lines":[{"line_number":3968,"context_line":"  Specify that the volume should be deleted when the server is destroyed."},{"line_number":3969,"context_line":"  (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3970,"context_line":""},{"line_number":3971,"context_line":"``--no-delete-on-termination \u003cdelete-on-termination\u003e``"},{"line_number":3972,"context_line":"  Specify that the attached volume should not be deleted when"},{"line_number":3973,"context_line":"  the server is destroyed. (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3974,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"df33271e_8cac188d","line":3971,"range":{"start_line":3971,"start_character":28,"end_line":3971,"end_character":52},"updated":"2020-04-08 17:09:06.000000000","message":"drop","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e600725d953d7bb7099274a2bf8eb3880c411411","unresolved":false,"context_lines":[{"line_number":3968,"context_line":"  Specify that the volume should be deleted when the server is destroyed."},{"line_number":3969,"context_line":"  (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3970,"context_line":""},{"line_number":3971,"context_line":"``--no-delete-on-termination \u003cdelete-on-termination\u003e``"},{"line_number":3972,"context_line":"  Specify that the attached volume should not be deleted when"},{"line_number":3973,"context_line":"  the server is destroyed. (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3974,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"df33271e_80a9707d","line":3971,"range":{"start_line":3971,"start_character":28,"end_line":3971,"end_character":52},"in_reply_to":"df33271e_8cac188d","updated":"2020-04-09 00:24:26.000000000","message":"Done","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9ac9e247246b36bd215fdc8988d5586fb9d762cb","unresolved":false,"context_lines":[{"line_number":3966,"context_line":""},{"line_number":3967,"context_line":"``--delete-on-termination``"},{"line_number":3968,"context_line":"  Specify that the volume should be deleted when the server is destroyed."},{"line_number":3969,"context_line":"  (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3970,"context_line":""},{"line_number":3971,"context_line":"``--no-delete-on-termination``"},{"line_number":3972,"context_line":"  Specify that the attached volume should not be deleted when"}],"source_content_type":"text/x-rst","patch_set":19,"id":"df33271e_5ad0f41f","line":3969,"updated":"2020-04-09 04:17:02.000000000","message":"nit: It would be better to mention the mutual exclusion with \u0027--no-delete-on-termination\u0027.","commit_id":"4d6c70d25df99a4f28f263cd3160c74ccf1343e3"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"994f7b7dd2dfd593d3080433cd229e7f5542d920","unresolved":false,"context_lines":[{"line_number":3966,"context_line":""},{"line_number":3967,"context_line":"``--delete-on-termination``"},{"line_number":3968,"context_line":"  Specify that the volume should be deleted when the server is destroyed."},{"line_number":3969,"context_line":"  (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3970,"context_line":""},{"line_number":3971,"context_line":"``--no-delete-on-termination``"},{"line_number":3972,"context_line":"  Specify that the attached volume should not be deleted when"}],"source_content_type":"text/x-rst","patch_set":19,"id":"df33271e_cd6a767f","line":3969,"in_reply_to":"df33271e_5ad0f41f","updated":"2020-04-10 00:43:50.000000000","message":"Done","commit_id":"4d6c70d25df99a4f28f263cd3160c74ccf1343e3"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9ac9e247246b36bd215fdc8988d5586fb9d762cb","unresolved":false,"context_lines":[{"line_number":3970,"context_line":""},{"line_number":3971,"context_line":"``--no-delete-on-termination``"},{"line_number":3972,"context_line":"  Specify that the attached volume should not be deleted when"},{"line_number":3973,"context_line":"  the server is destroyed. (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3974,"context_line":""},{"line_number":3975,"context_line":".. _nova_bash-completion:"},{"line_number":3976,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"df33271e_3acd3085","line":3973,"updated":"2020-04-09 04:17:02.000000000","message":"ditto","commit_id":"4d6c70d25df99a4f28f263cd3160c74ccf1343e3"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"994f7b7dd2dfd593d3080433cd229e7f5542d920","unresolved":false,"context_lines":[{"line_number":3970,"context_line":""},{"line_number":3971,"context_line":"``--no-delete-on-termination``"},{"line_number":3972,"context_line":"  Specify that the attached volume should not be deleted when"},{"line_number":3973,"context_line":"  the server is destroyed. (Supported by API versions \u00272.85\u0027 - \u00272.latest\u0027)"},{"line_number":3974,"context_line":""},{"line_number":3975,"context_line":".. _nova_bash-completion:"},{"line_number":3976,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"df33271e_ad6732b7","line":3973,"in_reply_to":"df33271e_3acd3085","updated":"2020-04-10 00:43:50.000000000","message":"Done","commit_id":"4d6c70d25df99a4f28f263cd3160c74ccf1343e3"}],"novaclient/base.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e1e71e3291f31a6b12a04c07017910d90b5b0d09","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def _patch(self, url, body, response_key\u003dNone, **kwargs):"},{"line_number":390,"context_line":"        self.run_hooks(\u0027modify_body_for_patch\u0027, body, **kwargs)"},{"line_number":391,"context_line":"        import remote_pdb;remote_pdb.set_trace()"},{"line_number":392,"context_line":"        resp, body \u003d self.api.client.patch(url, body\u003dbody)"},{"line_number":393,"context_line":"        if body:"},{"line_number":394,"context_line":"            if response_key:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_b474f79d","line":391,"range":{"start_line":391,"start_character":8,"end_line":391,"end_character":48},"updated":"2020-03-12 11:01:56.000000000","message":"for debug, will remove in next patch","commit_id":"64fee588af5b1d25dfdf8d8dc0638a01f2a23b34"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6a4ecc0fd74ebfcd8b5f773caa3a9d6e8855b4c7","unresolved":false,"context_lines":[{"line_number":4003,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":4004,"context_line":"                               {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4005,"context_line":""},{"line_number":4006,"context_line":"    def test_volume_update(self):"},{"line_number":4007,"context_line":"        \"\"\"Before microversion 2.85, we should keep the original behavior\"\"\""},{"line_number":4008,"context_line":"        self.run_command(\u0027volume-update sample-server Work Work\u0027,"},{"line_number":4009,"context_line":"                         api_version\u003d\u00272.84\u0027)"},{"line_number":4010,"context_line":"        self.assert_called(\u0027PUT\u0027, \u0027/servers/1234/os-volume_attachments/Work\u0027,"},{"line_number":4011,"context_line":"                           {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4012,"context_line":""},{"line_number":4013,"context_line":"    def test_volume_update_v285(self):"},{"line_number":4014,"context_line":"        self.run_command(\u0027volume-update sample-server --delete-on-termination \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_334ac0ab","line":4011,"range":{"start_line":4006,"start_character":0,"end_line":4011,"end_character":70},"updated":"2020-04-07 11:31:57.000000000","message":"You also want to assert that this doesn\u0027t change in 2.85 without --delete-on-termination right?","commit_id":"9ed3a20e752b907b2b4c74290fe11250de80f1cc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"50c732ccba2ed3e4522cc1a471636e38969ce0b3","unresolved":false,"context_lines":[{"line_number":4003,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":4004,"context_line":"                               {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4005,"context_line":""},{"line_number":4006,"context_line":"    def test_volume_update(self):"},{"line_number":4007,"context_line":"        \"\"\"Before microversion 2.85, we should keep the original behavior\"\"\""},{"line_number":4008,"context_line":"        self.run_command(\u0027volume-update sample-server Work Work\u0027,"},{"line_number":4009,"context_line":"                         api_version\u003d\u00272.84\u0027)"},{"line_number":4010,"context_line":"        self.assert_called(\u0027PUT\u0027, \u0027/servers/1234/os-volume_attachments/Work\u0027,"},{"line_number":4011,"context_line":"                           {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4012,"context_line":""},{"line_number":4013,"context_line":"    def test_volume_update_v285(self):"},{"line_number":4014,"context_line":"        self.run_command(\u0027volume-update sample-server --delete-on-termination \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_ce5be784","line":4011,"range":{"start_line":4006,"start_character":0,"end_line":4011,"end_character":70},"in_reply_to":"df33271e_0e7dcf1b","updated":"2020-04-07 12:01:39.000000000","message":"Because we modified the PUT API, I think we need to test the feature in old microverversion, and it should be ok.","commit_id":"9ed3a20e752b907b2b4c74290fe11250de80f1cc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5afab9f64c082f0fa39c5c52f8833ef1e4f9108e","unresolved":false,"context_lines":[{"line_number":4003,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":4004,"context_line":"                               {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4005,"context_line":""},{"line_number":4006,"context_line":"    def test_volume_update(self):"},{"line_number":4007,"context_line":"        \"\"\"Before microversion 2.85, we should keep the original behavior\"\"\""},{"line_number":4008,"context_line":"        self.run_command(\u0027volume-update sample-server Work Work\u0027,"},{"line_number":4009,"context_line":"                         api_version\u003d\u00272.84\u0027)"},{"line_number":4010,"context_line":"        self.assert_called(\u0027PUT\u0027, \u0027/servers/1234/os-volume_attachments/Work\u0027,"},{"line_number":4011,"context_line":"                           {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4012,"context_line":""},{"line_number":4013,"context_line":"    def test_volume_update_v285(self):"},{"line_number":4014,"context_line":"        self.run_command(\u0027volume-update sample-server --delete-on-termination \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_0e7dcf1b","line":4011,"range":{"start_line":4006,"start_character":0,"end_line":4011,"end_character":70},"in_reply_to":"df33271e_334ac0ab","updated":"2020-04-07 11:57:12.000000000","message":"It was added in L4021","commit_id":"9ed3a20e752b907b2b4c74290fe11250de80f1cc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"36bd1d8c888213239c3cf37d604e163abe28f2a0","unresolved":false,"context_lines":[{"line_number":4003,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":4004,"context_line":"                               {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4005,"context_line":""},{"line_number":4006,"context_line":"    def test_volume_update(self):"},{"line_number":4007,"context_line":"        \"\"\"Before microversion 2.85, we should keep the original behavior\"\"\""},{"line_number":4008,"context_line":"        self.run_command(\u0027volume-update sample-server Work Work\u0027,"},{"line_number":4009,"context_line":"                         api_version\u003d\u00272.84\u0027)"},{"line_number":4010,"context_line":"        self.assert_called(\u0027PUT\u0027, \u0027/servers/1234/os-volume_attachments/Work\u0027,"},{"line_number":4011,"context_line":"                           {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4012,"context_line":""},{"line_number":4013,"context_line":"    def test_volume_update_v285(self):"},{"line_number":4014,"context_line":"        self.run_command(\u0027volume-update sample-server --delete-on-termination \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_e2d07fcc","line":4011,"range":{"start_line":4006,"start_character":0,"end_line":4011,"end_character":70},"in_reply_to":"df33271e_421ccbc0","updated":"2020-04-07 12:49:41.000000000","message":"Done","commit_id":"9ed3a20e752b907b2b4c74290fe11250de80f1cc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"9bd66893f80975f39bfcac7c4538ff239b95d007","unresolved":false,"context_lines":[{"line_number":4003,"context_line":"                           {\u0027volumeAttachment\u0027:"},{"line_number":4004,"context_line":"                               {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4005,"context_line":""},{"line_number":4006,"context_line":"    def test_volume_update(self):"},{"line_number":4007,"context_line":"        \"\"\"Before microversion 2.85, we should keep the original behavior\"\"\""},{"line_number":4008,"context_line":"        self.run_command(\u0027volume-update sample-server Work Work\u0027,"},{"line_number":4009,"context_line":"                         api_version\u003d\u00272.84\u0027)"},{"line_number":4010,"context_line":"        self.assert_called(\u0027PUT\u0027, \u0027/servers/1234/os-volume_attachments/Work\u0027,"},{"line_number":4011,"context_line":"                           {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4012,"context_line":""},{"line_number":4013,"context_line":"    def test_volume_update_v285(self):"},{"line_number":4014,"context_line":"        self.run_command(\u0027volume-update sample-server --delete-on-termination \u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_421ccbc0","line":4011,"range":{"start_line":4006,"start_character":0,"end_line":4011,"end_character":70},"in_reply_to":"df33271e_ce5be784","updated":"2020-04-07 12:39:36.000000000","message":"Sorry my point is that microversion 2.85 should also retain the same behaviour if --delete-on-termination isn\u0027t provided:\n\n    def test_volume_update_swap_v285(self):\n        \"\"\"Microversion 2.85, should also keep the original behaviour\"\"\"\n        self.run_command(\u0027volume-update sample-server Work Work\u0027,\n                         api_version\u003d\u00272.85\u0027)\n        self.assert_called(\u0027PUT\u0027, \u0027/servers/1234/os-volume_attachments/Work\u0027,\n                           {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: \u0027Work\u0027}})","commit_id":"9ed3a20e752b907b2b4c74290fe11250de80f1cc"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7e39ac5fe687c7ae5e97aaa88ab8858a3d27ae15","unresolved":false,"context_lines":[{"line_number":4537,"context_line":"            82,  # There are no version-wrapped shell method changes for this."},{"line_number":4538,"context_line":"            83,  # There are no version-wrapped shell method changes for this."},{"line_number":4539,"context_line":"            84,  # There are no version-wrapped shell method changes for this."},{"line_number":4540,"context_line":"            85,  # Support specifing \u0027delete_on_termination\u0027 to update an"},{"line_number":4541,"context_line":"                 # attached volume."},{"line_number":4542,"context_line":"        ])"},{"line_number":4543,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4544,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":18,"id":"df33271e_c0c7f811","line":4541,"range":{"start_line":4540,"start_character":0,"end_line":4541,"end_character":35},"updated":"2020-04-09 00:36:55.000000000","message":"It should be removed because version-wrapped methods (@api_versions.wraps) are added in novaclient/v2/volumes.py.","commit_id":"4a8eceaf0aa2fd8f00eaf40fe51ee39a227915d4"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"cdc28e1f806d3e0cacb023f343acd1916c8a3c95","unresolved":false,"context_lines":[{"line_number":4537,"context_line":"            82,  # There are no version-wrapped shell method changes for this."},{"line_number":4538,"context_line":"            83,  # There are no version-wrapped shell method changes for this."},{"line_number":4539,"context_line":"            84,  # There are no version-wrapped shell method changes for this."},{"line_number":4540,"context_line":"            85,  # Support specifing \u0027delete_on_termination\u0027 to update an"},{"line_number":4541,"context_line":"                 # attached volume."},{"line_number":4542,"context_line":"        ])"},{"line_number":4543,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4544,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":18,"id":"df33271e_607a6cba","line":4541,"range":{"start_line":4540,"start_character":0,"end_line":4541,"end_character":35},"in_reply_to":"df33271e_c0c7f811","updated":"2020-04-09 00:53:38.000000000","message":"Done","commit_id":"4a8eceaf0aa2fd8f00eaf40fe51ee39a227915d4"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9ac9e247246b36bd215fdc8988d5586fb9d762cb","unresolved":false,"context_lines":[{"line_number":3998,"context_line":"                         api_version\u003d\u00272.84\u0027)"},{"line_number":3999,"context_line":"        self.assert_called(\u0027PUT\u0027, \u0027/servers/1234/os-volume_attachments/Work\u0027,"},{"line_number":4000,"context_line":"                           {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4001,"context_line":""},{"line_number":4002,"context_line":"    def test_volume_update_swap_v285(self):"},{"line_number":4003,"context_line":"        \"\"\"Microversion 2.85, we should also keep the original behavior.\"\"\""},{"line_number":4004,"context_line":"        self.run_command(\u0027volume-update sample-server Work Work\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"df33271e_9a9b9c71","line":4001,"updated":"2020-04-09 04:17:02.000000000","message":"It would be better to add the following error test cases.\n\n* Microversion 2.84 with --delete-on-termination\n* Microversion 2.84 with --no-delete-on-termination","commit_id":"4d6c70d25df99a4f28f263cd3160c74ccf1343e3"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"994f7b7dd2dfd593d3080433cd229e7f5542d920","unresolved":false,"context_lines":[{"line_number":3998,"context_line":"                         api_version\u003d\u00272.84\u0027)"},{"line_number":3999,"context_line":"        self.assert_called(\u0027PUT\u0027, \u0027/servers/1234/os-volume_attachments/Work\u0027,"},{"line_number":4000,"context_line":"                           {\u0027volumeAttachment\u0027: {\u0027volumeId\u0027: \u0027Work\u0027}})"},{"line_number":4001,"context_line":""},{"line_number":4002,"context_line":"    def test_volume_update_swap_v285(self):"},{"line_number":4003,"context_line":"        \"\"\"Microversion 2.85, we should also keep the original behavior.\"\"\""},{"line_number":4004,"context_line":"        self.run_command(\u0027volume-update sample-server Work Work\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"df33271e_4d5786cb","line":4001,"in_reply_to":"df33271e_9a9b9c71","updated":"2020-04-10 00:43:50.000000000","message":"Done","commit_id":"4d6c70d25df99a4f28f263cd3160c74ccf1343e3"}],"novaclient/v2/shell.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6d9ac847b2aa7ba6a5de28d0251a194ac83534ef","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"    metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":2685,"context_line":"    help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2686,"context_line":"@utils.arg("},{"line_number":2687,"context_line":"    \u0027dest_volume\u0027,"},{"line_number":2688,"context_line":"    metavar\u003d\u0027\u003cdest_volid\u003e\u0027,"},{"line_number":2689,"context_line":"    help\u003d_(\u0027ID of the destination volume.\u0027))"},{"line_number":2690,"context_line":"@utils.arg("}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_fc72167c","line":2687,"range":{"start_line":2687,"start_character":5,"end_line":2687,"end_character":16},"updated":"2020-03-17 12:51:26.000000000","message":"volume","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"c28f06df94ac2f4fdd7578f19fe7844a180cfdb8","unresolved":false,"context_lines":[{"line_number":2684,"context_line":"    metavar\u003d\u0027\u003cserver\u003e\u0027,"},{"line_number":2685,"context_line":"    help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2686,"context_line":"@utils.arg("},{"line_number":2687,"context_line":"    \u0027dest_volume\u0027,"},{"line_number":2688,"context_line":"    metavar\u003d\u0027\u003cdest_volid\u003e\u0027,"},{"line_number":2689,"context_line":"    help\u003d_(\u0027ID of the destination volume.\u0027))"},{"line_number":2690,"context_line":"@utils.arg("}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_b547d1bc","line":2687,"range":{"start_line":2687,"start_character":5,"end_line":2687,"end_character":16},"in_reply_to":"1fa4df85_fc72167c","updated":"2020-03-17 15:39:29.000000000","message":"Done","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6d9ac847b2aa7ba6a5de28d0251a194ac83534ef","unresolved":false,"context_lines":[{"line_number":2685,"context_line":"    help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2686,"context_line":"@utils.arg("},{"line_number":2687,"context_line":"    \u0027dest_volume\u0027,"},{"line_number":2688,"context_line":"    metavar\u003d\u0027\u003cdest_volid\u003e\u0027,"},{"line_number":2689,"context_line":"    help\u003d_(\u0027ID of the destination volume.\u0027))"},{"line_number":2690,"context_line":"@utils.arg("},{"line_number":2691,"context_line":"    \u0027delete_on_termination\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_1c6e1296","line":2688,"range":{"start_line":2688,"start_character":14,"end_line":2688,"end_character":24},"updated":"2020-03-17 12:51:26.000000000","message":"volid","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"c28f06df94ac2f4fdd7578f19fe7844a180cfdb8","unresolved":false,"context_lines":[{"line_number":2685,"context_line":"    help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2686,"context_line":"@utils.arg("},{"line_number":2687,"context_line":"    \u0027dest_volume\u0027,"},{"line_number":2688,"context_line":"    metavar\u003d\u0027\u003cdest_volid\u003e\u0027,"},{"line_number":2689,"context_line":"    help\u003d_(\u0027ID of the destination volume.\u0027))"},{"line_number":2690,"context_line":"@utils.arg("},{"line_number":2691,"context_line":"    \u0027delete_on_termination\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_f526a916","line":2688,"range":{"start_line":2688,"start_character":14,"end_line":2688,"end_character":24},"in_reply_to":"1fa4df85_1c6e1296","updated":"2020-03-17 15:39:29.000000000","message":"Instead of volume_id","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6d9ac847b2aa7ba6a5de28d0251a194ac83534ef","unresolved":false,"context_lines":[{"line_number":2686,"context_line":"@utils.arg("},{"line_number":2687,"context_line":"    \u0027dest_volume\u0027,"},{"line_number":2688,"context_line":"    metavar\u003d\u0027\u003cdest_volid\u003e\u0027,"},{"line_number":2689,"context_line":"    help\u003d_(\u0027ID of the destination volume.\u0027))"},{"line_number":2690,"context_line":"@utils.arg("},{"line_number":2691,"context_line":"    \u0027delete_on_termination\u0027,"},{"line_number":2692,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_7c04e6c6","line":2689,"range":{"start_line":2689,"start_character":22,"end_line":2689,"end_character":33},"updated":"2020-03-17 12:51:26.000000000","message":"I\u0027m not sure why we are referring to this as the destination, there\u0027s no migration here. If anything it\u0027s the target volume?","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"c28f06df94ac2f4fdd7578f19fe7844a180cfdb8","unresolved":false,"context_lines":[{"line_number":2686,"context_line":"@utils.arg("},{"line_number":2687,"context_line":"    \u0027dest_volume\u0027,"},{"line_number":2688,"context_line":"    metavar\u003d\u0027\u003cdest_volid\u003e\u0027,"},{"line_number":2689,"context_line":"    help\u003d_(\u0027ID of the destination volume.\u0027))"},{"line_number":2690,"context_line":"@utils.arg("},{"line_number":2691,"context_line":"    \u0027delete_on_termination\u0027,"},{"line_number":2692,"context_line":"    metavar\u003d\u0027\u003cdelete_on_termination\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_757879f7","line":2689,"range":{"start_line":2689,"start_character":22,"end_line":2689,"end_character":33},"in_reply_to":"1fa4df85_7c04e6c6","updated":"2020-03-17 15:39:29.000000000","message":"Yes, target is suitable.","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0e6ac3f62d4ffa793d3bf8f8cb0bcc864732ce33","unresolved":false,"context_lines":[{"line_number":2742,"context_line":"def do_volume_update(cs, args):"},{"line_number":2743,"context_line":"    \"\"\"Update the attachment on the server."},{"line_number":2744,"context_line":""},{"line_number":2745,"context_line":"    Migrates the data from an attached volume to the"},{"line_number":2746,"context_line":"    specified available volume and swaps out the active"},{"line_number":2747,"context_line":"    attachment to the new volume."},{"line_number":2748,"context_line":"    \"\"\""},{"line_number":2749,"context_line":"    kwargs \u003d dict()"},{"line_number":2750,"context_line":"    if (cs.api_version \u003e\u003d api_versions.APIVersion(\u00272.85\u0027) and"},{"line_number":2751,"context_line":"            \u0027delete_on_termination\u0027 in args):"}],"source_content_type":"text/x-python","patch_set":15,"id":"df33271e_c4d56ce7","line":2748,"range":{"start_line":2745,"start_character":0,"end_line":2748,"end_character":1},"updated":"2020-04-08 09:20:40.000000000","message":"This is added to the help text of the CLI so we need to be a bit more detailed to explain what can be done now. Something like:\n\nIf dest_volid is the same as the src_volid then the command migrates the data from the attached volume to the specified available volume and swaps out the active attachment to the new volume. Otherwise it only updates the parameters of the existing attachment.","commit_id":"efa734744d63a5ad345a744a10432f6d139c0df6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5e744d2d0479ef89c4a3d6924daa1d25d6de1537","unresolved":false,"context_lines":[{"line_number":2742,"context_line":"def do_volume_update(cs, args):"},{"line_number":2743,"context_line":"    \"\"\"Update the attachment on the server."},{"line_number":2744,"context_line":""},{"line_number":2745,"context_line":"    Migrates the data from an attached volume to the"},{"line_number":2746,"context_line":"    specified available volume and swaps out the active"},{"line_number":2747,"context_line":"    attachment to the new volume."},{"line_number":2748,"context_line":"    \"\"\""},{"line_number":2749,"context_line":"    kwargs \u003d dict()"},{"line_number":2750,"context_line":"    if (cs.api_version \u003e\u003d api_versions.APIVersion(\u00272.85\u0027) and"},{"line_number":2751,"context_line":"            \u0027delete_on_termination\u0027 in args):"}],"source_content_type":"text/x-python","patch_set":15,"id":"df33271e_415ae9f2","line":2748,"range":{"start_line":2745,"start_character":0,"end_line":2748,"end_character":1},"in_reply_to":"df33271e_c4d56ce7","updated":"2020-04-08 11:00:50.000000000","message":"Yes, we should change this, will update.","commit_id":"efa734744d63a5ad345a744a10432f6d139c0df6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f12cdf02c07a59e8452d8db6ce3060deacf3a39","unresolved":false,"context_lines":[{"line_number":2725,"context_line":"    help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2726,"context_line":"@utils.arg("},{"line_number":2727,"context_line":"    \u0027src_volume\u0027,"},{"line_number":2728,"context_line":"    metavar\u003d\u0027\u003csrc_volid\u003e\u0027,"},{"line_number":2729,"context_line":"    help\u003d_(\u0027ID of the source (original) volume.\u0027))"},{"line_number":2730,"context_line":"@utils.arg("},{"line_number":2731,"context_line":"    \u0027dest_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"df33271e_83dcf174","line":2728,"range":{"start_line":2728,"start_character":14,"end_line":2728,"end_character":23},"updated":"2020-04-08 14:18:12.000000000","message":"src_volume","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fcb0183fca81f0e841ab1d51b5540c5054083363","unresolved":false,"context_lines":[{"line_number":2725,"context_line":"    help\u003d_(\u0027Name or ID of server.\u0027))"},{"line_number":2726,"context_line":"@utils.arg("},{"line_number":2727,"context_line":"    \u0027src_volume\u0027,"},{"line_number":2728,"context_line":"    metavar\u003d\u0027\u003csrc_volid\u003e\u0027,"},{"line_number":2729,"context_line":"    help\u003d_(\u0027ID of the source (original) volume.\u0027))"},{"line_number":2730,"context_line":"@utils.arg("},{"line_number":2731,"context_line":"    \u0027dest_volume\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"df33271e_8cb8982a","line":2728,"range":{"start_line":2728,"start_character":14,"end_line":2728,"end_character":23},"in_reply_to":"df33271e_83dcf174","updated":"2020-04-08 16:57:16.000000000","message":"Done","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f12cdf02c07a59e8452d8db6ce3060deacf3a39","unresolved":false,"context_lines":[{"line_number":2729,"context_line":"    help\u003d_(\u0027ID of the source (original) volume.\u0027))"},{"line_number":2730,"context_line":"@utils.arg("},{"line_number":2731,"context_line":"    \u0027dest_volume\u0027,"},{"line_number":2732,"context_line":"    metavar\u003d\u0027\u003cdest_volid\u003e\u0027,"},{"line_number":2733,"context_line":"    help\u003d_(\u0027ID of the destination volume.\u0027))"},{"line_number":2734,"context_line":"@utils.arg("},{"line_number":2735,"context_line":"    \u0027--delete-on-termination\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"df33271e_03d2a15c","line":2732,"range":{"start_line":2732,"start_character":14,"end_line":2732,"end_character":24},"updated":"2020-04-08 14:18:12.000000000","message":"dest_volume","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fcb0183fca81f0e841ab1d51b5540c5054083363","unresolved":false,"context_lines":[{"line_number":2729,"context_line":"    help\u003d_(\u0027ID of the source (original) volume.\u0027))"},{"line_number":2730,"context_line":"@utils.arg("},{"line_number":2731,"context_line":"    \u0027dest_volume\u0027,"},{"line_number":2732,"context_line":"    metavar\u003d\u0027\u003cdest_volid\u003e\u0027,"},{"line_number":2733,"context_line":"    help\u003d_(\u0027ID of the destination volume.\u0027))"},{"line_number":2734,"context_line":"@utils.arg("},{"line_number":2735,"context_line":"    \u0027--delete-on-termination\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"df33271e_6cb3944e","line":2732,"range":{"start_line":2732,"start_character":14,"end_line":2732,"end_character":24},"in_reply_to":"df33271e_03d2a15c","updated":"2020-04-08 16:57:16.000000000","message":"Done","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f12cdf02c07a59e8452d8db6ce3060deacf3a39","unresolved":false,"context_lines":[{"line_number":2742,"context_line":"def do_volume_update(cs, args):"},{"line_number":2743,"context_line":"    \"\"\"Update the attachment on the server."},{"line_number":2744,"context_line":""},{"line_number":2745,"context_line":"    If dest_volid is the same as the src_volid then the command migrates"},{"line_number":2746,"context_line":"    the data from the attached volume to the specified available volume"},{"line_number":2747,"context_line":"    and swaps out the active attachment to the new volume. Otherwise it"},{"line_number":2748,"context_line":"    only updates the parameters of the existing attachment."}],"source_content_type":"text/x-python","patch_set":16,"id":"df33271e_e3eb3d0f","line":2745,"range":{"start_line":2745,"start_character":7,"end_line":2745,"end_character":17},"updated":"2020-04-08 14:18:12.000000000","message":"dest_volume","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f12cdf02c07a59e8452d8db6ce3060deacf3a39","unresolved":false,"context_lines":[{"line_number":2742,"context_line":"def do_volume_update(cs, args):"},{"line_number":2743,"context_line":"    \"\"\"Update the attachment on the server."},{"line_number":2744,"context_line":""},{"line_number":2745,"context_line":"    If dest_volid is the same as the src_volid then the command migrates"},{"line_number":2746,"context_line":"    the data from the attached volume to the specified available volume"},{"line_number":2747,"context_line":"    and swaps out the active attachment to the new volume. Otherwise it"},{"line_number":2748,"context_line":"    only updates the parameters of the existing attachment."}],"source_content_type":"text/x-python","patch_set":16,"id":"df33271e_43f3090b","line":2745,"range":{"start_line":2745,"start_character":37,"end_line":2745,"end_character":46},"updated":"2020-04-08 14:18:12.000000000","message":"src_volume","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fcb0183fca81f0e841ab1d51b5540c5054083363","unresolved":false,"context_lines":[{"line_number":2742,"context_line":"def do_volume_update(cs, args):"},{"line_number":2743,"context_line":"    \"\"\"Update the attachment on the server."},{"line_number":2744,"context_line":""},{"line_number":2745,"context_line":"    If dest_volid is the same as the src_volid then the command migrates"},{"line_number":2746,"context_line":"    the data from the attached volume to the specified available volume"},{"line_number":2747,"context_line":"    and swaps out the active attachment to the new volume. Otherwise it"},{"line_number":2748,"context_line":"    only updates the parameters of the existing attachment."}],"source_content_type":"text/x-python","patch_set":16,"id":"df33271e_cc83c055","line":2745,"range":{"start_line":2745,"start_character":37,"end_line":2745,"end_character":46},"in_reply_to":"df33271e_43f3090b","updated":"2020-04-08 16:57:16.000000000","message":"Done","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fcb0183fca81f0e841ab1d51b5540c5054083363","unresolved":false,"context_lines":[{"line_number":2742,"context_line":"def do_volume_update(cs, args):"},{"line_number":2743,"context_line":"    \"\"\"Update the attachment on the server."},{"line_number":2744,"context_line":""},{"line_number":2745,"context_line":"    If dest_volid is the same as the src_volid then the command migrates"},{"line_number":2746,"context_line":"    the data from the attached volume to the specified available volume"},{"line_number":2747,"context_line":"    and swaps out the active attachment to the new volume. Otherwise it"},{"line_number":2748,"context_line":"    only updates the parameters of the existing attachment."}],"source_content_type":"text/x-python","patch_set":16,"id":"df33271e_ac863c64","line":2745,"range":{"start_line":2745,"start_character":7,"end_line":2745,"end_character":17},"in_reply_to":"df33271e_e3eb3d0f","updated":"2020-04-08 16:57:16.000000000","message":"Done","commit_id":"cc1cbd91072bf1d361607a33f2b780bf54179912"}],"novaclient/v2/volumes.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6b9d5666eb43e74b52999d9f3704f0a79d9cd3c9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                            (server_id, src_volid,),"},{"line_number":125,"context_line":"                            body, \"volumeAttachment\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def patch_server_volume(self, server_id, dest_volid,"},{"line_number":128,"context_line":"                            delete_on_termination):"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        Re-config \u0027delete_on_termination\u0027 for an attached volume, that allows"},{"line_number":131,"context_line":"        the operator to choose whether to delete the attached volume when the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_1f5a844f","line":128,"range":{"start_line":127,"start_character":4,"end_line":128,"end_character":51},"updated":"2020-03-17 13:45:34.000000000","message":"it should be wrapped with `@api_versions.wraps(\"2.83\")`","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"48f84e5f067c17808cef2df5bcce8acfc1855c0c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                            (server_id, src_volid,),"},{"line_number":125,"context_line":"                            body, \"volumeAttachment\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def patch_server_volume(self, server_id, dest_volid,"},{"line_number":128,"context_line":"                            delete_on_termination):"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        Re-config \u0027delete_on_termination\u0027 for an attached volume, that allows"},{"line_number":131,"context_line":"        the operator to choose whether to delete the attached volume when the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_4f3129a2","line":128,"range":{"start_line":127,"start_character":4,"end_line":128,"end_character":51},"in_reply_to":"1fa4df85_10f4b386","updated":"2020-03-17 16:39:24.000000000","message":"`api_versions.wraps` is not only about resolving conflicts between several microversions that implements the similar methods, it is also about preventing to call Nova API when novaclient is initialized with an unsupported version.","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"c28f06df94ac2f4fdd7578f19fe7844a180cfdb8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                            (server_id, src_volid,),"},{"line_number":125,"context_line":"                            body, \"volumeAttachment\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def patch_server_volume(self, server_id, dest_volid,"},{"line_number":128,"context_line":"                            delete_on_termination):"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        Re-config \u0027delete_on_termination\u0027 for an attached volume, that allows"},{"line_number":131,"context_line":"        the operator to choose whether to delete the attached volume when the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_10f4b386","line":128,"range":{"start_line":127,"start_character":4,"end_line":128,"end_character":51},"in_reply_to":"1fa4df85_1f5a844f","updated":"2020-03-17 15:39:29.000000000","message":"This function is the only one in VolumeManager, and I think it\u0027s not necessary to add @api_versions.wraps(\"2.83\") to limit the microversion, otherwise there is an another microversion need to be added, I think that should be wrapped @api_versions.wraps(\"2.93\").\n\nOf course, adding @ api_versions.wraps (\"2.83\") is no problem, and if you insist, I can add this.","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"13505147b06ceedff02b7747474552456f98ea14","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                            (server_id, src_volid,),"},{"line_number":125,"context_line":"                            body, \"volumeAttachment\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def patch_server_volume(self, server_id, dest_volid,"},{"line_number":128,"context_line":"                            delete_on_termination):"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        Re-config \u0027delete_on_termination\u0027 for an attached volume, that allows"},{"line_number":131,"context_line":"        the operator to choose whether to delete the attached volume when the"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_9840c037","line":128,"range":{"start_line":127,"start_character":4,"end_line":128,"end_character":51},"in_reply_to":"1fa4df85_4f3129a2","updated":"2020-03-18 02:44:32.000000000","message":"Thanks Andrey, done.","commit_id":"d6575c438335e88e44df399bff4a7cf53efe3799"}],"releasenotes/notes/microversion-v2_85-230931f88c4f1d52.yaml":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6a4ecc0fd74ebfcd8b5f773caa3a9d6e8855b4c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support is added for compute API version 2.85. This adds the ability"},{"line_number":5,"context_line":"    to update an attached volume with a ``delete_on_termination``, which"},{"line_number":6,"context_line":"    specify if the attached volume should be deleted when the server is"},{"line_number":7,"context_line":"    destroyed."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"df33271e_33f80048","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":44},"updated":"2020-04-07 11:31:57.000000000","message":"microversion","commit_id":"9ed3a20e752b907b2b4c74290fe11250de80f1cc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"36bd1d8c888213239c3cf37d604e163abe28f2a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support is added for compute API version 2.85. This adds the ability"},{"line_number":5,"context_line":"    to update an attached volume with a ``delete_on_termination``, which"},{"line_number":6,"context_line":"    specify if the attached volume should be deleted when the server is"},{"line_number":7,"context_line":"    destroyed."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"df33271e_02d5a3b7","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":44},"in_reply_to":"df33271e_33f80048","updated":"2020-04-07 12:49:41.000000000","message":"Done","commit_id":"9ed3a20e752b907b2b4c74290fe11250de80f1cc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"e600725d953d7bb7099274a2bf8eb3880c411411","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    is destroyed."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - The ``--delete-on-termination`` and ``--no-delete-on-termination``"},{"line_number":10,"context_line":"    options are added to the ``nova volume-update`` CLI."},{"line_number":11,"context_line":"    - New kwarg called ``delete_on_termination`` added to the python API"},{"line_number":12,"context_line":"      binding:"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"df33271e_a0bd94b8","line":10,"updated":"2020-04-09 00:24:26.000000000","message":"Wrong indentation.","commit_id":"d28f701e753c4729ebc74af64a1747e0fe2f69ca"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"7e39ac5fe687c7ae5e97aaa88ab8858a3d27ae15","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support is added for compute API microversion 2.85. This adds the"},{"line_number":5,"context_line":"    ability to update an attached volume with a ``delete_on_termination``,"},{"line_number":6,"context_line":"    which specify if the attached volume should be deleted when the server"},{"line_number":7,"context_line":"    is destroyed."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"df33271e_6049ccb5","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":54},"updated":"2020-04-09 00:36:55.000000000","message":"nit: Add a link to the API microversion history.\nhttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id78","commit_id":"4a8eceaf0aa2fd8f00eaf40fe51ee39a227915d4"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"cdc28e1f806d3e0cacb023f343acd1916c8a3c95","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Support is added for compute API microversion 2.85. This adds the"},{"line_number":5,"context_line":"    ability to update an attached volume with a ``delete_on_termination``,"},{"line_number":6,"context_line":"    which specify if the attached volume should be deleted when the server"},{"line_number":7,"context_line":"    is destroyed."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"df33271e_a0511439","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":54},"in_reply_to":"df33271e_6049ccb5","updated":"2020-04-09 00:53:38.000000000","message":"Done","commit_id":"4a8eceaf0aa2fd8f00eaf40fe51ee39a227915d4"}]}