)]}'
{"doc/source/cli/nova.rst":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"675d6b4fc3eccaa7259b9773be7a55adf31e388f","unresolved":false,"context_lines":[{"line_number":2318,"context_line":""},{"line_number":2319,"context_line":"``--config-drive``"},{"line_number":2320,"context_line":"  Display servers that have a config drive attached."},{"line_number":2321,"context_line":"  (Admin only until microversion 2.82)."},{"line_number":2322,"context_line":""},{"line_number":2323,"context_line":"``--no-config-drive``"},{"line_number":2324,"context_line":"  Display servers that do not have a config drive attached."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df33271e_af30ee9f","line":2321,"updated":"2020-04-08 17:31:20.000000000","message":"nit: It would be better to mention the mutually exclusive with --no-config-drive.\nIt can be done in the follow-up patch.","commit_id":"ea092b29880e71f0ba2d8e1eb93a9cf73edee2a2"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"7d1815e915d4eeaeba304439030dfdfcf3011402","unresolved":false,"context_lines":[{"line_number":2318,"context_line":""},{"line_number":2319,"context_line":"``--config-drive``"},{"line_number":2320,"context_line":"  Display servers that have a config drive attached."},{"line_number":2321,"context_line":"  (Admin only until microversion 2.82)."},{"line_number":2322,"context_line":""},{"line_number":2323,"context_line":"``--no-config-drive``"},{"line_number":2324,"context_line":"  Display servers that do not have a config drive attached."}],"source_content_type":"text/x-rst","patch_set":4,"id":"df33271e_30a09af4","line":2321,"in_reply_to":"df33271e_af30ee9f","updated":"2020-04-10 03:55:35.000000000","message":"Done","commit_id":"ea092b29880e71f0ba2d8e1eb93a9cf73edee2a2"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"675d6b4fc3eccaa7259b9773be7a55adf31e388f","unresolved":false,"context_lines":[{"line_number":2322,"context_line":""},{"line_number":2323,"context_line":"``--no-config-drive``"},{"line_number":2324,"context_line":"  Display servers that do not have a config drive attached."},{"line_number":2325,"context_line":"  (Admin only until microversion 2.82)."},{"line_number":2326,"context_line":""},{"line_number":2327,"context_line":"``--progress \u003cprogress\u003e``"},{"line_number":2328,"context_line":"  Display servers based on their progress value"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df33271e_0f28fa31","line":2325,"updated":"2020-04-08 17:31:20.000000000","message":"ditto","commit_id":"ea092b29880e71f0ba2d8e1eb93a9cf73edee2a2"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"7d1815e915d4eeaeba304439030dfdfcf3011402","unresolved":false,"context_lines":[{"line_number":2322,"context_line":""},{"line_number":2323,"context_line":"``--no-config-drive``"},{"line_number":2324,"context_line":"  Display servers that do not have a config drive attached."},{"line_number":2325,"context_line":"  (Admin only until microversion 2.82)."},{"line_number":2326,"context_line":""},{"line_number":2327,"context_line":"``--progress \u003cprogress\u003e``"},{"line_number":2328,"context_line":"  Display servers based on their progress value"}],"source_content_type":"text/x-rst","patch_set":4,"id":"df33271e_90a1a6fa","line":2325,"in_reply_to":"df33271e_0f28fa31","updated":"2020-04-10 03:55:35.000000000","message":"Done","commit_id":"ea092b29880e71f0ba2d8e1eb93a9cf73edee2a2"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f5d32360e1ab9b5288a4f8a093bf658c9f7c6d99","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        self.run_command(\u0027list --config-drive\u0027)"},{"line_number":1851,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/detail?config_drive\u003dTrue\u0027)"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    def tset_list_with_no_config_drive(self):"},{"line_number":1854,"context_line":"        self.run_command(\u0027list --no-config-drive\u0027)"},{"line_number":1855,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/detail?config_drive\u003dFalse\u0027)"},{"line_number":1856,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_83123157","line":1853,"range":{"start_line":1853,"start_character":8,"end_line":1853,"end_character":12},"updated":"2020-04-08 14:14:10.000000000","message":"test","commit_id":"1c9bf8be110f2088ee2eb9613e9fe7dc68d0d194"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"5bdffc1779d1fb8f9172c1652fa5b7af1a460f5b","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        self.run_command(\u0027list --config-drive\u0027)"},{"line_number":1851,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/detail?config_drive\u003dTrue\u0027)"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    def tset_list_with_no_config_drive(self):"},{"line_number":1854,"context_line":"        self.run_command(\u0027list --no-config-drive\u0027)"},{"line_number":1855,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/detail?config_drive\u003dFalse\u0027)"},{"line_number":1856,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_e3d5fd1c","line":1853,"range":{"start_line":1853,"start_character":8,"end_line":1853,"end_character":12},"in_reply_to":"df33271e_83123157","updated":"2020-04-08 14:22:26.000000000","message":"Yeah, this has to be fixed; right now, this test won\u0027t be run because of the misspelling.","commit_id":"1c9bf8be110f2088ee2eb9613e9fe7dc68d0d194"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b4d1bff6f6974e39573863cf51289d577a0d07a7","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        self.run_command(\u0027list --config-drive\u0027)"},{"line_number":1851,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/detail?config_drive\u003dTrue\u0027)"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    def tset_list_with_no_config_drive(self):"},{"line_number":1854,"context_line":"        self.run_command(\u0027list --no-config-drive\u0027)"},{"line_number":1855,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/detail?config_drive\u003dFalse\u0027)"},{"line_number":1856,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_833eb126","line":1853,"range":{"start_line":1853,"start_character":8,"end_line":1853,"end_character":12},"in_reply_to":"df33271e_e3d5fd1c","updated":"2020-04-08 14:37:54.000000000","message":"Done","commit_id":"1c9bf8be110f2088ee2eb9613e9fe7dc68d0d194"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9c570bac36ba1070b468cace8275cd7bb5f4a7e6","unresolved":false,"context_lines":[{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    def test_list_with_no_config_drive(self):"},{"line_number":1854,"context_line":"        self.run_command(\u0027list --no-config-drive\u0027)"},{"line_number":1855,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/servers/detail?config_drive\u003dFalse\u0027)"},{"line_number":1856,"context_line":""},{"line_number":1857,"context_line":"    def test_list_with_progress(self):"},{"line_number":1858,"context_line":"        self.run_command(\u0027list --progress 100\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_c391d848","line":1855,"range":{"start_line":1855,"start_character":64,"end_line":1855,"end_character":69},"updated":"2020-04-08 15:02:26.000000000","message":"This makes a suggestion how to fix our API bug in https://bugs.launchpad.net/nova/+bug/1871409 But if we diverge there then we can still update the client code to send whatever that will represent the no-config-drive option","commit_id":"0a3582a8d99959b8dd321fc097f99af9e1d2fa84"}],"novaclient/v2/servers.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f5d32360e1ab9b5288a4f8a093bf658c9f7c6d99","unresolved":false,"context_lines":[{"line_number":894,"context_line":"                    val \u003d val.encode(\u0027utf-8\u0027)"},{"line_number":895,"context_line":"                qparams[opt] \u003d val"},{"line_number":896,"context_line":"            # NOTE(gibi): The False value won\u0027t actually do anything until we"},{"line_number":897,"context_line":"            # fixing bug 1871409 and cleaning up the API inconsistency, but we"},{"line_number":898,"context_line":"            # do it in preparation for that (hopefully backportable) fix"},{"line_number":899,"context_line":"            if opt \u003d\u003d \u0027config_drive\u0027 and val is not None:"},{"line_number":900,"context_line":"                qparams[opt] \u003d str(val)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_e32a1d7c","line":897,"range":{"start_line":897,"start_character":14,"end_line":897,"end_character":20},"updated":"2020-04-08 14:14:10.000000000","message":"fix","commit_id":"1c9bf8be110f2088ee2eb9613e9fe7dc68d0d194"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b4d1bff6f6974e39573863cf51289d577a0d07a7","unresolved":false,"context_lines":[{"line_number":894,"context_line":"                    val \u003d val.encode(\u0027utf-8\u0027)"},{"line_number":895,"context_line":"                qparams[opt] \u003d val"},{"line_number":896,"context_line":"            # NOTE(gibi): The False value won\u0027t actually do anything until we"},{"line_number":897,"context_line":"            # fixing bug 1871409 and cleaning up the API inconsistency, but we"},{"line_number":898,"context_line":"            # do it in preparation for that (hopefully backportable) fix"},{"line_number":899,"context_line":"            if opt \u003d\u003d \u0027config_drive\u0027 and val is not None:"},{"line_number":900,"context_line":"                qparams[opt] \u003d str(val)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_2338853b","line":897,"range":{"start_line":897,"start_character":14,"end_line":897,"end_character":20},"in_reply_to":"df33271e_e32a1d7c","updated":"2020-04-08 14:37:54.000000000","message":"Done","commit_id":"1c9bf8be110f2088ee2eb9613e9fe7dc68d0d194"}],"novaclient/v2/shell.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7bc5c03ab3a45c4d13fc785795a55afe1e8aed68","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"    default\u003dNone,"},{"line_number":1552,"context_line":"    help\u003d_(\u0027Display servers that have a config drive attached. (Admin only \u0027"},{"line_number":1553,"context_line":"           \u0027until microversion 2.82).\u0027))"},{"line_number":1554,"context_line":"# NOTE(gibi): this won\u0027t actually do anything until bug 1871409 is fixed"},{"line_number":1555,"context_line":"# and the REST API is cleaned up regarding the values of config_drive"},{"line_number":1556,"context_line":"@utils.arg("},{"line_number":1557,"context_line":"    \u0027--no-config-drive\u0027,"},{"line_number":1558,"context_line":"    action\u003d\u0027store_false\u0027,"},{"line_number":1559,"context_line":"    dest\u003d\u0027config_drive\u0027,"},{"line_number":1560,"context_line":"    help\u003d_(\u0027Display servers that do not have a config drive attached (Admin \u0027"},{"line_number":1561,"context_line":"           \u0027only until microversion 2.82)\u0027))"},{"line_number":1562,"context_line":"@utils.arg("},{"line_number":1563,"context_line":"    \u0027--progress\u0027,"},{"line_number":1564,"context_line":"    dest\u003d\u0027progress\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_63e60c19","line":1561,"range":{"start_line":1554,"start_character":0,"end_line":1561,"end_character":44},"updated":"2020-04-08 14:48:09.000000000","message":"as it would not work for now, should we just not expose this ? i mean only add --config-drive. and once we fix the it on API side then we expose.\n\nor we should mention something in help of this option so that it would not give false result to users which is un-filtered servers list.","commit_id":"0a3582a8d99959b8dd321fc097f99af9e1d2fa84"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9c570bac36ba1070b468cace8275cd7bb5f4a7e6","unresolved":false,"context_lines":[{"line_number":1666,"context_line":"    # search by tenant or user only works with all_tenants"},{"line_number":1667,"context_line":"    if args.tenant:"},{"line_number":1668,"context_line":"        args.all_tenants \u003d 1"},{"line_number":1669,"context_line":""},{"line_number":1670,"context_line":"    search_opts \u003d {"},{"line_number":1671,"context_line":"        \u0027all_tenants\u0027: args.all_tenants,"},{"line_number":1672,"context_line":"        \u0027reservation_id\u0027: args.reservation_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_a3abf41a","line":1669,"updated":"2020-04-08 15:02:26.000000000","message":"I guess we need to make --no-config-drive and --config-drive mutually exclusive","commit_id":"0a3582a8d99959b8dd321fc097f99af9e1d2fa84"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"581c8bf2feb7d6572147882d2331069d278ad5c3","unresolved":false,"context_lines":[{"line_number":1666,"context_line":"    # search by tenant or user only works with all_tenants"},{"line_number":1667,"context_line":"    if args.tenant:"},{"line_number":1668,"context_line":"        args.all_tenants \u003d 1"},{"line_number":1669,"context_line":""},{"line_number":1670,"context_line":"    search_opts \u003d {"},{"line_number":1671,"context_line":"        \u0027all_tenants\u0027: args.all_tenants,"},{"line_number":1672,"context_line":"        \u0027reservation_id\u0027: args.reservation_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_a6dae213","line":1669,"in_reply_to":"df33271e_a3abf41a","updated":"2020-04-08 15:35:02.000000000","message":"I agree, but I don\u0027t think I can do that with the weird argparse decorators we use :( Will investigate","commit_id":"0a3582a8d99959b8dd321fc097f99af9e1d2fa84"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"02c7a10d2631c3cc421b522d249c76bb2b769c9d","unresolved":false,"context_lines":[{"line_number":1666,"context_line":"    # search by tenant or user only works with all_tenants"},{"line_number":1667,"context_line":"    if args.tenant:"},{"line_number":1668,"context_line":"        args.all_tenants \u003d 1"},{"line_number":1669,"context_line":""},{"line_number":1670,"context_line":"    search_opts \u003d {"},{"line_number":1671,"context_line":"        \u0027all_tenants\u0027: args.all_tenants,"},{"line_number":1672,"context_line":"        \u0027reservation_id\u0027: args.reservation_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_78eb53db","line":1669,"in_reply_to":"df33271e_a6dae213","updated":"2020-04-08 16:29:39.000000000","message":"Figured it out","commit_id":"0a3582a8d99959b8dd321fc097f99af9e1d2fa84"}]}