)]}'
{"id":"openstack%2Fpython-novaclient~783010","triplet_id":"openstack%2Fpython-novaclient~master~I53caceb08667eb12e27016731868e8015dd10e34","project":"openstack/python-novaclient","branch":"master","topic":"bug1921388","hashtags":[],"change_id":"I53caceb08667eb12e27016731868e8015dd10e34","subject":"When creating a client, pass the default logger","status":"MERGED","created":"2021-03-25 14:12:32.000000000","updated":"2021-08-14 18:24:08.000000000","submitted":"2021-04-09 18:22:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"783010-bug1921388","meta_rev_id":"01321a60ed256ed45966fe9bb126b14b8ca847b9","_number":783010,"virtual_id_number":783010,"owner":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-09 18:22:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"recommended":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-08-14 18:24:08.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":2,"date":"2021-03-25 18:15:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":2,"date":"2021-04-09 01:50:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":2,"date":"2021-04-09 16:59:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2021-04-09 16:59:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-25 16:09:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-25 18:15:21.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2021-03-27 13:09:38.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2021-04-08 14:17:45.000000000","updated_by":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2021-08-14 18:22:05.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"CC"},{"updated":"2021-08-14 18:24:08.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"}],"messages":[{"id":"d59993816fde7be8fe5666b3247335c507c19fed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"date":"2021-03-25 14:12:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d520aa1971e0508024dab35bc4f71a982e63d1ea","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-25 16:09:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/da4530b8cd074dd699fb3664e9bc9021 : SUCCESS in 1h 48m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4c57384fd03c4db5a5f47766cb27d919 : SUCCESS in 6m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7b52239982104c0ba79dc9b80146cc03 : SUCCESS in 6m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cbaf52cf59db4a2c8b98016230f9202f : SUCCESS in 5m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f58a0a2d539649359475e891cddfeefc : SUCCESS in 5m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8c997b678e73417ab74a7599e2779afa : SUCCESS in 6m 23s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c761e0155cca41b182d4148f1296d80c : SUCCESS in 6m 08s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ab1a3c2fc66441a8e8d90c2458f997e : SUCCESS in 7m 46s\n- python-novaclient-functional https://zuul.opendev.org/t/openstack/build/f98897d77abd4a6fba28e8179c8c6f3b : SUCCESS in 59m 04s","accounts_in_message":[],"_revision_number":1},{"id":"099931b21d188f4fbf6e5398cb635ec1f2fcdc9f","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2021-03-25 18:15:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f184fc3a58e1c238fa2f43b8f046bffe03a72689","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-03-27 13:09:38.000000000","message":"Patch Set 1: Code-Review-1\n\nIf a logger is specified, the logger should be used.\nIf a logger is not specified, a keystoneauth.session logger should be used in keystoneauth.session operations.\nSo it should be kept as it is.","accounts_in_message":[],"_revision_number":1},{"id":"63eaa53c039eb6a156a0704abe31378194d3046e","author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"date":"2021-03-30 07:41:53.000000000","message":"Patch Set 1:\n\n\u003e If a logger is not specified, a keystoneauth.session logger should be used in keystoneauth.session operations.\n\nThis is not true. If a logger is not specified, a novaclient logger should be created and used. This how it works with every other OpenStack client library, and how it worked before novaclient did this refactoring to use keystoneayth.session.","accounts_in_message":[],"_revision_number":1},{"id":"e9dd07cac3c5a548fc90d7c70c28b266d1f587c7","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2021-04-09 01:50:08.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nI tried out this change with a local devstack and I think it makes sense now.\n\nThe client object we construct makes calls to the nova API and I think it is more useful to have such log messages logged under novaclient.\n\nComparing an example before this patch:\n\nDEBUG:keystoneauth.session:REQ: curl -g -i -X GET http://127.0.0.1/identity -H \"Accept: application/json\" -H \"User-Agent: python-novaclient keystoneauth1/4.3.0 python-requests/2.25.1 CPython/3.8.5\"\n...\nDEBUG:keystoneauth.session:REQ: curl -g -i -X GET http://127.0.0.1/compute/v2.1/servers/detail -H \"Accept: application/json\" -H \"User-Agent: python-novaclient\" -H \"X-Auth-Token: {SHA256}79208362548dea507eea94f28088b55a549e5724e76f693c01c142fd23c0494f\" -H \"X-OpenStack-Nova-API-Version: 2.1\"\n\nand after this patch:\n\nDEBUG:keystoneauth.session:REQ: curl -g -i -X GET http://127.0.0.1/identity -H \"Accept: application/json\" -H \"User-Agent: python-novaclient keystoneauth1/4.3.0 python-requests/2.25.1 CPython/3.8.5\"\n...\nDEBUG:novaclient.v2.client:REQ: curl -g -i -X GET http://127.0.0.1/compute/v2.1/servers/detail -H \"Accept: application/json\" -H \"User-Agent: python-novaclient\" -H \"X-Auth-Token: {SHA256}201a2ba5ffcd0feb9102d4f1f006cbc034533147ccd8b2467113b0942ec9797e\" -H \"X-OpenStack-Nova-API-Version: 2.1\"\n\nThe latter is more clear, IMHO.","accounts_in_message":[],"_revision_number":1},{"id":"3c29d42724471474a540ff3f4e5c50b8f7d0f706","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-04-09 16:59:24.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nFair enough. Thanks, melwitt.","accounts_in_message":[],"_revision_number":1},{"id":"096b605952f8495ab6451a6012387acf42163692","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 16:59:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"1bbf4cc1fc7364fee9477b67133cb01d7bfed77a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 18:22:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/386d56a70a1640629b001e8688335ae0 : SUCCESS in 1h 19m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fe8d6e86d9124c26af17f25a84f5fe84 : SUCCESS in 7m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/34f2d48ac1bd42dc978d2c658875f6c9 : SUCCESS in 5m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b5d8001d9ce24897b5ea48f058ec5232 : SUCCESS in 5m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/be9c30ed88e8442780ac0fbe202165dc : SUCCESS in 5m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3c89cda294ee4f51b6d22b1f5fb8c9ea : SUCCESS in 6m 49s\n- python-novaclient-functional https://zuul.opendev.org/t/openstack/build/7973d3ddab574ca18c59fd859a883047 : SUCCESS in 47m 06s","accounts_in_message":[],"_revision_number":1},{"id":"a85387be813a58d827bac38126bcb4b134afcd18","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 18:22:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"9c7244f98a60e8c381b4a68bd9129f434d963622","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 18:24:11.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a0db2b4844e446e392e0a421b1bbafdb : SUCCESS in 53s","accounts_in_message":[],"_revision_number":1},{"id":"435d5c2548a788a364f2da152710681ea2848b67","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2021-08-14 18:22:05.000000000","message":"Patch Set 1:\n\nCould this be backported to ease with debugging on stable branches? It seems, without this fix, novaclient does not pick up the service logging config (as it picks up the level for keystoneauth which defaults to WARN). I have observed this with Masakari where turning debug on did not make novaclient log debug (before this).","accounts_in_message":[],"_revision_number":1},{"id":"4fa584d7477418e8316fcbaf760b6a37c97dca2b","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2021-08-14 18:23:40.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Could this be backported to ease with debugging on stable branches? It seems, without this fix, novaclient does not pick up the service logging config (as it picks up the level for keystoneauth which defaults to WARN). I have observed this with Masakari where turning debug on did not make novaclient log debug (before this).\n\nI see this was merged as a bugfix so per policy you should be accepting so I\u0027m therefore proposing. 😊","accounts_in_message":[],"_revision_number":1},{"id":"01321a60ed256ed45966fe9bb126b14b8ca847b9","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2021-08-14 18:24:08.000000000","message":"Patch Set 1: Code-Review+1\n\nand have my +1 for good work","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d4399d3d36c456c1001b96178ce9b3e7ec082460","revisions":{"d4399d3d36c456c1001b96178ce9b3e7ec082460":{"kind":"REWORK","_number":1,"created":"2021-03-25 14:12:32.000000000","uploader":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"ref":"refs/changes/10/783010/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/10/783010/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/783010/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/783010/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/10/783010/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/10/783010/1"}}},"commit":{"parents":[{"commit":"90525a1f5f55e206554da373dda9f26735e7c67f","subject":"Merge \"Add Python3 xena unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/90525a1f5f55e206554da373dda9f26735e7c67f"}]}],"author":{"name":"Radomir Dopieralski","email":"openstack@sheep.art.pl","date":"2021-03-25 14:08:20.000000000","tz":60},"committer":{"name":"Radomir Dopieralski","email":"openstack@sheep.art.pl","date":"2021-03-25 14:12:29.000000000","tz":60},"subject":"When creating a client, pass the default logger","message":"When creating a client, pass the default logger\n\nWhen a client is created without a logger, novaclient creates a\ndefault logger, but it\u0027s then not used, because it\u0027s not passed\nto the factory function. Because of that, all novaclient calls\nare getting logged as \u0027keystoneauth.session\u0027 instead of\n\u0027novaclient.v2.client\u0027 as they should.\n\nCloses-bug: 1921388\nChange-Id: I53caceb08667eb12e27016731868e8015dd10e34\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d4399d3d36c456c1001b96178ce9b3e7ec082460"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/d4399d3d36c456c1001b96178ce9b3e7ec082460"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}