)]}'
{"id":"openstack%2Fpython-novaclient~806916","triplet_id":"openstack%2Fpython-novaclient~master~I9af89655a7e7276446a881fd28d21ddd6581048c","project":"openstack/python-novaclient","branch":"master","topic":"bp/configurable-instance-hostnames","hashtags":[],"change_id":"I9af89655a7e7276446a881fd28d21ddd6581048c","subject":"tests: Add missing \u0027nova update\u0027 unit tests","status":"MERGED","created":"2021-09-01 11:52:57.000000000","updated":"2021-09-02 15:47:10.000000000","submitted":"2021-09-02 15:44:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"806916-bp/configurable-instance-hostnames","meta_rev_id":"4865aadf3d091e6ddde7fde5ff21f2f34b4e4aac","_number":806916,"virtual_id_number":806916,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-09-02 15:44:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-09-02 14:10:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2021-09-02 13:01:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-09-02 14:10:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"}],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-09-01 12:33:16.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2021-09-01 13:22:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-09-01 14:36:59.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2021-09-02 13:02:06.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"}],"messages":[{"id":"0d03638ff29a7cc38ae54ae7443c22b279f1216f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-09-01 11:52:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c70d70bffd45928c81c8c6614dd9c2fa4aabd743","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-09-01 12:33:16.000000000","message":"Patch Set 1: Code-Review-1\n\nThe \u0027nova update\u0027 tests exist. They are functional tests.\n\nhttps://opendev.org/openstack/python-novaclient/src/commit/cfa172c4fd75cae1c6cbed31def48f28eafbb89b/novaclient/tests/functional/v2/test_servers.py#L104-L134\n\nSo add tests in functional tests.","accounts_in_message":[],"_revision_number":1},{"id":"2685290a38ce0ff3b4a8cf711e889c133b661618","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-01 13:22:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/18a1ce4ca50b4372bd016a2e1f1b3f03 : SUCCESS in 1h 23m 51s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1d079c1f80fc485a9005d80075f9e9f4 : SUCCESS in 8m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/352fb1b490514230b2db54e7d42cf26b : SUCCESS in 6m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b012f9662b904c8888f55893606d42c5 : SUCCESS in 4m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/542d1e45dc14431fb3accf374aef8138 : SUCCESS in 4m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f837500353b04e86a03185140b38a49c : SUCCESS in 5m 02s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4023beb1991d4660be16f310c50cf318 : SUCCESS in 5m 09s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9d8c333b8d7b45f88906dc11cdcbd5a6 : SUCCESS in 6m 45s\n- python-novaclient-functional https://zuul.opendev.org/t/openstack/build/59124225ee4a46ba9de6ade1562f63a3 : SUCCESS in 51m 25s","accounts_in_message":[],"_revision_number":1},{"id":"29a0636a10346d5517621a9d3f3046aeeba0de2a","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-09-02 09:53:49.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e The \u0027nova update\u0027 tests exist. They are functional tests.\n\u003e \n\u003e https://opendev.org/openstack/python-novaclient/src/commit/cfa172c4fd75cae1c6cbed31def48f28eafbb89b/novaclient/tests/functional/v2/test_servers.py#L104-L134\n\u003e \n\u003e So add tests in functional tests.\n\nAh, okay, I didn\u0027t spot these. Those are quite different tests though. We should have functional tests to verify the full workflow, but the bulk of the tests should exist in unit tests since they\u0027re *much* faster to run and test locally (you don\u0027t need to set up a deployment first). I\u0027ve reworded the commit message to state this. Hopefully that works for you","accounts_in_message":[],"_revision_number":1},{"id":"2cb88d98707919d747ca78fadf56323367a945c5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-09-02 10:02:06.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"e3db4866db4771ab153732348e5995f1510e8e07","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 11:22:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a802271a41d54149a5d2eea236bb3b21 : SUCCESS in 1h 19m 09s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d9ce04e9b27c4eb4a5e513196d895733 : SUCCESS in 6m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b7358b6e761d46c8b3f63fb0da177933 : SUCCESS in 7m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6f08a9727b524c24b5531f88f7b05741 : SUCCESS in 5m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4c259d4d44014054a14dc0dbe2bdea4c : SUCCESS in 6m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c5a263cfee904324ae0429418baea93f : SUCCESS in 5m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/af94af8a5cfd48ca899268bb95a1338f : SUCCESS in 6m 09s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/920483c4ddff4760aaa6be4602deeb6a : SUCCESS in 8m 26s\n- python-novaclient-functional https://zuul.opendev.org/t/openstack/build/62314c2668314e529418b32f0cdc19b8 : SUCCESS in 54m 22s","accounts_in_message":[],"_revision_number":2},{"id":"4fe64715b12922d5214cc06d8615b7ad89440c7b","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2021-09-02 13:01:13.000000000","message":"Patch Set 2: Code-Review+2\n\nThey might be redundant, but it is no problem that they exist.\nThanks.","accounts_in_message":[],"_revision_number":2},{"id":"f9d19af0cd73f76515aa1329c8f4a3ce8ca9f505","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-09-02 14:10:54.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"41c529c5aa3479c92d7052e54bef784fa8d77a81","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 14:11:25.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"bdc905a741e4900ae250b77041470baa5d3ef826","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 15:44:56.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/b39d35605b1644f3bd98d803a922da33 : SUCCESS in 1h 32m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8672d4f901e84d3c94cec39bd53ec49d : SUCCESS in 6m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3276c3836b3843a699879852db1145b1 : SUCCESS in 5m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0121594cb95647ec8cf91574e241a63a : SUCCESS in 8m 23s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9dcd9e70feb54b089f8854fb17485150 : SUCCESS in 5m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/70d1f02cb8a342919002f173c0c74b91 : SUCCESS in 7m 36s\n- python-novaclient-functional https://zuul.opendev.org/t/openstack/build/d66e3b9c4aea4d6e9e2fb38c01bff69f : SUCCESS in 50m 42s","accounts_in_message":[],"_revision_number":2},{"id":"a69d8603db2588ebcb6fb5dea68d3eb2fd00ff74","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 15:44:57.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"4865aadf3d091e6ddde7fde5ff21f2f34b4e4aac","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 15:47:10.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2b5fa0f3a2244696b677330a87568d7d : SUCCESS in 1m 54s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"01c7a3aa10f13eb889221f609dc4fb1463904fe3","revisions":{"4e665aed4659d7a19c62566a95d2c0fe8b46568a":{"kind":"REWORK","_number":1,"created":"2021-09-01 11:52:57.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/16/806916/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/16/806916/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/16/806916/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/16/806916/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/16/806916/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/16/806916/1"}}},"commit":{"parents":[{"commit":"4a5bdde3b0c330a06c9aa56f28541cd22bc438f3","subject":"Add pre-commit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4a5bdde3b0c330a06c9aa56f28541cd22bc438f3"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-09-01 10:27:31.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-09-01 10:55:38.000000000","tz":60},"subject":"tests: Add missing \u0027nova update\u0027 tests","message":"tests: Add missing \u0027nova update\u0027 tests\n\nChange-Id: I9af89655a7e7276446a881fd28d21ddd6581048c\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4e665aed4659d7a19c62566a95d2c0fe8b46568a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4e665aed4659d7a19c62566a95d2c0fe8b46568a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4a5bdde3b0c330a06c9aa56f28541cd22bc438f3","is_merged_in_target_branch":true,"change_id":"I66ed7fb2f0b4ef5227bdf40d51e3c15c3a54816a","change_number":806915,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"01c7a3aa10f13eb889221f609dc4fb1463904fe3":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-09-02 10:02:06.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/16/806916/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/16/806916/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/16/806916/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/16/806916/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/16/806916/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/16/806916/2"}}},"commit":{"parents":[{"commit":"4a5bdde3b0c330a06c9aa56f28541cd22bc438f3","subject":"Add pre-commit","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4a5bdde3b0c330a06c9aa56f28541cd22bc438f3"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-09-01 10:27:31.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-09-02 09:50:52.000000000","tz":60},"subject":"tests: Add missing \u0027nova update\u0027 unit tests","message":"tests: Add missing \u0027nova update\u0027 unit tests\n\nWe have functional tests for the \u0027nova update\u0027 commands, but no unit\ntests to verify e.g. that we can\u0027t set a description for the server\nbefore microversion 2.19. Add such tests.\n\nChange-Id: I9af89655a7e7276446a881fd28d21ddd6581048c\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/01c7a3aa10f13eb889221f609dc4fb1463904fe3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/01c7a3aa10f13eb889221f609dc4fb1463904fe3"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4a5bdde3b0c330a06c9aa56f28541cd22bc438f3","is_merged_in_target_branch":true,"change_id":"I66ed7fb2f0b4ef5227bdf40d51e3c15c3a54816a","change_number":806915,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}