)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3376819d8b0b58ef16e80653e88d687e7da5521c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cfb4170c_7af66cda","updated":"2022-05-23 10:26:39.000000000","message":"\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e It is not backward compatible change.\n\u003e For example,\n\u003e When calling the method,\n\u003e resize(server, flavor, some_disk_config) has no problem before this change.\n\u003e However resize(server, flavor, some_disk_config) raises TypeError after this change.\n\u003e \n\u003e At least, the change that is not backward compatible should be described in a release note.\n\nyou are right \nresize(server, flavor, some_disk_config) would not work but that is also genreally considerd bad partice.\n\nyou should not call kwargs as if they were positional\nso some_disk_config should never be passed as a postioanal argument like that\n","commit_id":"754457a6f162a28936c57f69d38357e2e42eec68"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5bc93e2f02b86c8dbf1bf750d622169c48e874e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"22900170_eb40e902","updated":"2022-12-12 17:49:02.000000000","message":"Resolved the backwards-compatibility issue","commit_id":"754457a6f162a28936c57f69d38357e2e42eec68"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"43d74a721c36aad11435ff3c794480708a2c2e6f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18a77abc_7ffd19ad","in_reply_to":"cfb4170c_7af66cda","updated":"2022-07-21 09:42:35.000000000","message":"I like the change and agree entirely that using too many positional arguments is a bad practice BUT it doesn\u0027t change the fact that the current change is not backward compatible and unfortunately breaks existing code like - https://github.com/openstack/horizon/blob/ea9137f63dbfa4d2094475df4b076970553ee8be/openstack_dashboard/api/nova.py#L621","commit_id":"754457a6f162a28936c57f69d38357e2e42eec68"}]}