)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"99e13f80f6665c32ad7d24c6a9dbe8eefa6b327c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e4edd4e_696d6e71","updated":"2022-02-22 21:06:03.000000000","message":"doc/source/cli/nova.rst should be updated.","commit_id":"ef248f9b7fec66949b056109248ac962e6caf5d1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8471bf51a2cf3bd52b43176d284499f6d518d545","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2cf2b577_60360826","in_reply_to":"7e4edd4e_696d6e71","updated":"2022-02-24 07:39:02.000000000","message":"Done","commit_id":"ef248f9b7fec66949b056109248ac962e6caf5d1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8471bf51a2cf3bd52b43176d284499f6d518d545","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e06cb921_3a92f07c","updated":"2022-02-24 07:39:02.000000000","message":"Thanks Takashi","commit_id":"3196e7a0a5c123dacd4d7ff3648469406c637064"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f039b0a60df8cfa60dd618cd39b9dc9ca8911c60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bee549f3_ced5fd57","updated":"2022-02-25 11:36:12.000000000","message":"we resolved to nolonger extend nova clients cli at the ptg.\nhttps://etherpad.opendev.org/p/nova-yoga-ptg#L513\nso new lib functionality coudl be added but --reimage-boot-volume should not be added to the cli.\nall new cli fucntionality should be added to osc directly.\n\nso -2 is because we are passed the client freeze and new clis should not be added.","commit_id":"3196e7a0a5c123dacd4d7ff3648469406c637064"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3b27db0a5df9e01c120e9135406c6ccdf633019d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1b1b2916_0d982073","updated":"2022-02-25 18:32:12.000000000","message":"we are still after FF for yoga so we should hold this until after rc1 and after the api microverion is merged in nova. however ill drop -2 since the cli change is removed, this is now just adding the library support for the microverion which can then be called via orc.","commit_id":"661407d1202b3e102b4421eb8c1eb67eba9d1558"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"47960ca0766e7cf5b43bf8542667b31ecaefa47a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b2cd0c36_94bcc311","updated":"2022-02-25 18:35:44.000000000","message":"Thanks Sean","commit_id":"dbc8d031622a05f487b61f9eb29b3303487ee08a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f64e66d53f143a8d4fc290b6cf5a4c67eb568940","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"05af97c9_61608199","updated":"2022-07-30 14:47:37.000000000","message":"This patch should be rebased as microversion 2.93 or later.","commit_id":"3049f9be1f6892ff525a5fa94ff5a470405cde77"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3a1ec3f995141c695da54a197f74fc3111eed318","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"80840260_556ae250","in_reply_to":"05af97c9_61608199","updated":"2022-08-30 21:24:01.000000000","message":"Done","commit_id":"3049f9be1f6892ff525a5fa94ff5a470405cde77"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"46015fd3f4cfbe7f20bc5a41c27f60f0f0ae0999","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"410fb9dc_e3936aa5","updated":"2022-09-01 14:46:51.000000000","message":"I would like to know other core reviewers\u0027 opinions...","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a7dee4d465dc527ffccccc95f25d9e7272b95c1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8abb74c0_8e807dc9","updated":"2022-08-31 19:29:16.000000000","message":"i think this looks reasonable.\n\nthe actully clint check to prevent you rebuilding with the new microversion unless you pass the new paramater will be in osc so this is just the python bindings.","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e80f1d9079eede140593e56ac5d09aac1fbdc894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5e35f3dd_ec1f4bc8","updated":"2022-09-06 10:35:57.000000000","message":"I have a question but maybe we were having a consensus about the parameter that I no longer remember.","commit_id":"14abc2fffc581cdcebf73b79305ee1afd9542835"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ea0bd94938465344221b8fc6f61cc908a4373400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"cc963fe9_85183929","updated":"2022-09-06 17:18:31.000000000","message":"In theory, we shouldn\u0027t have been merged this patch today as we entered Client lib Freeze. ","commit_id":"94d3445e10711ff965e0ec141aaa0d0828dc43f0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"24d6d10214bab4842ebf04f169d6ebde89cd5ca0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"bc97b04e_0d0f4ad2","updated":"2022-09-06 13:15:10.000000000","message":"LGTM","commit_id":"94d3445e10711ff965e0ec141aaa0d0828dc43f0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6518f6773926ea9066a0d7f68d6d519012a016e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3ef10498_6b36b174","updated":"2022-09-06 11:27:51.000000000","message":"ack this look like the minimal change we need","commit_id":"94d3445e10711ff965e0ec141aaa0d0828dc43f0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bc79721809c33758ac32939c13d995edf59bf125","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2edcba76_edb1ab2f","updated":"2022-09-06 15:01:01.000000000","message":"recheck test_list_instance_action_with_changes_before","commit_id":"94d3445e10711ff965e0ec141aaa0d0828dc43f0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"30ef2eb9a88bad8ef6b56030307c0c49bc90a5b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"668801c2_de1a2716","in_reply_to":"33edd106_4e0a817b","updated":"2022-09-06 20:44:48.000000000","message":"I thought novaclient isn\u0027t released yet and the deadline was extended by nova requesting an exception.","commit_id":"94d3445e10711ff965e0ec141aaa0d0828dc43f0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"aa3e77dd5495bb1ef3754c84f3ff53affe7be9b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"33edd106_4e0a817b","in_reply_to":"cc963fe9_85183929","updated":"2022-09-06 17:19:57.000000000","message":"https://releases.openstack.org/zed/schedule.html#z-final-clientlib","commit_id":"94d3445e10711ff965e0ec141aaa0d0828dc43f0"}],"novaclient/__init__.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e80f1d9079eede140593e56ac5d09aac1fbdc894","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# when client supported the max version, and bumped sequentially, otherwise"},{"line_number":26,"context_line":"# the client may break due to server side new version may include some"},{"line_number":27,"context_line":"# backward incompatible change."},{"line_number":28,"context_line":"API_MAX_VERSION \u003d api_versions.APIVersion(\"2.93\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"0df01ae3_b0fcff26","line":28,"updated":"2022-09-06 10:35:57.000000000","message":"2.92 is merged, so we can review this one.","commit_id":"14abc2fffc581cdcebf73b79305ee1afd9542835"}],"novaclient/tests/unit/v2/test_servers.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e80f1d9079eede140593e56ac5d09aac1fbdc894","unresolved":false,"context_lines":[{"line_number":2114,"context_line":"            self.cs.servers.rebuild,"},{"line_number":2115,"context_line":"            \u00271234\u0027, fakes.FAKE_IMAGE_UUID_1,"},{"line_number":2116,"context_line":"            reimage_boot_volume\u003dTrue)"},{"line_number":2117,"context_line":"        self.assertIn(\u0027reimage_boot_volume\u0027, str(ex))"}],"source_content_type":"text/x-python","patch_set":11,"id":"096b2cfe_98d37a4e","line":2117,"updated":"2022-09-06 10:35:57.000000000","message":"good verification.","commit_id":"14abc2fffc581cdcebf73b79305ee1afd9542835"}],"novaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e80f1d9079eede140593e56ac5d09aac1fbdc894","unresolved":false,"context_lines":[{"line_number":4699,"context_line":"            86,  # doesn\u0027t require any changes in novaclient."},{"line_number":4700,"context_line":"            87,  # doesn\u0027t require any changes in novaclient."},{"line_number":4701,"context_line":"            89,  # There are no version-wrapped shell method changes for this."},{"line_number":4702,"context_line":"            93,  # There are no version-wrapped shell method changes for this."},{"line_number":4703,"context_line":"        ])"},{"line_number":4704,"context_line":"        versions_supported \u003d set(range(0,"},{"line_number":4705,"context_line":"                                 novaclient.API_MAX_VERSION.ver_minor + 1))"}],"source_content_type":"text/x-python","patch_set":11,"id":"c2bd4241_fb8ba838","line":4702,"updated":"2022-09-06 10:35:57.000000000","message":"well, now the shell is no longer supported, so I\u0027m not sure we should need to provide this but meh.","commit_id":"14abc2fffc581cdcebf73b79305ee1afd9542835"}],"novaclient/v2/servers.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ad243d98bba3752b8a0c6a0f3cd1c2e3305b2545","unresolved":true,"context_lines":[{"line_number":1703,"context_line":"        :param hostname: Optional hostname to configure for the instance. If"},{"line_number":1704,"context_line":"            None is specified, the existing hostname will be unset."},{"line_number":1705,"context_line":"            (starting from microversion 2.90)"},{"line_number":1706,"context_line":"        :param reimage_boot_volume: Option to rebuild a volume backed instance."},{"line_number":1707,"context_line":"            By default, it will not rebuild a volume backed instance."},{"line_number":1708,"context_line":"            (starting from microversion 2.93)"},{"line_number":1709,"context_line":"        :returns: :class:`Server`"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa6841f_49e78301","line":1706,"range":{"start_line":1706,"start_character":15,"end_line":1706,"end_character":34},"updated":"2022-09-01 13:51:39.000000000","message":"Is this parameter necessary?\nIt seems unnecessary.\nWhether rebuilding a volume backed instance or not\nis checked in nova side.","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"1b3ee6cdfe75db2dd12aca4b932df4269a011e62","unresolved":true,"context_lines":[{"line_number":1703,"context_line":"        :param hostname: Optional hostname to configure for the instance. If"},{"line_number":1704,"context_line":"            None is specified, the existing hostname will be unset."},{"line_number":1705,"context_line":"            (starting from microversion 2.90)"},{"line_number":1706,"context_line":"        :param reimage_boot_volume: Option to rebuild a volume backed instance."},{"line_number":1707,"context_line":"            By default, it will not rebuild a volume backed instance."},{"line_number":1708,"context_line":"            (starting from microversion 2.93)"},{"line_number":1709,"context_line":"        :returns: :class:`Server`"}],"source_content_type":"text/x-python","patch_set":10,"id":"ed3028f3_900a3457","line":1706,"range":{"start_line":1706,"start_character":15,"end_line":1706,"end_character":34},"updated":"2022-09-01 13:56:40.000000000","message":"There is no need to change the request body depending on whether the target server is a volume-backed server or not.","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18d997bf9a0f3c5d48ff404dde1647e39e7eb041","unresolved":true,"context_lines":[{"line_number":1703,"context_line":"        :param hostname: Optional hostname to configure for the instance. If"},{"line_number":1704,"context_line":"            None is specified, the existing hostname will be unset."},{"line_number":1705,"context_line":"            (starting from microversion 2.90)"},{"line_number":1706,"context_line":"        :param reimage_boot_volume: Option to rebuild a volume backed instance."},{"line_number":1707,"context_line":"            By default, it will not rebuild a volume backed instance."},{"line_number":1708,"context_line":"            (starting from microversion 2.93)"},{"line_number":1709,"context_line":"        :returns: :class:`Server`"}],"source_content_type":"text/x-python","patch_set":10,"id":"a787c5ee_d450ca98","line":1706,"range":{"start_line":1706,"start_character":15,"end_line":1706,"end_character":34},"in_reply_to":"18661047_ccfd6a38","updated":"2022-09-02 09:19:07.000000000","message":"the check is done in osc primarly.\n\nstrictly speaking we do not need to check the parmater here\n\ni.e. \n        if (\n            \u0027reimage_boot_volume\u0027 in kwargs and\n            self.api_version \u003c api_versions.APIVersion(\"2.93\")\n        ):\n            raise exceptions.UnsupportedAttribute(\n                \u0027reimage_boot_volume\u0027, \u00272.93\u0027)\n                \nit would be incoreect to require the parmater in nova clint for 2.93 but we could raise an eroror as the code does below that.\nit woudl be better to do that check also in osc but i was more or less ok with keeping it.\n\nif we weant to move that check to osc which is where it really should be im ok with\nthat.\n\nnova client however does at least need to allow the new microverison ot be used.\n\nso some of this chage such as updating API_MAX_VERSION is required.","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"904998ae5d7b2bfbfb0f17d61435dbd549f13877","unresolved":true,"context_lines":[{"line_number":1703,"context_line":"        :param hostname: Optional hostname to configure for the instance. If"},{"line_number":1704,"context_line":"            None is specified, the existing hostname will be unset."},{"line_number":1705,"context_line":"            (starting from microversion 2.90)"},{"line_number":1706,"context_line":"        :param reimage_boot_volume: Option to rebuild a volume backed instance."},{"line_number":1707,"context_line":"            By default, it will not rebuild a volume backed instance."},{"line_number":1708,"context_line":"            (starting from microversion 2.93)"},{"line_number":1709,"context_line":"        :returns: :class:`Server`"}],"source_content_type":"text/x-python","patch_set":10,"id":"18661047_ccfd6a38","line":1706,"range":{"start_line":1706,"start_character":15,"end_line":1706,"end_character":34},"in_reply_to":"7aa6841f_49e78301","updated":"2022-09-01 14:23:05.000000000","message":"It was decided to be checked in the original design but the revision which is the Zed spec doesn\u0027t have checks on nova side. This is part of the design decision which we agreed upon to add check for this on client side and no need to check it on API side.","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"578cf3555901d1ac35180103d9f7a75539998fb3","unresolved":false,"context_lines":[{"line_number":1703,"context_line":"        :param hostname: Optional hostname to configure for the instance. If"},{"line_number":1704,"context_line":"            None is specified, the existing hostname will be unset."},{"line_number":1705,"context_line":"            (starting from microversion 2.90)"},{"line_number":1706,"context_line":"        :param reimage_boot_volume: Option to rebuild a volume backed instance."},{"line_number":1707,"context_line":"            By default, it will not rebuild a volume backed instance."},{"line_number":1708,"context_line":"            (starting from microversion 2.93)"},{"line_number":1709,"context_line":"        :returns: :class:`Server`"}],"source_content_type":"text/x-python","patch_set":10,"id":"eb2705cf_3fdc2829","line":1706,"range":{"start_line":1706,"start_character":15,"end_line":1706,"end_character":34},"in_reply_to":"a787c5ee_d450ca98","updated":"2022-09-04 19:41:49.000000000","message":"Ack","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5837156043934a17a121ef86226a1151c9392ae6","unresolved":true,"context_lines":[{"line_number":1703,"context_line":"        :param hostname: Optional hostname to configure for the instance. If"},{"line_number":1704,"context_line":"            None is specified, the existing hostname will be unset."},{"line_number":1705,"context_line":"            (starting from microversion 2.90)"},{"line_number":1706,"context_line":"        :param reimage_boot_volume: Option to rebuild a volume backed instance."},{"line_number":1707,"context_line":"            By default, it will not rebuild a volume backed instance."},{"line_number":1708,"context_line":"            (starting from microversion 2.93)"},{"line_number":1709,"context_line":"        :returns: :class:`Server`"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf14a28e_739055b5","line":1706,"range":{"start_line":1706,"start_character":15,"end_line":1706,"end_character":34},"in_reply_to":"ed3028f3_900a3457","updated":"2022-09-01 14:00:39.000000000","message":"the requst body is not changed.","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18d997bf9a0f3c5d48ff404dde1647e39e7eb041","unresolved":true,"context_lines":[{"line_number":1741,"context_line":"        ):"},{"line_number":1742,"context_line":"            raise exceptions.UnsupportedAttribute(\u0027hostname\u0027, \u00272.90\u0027)"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"        if ("},{"line_number":1745,"context_line":"            \u0027reimage_boot_volume\u0027 in kwargs and"},{"line_number":1746,"context_line":"            self.api_version \u003c api_versions.APIVersion(\"2.93\")"},{"line_number":1747,"context_line":"        ):"},{"line_number":1748,"context_line":"            raise exceptions.UnsupportedAttribute("},{"line_number":1749,"context_line":"                \u0027reimage_boot_volume\u0027, \u00272.93\u0027)"},{"line_number":1750,"context_line":""},{"line_number":1751,"context_line":"        body \u003d {\u0027imageRef\u0027: base.getid(image)}"},{"line_number":1752,"context_line":"        if password is not None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ad618733_5aa3a1e7","line":1749,"range":{"start_line":1744,"start_character":6,"end_line":1749,"end_character":46},"updated":"2022-09-02 09:19:07.000000000","message":"this is just asserting that you dont pass the parmater with old micorversion.s\n\nit does not raise an error if you dont pass it for the new one because we decied that shoudl only be a clinet side check.\n\nso it shoudl not be enforced in teh python bidnings.\n\nthis proably should pop the kwarg however.","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"578cf3555901d1ac35180103d9f7a75539998fb3","unresolved":false,"context_lines":[{"line_number":1741,"context_line":"        ):"},{"line_number":1742,"context_line":"            raise exceptions.UnsupportedAttribute(\u0027hostname\u0027, \u00272.90\u0027)"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"        if ("},{"line_number":1745,"context_line":"            \u0027reimage_boot_volume\u0027 in kwargs and"},{"line_number":1746,"context_line":"            self.api_version \u003c api_versions.APIVersion(\"2.93\")"},{"line_number":1747,"context_line":"        ):"},{"line_number":1748,"context_line":"            raise exceptions.UnsupportedAttribute("},{"line_number":1749,"context_line":"                \u0027reimage_boot_volume\u0027, \u00272.93\u0027)"},{"line_number":1750,"context_line":""},{"line_number":1751,"context_line":"        body \u003d {\u0027imageRef\u0027: base.getid(image)}"},{"line_number":1752,"context_line":"        if password is not None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"e4d592a3_76592097","line":1749,"range":{"start_line":1744,"start_character":6,"end_line":1749,"end_character":46},"in_reply_to":"ad618733_5aa3a1e7","updated":"2022-09-04 19:41:49.000000000","message":"Ack","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18d997bf9a0f3c5d48ff404dde1647e39e7eb041","unresolved":true,"context_lines":[{"line_number":1790,"context_line":"                                 self.transform_userdata(userdata))"},{"line_number":1791,"context_line":""},{"line_number":1792,"context_line":"        resp, body \u003d self._action_return_resp_and_body(\u0027rebuild\u0027, server,"},{"line_number":1793,"context_line":"                                                       body, **kwargs)"},{"line_number":1794,"context_line":"        return Server(self, body[\u0027server\u0027], resp\u003dresp)"},{"line_number":1795,"context_line":""},{"line_number":1796,"context_line":"    @api_versions.wraps(\"2.0\", \"2.55\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"cdb43557_e0869654","line":1793,"range":{"start_line":1793,"start_character":63,"end_line":1793,"end_character":69},"updated":"2022-09-02 09:19:07.000000000","message":"so that its not passed  here, this is not after all a query args that is valid to pass to the api.","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"578cf3555901d1ac35180103d9f7a75539998fb3","unresolved":false,"context_lines":[{"line_number":1790,"context_line":"                                 self.transform_userdata(userdata))"},{"line_number":1791,"context_line":""},{"line_number":1792,"context_line":"        resp, body \u003d self._action_return_resp_and_body(\u0027rebuild\u0027, server,"},{"line_number":1793,"context_line":"                                                       body, **kwargs)"},{"line_number":1794,"context_line":"        return Server(self, body[\u0027server\u0027], resp\u003dresp)"},{"line_number":1795,"context_line":""},{"line_number":1796,"context_line":"    @api_versions.wraps(\"2.0\", \"2.55\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9d81a196_d3b4cade","line":1793,"range":{"start_line":1793,"start_character":63,"end_line":1793,"end_character":69},"in_reply_to":"cdb43557_e0869654","updated":"2022-09-04 19:41:49.000000000","message":"Done","commit_id":"4b0dbffb8d1ecb302964e0ef6ca6196251dd1f07"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e80f1d9079eede140593e56ac5d09aac1fbdc894","unresolved":true,"context_lines":[{"line_number":1747,"context_line":"                    \u0027reimage_boot_volume\u0027, \u00272.93\u0027)"},{"line_number":1748,"context_line":"            # We pop \u0027reimage_boot_volume\u0027 since we don\u0027t want to"},{"line_number":1749,"context_line":"            # pass it in the request body"},{"line_number":1750,"context_line":"            kwargs.pop(\u0027reimage_boot_volume\u0027)"},{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"        body \u003d {\u0027imageRef\u0027: base.getid(image)}"},{"line_number":1753,"context_line":"        if password is not None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"8b3bc620_dd9c3e7c","line":1750,"updated":"2022-09-06 10:35:57.000000000","message":"maybe I\u0027m misunderstanding something, but by default we accept to reimage a boot volume with 2.93 :\nhttps://review.opendev.org/c/openstack/nova/+/830883/32/nova/api/openstack/compute/servers.py\n\nSo, here, even if someone is adding a parameter reimage_boot_volume\u003dFalse, we will support it.\nSo, why do we need to have a specific parameter here ?","commit_id":"14abc2fffc581cdcebf73b79305ee1afd9542835"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"30ef2eb9a88bad8ef6b56030307c0c49bc90a5b4","unresolved":true,"context_lines":[{"line_number":1747,"context_line":"                    \u0027reimage_boot_volume\u0027, \u00272.93\u0027)"},{"line_number":1748,"context_line":"            # We pop \u0027reimage_boot_volume\u0027 since we don\u0027t want to"},{"line_number":1749,"context_line":"            # pass it in the request body"},{"line_number":1750,"context_line":"            kwargs.pop(\u0027reimage_boot_volume\u0027)"},{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"        body \u003d {\u0027imageRef\u0027: base.getid(image)}"},{"line_number":1753,"context_line":"        if password is not None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"89be19ec_24edf33a","line":1750,"in_reply_to":"15d8b3cd_52f9aa12","updated":"2022-09-06 20:44:48.000000000","message":"So what we have right now is\n1) a client side parameter (--confirm-reimage) on the OSC side\n2) No check on the API side and just passing the microversion should rebuild a volume backed instance\n\nSo if someone directly hits the API, they just need to pass the microversion 2.93 but if they request via client i.e. via the OSC client, they will need to pass both microversion 2.93 and --confirm-reimage parameter.","commit_id":"14abc2fffc581cdcebf73b79305ee1afd9542835"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cd5d967a3fcf061bae3d4924a43ad6996b1d9447","unresolved":true,"context_lines":[{"line_number":1747,"context_line":"                    \u0027reimage_boot_volume\u0027, \u00272.93\u0027)"},{"line_number":1748,"context_line":"            # We pop \u0027reimage_boot_volume\u0027 since we don\u0027t want to"},{"line_number":1749,"context_line":"            # pass it in the request body"},{"line_number":1750,"context_line":"            kwargs.pop(\u0027reimage_boot_volume\u0027)"},{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"        body \u003d {\u0027imageRef\u0027: base.getid(image)}"},{"line_number":1753,"context_line":"        if password is not None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"c0b0cd0e_6e8d0623","line":1750,"in_reply_to":"7384584f_d2b91513","updated":"2022-09-06 10:43:25.000000000","message":"it is checked in osc by the way https://review.opendev.org/c/openstack/python-openstackclient/+/831014/4/openstackclient/compute/v2/server.py#3229\n\ni suspect this really is just a hold over form when this was going to be passed to nova and can be remvoed","commit_id":"14abc2fffc581cdcebf73b79305ee1afd9542835"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ea0bd94938465344221b8fc6f61cc908a4373400","unresolved":true,"context_lines":[{"line_number":1747,"context_line":"                    \u0027reimage_boot_volume\u0027, \u00272.93\u0027)"},{"line_number":1748,"context_line":"            # We pop \u0027reimage_boot_volume\u0027 since we don\u0027t want to"},{"line_number":1749,"context_line":"            # pass it in the request body"},{"line_number":1750,"context_line":"            kwargs.pop(\u0027reimage_boot_volume\u0027)"},{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"        body \u003d {\u0027imageRef\u0027: base.getid(image)}"},{"line_number":1753,"context_line":"        if password is not None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"15d8b3cd_52f9aa12","line":1750,"in_reply_to":"8b3bc620_dd9c3e7c","updated":"2022-09-06 17:18:31.000000000","message":"Well, actually I looked at the spec and we discussed this :\nhttps://review.opendev.org/c/openstack/nova-specs/+/840155/5/specs/zed/approved/volume-backed-server-rebuild.rst#143\n\n\nSo, even if the user doesn\u0027t want to reimage the boot value with 2.93, it will be done. Looks to me we have a bug, nope ?\n\nWhat we should do IIUC is to verify whether we have a API parameter that was passed and only accept to reimage if the parameter is Yes (by default, it would be if no parameter would be passed with 2.93)","commit_id":"14abc2fffc581cdcebf73b79305ee1afd9542835"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ee5914132549483602e65388e58e47de3e7533ce","unresolved":true,"context_lines":[{"line_number":1747,"context_line":"                    \u0027reimage_boot_volume\u0027, \u00272.93\u0027)"},{"line_number":1748,"context_line":"            # We pop \u0027reimage_boot_volume\u0027 since we don\u0027t want to"},{"line_number":1749,"context_line":"            # pass it in the request body"},{"line_number":1750,"context_line":"            kwargs.pop(\u0027reimage_boot_volume\u0027)"},{"line_number":1751,"context_line":""},{"line_number":1752,"context_line":"        body \u003d {\u0027imageRef\u0027: base.getid(image)}"},{"line_number":1753,"context_line":"        if password is not None:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7384584f_d2b91513","line":1750,"in_reply_to":"8b3bc620_dd9c3e7c","updated":"2022-09-06 10:41:48.000000000","message":"strictly speaking we dont this should really be done in the osc patch\n\nall we care about in this patch is that the python binding actully work with 2.93\n\nit would be incorrect to reject reimage_boot_volume\u003dFalse, in the python bindings\nas we agreed to only do the check in the openstack client.\n\nthis addtional check is here to make sure you dont pass\n\nreimage_boot_volume for \u003c2.93 but that should be caught in osc so im not really sure how you get here.","commit_id":"14abc2fffc581cdcebf73b79305ee1afd9542835"}],"releasenotes/notes/add-support-for-volume-backed-rebuild-6a32d9d88fed6b4a.yaml":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"99e13f80f6665c32ad7d24c6a9dbe8eefa6b327c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Added support for `microversion 2.91`_."},{"line_number":5,"context_line":"    This microversion provides the ability to rebuild a volume"},{"line_number":6,"context_line":"    backed instance (``nova rebuild --reimage-boot-volume``)."},{"line_number":7,"context_line":"    .. _microversion 2.90: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion-2-90"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"71a64ed4_86bb7724","line":7,"range":{"start_line":7,"start_character":119,"end_line":7,"end_character":123},"updated":"2022-02-22 21:06:03.000000000","message":"2-91","commit_id":"ef248f9b7fec66949b056109248ac962e6caf5d1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"99e13f80f6665c32ad7d24c6a9dbe8eefa6b327c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Added support for `microversion 2.91`_."},{"line_number":5,"context_line":"    This microversion provides the ability to rebuild a volume"},{"line_number":6,"context_line":"    backed instance (``nova rebuild --reimage-boot-volume``)."},{"line_number":7,"context_line":"    .. _microversion 2.90: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion-2-90"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2800b0b0_dcb0cc90","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":25},"updated":"2022-02-22 21:06:03.000000000","message":"2.91","commit_id":"ef248f9b7fec66949b056109248ac962e6caf5d1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8471bf51a2cf3bd52b43176d284499f6d518d545","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added support for `microversion 2.91`_."},{"line_number":5,"context_line":"    This microversion provides the ability to rebuild a volume"},{"line_number":6,"context_line":"    backed instance (``nova rebuild --reimage-boot-volume``)."},{"line_number":7,"context_line":"    .. _microversion 2.90: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion-2-90"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0a559ef9_12c569e6","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":25},"in_reply_to":"2800b0b0_dcb0cc90","updated":"2022-02-24 07:39:02.000000000","message":"Done","commit_id":"ef248f9b7fec66949b056109248ac962e6caf5d1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8471bf51a2cf3bd52b43176d284499f6d518d545","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Added support for `microversion 2.91`_."},{"line_number":5,"context_line":"    This microversion provides the ability to rebuild a volume"},{"line_number":6,"context_line":"    backed instance (``nova rebuild --reimage-boot-volume``)."},{"line_number":7,"context_line":"    .. _microversion 2.90: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion-2-90"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d0c570ea_3cbc0e53","line":7,"range":{"start_line":7,"start_character":119,"end_line":7,"end_character":123},"in_reply_to":"71a64ed4_86bb7724","updated":"2022-02-24 07:39:02.000000000","message":"Done","commit_id":"ef248f9b7fec66949b056109248ac962e6caf5d1"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e575a525e01a4d917ec013cd18ab613366495bb9","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for `microversion 2.91`_."},{"line_number":5,"context_line":"    This microversion provides the ability to rebuild a volume"},{"line_number":6,"context_line":"    backed instance (``nova rebuild --reimage-boot-volume``)."},{"line_number":7,"context_line":"    .. _microversion 2.91: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion-2-91"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"162b458f_c8d348d3","line":6,"updated":"2022-02-24 12:24:35.000000000","message":"Add a blank line between line 6 and line 7.","commit_id":"3196e7a0a5c123dacd4d7ff3648469406c637064"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3b27db0a5df9e01c120e9135406c6ccdf633019d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for `microversion 2.91`_."},{"line_number":5,"context_line":"    This microversion provides the ability to rebuild a volume"},{"line_number":6,"context_line":"    backed instance (``nova rebuild --reimage-boot-volume``)."},{"line_number":7,"context_line":"    .. _microversion 2.91: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion-2-91"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2a6cece3_8fb9bd94","line":6,"in_reply_to":"162b458f_c8d348d3","updated":"2022-02-25 18:32:12.000000000","message":"this still need to be updated since the command is no longer added","commit_id":"3196e7a0a5c123dacd4d7ff3648469406c637064"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"47960ca0766e7cf5b43bf8542667b31ecaefa47a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for `microversion 2.91`_."},{"line_number":5,"context_line":"    This microversion provides the ability to rebuild a volume"},{"line_number":6,"context_line":"    backed instance (``nova rebuild --reimage-boot-volume``)."},{"line_number":7,"context_line":"    .. _microversion 2.91: https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#microversion-2-91"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1b55ad3c_668d63cb","line":6,"in_reply_to":"2a6cece3_8fb9bd94","updated":"2022-02-25 18:35:44.000000000","message":"Done","commit_id":"3196e7a0a5c123dacd4d7ff3648469406c637064"}]}