)]}'
{"id":"openstack%2Fpython-novaclient~887268","triplet_id":"openstack%2Fpython-novaclient~master~I47d3b572247cc63e696c3feb0062fff8a633a55c","project":"openstack/python-novaclient","branch":"master","topic":"bug/2025358","attention_set":{},"removed_from_attention_set":{"34564":{"account":{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},"last_update":"2023-07-06 01:18:03.000000000","reason":"Change was abandoned"},"679":{"account":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"last_update":"2023-07-06 01:18:03.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I47d3b572247cc63e696c3feb0062fff8a633a55c","subject":"Do exact-matching when finding one instance by name","status":"ABANDONED","created":"2023-06-29 11:50:03.000000000","updated":"2023-07-06 01:18:03.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2fd028ac94402982f095936537ca21c3fa0f1d25","_number":887268,"virtual_id_number":887268,"owner":{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"tag":"autogenerated:zuul:check","value":1,"date":"2023-06-30 09:47:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-29 13:11:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-29 14:12:02.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"}],"messages":[{"id":"f6818d7f61149e83c9abda6c171c5b2a9faa33a8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},"date":"2023-06-29 11:50:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e27b078b83f91d9f18af457f5cb0b268bb256998","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-29 13:11:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f970fc80ba604cd3ae4b3288c95d550f\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f456c2000fe64ecda8578f5a2473b9c5 : SUCCESS in 1h 18m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/959fcd689c2e4430a653a42cd915bdfa : SUCCESS in 5m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/15282edd907d48c8a9f190d2f43c7506 : SUCCESS in 4m 55s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a3c4a3c123ae4b3eb37be8613b5f7b1c : SUCCESS in 4m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9f6a949abbbf4da98ccbf0957b9e5b2f : SUCCESS in 4m 22s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/7fc546ca597c4fa3a5c6ad2da6f8e7a1 : SUCCESS in 4m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0cccb82147104100b7f0cddb1c9d30c2 : SUCCESS in 6m 12s\n- python-novaclient-functional https://zuul.opendev.org/t/openstack/build/c74578728d0647cab0ef209134a747f8 : SUCCESS in 1h 14m 27s","accounts_in_message":[],"_revision_number":1},{"id":"a4d7473b021c04a9ccaabbe5b68afd1a3d6909d2","author":{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},"date":"2023-06-30 06:31:42.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"5ce1f05512d03583e1c2301d8f77681c70749ad3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},"date":"2023-06-30 08:13:50.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1\n* Workflow-1\n","accounts_in_message":[],"_revision_number":2},{"id":"6a90d882d5281fc88d1ea76d50f50c416507c3b8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-30 09:47:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9cbd11ebff3a46278049203e87d9cd03\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/c75187456b2641b3bc9656ddf286d16b : SUCCESS in 1h 32m 15s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5c6a7306158444ecb6411e2461c69cf5 : SUCCESS in 5m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/224ded6f86074a6fa5adff1bc60fde90 : SUCCESS in 4m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4999d44b88ca41f7b45abb55c62f7ea4 : SUCCESS in 5m 05s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5fdb5e8f5aa44a629635d2c6235f8d77 : SUCCESS in 4m 06s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/974f820bac374726a553d54669a82908 : SUCCESS in 4m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fac5716f71ae4589907c8dd0020a348b : SUCCESS in 5m 49s\n- python-novaclient-functional https://zuul.opendev.org/t/openstack/build/a48b6ce142eb4b31894359144844103e : SUCCESS in 47m 45s","accounts_in_message":[],"_revision_number":2},{"id":"2fd028ac94402982f095936537ca21c3fa0f1d25","tag":"autogenerated:gerrit:abandon","author":{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},"date":"2023-07-06 01:18:03.000000000","message":"Abandoned\n\nWe came to the following conclusion:\n~~~\nAfter discussing this issue with the team internally, this issue was already reported, but we considered it not a bug. Mainly because it can be \"workaround\" using the id.\nWe don\u0027t want to change anything in the client implementation as they are many implications.\n\nOne of the main reasons is that the API\u0027s regex is dependent on the underlying database. And users should not be aware of that.\nSo the team chooses to keep the actual code unchanged and document this behavior as a short and middle-term solution.\n\nHowever, the team is not opposed to deal with this problem as a long-term solution by changing the API modifying and making the regex a standard Python one and then enabling the usage of it by the client.\n~~~\nTherefore, I\u0027m abandoning this change.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2b601b4fa834d79948e14a2e36beddca06c56b0c","revisions":{"4d3fc0066169d0744c922c1fa68ace0571667357":{"kind":"REWORK","_number":1,"created":"2023-06-29 11:50:03.000000000","uploader":{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},"ref":"refs/changes/68/887268/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/68/887268/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/887268/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/887268/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/887268/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/68/887268/1"}}},"commit":{"parents":[{"commit":"e464940f39d1643128c9cef0b92e02c3d0e754c7","subject":"Typo - nova CLI deprecation warning","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e464940f39d1643128c9cef0b92e02c3d0e754c7"}]}],"author":{"name":"Yamato Tanaka","email":"yatanaka@redhat.com","date":"2023-06-29 11:43:57.000000000","tz":540},"committer":{"name":"Yamato Tanaka","email":"yatanaka@redhat.com","date":"2023-06-29 11:43:57.000000000","tz":540},"subject":"Do exact-matching when finding one instance by name","message":"Do exact-matching when finding one instance by name\n\nWhen we search an instance by its display_name, Nova API considered\nthe display_name as a regular expression.\n\nhttps://docs.openstack.org/api-ref/compute/?expanded\u003dlist-servers-detail\n\u003e name (Optional)\n\u003e query\n\u003e string\n\u003e Filters the response by a server name, as a string. You can use regular expressions in the query.\n\nHowever, in the current implementation, nova cli filter the\nresponse of the Nova API by exact-matching, not regular expression\nmatching. Because of this inconsistency, we cannot find instances whose\ndisplay_name contains special characters which has special meanings in\nregular expression, such as (){}[]?*, etc.\n\nThis change escapes these special characters before calling the Nova\nAPI. By this change, we can find instances by its display_name even if\nit contains these special characters.\n\nCloses-Bug: #2025358\nChange-Id: I47d3b572247cc63e696c3feb0062fff8a633a55c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4d3fc0066169d0744c922c1fa68ace0571667357"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/4d3fc0066169d0744c922c1fa68ace0571667357"}]},"branch":"refs/heads/master"},"2b601b4fa834d79948e14a2e36beddca06c56b0c":{"kind":"REWORK","_number":2,"created":"2023-06-30 08:13:50.000000000","uploader":{"_account_id":34564,"name":"Yamato Tanaka","email":"yatanaka@redhat.com","username":"yatanaka-1007"},"ref":"refs/changes/68/887268/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-novaclient","ref":"refs/changes/68/887268/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/887268/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/887268/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-novaclient refs/changes/68/887268/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-novaclient refs/changes/68/887268/2"}}},"commit":{"parents":[{"commit":"e464940f39d1643128c9cef0b92e02c3d0e754c7","subject":"Typo - nova CLI deprecation warning","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/e464940f39d1643128c9cef0b92e02c3d0e754c7"}]}],"author":{"name":"Yamato Tanaka","email":"yatanaka@redhat.com","date":"2023-06-29 11:43:57.000000000","tz":540},"committer":{"name":"Yamato Tanaka","email":"yatanaka@redhat.com","date":"2023-06-30 08:02:13.000000000","tz":540},"subject":"Do exact-matching when finding one instance by name","message":"Do exact-matching when finding one instance by name\n\nWhen we search an instance by its display_name, Nova API considered\nthe display_name as a regular expression.\n\nhttps://docs.openstack.org/api-ref/compute/?expanded\u003dlist-servers-detail\n\u003e name (Optional)\n\u003e query\n\u003e string\n\u003e Filters the response by a server name, as a string. You can use regular expressions in the query.\n\nHowever, in the current implementation, nova cli filter the\nresponse of the Nova API by exact-matching, not regular expression\nmatching. Because of this inconsistency, we cannot find instances whose\ndisplay_name contains special characters which has special meanings in\nregular expression, such as (){}[]?*, etc.\n\nThis change escapes these special characters before calling the Nova\nAPI. By this change, we can find instances by its display_name even if\nit contains these special characters.\n\nCloses-Bug: #2025358\nChange-Id: I47d3b572247cc63e696c3feb0062fff8a633a55c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2b601b4fa834d79948e14a2e36beddca06c56b0c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-novaclient/commit/2b601b4fa834d79948e14a2e36beddca06c56b0c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}