)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"193f4274fc878c2150a4dd184df444274a7acea4","unresolved":true,"context_lines":[{"line_number":10,"context_line":"tuple of four values, not three, for each value in _get_option_tuple,"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Provide compatibility across Pythons with some exception handling."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1363c0a4075acbdbdc59e16948596f1081aefc27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"47041d69_6cf905b2","line":13,"updated":"2024-08-19 12:51:19.000000000","message":"just so that your aware\n\nnova-client\u0027s cli has been deprecated and frozen for several years.\n\nwe will likely remove it in 2025.1 or 2025.2\nour goal woudl be to remove the python-novaclient deliverable entirly\nby 2026.1 if we can enabled that.\n\nthis cycle the openstack clinet finally was updated to not use opentack client at all and now just uses the sdk.\n\nwe are hopign that all the main openstack project will also move to the sdk before 2026.1 so we can retire this project.\n\n\nwe can fix the compatiblity for now but you should move away form usign this in production, documenation and new code.","commit_id":"6b02a82f95263e3a0be5eb02184420345b513cf4"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"267af56362ba312f144a061e2456bcde117a2319","unresolved":true,"context_lines":[{"line_number":10,"context_line":"tuple of four values, not three, for each value in _get_option_tuple,"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Provide compatibility across Pythons with some exception handling."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1363c0a4075acbdbdc59e16948596f1081aefc27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6c3e28c9_c2cc0819","line":13,"in_reply_to":"47041d69_6cf905b2","updated":"2024-08-19 12:58:39.000000000","message":"Hi sean\n\nI\u0027m not directly using the nova client; just updating packaging in Ubuntu and while this code still exists, it needs to pass tests.\n\nA move in process still as you state but hopefully one to complete soon!","commit_id":"6b02a82f95263e3a0be5eb02184420345b513cf4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"193f4274fc878c2150a4dd184df444274a7acea4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f9851b1_06c12bb3","updated":"2024-08-19 12:51:19.000000000","message":"-1 because of lack of tests","commit_id":"6b02a82f95263e3a0be5eb02184420345b513cf4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3fb7c7ba758dfd66b892d69ec0da20441ba00984","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"05e282cc_c5b663bd","updated":"2024-08-19 16:32:35.000000000","message":"i think we might have unrelated functional test failure so we might need to fix that first but lets see if its an intermittent failure or a repeatable one.","commit_id":"4629d4b28815eafe929f544c131855a6b97ca8df"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"21b940dbb140bb53964920b5eab2d7e7ca124d3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f3987fd_468a8f24","updated":"2024-11-22 13:58:26.000000000","message":"recheck","commit_id":"4629d4b28815eafe929f544c131855a6b97ca8df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b9256f98e8f4ed12b73d45a6b811393333bf3f13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc2191a3_f7c95803","updated":"2024-08-27 18:49:42.000000000","message":"the functional test failure is fixed by https://review.opendev.org/c/openstack/python-novaclient/+/927249/2","commit_id":"4629d4b28815eafe929f544c131855a6b97ca8df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82e31bc9110ad63d4fc3851644c4172fb64e4cdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"acd3b906_b7a52ada","updated":"2024-08-27 18:49:16.000000000","message":"this has better testing but https://review.opendev.org/c/openstack/python-novaclient/+/927251 has support for 3.12 as well\n\nill +2 both but i think stephens is likely the more future proof solution.","commit_id":"4629d4b28815eafe929f544c131855a6b97ca8df"}],"novaclient/shell.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ecf1df950de2166921345da0adacb988dced6c50","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2010 Jacob Kaplan-Moss"},{"line_number":2,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"b36bace9_4289bef3","line":1,"updated":"2024-08-19 12:56:26.000000000","message":"note as i said in the commit this submoduel of novaclint is feature froze adn deprecated for removal.\n\nits not really supported anymore and has not been for several years but we will accpet minor fixes like this.\n\n\nhowever when we deprecated support \nhttps://github.com/openstack/python-novaclient/commit/0fb7190c062a08a3969a71955c014e3a572cdc9e\n\nhttps://github.com/openstack/python-novaclient/blob/0fb7190c062a08a3969a71955c014e3a572cdc9e/setup.cfg#L24\n\nwe offcially only supprot up to python 3.9\n\nso nova client\u0027s shell (cli) is not supproted upstream on 3.10+\nit shoudl not be used in production anymore as it has been fully replaced by the openstack client.","commit_id":"6b02a82f95263e3a0be5eb02184420345b513cf4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"193f4274fc878c2150a4dd184df444274a7acea4","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                               for action, option, value in option_tuples]"},{"line_number":243,"context_line":"            if len(set(normalizeds)) \u003d\u003d 1:"},{"line_number":244,"context_line":"                return option_tuples[:1]"},{"line_number":245,"context_line":"        return option_tuples"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class OpenStackComputeShell(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5780dd87_cabaeb5a","line":245,"updated":"2024-08-19 12:51:19.000000000","message":"can you add a unit test that mocks\n\n_get_option_tuples\nand tests this funciton with both 3 args and 4 args per option","commit_id":"6b02a82f95263e3a0be5eb02184420345b513cf4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b355c9fedfe4efe5cae90586f922e17e9bcc187f","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                               for action, option, value in option_tuples]"},{"line_number":243,"context_line":"            if len(set(normalizeds)) \u003d\u003d 1:"},{"line_number":244,"context_line":"                return option_tuples[:1]"},{"line_number":245,"context_line":"        return option_tuples"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class OpenStackComputeShell(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"747fd36a_3de2654d","line":245,"in_reply_to":"537f61b9_533ea33f","updated":"2024-08-19 13:25:46.000000000","message":"im not suggesting removing any existing testing.\n\nim asking you to add a new test case to test the except fallback behavior.\n\nyes it can be tested by runnign the test under booth 3.10 and 3.11\n\nbut it would be nice to also test it explcitly in addtion to that.","commit_id":"6b02a82f95263e3a0be5eb02184420345b513cf4"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"267af56362ba312f144a061e2456bcde117a2319","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                               for action, option, value in option_tuples]"},{"line_number":243,"context_line":"            if len(set(normalizeds)) \u003d\u003d 1:"},{"line_number":244,"context_line":"                return option_tuples[:1]"},{"line_number":245,"context_line":"        return option_tuples"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class OpenStackComputeShell(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"537f61b9_533ea33f","line":245,"in_reply_to":"5780dd87_cabaeb5a","updated":"2024-08-19 12:58:39.000000000","message":"I\u0027d actually rather leave the direct testing with the argparse super class in place; we test with Pythons before an after the change in the behaviour which captures both paths through the code.\n\nIf we mock, then we insulate the test from any future change in internal behaviours (which may be moot when plans to remove novaclient complete).","commit_id":"6b02a82f95263e3a0be5eb02184420345b513cf4"},{"author":{"_account_id":935,"name":"James Page","email":"ringo.page@gmail.com","username":"james-page"},"change_message_id":"822c8ce3ebcdc93c903cce76e11e32166043c85c","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                               for action, option, value in option_tuples]"},{"line_number":243,"context_line":"            if len(set(normalizeds)) \u003d\u003d 1:"},{"line_number":244,"context_line":"                return option_tuples[:1]"},{"line_number":245,"context_line":"        return option_tuples"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class OpenStackComputeShell(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"76f57bdf_4d15c4ec","line":245,"in_reply_to":"747fd36a_3de2654d","updated":"2024-08-19 15:15:24.000000000","message":"ack - I\u0027ve added some synthetic tests to test the parsing of the different return tuple formats.\n\nI tried something a little more integrated but that proved challenging with the use of methods in the argparse base class.","commit_id":"6b02a82f95263e3a0be5eb02184420345b513cf4"}]}