)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":39263,"name":"Udayendu Kar","display_name":"Udayendu Kar","email":"udayendu.kar@gmail.com","username":"udayendu.kar"},"change_message_id":"137fb06363c6c6ac23d87a315f46fd472edd554a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2ed8d44_d0c2bee5","updated":"2026-07-27 14:32:48.000000000","message":"Thanks @andr.kurilin@gmail.com for the suggestion. Fixing it now.","commit_id":"b74fa01f64ba35c81e6d9ab24f37d96aaa99559d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fa4ae1d4a44ca15ce55c2eccccabd0d8f87a46c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"186eb58b_c54b3f22","updated":"2026-06-29 12:45:40.000000000","message":"The osprofiler is defined in test-requirements.txt.\n\nhttps://opendev.org/openstack/python-novaclient/src/branch/master/test-requirements.txt#L5\n\nThen the osprofiler is installed when testing.\nI\u0027m not sure that this change has to be applied.","commit_id":"b74fa01f64ba35c81e6d9ab24f37d96aaa99559d"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7505244e53ad467f6971577203333513a44e04b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3795026e_5049e074","updated":"2026-07-23 07:28:10.000000000","message":"osprofiler is listed in test-requirements for novaclient. If it is not installed - it is a problem of test environment, and such cases should not be silently ignored (nobody checks skipped tests). If you want to bring more visibility, replace skipTest with fail statement.","commit_id":"b74fa01f64ba35c81e6d9ab24f37d96aaa99559d"},{"author":{"_account_id":39263,"name":"Udayendu Kar","display_name":"Udayendu Kar","email":"udayendu.kar@gmail.com","username":"udayendu.kar"},"change_message_id":"f35d95de543d2c5aa8a383a6096f7faa5d09a45a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a2e333f_a3253472","in_reply_to":"186eb58b_c54b3f22","updated":"2026-07-04 06:29:05.000000000","message":"This patch is to make the error traces more meaningful in case the osprofiler is not installed for some reason, its not able to detect the exact issue. And if this path will be there, it will pinpoint the issue.","commit_id":"b74fa01f64ba35c81e6d9ab24f37d96aaa99559d"}],"novaclient/tests/unit/test_shell.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7505244e53ad467f6971577203333513a44e04b5","unresolved":true,"context_lines":[{"line_number":658,"context_line":"        self.make_env()"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        if not novaclient.shell.osprofiler_profiler:"},{"line_number":661,"context_line":"            self.skipTest(\"osprofiler not installed\")"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        def client(*args, **kwargs):"},{"line_number":664,"context_line":"            self.assertEqual(\u0027swordfish\u0027, kwargs[\u0027profile\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"85076b64_d6ccdd10","line":661,"updated":"2026-07-23 07:28:10.000000000","message":"```suggestion\n            self.fail(\"osprofiler not installed\")\n```","commit_id":"b74fa01f64ba35c81e6d9ab24f37d96aaa99559d"},{"author":{"_account_id":39263,"name":"Udayendu Kar","display_name":"Udayendu Kar","email":"udayendu.kar@gmail.com","username":"udayendu.kar"},"change_message_id":"137fb06363c6c6ac23d87a315f46fd472edd554a","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        self.make_env()"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        if not novaclient.shell.osprofiler_profiler:"},{"line_number":661,"context_line":"            self.skipTest(\"osprofiler not installed\")"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        def client(*args, **kwargs):"},{"line_number":664,"context_line":"            self.assertEqual(\u0027swordfish\u0027, kwargs[\u0027profile\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"eac9168d_e7fa1d10","line":661,"in_reply_to":"85076b64_d6ccdd10","updated":"2026-07-27 14:32:48.000000000","message":"Acknowledged","commit_id":"b74fa01f64ba35c81e6d9ab24f37d96aaa99559d"}]}