)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"da35bba79cff1c40036dde003811cd6e1cf1b81c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"is hacking, which is the same as in other repositories like"},{"line_number":12,"context_line":"ceilometer, python-aodhclient, python-glanceclient."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This also adds a i18n.py file for the translation, which"},{"line_number":15,"context_line":"again follows similar pattern as the repositories mentioned"},{"line_number":16,"context_line":"above."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I08bd18171f00d023c6f3f3c64d18f03032a6af96"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cee3eb59_64c61922","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":6},"updated":"2023-11-07 14:17:19.000000000","message":"Is there a reason why these two unrelated changes are combined as one PS?","commit_id":"8e2b3f920d4a18094071fd72e2fba82fefa00a29"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"26324f0edb319847a8479f474d4452632d4d2657","unresolved":true,"context_lines":[{"line_number":11,"context_line":"is hacking, which is the same as in other repositories like"},{"line_number":12,"context_line":"ceilometer, python-aodhclient, python-glanceclient."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This also adds a i18n.py file for the translation, which"},{"line_number":15,"context_line":"again follows similar pattern as the repositories mentioned"},{"line_number":16,"context_line":"above."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I08bd18171f00d023c6f3f3c64d18f03032a6af96"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"acccd295_b1363937","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":6},"in_reply_to":"c6b2caa2_73815a85","updated":"2023-11-07 16:13:06.000000000","message":"Ah that\u0027s the background for it. Yeah it would be very nice if you spilt the tox.ini change separate from the i18n just for clarity that they are indeed addressing two different things, even loosely related. Happy to +2 them both","commit_id":"8e2b3f920d4a18094071fd72e2fba82fefa00a29"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"cfbc081b60f364feed421d5073567e917970fc4c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"is hacking, which is the same as in other repositories like"},{"line_number":12,"context_line":"ceilometer, python-aodhclient, python-glanceclient."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This also adds a i18n.py file for the translation, which"},{"line_number":15,"context_line":"again follows similar pattern as the repositories mentioned"},{"line_number":16,"context_line":"above."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I08bd18171f00d023c6f3f3c64d18f03032a6af96"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c6b2caa2_73815a85","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":6},"in_reply_to":"cee3eb59_64c61922","updated":"2023-11-07 14:33:20.000000000","message":"To me these changes were related at the time of working on it. I thought, that the creation of the i18n file would fix the issue. In the end, the issue was fixed by the tox.ini changes instead, but the i18n file still seems like the correct thing to do. I left it as one PS as all of this is still related to translations. I can split it though if you think it\u0027ll be better.","commit_id":"8e2b3f920d4a18094071fd72e2fba82fefa00a29"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"da35bba79cff1c40036dde003811cd6e1cf1b81c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"167ea0de_869dd620","updated":"2023-11-07 14:17:19.000000000","message":"I don\u0027t have anything against the changes proposed themselves. Just would like to understand why these two seemingly unrelated changes are proposed as one before giving my +2","commit_id":"8e2b3f920d4a18094071fd72e2fba82fefa00a29"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"09f54e7a774b0d6ced794e179034adcf0bdb9e8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1fb1824c_049dd2f1","updated":"2023-11-08 14:30:59.000000000","message":"Thanks Jaromir!","commit_id":"74d9094e5ed20f82178d5782c08059d1444d2eb9"}]}