)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9b03dcede030f39afe622dd70fa515a657ec146f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"870ace71_b90a1d4c","updated":"2025-06-02 06:08:11.000000000","message":"One question inside, otherwise looks good","commit_id":"e81c54e4974c8b8ceb209b201776bfdd642f081f"}],"observabilityclient/v1/client.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9b03dcede030f39afe622dd70fa515a657ec146f","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        session_options \u003d session_options or {}"},{"line_number":29,"context_line":"        adapter_options \u003d adapter_options or {}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        adapter_options.setdefault(\u0027service_type\u0027, \"prometheus\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        if session is None:"},{"line_number":34,"context_line":"            session \u003d keystoneauth1.session.Session(**session_options)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7d51d41e_68e218a2","line":31,"updated":"2025-06-02 06:08:11.000000000","message":"Is the change from metric service to prometheus service intended?","commit_id":"e81c54e4974c8b8ceb209b201776bfdd642f081f"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"97614ee87d62c04588b12509589137c93dcf0291","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        session_options \u003d session_options or {}"},{"line_number":29,"context_line":"        adapter_options \u003d adapter_options or {}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        adapter_options.setdefault(\u0027service_type\u0027, \"prometheus\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        if session is None:"},{"line_number":34,"context_line":"            session \u003d keystoneauth1.session.Session(**session_options)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8369b2b7_98592097","line":31,"in_reply_to":"7d51d41e_68e218a2","updated":"2025-06-02 06:32:55.000000000","message":"Yes. The adapter_options were previously unused, I think the piece of code was copied from the gnocchiclient back when the observabilityclient was first written.\n\n\"prometheus\" is the service type we agreed to use for Aetos (and prometheus if the administrators don\u0027t want Aetos) back during the PTG.\n\nUsing the observabilityclient with service_type\u003d\"metric\" (which means gnocchi) doesn\u0027t make sense and naming the prometheus / aetos endpoints as \"metric\" in keystone would get pretty confusing imo.","commit_id":"e81c54e4974c8b8ceb209b201776bfdd642f081f"}]}