)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ea2a69772292e29ae17da85e531f6e101da1997","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  how it\u0027s created for Prometheus."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Changes to the previous behavior of get_prometheus_client:"},{"line_number":17,"context_line":"- It\u0027s not possible to override PrometheusAPIClient arguments with"},{"line_number":18,"context_line":"  environment variables if they\u0027re retrieved from Keystone."},{"line_number":19,"context_line":"- It\u0027s not possible to use config file / environment variables to"},{"line_number":20,"context_line":"  connect to Aetos (the session parameter won\u0027t be passed to"},{"line_number":21,"context_line":"  PrometheusAPIClient)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"987cdcb5_efbb22f3","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":59},"updated":"2025-07-31 14:57:00.000000000","message":"I wonder if this is worth describing in a release note","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"ff2213e6664331ad90cd24c46359d48b44e67b5a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  how it\u0027s created for Prometheus."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Changes to the previous behavior of get_prometheus_client:"},{"line_number":17,"context_line":"- It\u0027s not possible to override PrometheusAPIClient arguments with"},{"line_number":18,"context_line":"  environment variables if they\u0027re retrieved from Keystone."},{"line_number":19,"context_line":"- It\u0027s not possible to use config file / environment variables to"},{"line_number":20,"context_line":"  connect to Aetos (the session parameter won\u0027t be passed to"},{"line_number":21,"context_line":"  PrometheusAPIClient)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e13ad40c_6152b56e","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":59},"in_reply_to":"987cdcb5_efbb22f3","updated":"2025-07-31 20:47:03.000000000","message":"Done","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ea2a69772292e29ae17da85e531f6e101da1997","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Changes to the previous behavior of get_prometheus_client:"},{"line_number":17,"context_line":"- It\u0027s not possible to override PrometheusAPIClient arguments with"},{"line_number":18,"context_line":"  environment variables if they\u0027re retrieved from Keystone."},{"line_number":19,"context_line":"- It\u0027s not possible to use config file / environment variables to"},{"line_number":20,"context_line":"  connect to Aetos (the session parameter won\u0027t be passed to"},{"line_number":21,"context_line":"  PrometheusAPIClient)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"I think even though, there are some changes to how Aetos can access"},{"line_number":24,"context_line":"can be configured, it\u0027s getting it a bit closer to how other services"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"622d2784_055a8b55","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":22},"updated":"2025-07-31 14:57:00.000000000","message":"IIUC this is not accurate because request session is set internally by PrometheusAPIClient if not passed or do I misunderstand something ?","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"38720b4861da524f01ad2de471115a533739a88c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Changes to the previous behavior of get_prometheus_client:"},{"line_number":17,"context_line":"- It\u0027s not possible to override PrometheusAPIClient arguments with"},{"line_number":18,"context_line":"  environment variables if they\u0027re retrieved from Keystone."},{"line_number":19,"context_line":"- It\u0027s not possible to use config file / environment variables to"},{"line_number":20,"context_line":"  connect to Aetos (the session parameter won\u0027t be passed to"},{"line_number":21,"context_line":"  PrometheusAPIClient)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"I think even though, there are some changes to how Aetos can access"},{"line_number":24,"context_line":"can be configured, it\u0027s getting it a bit closer to how other services"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"03fae667_ccdf144a","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":22},"in_reply_to":"3d9533c2_b5ae299c","updated":"2025-08-06 08:58:11.000000000","message":"I guess access to aetos can be still allowed if noauth is used there but I\u0027m not very certain about it and don\u0027t know how many people would use aetos without auth so I\u0027m ok with the current explanation.","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"ff2213e6664331ad90cd24c46359d48b44e67b5a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Changes to the previous behavior of get_prometheus_client:"},{"line_number":17,"context_line":"- It\u0027s not possible to override PrometheusAPIClient arguments with"},{"line_number":18,"context_line":"  environment variables if they\u0027re retrieved from Keystone."},{"line_number":19,"context_line":"- It\u0027s not possible to use config file / environment variables to"},{"line_number":20,"context_line":"  connect to Aetos (the session parameter won\u0027t be passed to"},{"line_number":21,"context_line":"  PrometheusAPIClient)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"I think even though, there are some changes to how Aetos can access"},{"line_number":24,"context_line":"can be configured, it\u0027s getting it a bit closer to how other services"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9216cabc_9cab8be5","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":22},"in_reply_to":"622d2784_055a8b55","updated":"2025-07-31 20:47:03.000000000","message":"You\u0027re right about this not being completely accurate. When I was thinking about \"session\", I meant \"keystone session\". The PrometheusAPIClient will initialize its own session object from the python requests library. But in that case, the requests won\u0027t include keystone tokens and so it can\u0027t be used for accessing Aetos.\n\nI adjusted the commit to make it more accurate. Is it better now?","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"aaa35b0c6066b315193410685d03a8cac7fb0703","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Changes to the previous behavior of get_prometheus_client:"},{"line_number":17,"context_line":"- It\u0027s not possible to override PrometheusAPIClient arguments with"},{"line_number":18,"context_line":"  environment variables if they\u0027re retrieved from Keystone."},{"line_number":19,"context_line":"- It\u0027s not possible to use config file / environment variables to"},{"line_number":20,"context_line":"  connect to Aetos (the session parameter won\u0027t be passed to"},{"line_number":21,"context_line":"  PrometheusAPIClient)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"I think even though, there are some changes to how Aetos can access"},{"line_number":24,"context_line":"can be configured, it\u0027s getting it a bit closer to how other services"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3d9533c2_b5ae299c","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":22},"in_reply_to":"9216cabc_9cab8be5","updated":"2025-08-05 19:55:59.000000000","message":"@kajinamit@oss.nttdata.com ?","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"}],"observabilityclient/utils/metric_utils.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ea2a69772292e29ae17da85e531f6e101da1997","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    return None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def get_prom_client_from_keystone(session, adapter_options\u003d{}):"},{"line_number":53,"context_line":"    endpoint \u003d adapter.Adapter("},{"line_number":54,"context_line":"        session\u003dsession, **adapter_options"},{"line_number":55,"context_line":"    ).get_endpoint()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef0442bd_8a17e205","line":52,"range":{"start_line":52,"start_character":59,"end_line":52,"end_character":61},"updated":"2025-07-31 14:57:00.000000000","message":"We should not use mutable value as a default. We should use None instead and replace it by {} in the subsequent logic.\n\nI know this is the problem already implemented but I think it\u0027s good canche to fix it.","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"ff2213e6664331ad90cd24c46359d48b44e67b5a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    return None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def get_prom_client_from_keystone(session, adapter_options\u003d{}):"},{"line_number":53,"context_line":"    endpoint \u003d adapter.Adapter("},{"line_number":54,"context_line":"        session\u003dsession, **adapter_options"},{"line_number":55,"context_line":"    ).get_endpoint()"}],"source_content_type":"text/x-python","patch_set":1,"id":"386f7b68_78017aa7","line":52,"range":{"start_line":52,"start_character":59,"end_line":52,"end_character":61},"in_reply_to":"ef0442bd_8a17e205","updated":"2025-07-31 20:47:03.000000000","message":"Done","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ea2a69772292e29ae17da85e531f6e101da1997","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    tls \u003d parsed_url.scheme \u003d\u003d \"https\""},{"line_number":61,"context_line":"    if parsed_url.port is not None:"},{"line_number":62,"context_line":"        port \u003d parsed_url.port"},{"line_number":63,"context_line":"    elif parsed_url.scheme \u003d\u003d \"https\":"},{"line_number":64,"context_line":"        port \u003d 443"},{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        port \u003d 80"},{"line_number":67,"context_line":"    escaped_host \u003d netutils.escape_ipv6(host)"},{"line_number":68,"context_line":"    client \u003d PrometheusAPIClient("},{"line_number":69,"context_line":"        f\"{escaped_host}:{port}\", session, root_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"35747cf5_32730e20","line":66,"range":{"start_line":63,"start_character":0,"end_line":66,"end_character":17},"updated":"2025-07-31 14:57:00.000000000","message":"Maybe we can just omit port in case a standard one (443/80) is used ? Even if we keep these I think using the tls boolean here would be cleaner.","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"ff2213e6664331ad90cd24c46359d48b44e67b5a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    tls \u003d parsed_url.scheme \u003d\u003d \"https\""},{"line_number":61,"context_line":"    if parsed_url.port is not None:"},{"line_number":62,"context_line":"        port \u003d parsed_url.port"},{"line_number":63,"context_line":"    elif parsed_url.scheme \u003d\u003d \"https\":"},{"line_number":64,"context_line":"        port \u003d 443"},{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        port \u003d 80"},{"line_number":67,"context_line":"    escaped_host \u003d netutils.escape_ipv6(host)"},{"line_number":68,"context_line":"    client \u003d PrometheusAPIClient("},{"line_number":69,"context_line":"        f\"{escaped_host}:{port}\", session, root_path"}],"source_content_type":"text/x-python","patch_set":1,"id":"56761d12_77865b83","line":66,"range":{"start_line":63,"start_character":0,"end_line":66,"end_character":17},"in_reply_to":"35747cf5_32730e20","updated":"2025-07-31 20:47:03.000000000","message":"It\u0027s true that we actually don\u0027t need this for the default ports.","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3ea2a69772292e29ae17da85e531f6e101da1997","unresolved":true,"context_lines":[{"line_number":109,"context_line":"    return client"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def get_prometheus_client(session\u003dNone, adapter_options\u003d{}):"},{"line_number":113,"context_line":"    keystone_error \u003d None"},{"line_number":114,"context_line":"    if session is not None:"},{"line_number":115,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f441b9e_3eb644d2","line":112,"range":{"start_line":112,"start_character":56,"end_line":112,"end_character":58},"updated":"2025-07-31 14:57:00.000000000","message":"Ditto. Use None.","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"ff2213e6664331ad90cd24c46359d48b44e67b5a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    return client"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"def get_prometheus_client(session\u003dNone, adapter_options\u003d{}):"},{"line_number":113,"context_line":"    keystone_error \u003d None"},{"line_number":114,"context_line":"    if session is not None:"},{"line_number":115,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"89e1d4c1_27f75118","line":112,"range":{"start_line":112,"start_character":56,"end_line":112,"end_character":58},"in_reply_to":"3f441b9e_3eb644d2","updated":"2025-07-31 20:47:03.000000000","message":"Done","commit_id":"07fa7dfad167b4cf76e0abcef3b3fa8ea59e91c7"}]}