)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"410265aa92d3f6af6dd091116f3744b434f2a3c8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-06-26 19:28:24 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Keep session transport options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"currently there\u0027s no way to use observabilityclient against Keystone"},{"line_number":10,"context_line":"endpoint (Aetos) that uses self-signed TLS cert,"},{"line_number":11,"context_line":"as verify/insecure option set by clouds.yaml/openstackclient"},{"line_number":12,"context_line":"is effectively overridden based solely on endpoint URL scheme."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Instead, presume that all transport options are already properly set,"},{"line_number":15,"context_line":"and do not touch them at all when working with pre-created session."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I423f1f444c4d5ac4357db6e3c57c0e486c61c79d"},{"line_number":18,"context_line":"Signed-off-by: Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a3ed75dc_5668e0a5","line":15,"range":{"start_line":7,"start_character":0,"end_line":15,"end_character":67},"updated":"2026-06-26 16:55:47.000000000","message":"This looks like a release note is required, since this addresses a known issue.","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"19bb6c3c67899aa4f0dd2efeb197287c29fc2ba1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-06-26 19:28:24 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Keep session transport options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"currently there\u0027s no way to use observabilityclient against Keystone"},{"line_number":10,"context_line":"endpoint (Aetos) that uses self-signed TLS cert,"},{"line_number":11,"context_line":"as verify/insecure option set by clouds.yaml/openstackclient"},{"line_number":12,"context_line":"is effectively overridden based solely on endpoint URL scheme."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Instead, presume that all transport options are already properly set,"},{"line_number":15,"context_line":"and do not touch them at all when working with pre-created session."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I423f1f444c4d5ac4357db6e3c57c0e486c61c79d"},{"line_number":18,"context_line":"Signed-off-by: Pavlo Shchelokovskyy \u003cshchelokovskyy@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c4e697e1_7264148c","line":15,"range":{"start_line":7,"start_character":0,"end_line":15,"end_character":67},"in_reply_to":"a3ed75dc_5668e0a5","updated":"2026-07-28 16:41:59.000000000","message":"Done","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"410265aa92d3f6af6dd091116f3744b434f2a3c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"438b8565_9e878d2a","updated":"2026-06-26 16:55:47.000000000","message":"I\u0027ve left suggestions for additional test coverage and release notes","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"}],"observabilityclient/prometheus_client.py":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"410265aa92d3f6af6dd091116f3744b434f2a3c8","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class PrometheusAPIClient:"},{"line_number":56,"context_line":"    def __init__(self, host, session\u003dNone, root_path\u003d\"\", scheme\u003dNone):"},{"line_number":57,"context_line":"        self._scheme \u003d scheme"},{"line_number":58,"context_line":"        self._host \u003d host"},{"line_number":59,"context_line":"        if not self._host.endswith(\u0027/\u0027):"},{"line_number":60,"context_line":"            self._host +\u003d \u0027/\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"4010ca14_34c95a6b","line":57,"updated":"2026-06-26 16:55:47.000000000","message":"Since there\u0027s a new parameter added here, update the unit tests to:\n* Validate behaviour when schema is passed\n* Validate behaviour when schema is not passed","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"19bb6c3c67899aa4f0dd2efeb197287c29fc2ba1","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class PrometheusAPIClient:"},{"line_number":56,"context_line":"    def __init__(self, host, session\u003dNone, root_path\u003d\"\", scheme\u003dNone):"},{"line_number":57,"context_line":"        self._scheme \u003d scheme"},{"line_number":58,"context_line":"        self._host \u003d host"},{"line_number":59,"context_line":"        if not self._host.endswith(\u0027/\u0027):"},{"line_number":60,"context_line":"            self._host +\u003d \u0027/\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"11c71298_93a1e518","line":57,"in_reply_to":"4010ca14_34c95a6b","updated":"2026-07-28 16:41:59.000000000","message":"Done","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"410265aa92d3f6af6dd091116f3744b434f2a3c8","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    def set_basic_auth(self, auth_user, auth_password):"},{"line_number":77,"context_line":"        self._session.auth \u003d (auth_user, auth_password)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _get_url(self, endpoint):"},{"line_number":80,"context_line":"        if self._scheme is None:"},{"line_number":81,"context_line":"            scheme \u003d \u0027https\u0027 if self._session.verify else \u0027http\u0027"},{"line_number":82,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c3776922_53ac7658","line":79,"updated":"2026-06-26 16:55:47.000000000","message":"Update the tests to validate this behaviour, i.e. make sure the url is appropriately set with/without self._scheme being set","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"19bb6c3c67899aa4f0dd2efeb197287c29fc2ba1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def set_basic_auth(self, auth_user, auth_password):"},{"line_number":77,"context_line":"        self._session.auth \u003d (auth_user, auth_password)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _get_url(self, endpoint):"},{"line_number":80,"context_line":"        if self._scheme is None:"},{"line_number":81,"context_line":"            scheme \u003d \u0027https\u0027 if self._session.verify else \u0027http\u0027"},{"line_number":82,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c49c93ba_52487ebc","line":79,"in_reply_to":"c3776922_53ac7658","updated":"2026-07-28 16:41:59.000000000","message":"Done","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"}],"observabilityclient/utils/metric_utils.py":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"410265aa92d3f6af6dd091116f3744b434f2a3c8","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    return None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def get_prom_client_from_keystone(session, adapter_options\u003dNone):"},{"line_number":53,"context_line":"    if adapter_options is None:"},{"line_number":54,"context_line":"        adapter_options \u003d {}"},{"line_number":55,"context_line":"    endpoint \u003d adapter.Adapter("}],"source_content_type":"text/x-python","patch_set":1,"id":"2d0d20ad_fc3a7541","line":52,"updated":"2026-06-26 16:55:47.000000000","message":"This needs a test to make sure we continue to pass the expected parameters when creating the client.","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"19bb6c3c67899aa4f0dd2efeb197287c29fc2ba1","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    return None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def get_prom_client_from_keystone(session, adapter_options\u003dNone):"},{"line_number":53,"context_line":"    if adapter_options is None:"},{"line_number":54,"context_line":"        adapter_options \u003d {}"},{"line_number":55,"context_line":"    endpoint \u003d adapter.Adapter("}],"source_content_type":"text/x-python","patch_set":1,"id":"b6dd9549_b2921d27","line":52,"in_reply_to":"2d0d20ad_fc3a7541","updated":"2026-07-28 16:41:59.000000000","message":"not sure wdym here","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"48aa503f896f56b3b4a9da39f7bad88746e62419","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    return None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"def get_prom_client_from_keystone(session, adapter_options\u003dNone):"},{"line_number":53,"context_line":"    if adapter_options is None:"},{"line_number":54,"context_line":"        adapter_options \u003d {}"},{"line_number":55,"context_line":"    endpoint \u003d adapter.Adapter("}],"source_content_type":"text/x-python","patch_set":1,"id":"b4adaaa3_aaaa2560","line":52,"in_reply_to":"b6dd9549_b2921d27","updated":"2026-07-28 17:05:50.000000000","message":"Add a test for this method, which checks that when the scheme is http vs https, then the PrometheusClient is created with the expected parameter for scheme.","commit_id":"84e1af7ae0ad6ba22e66288962dfa9b61c02e739"}]}