)]}'
{"octaviaclient/api/load_balancer_v2.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7af97e9a56402e3ec6d4e082d8e70808599e7ff3","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            A dict of the created listener\u0027s settings"},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        url \u003d const.BASE_LISTENER_URL"},{"line_number":137,"context_line":"        listener \u003d self.create(url, method\u003d\u0027POST\u0027, **kwargs)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        return listener"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_aed76aee","line":137,"range":{"start_line":137,"start_character":36,"end_line":137,"end_character":49},"updated":"2017-06-02 18:57:34.000000000","message":"Post is default and this param is not on the load balancer create.  We should be consistent and either remove this one or add it to load balancer","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"62064bf4d6bb0b317c05ad0d5be1702095013512","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            A dict of the created listener\u0027s settings"},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        url \u003d const.BASE_LISTENER_URL"},{"line_number":137,"context_line":"        listener \u003d self.create(url, method\u003d\u0027POST\u0027, **kwargs)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        return listener"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_13aac817","line":137,"range":{"start_line":137,"start_character":36,"end_line":137,"end_character":49},"in_reply_to":"df140735_aed76aee","updated":"2017-06-05 23:30:38.000000000","message":"Done","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"}],"octaviaclient/osc/v2/constants.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7af97e9a56402e3ec6d4e082d8e70808599e7ff3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u0027Provider\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LISTENER_ROWS \u003d ("},{"line_number":41,"context_line":"    \u0027Admin State Up\u0027,"},{"line_number":42,"context_line":"    \u0027Connection Limit\u0027,"},{"line_number":43,"context_line":"    \u0027Created At\u0027,"},{"line_number":44,"context_line":"    \u0027Default Pool ID\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_eefa0273","line":41,"range":{"start_line":41,"start_character":5,"end_line":41,"end_character":19},"updated":"2017-06-02 18:57:34.000000000","message":"Same question here about these being pretty names vs. the API names.","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"62064bf4d6bb0b317c05ad0d5be1702095013512","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u0027Provider\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LISTENER_ROWS \u003d ("},{"line_number":41,"context_line":"    \u0027Admin State Up\u0027,"},{"line_number":42,"context_line":"    \u0027Connection Limit\u0027,"},{"line_number":43,"context_line":"    \u0027Created At\u0027,"},{"line_number":44,"context_line":"    \u0027Default Pool ID\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_f3a4f44c","line":41,"range":{"start_line":41,"start_character":5,"end_line":41,"end_character":19},"in_reply_to":"df140735_eefa0273","updated":"2017-06-05 23:30:38.000000000","message":"Done","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7af97e9a56402e3ec6d4e082d8e70808599e7ff3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027Project ID\u0027,"},{"line_number":54,"context_line":"    \u0027Protocol\u0027,"},{"line_number":55,"context_line":"    \u0027Protocol Port\u0027,"},{"line_number":56,"context_line":"    \u0027Provisioning Status\u0027,"},{"line_number":57,"context_line":"    \u0027SNI Container Refs\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"LISTENER_COLUMNS \u003d ("}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_6e15d29b","line":56,"updated":"2017-06-02 18:57:34.000000000","message":"updated_at is missing here.","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"62064bf4d6bb0b317c05ad0d5be1702095013512","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \u0027Project ID\u0027,"},{"line_number":54,"context_line":"    \u0027Protocol\u0027,"},{"line_number":55,"context_line":"    \u0027Protocol Port\u0027,"},{"line_number":56,"context_line":"    \u0027Provisioning Status\u0027,"},{"line_number":57,"context_line":"    \u0027SNI Container Refs\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"LISTENER_COLUMNS \u003d ("}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_b351dc38","line":56,"in_reply_to":"df140735_6e15d29b","updated":"2017-06-05 23:30:38.000000000","message":"Done","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f47653937369749cf3d4b5aa5a4323ce6067954e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0027Provisioning Status\u0027,"},{"line_number":57,"context_line":"    \u0027SNI Container Refs\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"LISTENER_COLUMNS \u003d ("},{"line_number":60,"context_line":"    \u0027ID\u0027,"},{"line_number":61,"context_line":"    \u0027Name\u0027,"},{"line_number":62,"context_line":"    \u0027Project ID\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_e2c33388","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":20},"updated":"2017-06-02 21:53:39.000000000","message":"The list of columns listner list is returning is wrong.  It should be:\n\n| id | default_pool_id | name | project_id | protocol | protocol_port | admin_state_up |","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"}],"octaviaclient/osc/v2/listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7af97e9a56402e3ec6d4e082d8e70808599e7ff3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            help\u003d\"The protocol for the listener\""},{"line_number":53,"context_line":"        )"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--connection-limit\u0027,"},{"line_number":56,"context_line":"            metavar\u003d\u0027\u003climit\u003e\u0027,"},{"line_number":57,"context_line":"            help\u003d\"The maximum number of connections permitted for this \""},{"line_number":58,"context_line":"                 \"listener.\""}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_d153636a","line":55,"updated":"2017-06-02 18:57:34.000000000","message":"I wonder if we should do type checking and validation here as well or just send it through to the API.\n\nThis could be:\ntype\u003dint","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"62064bf4d6bb0b317c05ad0d5be1702095013512","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            help\u003d\"The protocol for the listener\""},{"line_number":53,"context_line":"        )"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--connection-limit\u0027,"},{"line_number":56,"context_line":"            metavar\u003d\u0027\u003climit\u003e\u0027,"},{"line_number":57,"context_line":"            help\u003d\"The maximum number of connections permitted for this \""},{"line_number":58,"context_line":"                 \"listener.\""}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_166cf699","line":55,"in_reply_to":"df140735_d153636a","updated":"2017-06-05 23:30:38.000000000","message":"Done","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f47653937369749cf3d4b5aa5a4323ce6067954e","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        response \u003d self.app.client_manager.load_balancer.listener_delete("},{"line_number":149,"context_line":"            listener_id\u003dlistener_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        return response"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class ListListener(lister.Lister):"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_f83c04c9","line":151,"range":{"start_line":151,"start_character":2,"end_line":151,"end_character":23},"updated":"2017-06-02 21:53:39.000000000","message":"This command is returning \"\u003cResponse [204]\u003e\" when it should not return any output.\n\n(octaviaclient) michjohn@devstackpy27:~/.../testclient/python-octaviaclient$ openstack loadbalancer listener delete \"Foo listener\"\n\u003cResponse [204]\u003e","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"62064bf4d6bb0b317c05ad0d5be1702095013512","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        response \u003d self.app.client_manager.load_balancer.listener_delete("},{"line_number":149,"context_line":"            listener_id\u003dlistener_id)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        return response"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class ListListener(lister.Lister):"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_f66622bb","line":151,"range":{"start_line":151,"start_character":2,"end_line":151,"end_character":23},"in_reply_to":"df140735_f83c04c9","updated":"2017-06-05 23:30:38.000000000","message":"Done","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7af97e9a56402e3ec6d4e082d8e70808599e7ff3","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":248,"context_line":"            help\u003d\"Description of this listener\""},{"line_number":249,"context_line":"        )"},{"line_number":250,"context_line":"        parser.add_argument("},{"line_number":251,"context_line":"            \u0027--protocol\u0027,"},{"line_number":252,"context_line":"            metavar\u003d\u0027\u003cprotocol\u003e\u0027,"},{"line_number":253,"context_line":"            help\u003d\"Set protocol\""},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":"        parser.add_argument("},{"line_number":256,"context_line":"            \u0027--connection-limit\u0027,"},{"line_number":257,"context_line":"            metavar\u003d\u0027\u003climit\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_71bff760","line":254,"range":{"start_line":250,"start_character":0,"end_line":254,"end_character":9},"updated":"2017-06-02 18:57:34.000000000","message":"We do not allow users to change the protocol after the listener is created.","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"62064bf4d6bb0b317c05ad0d5be1702095013512","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":248,"context_line":"            help\u003d\"Description of this listener\""},{"line_number":249,"context_line":"        )"},{"line_number":250,"context_line":"        parser.add_argument("},{"line_number":251,"context_line":"            \u0027--protocol\u0027,"},{"line_number":252,"context_line":"            metavar\u003d\u0027\u003cprotocol\u003e\u0027,"},{"line_number":253,"context_line":"            help\u003d\"Set protocol\""},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":"        parser.add_argument("},{"line_number":256,"context_line":"            \u0027--connection-limit\u0027,"},{"line_number":257,"context_line":"            metavar\u003d\u0027\u003climit\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_b60aeace","line":254,"range":{"start_line":250,"start_character":0,"end_line":254,"end_character":9},"in_reply_to":"df140735_71bff760","updated":"2017-06-05 23:30:38.000000000","message":"Done","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f47653937369749cf3d4b5aa5a4323ce6067954e","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        response \u003d self.app.client_manager.load_balancer.listener_set("},{"line_number":314,"context_line":"            listener_id, json\u003dbody)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_782fd43e","line":316,"range":{"start_line":316,"start_character":8,"end_line":316,"end_character":23},"updated":"2017-06-02 21:53:39.000000000","message":"This returns raw json output, but it shouldn\u0027t return anything.","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"62064bf4d6bb0b317c05ad0d5be1702095013512","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        response \u003d self.app.client_manager.load_balancer.listener_set("},{"line_number":314,"context_line":"            listener_id, json\u003dbody)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":12,"id":"df140735_960da6e9","line":316,"range":{"start_line":316,"start_character":8,"end_line":316,"end_character":23},"in_reply_to":"df140735_782fd43e","updated":"2017-06-05 23:30:38.000000000","message":"Done","commit_id":"e5fe0ef9227d140fe52d839f352f14002b196fdf"}]}