)]}'
{"octaviaclient/api/load_balancer_v2.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            A member details on successful creation"},{"line_number":276,"context_line":"        \"\"\""},{"line_number":277,"context_line":"        url \u003d const.BASE_MEMBER_URL.format(pool_id\u003dpool_id)"},{"line_number":278,"context_line":"        member \u003d self.create(url, method\u003d\u0027POST\u0027, **kwargs)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        return member"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_56b06043","line":278,"range":{"start_line":278,"start_character":34,"end_line":278,"end_character":47},"updated":"2017-06-02 23:54:30.000000000","message":"Post is default and this param is not on the load balancer create.  We should be consistent and either remove this one or add it to load balancer","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"}],"octaviaclient/osc/v2/constants.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"MEMBER_ROWS \u003d ("},{"line_number":107,"context_line":"    \u0027Address\u0027,"},{"line_number":108,"context_line":"    \u0027Admin State Up\u0027,"},{"line_number":109,"context_line":"    \u0027Created At\u0027,"},{"line_number":110,"context_line":"    \u0027ID\u0027,"},{"line_number":111,"context_line":"    \u0027Name\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_96f038ff","line":108,"range":{"start_line":108,"start_character":5,"end_line":108,"end_character":19},"updated":"2017-06-02 23:54:30.000000000","message":"Same question here about these being pretty names vs. the API names.","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"}],"octaviaclient/osc/v2/member.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3492b9e12de4b082bca9927136a76195bc2f03d2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def get_parser(self, prog_name):"},{"line_number":59,"context_line":"        parser \u003d super(ShowMember, self).get_parser(prog_name)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        parser.add_argument("},{"line_number":62,"context_line":"            \u0027pool_id\u0027,"},{"line_number":63,"context_line":"            metavar\u003d\u0027\u003cpool_id\u003e\u0027,"},{"line_number":64,"context_line":"            help\u003d\u0027Pool id of the members\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_9643986c","line":61,"range":{"start_line":61,"start_character":1,"end_line":61,"end_character":28},"updated":"2017-06-03 00:07:32.000000000","message":"The legacy neutron client had these in the other order.\n\n\u003cmember_id\u003e \u003cpool_id\u003e","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    def get_parser(self, prog_name):"},{"line_number":59,"context_line":"        parser \u003d super(ShowMember, self).get_parser(prog_name)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        parser.add_argument("},{"line_number":62,"context_line":"            \u0027pool_id\u0027,"},{"line_number":63,"context_line":"            metavar\u003d\u0027\u003cpool_id\u003e\u0027,"},{"line_number":64,"context_line":"            help\u003d\u0027Pool id of the members\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_49d7524c","line":61,"range":{"start_line":61,"start_character":1,"end_line":61,"end_character":28},"in_reply_to":"df140735_9643986c","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        )"},{"line_number":104,"context_line":"        parser.add_argument("},{"line_number":105,"context_line":"            \u0027--weight\u0027,"},{"line_number":106,"context_line":"            metavar\u003d\u0027\u003cweight\u003e\u0027,"},{"line_number":107,"context_line":"            help\u003d\"The weight of a member determines the portion of requests \""},{"line_number":108,"context_line":"                 \"or connections it services compared to the other members of \""},{"line_number":109,"context_line":"                 \"the pool.\""}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_96b3980a","line":106,"range":{"start_line":106,"start_character":28,"end_line":106,"end_character":31},"updated":"2017-06-02 23:54:30.000000000","message":"We can add client side validation here:\ntype\u003dint, choices\u003drange(0, 256)\n\nNot 100% sure if we should or not though.  I hate to have validation in multiple locations (though we did with neutron client).\n\nOpen to comments from others.","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        )"},{"line_number":104,"context_line":"        parser.add_argument("},{"line_number":105,"context_line":"            \u0027--weight\u0027,"},{"line_number":106,"context_line":"            metavar\u003d\u0027\u003cweight\u003e\u0027,"},{"line_number":107,"context_line":"            help\u003d\"The weight of a member determines the portion of requests \""},{"line_number":108,"context_line":"                 \"or connections it services compared to the other members of \""},{"line_number":109,"context_line":"                 \"the pool.\""}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_a9194e22","line":106,"range":{"start_line":106,"start_character":28,"end_line":106,"end_character":31},"in_reply_to":"df140735_96b3980a","updated":"2017-06-06 16:41:40.000000000","message":"I think I am going to add this, I think validation is good here.","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        )"},{"line_number":122,"context_line":"        parser.add_argument("},{"line_number":123,"context_line":"            \u0027--protocol-port\u0027,"},{"line_number":124,"context_line":"            metavar\u003d\u0027\u003cprotocol_port\u003e\u0027,"},{"line_number":125,"context_line":"            help\u003d\"The protocol port number the backend member server is \""},{"line_number":126,"context_line":"                 \"listening on.\","},{"line_number":127,"context_line":"            required\u003dTrue"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_d607d081","line":124,"range":{"start_line":124,"start_character":37,"end_line":124,"end_character":38},"updated":"2017-06-02 23:54:30.000000000","message":"Same here:\nWe can add client side validation here:\ntype\u003dint, choices\u003drange(1, 65535)","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--monitor-port\u0027,"},{"line_number":131,"context_line":"            metavar\u003d\u0027\u003cmonitor_port\u003e\u0027,"},{"line_number":132,"context_line":"            help\u003d\"An alternate protocol port used for health monitoring a \""},{"line_number":133,"context_line":"                 \"backend member. Default is null which monitors the member \""},{"line_number":134,"context_line":"                 \"protocol_port.\","}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_b60c5ca5","line":131,"range":{"start_line":131,"start_character":36,"end_line":131,"end_character":37},"updated":"2017-06-02 23:54:30.000000000","message":"Same here\nWe can add client side validation here:\ntype\u003dint, choices\u003drange(1, 65535)","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--monitor-port\u0027,"},{"line_number":131,"context_line":"            metavar\u003d\u0027\u003cmonitor_port\u003e\u0027,"},{"line_number":132,"context_line":"            help\u003d\"An alternate protocol port used for health monitoring a \""},{"line_number":133,"context_line":"                 \"backend member. Default is null which monitors the member \""},{"line_number":134,"context_line":"                 \"protocol_port.\","}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_e996264c","line":131,"range":{"start_line":131,"start_character":36,"end_line":131,"end_character":37},"in_reply_to":"df140735_b60c5ca5","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027--monitor-port\u0027,"},{"line_number":131,"context_line":"            metavar\u003d\u0027\u003cmonitor_port\u003e\u0027,"},{"line_number":132,"context_line":"            help\u003d\"An alternate protocol port used for health monitoring a \""},{"line_number":133,"context_line":"                 \"backend member. Default is null which monitors the member \""},{"line_number":134,"context_line":"                 \"protocol_port.\","},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        parser.add_argument("},{"line_number":137,"context_line":"            \u0027--monitor-address\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_5696204e","line":134,"range":{"start_line":133,"start_character":34,"end_line":134,"end_character":32},"updated":"2017-06-02 23:54:30.000000000","message":"We can delete this sentence","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027--monitor-port\u0027,"},{"line_number":131,"context_line":"            metavar\u003d\u0027\u003cmonitor_port\u003e\u0027,"},{"line_number":132,"context_line":"            help\u003d\"An alternate protocol port used for health monitoring a \""},{"line_number":133,"context_line":"                 \"backend member. Default is null which monitors the member \""},{"line_number":134,"context_line":"                 \"protocol_port.\","},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        parser.add_argument("},{"line_number":137,"context_line":"            \u0027--monitor-address\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_29a9be8e","line":134,"range":{"start_line":133,"start_character":34,"end_line":134,"end_character":32},"in_reply_to":"df140735_5696204e","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            \u0027--monitor-address\u0027,"},{"line_number":138,"context_line":"            metavar\u003d\u0027\u003cmonitor_address\u003e\u0027,"},{"line_number":139,"context_line":"            help\u003d\"An alternate IP address used for health monitoring a \""},{"line_number":140,"context_line":"                 \"backend member. Default is null which monitors the \""},{"line_number":141,"context_line":"                 \"member address.\""},{"line_number":142,"context_line":"        )"},{"line_number":143,"context_line":"        admin_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":144,"context_line":"        admin_group.add_argument("}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_f6989475","line":141,"range":{"start_line":140,"start_character":34,"end_line":141,"end_character":33},"updated":"2017-06-02 23:54:30.000000000","message":"We can delete this sentence","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            \u0027--monitor-address\u0027,"},{"line_number":138,"context_line":"            metavar\u003d\u0027\u003cmonitor_address\u003e\u0027,"},{"line_number":139,"context_line":"            help\u003d\"An alternate IP address used for health monitoring a \""},{"line_number":140,"context_line":"                 \"backend member. Default is null which monitors the \""},{"line_number":141,"context_line":"                 \"member address.\""},{"line_number":142,"context_line":"        )"},{"line_number":143,"context_line":"        admin_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":144,"context_line":"        admin_group.add_argument("}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_a9c70e64","line":141,"range":{"start_line":140,"start_character":34,"end_line":141,"end_character":33},"in_reply_to":"df140735_f6989475","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            help\u003d\"Set the n1ame of the member\""},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":"        parser.add_argument("},{"line_number":197,"context_line":"            \u0027--weight\u0027,"},{"line_number":198,"context_line":"            metavar\u003d\u0027\u003cweight\u003e\u0027,"},{"line_number":199,"context_line":"            help\u003d\"Set the weight of member in the pool\""},{"line_number":200,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_f6a654ab","line":197,"range":{"start_line":197,"start_character":22,"end_line":197,"end_character":23},"updated":"2017-06-02 23:54:30.000000000","message":"We can add client side validation here:\ntype\u003dint, choices\u003drange(0, 256)\nNot 100% sure if we should or not though.  I hate to have validation in multiple locations (though we did with neutron client).\nOpen to comments from others.","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            help\u003d\"Set the n1ame of the member\""},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":"        parser.add_argument("},{"line_number":197,"context_line":"            \u0027--weight\u0027,"},{"line_number":198,"context_line":"            metavar\u003d\u0027\u003cweight\u003e\u0027,"},{"line_number":199,"context_line":"            help\u003d\"Set the weight of member in the pool\""},{"line_number":200,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_c9912254","line":197,"range":{"start_line":197,"start_character":22,"end_line":197,"end_character":23},"in_reply_to":"df140735_f6a654ab","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            metavar\u003d\u0027\u003cweight\u003e\u0027,"},{"line_number":199,"context_line":"            help\u003d\"Set the weight of member in the pool\""},{"line_number":200,"context_line":"        )"},{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027--address\u0027,"},{"line_number":203,"context_line":"            metavar\u003d\u0027\u003cip_address\u003e\u0027,"},{"line_number":204,"context_line":"            help\u003d\"Set the IP address of the backend member server\","},{"line_number":205,"context_line":"        )"},{"line_number":206,"context_line":"        parser.add_argument("},{"line_number":207,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":208,"context_line":"            metavar\u003d\u0027\u003csubnet_id\u003e\u0027,"},{"line_number":209,"context_line":"            help\u003d\"Set the subnet ID the member service is accessible from.\""},{"line_number":210,"context_line":"        )"},{"line_number":211,"context_line":"        parser.add_argument("},{"line_number":212,"context_line":"            \u0027--protocol-port\u0027,"},{"line_number":213,"context_line":"            metavar\u003d\u0027\u003cprotocol_port\u003e\u0027,"},{"line_number":214,"context_line":"            help\u003d\"Set the protocol port number the backend member server is \""},{"line_number":215,"context_line":"                 \"listening on.\","},{"line_number":216,"context_line":"        )"},{"line_number":217,"context_line":"        parser.add_argument("},{"line_number":218,"context_line":"            \u0027--monitor-port\u0027,"},{"line_number":219,"context_line":"            metavar\u003d\u0027\u003cmonitor_port\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_16c3083a","line":216,"range":{"start_line":201,"start_character":0,"end_line":216,"end_character":9},"updated":"2017-06-02 23:54:30.000000000","message":"We do not allow the user to update these (it\u0027s basically a delete / recreate anyway).","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            metavar\u003d\u0027\u003cweight\u003e\u0027,"},{"line_number":199,"context_line":"            help\u003d\"Set the weight of member in the pool\""},{"line_number":200,"context_line":"        )"},{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027--address\u0027,"},{"line_number":203,"context_line":"            metavar\u003d\u0027\u003cip_address\u003e\u0027,"},{"line_number":204,"context_line":"            help\u003d\"Set the IP address of the backend member server\","},{"line_number":205,"context_line":"        )"},{"line_number":206,"context_line":"        parser.add_argument("},{"line_number":207,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":208,"context_line":"            metavar\u003d\u0027\u003csubnet_id\u003e\u0027,"},{"line_number":209,"context_line":"            help\u003d\"Set the subnet ID the member service is accessible from.\""},{"line_number":210,"context_line":"        )"},{"line_number":211,"context_line":"        parser.add_argument("},{"line_number":212,"context_line":"            \u0027--protocol-port\u0027,"},{"line_number":213,"context_line":"            metavar\u003d\u0027\u003cprotocol_port\u003e\u0027,"},{"line_number":214,"context_line":"            help\u003d\"Set the protocol port number the backend member server is \""},{"line_number":215,"context_line":"                 \"listening on.\","},{"line_number":216,"context_line":"        )"},{"line_number":217,"context_line":"        parser.add_argument("},{"line_number":218,"context_line":"            \u0027--monitor-port\u0027,"},{"line_number":219,"context_line":"            metavar\u003d\u0027\u003cmonitor_port\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_c99fe24d","line":216,"range":{"start_line":201,"start_character":0,"end_line":216,"end_character":9},"in_reply_to":"df140735_16c3083a","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                 \"listening on.\","},{"line_number":216,"context_line":"        )"},{"line_number":217,"context_line":"        parser.add_argument("},{"line_number":218,"context_line":"            \u0027--monitor-port\u0027,"},{"line_number":219,"context_line":"            metavar\u003d\u0027\u003cmonitor_port\u003e\u0027,"},{"line_number":220,"context_line":"            help\u003d\"An alternate protocol port used for health monitoring a \""},{"line_number":221,"context_line":"                 \"backend member\","}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_96fdd86f","line":218,"range":{"start_line":218,"start_character":28,"end_line":218,"end_character":29},"updated":"2017-06-02 23:54:30.000000000","message":"Same here\nWe can add client side validation here:\ntype\u003dint, choices\u003drange(1, 65535)","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                 \"listening on.\","},{"line_number":216,"context_line":"        )"},{"line_number":217,"context_line":"        parser.add_argument("},{"line_number":218,"context_line":"            \u0027--monitor-port\u0027,"},{"line_number":219,"context_line":"            metavar\u003d\u0027\u003cmonitor_port\u003e\u0027,"},{"line_number":220,"context_line":"            help\u003d\"An alternate protocol port used for health monitoring a \""},{"line_number":221,"context_line":"                 \"backend member\","}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_09b39aea","line":218,"range":{"start_line":218,"start_character":28,"end_line":218,"end_character":29},"in_reply_to":"df140735_96fdd86f","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3492b9e12de4b082bca9927136a76195bc2f03d2","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            json\u003dpost_data"},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        return response"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"class DeleteMember(command.Command):"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_16578828","line":256,"range":{"start_line":256,"start_character":8,"end_line":256,"end_character":23},"updated":"2017-06-03 00:07:32.000000000","message":"This returns raw json output, but it shouldn\u0027t return anything.","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            json\u003dpost_data"},{"line_number":254,"context_line":"        )"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        return response"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"class DeleteMember(command.Command):"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_89ec4abb","line":256,"range":{"start_line":256,"start_character":8,"end_line":256,"end_character":23},"in_reply_to":"df140735_16578828","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3492b9e12de4b082bca9927136a76195bc2f03d2","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            member_id\u003did"},{"line_number":287,"context_line":"        )"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_162c28aa","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":23},"updated":"2017-06-03 00:07:32.000000000","message":"This command is returning \"\u003cResponse [204]\u003e\" when it should not return any output.\n(octaviaclient) michjohn@devstackpy27:~/.../testclient/python-octaviaclient$ openstack loadbalancer member delete 60954fc3-48ae-4e34-af81-9566c1d4ba52 \"my member\"\n\u003cResponse [204]\u003e","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            member_id\u003did"},{"line_number":287,"context_line":"        )"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        return response"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_692d76fc","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":23},"in_reply_to":"df140735_162c28aa","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"744f8247eb97ce62c954bf65f9792059a3b5515c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            metavar\u003d\u0027\u003cmember_id\u003e\u0027,"},{"line_number":64,"context_line":"            help\u003d\"ID of the member to be shown\""},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027pool_id\u0027,"},{"line_number":68,"context_line":"            metavar\u003d\u0027\u003cpool\u003e\u0027,"},{"line_number":69,"context_line":"            help\u003d\u0027Pool name or ID to show the members of.\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"df140735_2d44251b","line":66,"updated":"2017-06-06 18:42:19.000000000","message":"This should be a keyword arg, --pool","commit_id":"1c18674994d1fd4451bc77f2866c57545b724b26"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"fe97621d776f5704f13cf0862916738a238dbaa4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            metavar\u003d\u0027\u003cmember_id\u003e\u0027,"},{"line_number":64,"context_line":"            help\u003d\"ID of the member to be shown\""},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027pool_id\u0027,"},{"line_number":68,"context_line":"            metavar\u003d\u0027\u003cpool\u003e\u0027,"},{"line_number":69,"context_line":"            help\u003d\u0027Pool name or ID to show the members of.\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"df140735_cdfb6945","line":66,"in_reply_to":"df140735_2d44251b","updated":"2017-06-06 18:59:34.000000000","message":"Done","commit_id":"1c18674994d1fd4451bc77f2866c57545b724b26"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"04850a616323deef964796c3214193d266f89dab","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        )"},{"line_number":124,"context_line":"        parser.add_argument("},{"line_number":125,"context_line":"            \u0027--protocol-port\u0027,"},{"line_number":126,"context_line":"            metavar\u003d\u0027\u003cprotocol_port\u003e\u0027,"},{"line_number":127,"context_line":"            help\u003d\"The protocol port number the backend member server is \""},{"line_number":128,"context_line":"                 \"listening on.\","},{"line_number":129,"context_line":"            required\u003dTrue"}],"source_content_type":"text/x-python","patch_set":18,"id":"df140735_ee08632e","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":38},"updated":"2017-06-06 20:58:23.000000000","message":"Missed this previous comment:\n\nSame here:\nWe can add client side validation here:\ntype\u003dint, choices\u003drange(1, 65535)","commit_id":"6d34e01b5fa2ac64bcaf42136f2eea2f74341173"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"04850a616323deef964796c3214193d266f89dab","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            \u0027--monitor-address\u0027,"},{"line_number":141,"context_line":"            metavar\u003d\u0027\u003cmonitor_address\u003e\u0027,"},{"line_number":142,"context_line":"            help\u003d\"An alternate IP address used for health monitoring a \""},{"line_number":143,"context_line":"                 \"backend member. Default is null which monitors the \""},{"line_number":144,"context_line":"                 \"member address.\""},{"line_number":145,"context_line":"        )"},{"line_number":146,"context_line":"        admin_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":147,"context_line":"        admin_group.add_argument("}],"source_content_type":"text/x-python","patch_set":18,"id":"df140735_ae026b0a","line":144,"range":{"start_line":143,"start_character":34,"end_line":144,"end_character":33},"updated":"2017-06-06 20:58:23.000000000","message":"This should be deleted.  It was marked as done, but still present.","commit_id":"6d34e01b5fa2ac64bcaf42136f2eea2f74341173"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"67ab6f665e2bfda1435c3079aa3b6d378d5a791c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            metavar\u003d\u0027\u003cmember_id\u003e\u0027,"},{"line_number":64,"context_line":"            help\u003d\"ID of the member to be shown\""},{"line_number":65,"context_line":"        )"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027pool_id\u0027,"},{"line_number":68,"context_line":"            metavar\u003d\u0027\u003cpool\u003e\u0027,"},{"line_number":69,"context_line":"            help\u003d\u0027Pool name or ID to show the members of.\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"df140735_1b93d65e","line":66,"updated":"2017-06-06 23:09:44.000000000","message":"You missed making this a keyword arg. T_T","commit_id":"d16361c4f16710c578a91a240c0a036e01ec5c0a"}],"octaviaclient/tests/unit/osc/v2/fakes.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            \"subnet_id\": uuid.uuid4().hex,"},{"line_number":153,"context_line":"            \"tenant_id\": uuid.uuid4().hex,"},{"line_number":154,"context_line":"            \"provisioning_status\": \"ACTIVE\","},{"line_number":155,"context_line":"            \"address\": \"10.2.1.11\","},{"line_number":156,"context_line":"            \"protocol_port\": 80,"},{"line_number":157,"context_line":"            \"id\": uuid.uuid4().hex,"},{"line_number":158,"context_line":"            \"operating_status\": \"NO_MONITOR\","}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_f61bf4c6","line":155,"range":{"start_line":155,"start_character":24,"end_line":155,"end_character":33},"updated":"2017-06-02 23:54:30.000000000","message":"Please use one of the documentation/TEST-NET ip address ranges for tests and documentation.\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            \"subnet_id\": uuid.uuid4().hex,"},{"line_number":153,"context_line":"            \"tenant_id\": uuid.uuid4().hex,"},{"line_number":154,"context_line":"            \"provisioning_status\": \"ACTIVE\","},{"line_number":155,"context_line":"            \"address\": \"10.2.1.11\","},{"line_number":156,"context_line":"            \"protocol_port\": 80,"},{"line_number":157,"context_line":"            \"id\": uuid.uuid4().hex,"},{"line_number":158,"context_line":"            \"operating_status\": \"NO_MONITOR\","}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_295ade81","line":155,"range":{"start_line":155,"start_character":24,"end_line":155,"end_character":33},"in_reply_to":"df140735_f61bf4c6","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"}],"octaviaclient/tests/unit/osc/v2/test_member.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    @mock.patch(\u0027octaviaclient.osc.v2.utils.get_member_attrs\u0027)"},{"line_number":115,"context_line":"    def test_member_create(self, mock_attrs):"},{"line_number":116,"context_line":"        mock_attrs.return_value \u003d {"},{"line_number":117,"context_line":"            \u0027ip_address\u0027: \u002710.1.1.0\u0027,"},{"line_number":118,"context_line":"            \u0027protocol_port\u0027: self.mem.protocol_port,"},{"line_number":119,"context_line":"            \u0027weight\u0027: self.mem.weight,"},{"line_number":120,"context_line":"            \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_b67fbcde","line":117,"range":{"start_line":117,"start_character":27,"end_line":117,"end_character":35},"updated":"2017-06-02 23:54:30.000000000","message":"Please use one of the documentation/TEST-NET ip address ranges for tests and documentation.\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    @mock.patch(\u0027octaviaclient.osc.v2.utils.get_member_attrs\u0027)"},{"line_number":115,"context_line":"    def test_member_create(self, mock_attrs):"},{"line_number":116,"context_line":"        mock_attrs.return_value \u003d {"},{"line_number":117,"context_line":"            \u0027ip_address\u0027: \u002710.1.1.0\u0027,"},{"line_number":118,"context_line":"            \u0027protocol_port\u0027: self.mem.protocol_port,"},{"line_number":119,"context_line":"            \u0027weight\u0027: self.mem.weight,"},{"line_number":120,"context_line":"            \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_e98aa6bc","line":117,"range":{"start_line":117,"start_character":27,"end_line":117,"end_character":35},"in_reply_to":"df140735_b67fbcde","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            \u0027admin_state_up\u0027: True,"},{"line_number":121,"context_line":"            \u0027pool_id\u0027: self.mem.pool_id}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        arglist \u003d [\u0027pool_id\u0027, \u0027--address\u0027, \u002710.1.1.0\u0027,"},{"line_number":124,"context_line":"                   \u0027--protocol-port\u0027, \u002780\u0027,"},{"line_number":125,"context_line":"                   \u0027--weight\u0027, \u00271\u0027, \u0027--enable\u0027]"},{"line_number":126,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_968038c1","line":123,"range":{"start_line":123,"start_character":44,"end_line":123,"end_character":52},"updated":"2017-06-02 23:54:30.000000000","message":"Please use one of the documentation/TEST-NET ip address ranges for tests and documentation.\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            \u0027admin_state_up\u0027: True,"},{"line_number":121,"context_line":"            \u0027pool_id\u0027: self.mem.pool_id}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        arglist \u003d [\u0027pool_id\u0027, \u0027--address\u0027, \u002710.1.1.0\u0027,"},{"line_number":124,"context_line":"                   \u0027--protocol-port\u0027, \u002780\u0027,"},{"line_number":125,"context_line":"                   \u0027--weight\u0027, \u00271\u0027, \u0027--enable\u0027]"},{"line_number":126,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_c985a2ae","line":123,"range":{"start_line":123,"start_character":44,"end_line":123,"end_character":52},"in_reply_to":"df140735_968038c1","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                   \u0027--protocol-port\u0027, \u002780\u0027,"},{"line_number":125,"context_line":"                   \u0027--weight\u0027, \u00271\u0027, \u0027--enable\u0027]"},{"line_number":126,"context_line":"        verifylist \u003d ["},{"line_number":127,"context_line":"            (\u0027address\u0027, \u002710.1.1.0\u0027),"},{"line_number":128,"context_line":"            (\u0027protocol_port\u0027, \u002780\u0027),"},{"line_number":129,"context_line":"            (\u0027weight\u0027, \u00271\u0027)"},{"line_number":130,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_366bac1e","line":127,"range":{"start_line":127,"start_character":25,"end_line":127,"end_character":33},"updated":"2017-06-02 23:54:30.000000000","message":"Please use one of the documentation/TEST-NET ip address ranges for tests and documentation.\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                   \u0027--protocol-port\u0027, \u002780\u0027,"},{"line_number":125,"context_line":"                   \u0027--weight\u0027, \u00271\u0027, \u0027--enable\u0027]"},{"line_number":126,"context_line":"        verifylist \u003d ["},{"line_number":127,"context_line":"            (\u0027address\u0027, \u002710.1.1.0\u0027),"},{"line_number":128,"context_line":"            (\u0027protocol_port\u0027, \u002780\u0027),"},{"line_number":129,"context_line":"            (\u0027weight\u0027, \u00271\u0027)"},{"line_number":130,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_a9902eee","line":127,"range":{"start_line":127,"start_character":25,"end_line":127,"end_character":33},"in_reply_to":"df140735_366bac1e","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2b746d58b17749bc2f218532fc70f294e7142fb2","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":134,"context_line":"        self.api_mock.member_create.assert_called_with("},{"line_number":135,"context_line":"            pool_id\u003dself.mem.pool_id, json\u003d{"},{"line_number":136,"context_line":"                \u0027member\u0027: {\u0027ip_address\u0027: \u002710.1.1.0\u0027,"},{"line_number":137,"context_line":"                           \u0027protocol_port\u0027: self.mem.protocol_port,"},{"line_number":138,"context_line":"                           \u0027weight\u0027: self.mem.weight,"},{"line_number":139,"context_line":"                           \u0027admin_state_up\u0027: True}})"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_7685a4ce","line":136,"range":{"start_line":136,"start_character":42,"end_line":136,"end_character":50},"updated":"2017-06-02 23:54:30.000000000","message":"Please use one of the documentation/TEST-NET ip address ranges for tests and documentation.\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":134,"context_line":"        self.api_mock.member_create.assert_called_with("},{"line_number":135,"context_line":"            pool_id\u003dself.mem.pool_id, json\u003d{"},{"line_number":136,"context_line":"                \u0027member\u0027: {\u0027ip_address\u0027: \u002710.1.1.0\u0027,"},{"line_number":137,"context_line":"                           \u0027protocol_port\u0027: self.mem.protocol_port,"},{"line_number":138,"context_line":"                           \u0027weight\u0027: self.mem.weight,"},{"line_number":139,"context_line":"                           \u0027admin_state_up\u0027: True}})"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_69c0d6e1","line":136,"range":{"start_line":136,"start_character":42,"end_line":136,"end_character":50},"in_reply_to":"df140735_7685a4ce","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"}],"setup.cfg":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8e479bb523cb3fec300c945b7a04d9cbbf447d12","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    loadbalancer_member_show \u003d octaviaclient.osc.v2.member:ShowMember"},{"line_number":48,"context_line":"    loadbalancer_member_delete \u003d octaviaclient.osc.v2.member:DeleteMember"},{"line_number":49,"context_line":"    loadbalancer_member_set \u003d octaviaclient.osc.v2.member:SetMember"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[build_sphinx]"},{"line_number":53,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":15,"id":"df140735_13467ac1","line":50,"updated":"2017-06-02 22:56:56.000000000","message":"nit: Extra line here","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"},{"author":{"_account_id":25674,"name":"Jude Cross","email":"jucross@blizzard.com","username":"problem_v"},"change_message_id":"811654d87b761ec441f9a04d090575b3e435360d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    loadbalancer_member_show \u003d octaviaclient.osc.v2.member:ShowMember"},{"line_number":48,"context_line":"    loadbalancer_member_delete \u003d octaviaclient.osc.v2.member:DeleteMember"},{"line_number":49,"context_line":"    loadbalancer_member_set \u003d octaviaclient.osc.v2.member:SetMember"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"[build_sphinx]"},{"line_number":53,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":15,"id":"df140735_496872f3","line":50,"in_reply_to":"df140735_13467ac1","updated":"2017-06-06 16:41:40.000000000","message":"Done","commit_id":"f14d3375a31c31bf9e6d19385652521e30d973ec"}]}