)]}'
{"id":"openstack%2Fpython-octaviaclient~478724","triplet_id":"openstack%2Fpython-octaviaclient~master~Ied399c02ce35eb2c38de6129c24d46c25f6eb4b5","project":"openstack/python-octaviaclient","branch":"master","topic":"six.iteritems","hashtags":[],"change_id":"Ied399c02ce35eb2c38de6129c24d46c25f6eb4b5","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2017-06-29 04:31:05.000000000","updated":"2017-07-03 18:56:28.000000000","submitted":"2017-07-03 18:56:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1415517a0f11493a63ab45620e1b0e1977740b42","_number":478724,"virtual_id_number":478724,"owner":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":2,"date":"2017-07-03 18:56:28.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"all":[{"value":2,"date":"2017-06-30 21:26:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-03 18:51:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-07-03 18:51:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-30 21:26:25.000000000","updated_by":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"reviewer":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"state":"REVIEWER"},{"updated":"2017-07-03 18:51:49.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2017-07-03 18:56:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"38e828092c86b86a4a09b1f122c36fec7082b27b","author":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"date":"2017-06-29 04:31:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e21377382b405443e1722a6949895703c1a47783","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-29 04:40:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-octaviaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/24/478724/1/check/gate-python-octaviaclient-docs-ubuntu-xenial/1a42463//doc/build/html/ : SUCCESS in 4m 32s\n- gate-python-octaviaclient-pep8-ubuntu-xenial http://logs.openstack.org/24/478724/1/check/gate-python-octaviaclient-pep8-ubuntu-xenial/5751d0c/ : SUCCESS in 3m 08s\n- gate-python-octaviaclient-python27-ubuntu-xenial http://logs.openstack.org/24/478724/1/check/gate-python-octaviaclient-python27-ubuntu-xenial/aa6a028/ : SUCCESS in 2m 01s\n- gate-python-octaviaclient-python35 http://logs.openstack.org/24/478724/1/check/gate-python-octaviaclient-python35/db77405/ : SUCCESS in 2m 54s\n- check-osc-plugins http://logs.openstack.org/24/478724/1/check/check-osc-plugins/dbf4edb/ : SUCCESS in 7m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7642f1abeeaadc61055ecfa9ffb6f9037543d10c","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2017-06-30 21:26:25.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"2c807ca06e95957d3cca3c9b61a750429baeba08","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2017-07-03 18:51:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"23b3d31c9d3911a3003b78a64c1bbe5538eb4a61","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-03 18:52:00.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a5f190a2bc74610ef993b46462ceb14cb44a2cdb","date":"2017-07-03 18:56:28.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"869dd1cc4f33b500afc297356f2735a4e5c20aca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-03 18:56:28.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-octaviaclient-docs-ubuntu-xenial http://docs-draft.openstack.org/24/478724/1/gate/gate-python-octaviaclient-docs-ubuntu-xenial/e5bebc8//doc/build/html/ : SUCCESS in 3m 11s\n- gate-python-octaviaclient-pep8-ubuntu-xenial http://logs.openstack.org/24/478724/1/gate/gate-python-octaviaclient-pep8-ubuntu-xenial/6f334aa/ : SUCCESS in 2m 43s\n- gate-python-octaviaclient-python27-ubuntu-xenial http://logs.openstack.org/24/478724/1/gate/gate-python-octaviaclient-python27-ubuntu-xenial/df23bde/ : SUCCESS in 4m 06s\n- gate-python-octaviaclient-python35 http://logs.openstack.org/24/478724/1/gate/gate-python-octaviaclient-python35/ee1efd8/ : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7aa02f4dda0a6ebdb6c264a4f5ccb8258eaa406e","revisions":{"7aa02f4dda0a6ebdb6c264a4f5ccb8258eaa406e":{"kind":"REWORK","_number":1,"created":"2017-06-29 04:31:05.000000000","uploader":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"ref":"refs/changes/24/478724/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/24/478724/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/24/478724/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/24/478724/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/24/478724/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/24/478724/1"}}},"commit":{"parents":[{"commit":"d5da9d25caa2c9972059eb20291b70470bc25ecb","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/d5da9d25caa2c9972059eb20291b70470bc25ecb"}]}],"author":{"name":"Kiran_totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-29 04:31:19.000000000","tz":330},"committer":{"name":"Kiran_totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-29 04:32:20.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Ied399c02ce35eb2c38de6129c24d46c25f6eb4b5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/7aa02f4dda0a6ebdb6c264a4f5ccb8258eaa406e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/7aa02f4dda0a6ebdb6c264a4f5ccb8258eaa406e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}