)]}'
{"octaviaclient/api/load_balancer_v2.py":[{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"41cde54421cf61254f36f1f3a9e17985aa4041ff","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        :param params:"},{"line_number":616,"context_line":"            A dict of arguments to update project quota"},{"line_number":617,"context_line":"        :return:"},{"line_number":618,"context_line":"            Response Code from API"},{"line_number":619,"context_line":"        \"\"\""},{"line_number":620,"context_line":"        url \u003d const.BASE_SINGLE_QUOTA_URL.format(uuid\u003dproject_id)"},{"line_number":621,"context_line":"        response \u003d self.create(url, method\u003d\u0027PUT\u0027, **params)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_20d462e8","line":618,"range":{"start_line":618,"start_character":12,"end_line":618,"end_character":34},"updated":"2017-11-29 13:34:28.000000000","message":"According to the API, it also returns the updated object","commit_id":"cd016709a9857feb02930e4b274f4c54e73cfb06"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"485cd88480c5f8816b90c47df3c85aaa2f24393d","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        :param params:"},{"line_number":616,"context_line":"            A dict of arguments to update project quota"},{"line_number":617,"context_line":"        :return:"},{"line_number":618,"context_line":"            Response Code from API"},{"line_number":619,"context_line":"        \"\"\""},{"line_number":620,"context_line":"        url \u003d const.BASE_SINGLE_QUOTA_URL.format(uuid\u003dproject_id)"},{"line_number":621,"context_line":"        response \u003d self.create(url, method\u003d\u0027PUT\u0027, **params)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_ad7b8a89","line":618,"range":{"start_line":618,"start_character":12,"end_line":618,"end_character":34},"in_reply_to":"ff82abbf_20d462e8","updated":"2017-11-29 13:55:49.000000000","message":"You\u0027re right. :return of other API calls also need updating -- I\u0027ll address all on next patch set.","commit_id":"cd016709a9857feb02930e4b274f4c54e73cfb06"}],"octaviaclient/osc/v2/constants.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c4319d0ca0c2231f19ecea959362d732afc8652c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    \u0027admin_state_up\u0027,"},{"line_number":201,"context_line":")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"QUOTA_ROWS \u003d {"},{"line_number":204,"context_line":"    \u0027health_monitor\u0027,"},{"line_number":205,"context_line":"    \u0027listener\u0027,"},{"line_number":206,"context_line":"    \u0027load_balancer\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_bb5ff93f","line":203,"updated":"2017-11-21 18:21:01.000000000","message":"Can we re-order this?\nload_balancer\nlistener\npool\nhealth_monitor\nmember\n\nIt will make the columns in the output more consistent with other commands.","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"777c2d3e12424747e8c41f1ce3ea2bae8063c94a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    \u0027admin_state_up\u0027,"},{"line_number":201,"context_line":")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"QUOTA_ROWS \u003d {"},{"line_number":204,"context_line":"    \u0027health_monitor\u0027,"},{"line_number":205,"context_line":"    \u0027listener\u0027,"},{"line_number":206,"context_line":"    \u0027load_balancer\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_70517562","line":203,"in_reply_to":"ff82abbf_bb5ff93f","updated":"2017-11-22 18:36:27.000000000","message":"Done","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c4319d0ca0c2231f19ecea959362d732afc8652c","unresolved":false,"context_lines":[{"line_number":209,"context_line":"}"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"QUOTA_COLUMNS \u003d ("},{"line_number":212,"context_line":"    \u0027health_monitor\u0027,"},{"line_number":213,"context_line":"    \u0027listener\u0027,"},{"line_number":214,"context_line":"    \u0027load_balancer\u0027,"},{"line_number":215,"context_line":"    \u0027member\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_fb458171","line":212,"updated":"2017-11-21 18:21:01.000000000","message":"Can we re-order this?\nproject_id\nload_balancer\nlistener\npool\nhealth_monitor\nmember\n\nIt will make the columns in the output more consistent with other commands.","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"777c2d3e12424747e8c41f1ce3ea2bae8063c94a","unresolved":false,"context_lines":[{"line_number":209,"context_line":"}"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"QUOTA_COLUMNS \u003d ("},{"line_number":212,"context_line":"    \u0027health_monitor\u0027,"},{"line_number":213,"context_line":"    \u0027listener\u0027,"},{"line_number":214,"context_line":"    \u0027load_balancer\u0027,"},{"line_number":215,"context_line":"    \u0027member\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_1050295d","line":212,"in_reply_to":"ff82abbf_fb458171","updated":"2017-11-22 18:36:27.000000000","message":"Done","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"8a83aac3a90d9000c428bd177ceeee2aa5f91649","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    \u0027admin_state_up\u0027,"},{"line_number":201,"context_line":")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"QUOTA_ROWS \u003d {"},{"line_number":204,"context_line":"    \u0027load_balancer\u0027,"},{"line_number":205,"context_line":"    \u0027listener\u0027,"},{"line_number":206,"context_line":"    \u0027pool\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_cd3b1a36","line":203,"range":{"start_line":203,"start_character":13,"end_line":203,"end_character":14},"updated":"2017-12-04 22:07:15.000000000","message":"I think you meant \u0027(\u0027","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"25ac3cacbdf737d6fcb41a301e936b2b8ed471b7","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    \u0027admin_state_up\u0027,"},{"line_number":201,"context_line":")"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"QUOTA_ROWS \u003d {"},{"line_number":204,"context_line":"    \u0027load_balancer\u0027,"},{"line_number":205,"context_line":"    \u0027listener\u0027,"},{"line_number":206,"context_line":"    \u0027pool\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_a83ec426","line":203,"range":{"start_line":203,"start_character":13,"end_line":203,"end_character":14},"in_reply_to":"df87a7cf_cd3b1a36","updated":"2017-12-06 11:22:43.000000000","message":"Done","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"}],"octaviaclient/osc/v2/quota.py":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"aad3d30825cb0ee954848b18eb443c305f2f6628","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        parser \u003d super(SetQuota, self).get_parser(prog_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027--health-monitor\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003chealth_monitor\u003e\u0027,"},{"line_number":95,"context_line":"            help\u003d\"Health monitor quota limit.\""},{"line_number":96,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_481f7f07","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":22},"updated":"2017-11-19 22:16:11.000000000","message":"For consistency (same as load_balancer), this should be an underscore.\nthis would also match to column name output the user get in quota list: http://paste.openstack.org/show/626760/","commit_id":"a36cb9e11dc77514861192d1dbd96f8a339161db"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"70ea23c14dbe358448a8c809b3a68ac76cc1d71d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        parser \u003d super(SetQuota, self).get_parser(prog_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027--health-monitor\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003chealth_monitor\u003e\u0027,"},{"line_number":95,"context_line":"            help\u003d\"Health monitor quota limit.\""},{"line_number":96,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_c8c12f56","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":22},"in_reply_to":"1f485f77_481f7f07","updated":"2017-11-19 22:23:58.000000000","message":"Actually, for consistency across all osc plugins including octavia itself (e.g. check octaviaclient/osc/v2/load_balancer.py), it should be a hyphen in L103.","commit_id":"a36cb9e11dc77514861192d1dbd96f8a339161db"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"dd5dda589ce4e39137dd2a5a2b1d8ba88dc62804","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        parser \u003d super(SetQuota, self).get_parser(prog_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027--health-monitor\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003chealth_monitor\u003e\u0027,"},{"line_number":95,"context_line":"            help\u003d\"Health monitor quota limit.\""},{"line_number":96,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_9167a626","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":22},"in_reply_to":"1f485f77_c8c12f56","updated":"2017-11-20 08:17:01.000000000","message":"https://github.com/openstack/python-octaviaclient/blob/20920487a4a32493d19bbefed002e21f549a88b1/octaviaclient/osc/v2/load_balancer.py#L103 ?\n\nI don\u0027t follow.","commit_id":"a36cb9e11dc77514861192d1dbd96f8a339161db"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1b5c5a04af21e7e12fb8b531dfdad1dda6a15100","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        parser \u003d super(SetQuota, self).get_parser(prog_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027--health-monitor\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003chealth_monitor\u003e\u0027,"},{"line_number":95,"context_line":"            help\u003d\"Health monitor quota limit.\""},{"line_number":96,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_bcc88174","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":22},"in_reply_to":"ff82abbf_9167a626","updated":"2017-11-20 08:39:49.000000000","message":"\"All long options names shall begin with two dashes (\u0027--\u0027) and use a single dash (\u0027-\u0027) internally between words (--like-this). Underscores (\u0027_\u0027) shall not be used in option names.\"\n\nhttps://wiki.openstack.org/wiki/OpenStackClient/HumanInterfaceGuidelines#Command_Structure","commit_id":"a36cb9e11dc77514861192d1dbd96f8a339161db"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"42ba2781d9d27681f126fd9bc4a884d86cbd53a9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        parser \u003d super(SetQuota, self).get_parser(prog_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027--health-monitor\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003chealth_monitor\u003e\u0027,"},{"line_number":95,"context_line":"            help\u003d\"Health monitor quota limit.\""},{"line_number":96,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_dc4465ba","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":22},"in_reply_to":"ff82abbf_bcc88174","updated":"2017-11-20 08:47:05.000000000","message":"Fair enough.\nSo, should we change --load_balancer to --load-balancer? (line#103 in this file for example)","commit_id":"a36cb9e11dc77514861192d1dbd96f8a339161db"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"67ea54262666f28073cc89a282735f314367f423","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        parser \u003d super(SetQuota, self).get_parser(prog_name)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027--health-monitor\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003chealth_monitor\u003e\u0027,"},{"line_number":95,"context_line":"            help\u003d\"Health monitor quota limit.\""},{"line_number":96,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_3c8231ca","line":93,"range":{"start_line":93,"start_character":21,"end_line":93,"end_character":22},"in_reply_to":"ff82abbf_dc4465ba","updated":"2017-11-20 08:48:00.000000000","message":"oh, you did.","commit_id":"a36cb9e11dc77514861192d1dbd96f8a339161db"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c4319d0ca0c2231f19ecea959362d732afc8652c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        parser.add_argument("},{"line_number":32,"context_line":"            \u0027--project\u0027,"},{"line_number":33,"context_line":"            metavar\u003d\u0027\u003cproject-id\u003e\u0027,"},{"line_number":34,"context_line":"            help\u003d\"List quotas by project.\""},{"line_number":35,"context_line":"        )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_7b6df196","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":41},"updated":"2017-11-21 18:21:01.000000000","message":"Can we make the project ID help strings consistent?\nIt is \"Name or UUID of the project\" below on show quota.","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"777c2d3e12424747e8c41f1ce3ea2bae8063c94a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        parser.add_argument("},{"line_number":32,"context_line":"            \u0027--project\u0027,"},{"line_number":33,"context_line":"            metavar\u003d\u0027\u003cproject-id\u003e\u0027,"},{"line_number":34,"context_line":"            help\u003d\"List quotas by project.\""},{"line_number":35,"context_line":"        )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_10fee936","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":41},"in_reply_to":"ff82abbf_7b6df196","updated":"2017-11-22 18:36:27.000000000","message":"Done","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c4319d0ca0c2231f19ecea959362d732afc8652c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027--health-monitor\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003chealth_monitor\u003e\u0027,"},{"line_number":95,"context_line":"            help\u003d\"Health monitor quota limit.\""},{"line_number":96,"context_line":"        )"},{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027--listener\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_3be9a919","line":95,"range":{"start_line":95,"start_character":18,"end_line":95,"end_character":45},"updated":"2017-11-21 18:21:01.000000000","message":"For these help strings, can we include information about how to set the default quota and unlimited like the API reference includes?\nhttps://developer.openstack.org/api-ref/load-balancer/v2/index.html#id179","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"777c2d3e12424747e8c41f1ce3ea2bae8063c94a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027--health-monitor\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003chealth_monitor\u003e\u0027,"},{"line_number":95,"context_line":"            help\u003d\"Health monitor quota limit.\""},{"line_number":96,"context_line":"        )"},{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027--listener\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_6ebc31dc","line":95,"range":{"start_line":95,"start_character":18,"end_line":95,"end_character":45},"in_reply_to":"ff82abbf_3be9a919","updated":"2017-11-22 18:36:27.000000000","message":"\"Health monitor quota limit. Value -1 means unlimited; value None means default quota.\"\n\nSomething like this?","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"change_message_id":"4ba47738f995c439a888e58a7c56be43f83aae1c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        )"},{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027--listener\u0027,"},{"line_number":99,"context_line":"            metavar\u003d\u0027\u003clistener\u003e\u0027,"},{"line_number":100,"context_line":"            help\u003d\"Listener quota limit.\""},{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_485d3f45","line":99,"range":{"start_line":99,"start_character":12,"end_line":99,"end_character":33},"updated":"2017-11-20 09:44:37.000000000","message":"It hints the user to provide with a listener object\\id\\name, while it really should be an integer.\nI would suggest placing \u0027QUOTA\u0027, or even \u0027N\u0027, as your metavar, instead.\nSame for the rest of the arguments in this list.","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"777c2d3e12424747e8c41f1ce3ea2bae8063c94a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        )"},{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027--listener\u0027,"},{"line_number":99,"context_line":"            metavar\u003d\u0027\u003clistener\u003e\u0027,"},{"line_number":100,"context_line":"            help\u003d\"Listener quota limit.\""},{"line_number":101,"context_line":"        )"},{"line_number":102,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_eed041fa","line":99,"range":{"start_line":99,"start_character":12,"end_line":99,"end_character":33},"in_reply_to":"1f485f77_485d3f45","updated":"2017-11-22 18:36:27.000000000","message":"I agree with you. Although, for consistency with openstackclient [1], metavar should be the argument name.\n\nI will change help strings to \"New value for the $argument_name quota\", which addresses your comment while also aligning with other OSC commands.\n\n[1] https://github.com/openstack/python-openstackclient/blob/master/openstackclient/common/quota.py#L334","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"change_message_id":"4ba47738f995c439a888e58a7c56be43f83aae1c","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        return parser"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def take_action(self, parsed_args):"},{"line_number":127,"context_line":"        attrs \u003d v2_utils.get_quota_attrs(self.app.client_manager,"},{"line_number":128,"context_line":"                                         parsed_args)"},{"line_number":129,"context_line":"        project_id \u003d attrs.pop(\u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_088ce7d4","line":126,"updated":"2017-11-20 09:44:37.000000000","message":"Correct me if I\u0027m wrong, there is no purpose of calling set_quota() without any parameters.\nPerhaps enforce the provision of at least 1 argument of the above (excluding project), with informative error message, would you agree?\nIn lack of proper method to enforce the condition above, see:\n1. https://review.openstack.org/#/c/519439/8/octaviaclient/osc/v2/validate.py ####check_loadbalancer_attrs()\n2. https://review.openstack.org/#/c/519439/8/octaviaclient/osc/v2/load_balancer.py ### vip_group desc","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c4319d0ca0c2231f19ecea959362d732afc8652c","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        return parser"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def take_action(self, parsed_args):"},{"line_number":127,"context_line":"        attrs \u003d v2_utils.get_quota_attrs(self.app.client_manager,"},{"line_number":128,"context_line":"                                         parsed_args)"},{"line_number":129,"context_line":"        project_id \u003d attrs.pop(\u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_5b0a6dd2","line":126,"in_reply_to":"1f485f77_088ce7d4","updated":"2017-11-21 18:21:01.000000000","message":"+1","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"777c2d3e12424747e8c41f1ce3ea2bae8063c94a","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        return parser"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def take_action(self, parsed_args):"},{"line_number":127,"context_line":"        attrs \u003d v2_utils.get_quota_attrs(self.app.client_manager,"},{"line_number":128,"context_line":"                                         parsed_args)"},{"line_number":129,"context_line":"        project_id \u003d attrs.pop(\u0027project_id\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_efb3584c","line":126,"in_reply_to":"1f485f77_088ce7d4","updated":"2017-11-22 18:36:27.000000000","message":"Done, plus UT. Thanks!","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"41cde54421cf61254f36f1f3a9e17985aa4041ff","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                  \u0027unlimited.\u0027)"},{"line_number":119,"context_line":"        )"},{"line_number":120,"context_line":"        quota_group.add_argument("},{"line_number":121,"context_line":"            \u0027--load-balancer\u0027,"},{"line_number":122,"context_line":"            metavar\u003d\u0027\u003cload_balancer\u003e\u0027,"},{"line_number":123,"context_line":"            help\u003d(\u0027New value for the load balancer quota limit. Value -1 \u0027"},{"line_number":124,"context_line":"                  \u0027means unlimited.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_1bc3d358","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":29},"updated":"2017-11-29 13:34:28.000000000","message":"For consistency, should probably be \u0027--loadbalancer\u0027, instead. Currently, the full version of this command would be: openstack *loadbalancer* quota show --*load-balancer* lb, which I find to be rather confusing. Would you agree?","commit_id":"cd016709a9857feb02930e4b274f4c54e73cfb06"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"485cd88480c5f8816b90c47df3c85aaa2f24393d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                  \u0027unlimited.\u0027)"},{"line_number":119,"context_line":"        )"},{"line_number":120,"context_line":"        quota_group.add_argument("},{"line_number":121,"context_line":"            \u0027--load-balancer\u0027,"},{"line_number":122,"context_line":"            metavar\u003d\u0027\u003cload_balancer\u003e\u0027,"},{"line_number":123,"context_line":"            help\u003d(\u0027New value for the load balancer quota limit. Value -1 \u0027"},{"line_number":124,"context_line":"                  \u0027means unlimited.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_ad2dca95","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":29},"in_reply_to":"ff82abbf_1bc3d358","updated":"2017-11-29 13:55:49.000000000","message":"Check comments on https://review.openstack.org/#/c/518767/3/octaviaclient/osc/v2/quota.py@93\n\nAnd the follow-up by Nir on it: https://review.openstack.org/#/c/521482/","commit_id":"cd016709a9857feb02930e4b274f4c54e73cfb06"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"5a1dd8d9faf0e396e2c12645787568b8cf831584","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                  \u0027unlimited.\u0027)"},{"line_number":119,"context_line":"        )"},{"line_number":120,"context_line":"        quota_group.add_argument("},{"line_number":121,"context_line":"            \u0027--load-balancer\u0027,"},{"line_number":122,"context_line":"            metavar\u003d\u0027\u003cload_balancer\u003e\u0027,"},{"line_number":123,"context_line":"            help\u003d(\u0027New value for the load balancer quota limit. Value -1 \u0027"},{"line_number":124,"context_line":"                  \u0027means unlimited.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_681237b7","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":29},"in_reply_to":"ff82abbf_6da02243","updated":"2017-11-30 11:19:35.000000000","message":"I\u0027ll wait for Nir\u0027s review as he has a follow-up on this. Either I leave it as is now or I revert to --loadbalancer and Nir updates his patch.","commit_id":"cd016709a9857feb02930e4b274f4c54e73cfb06"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"1ee9aefa8be14181c8208f46f970cda6effbec5b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                  \u0027unlimited.\u0027)"},{"line_number":119,"context_line":"        )"},{"line_number":120,"context_line":"        quota_group.add_argument("},{"line_number":121,"context_line":"            \u0027--load-balancer\u0027,"},{"line_number":122,"context_line":"            metavar\u003d\u0027\u003cload_balancer\u003e\u0027,"},{"line_number":123,"context_line":"            help\u003d(\u0027New value for the load balancer quota limit. Value -1 \u0027"},{"line_number":124,"context_line":"                  \u0027means unlimited.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_6da02243","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":29},"in_reply_to":"ff82abbf_ad2dca95","updated":"2017-11-29 14:27:11.000000000","message":"I commented on Nir\u0027s patch too, before. IMO this is very confusing.\nPlus, it can always be undone in Nir\u0027s patch.","commit_id":"cd016709a9857feb02930e4b274f4c54e73cfb06"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"8a83aac3a90d9000c428bd177ceeee2aa5f91649","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _check_attrs(attrs):"},{"line_number":92,"context_line":"        args \u003d [\u0027health-monitor\u0027, \u0027listener\u0027, \u0027loadbalancer\u0027, \u0027member\u0027,"},{"line_number":93,"context_line":"                \u0027listener\u0027, \u0027pool\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not any(arg in attrs for arg in args):"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_4d306a57","line":92,"range":{"start_line":92,"start_character":46,"end_line":92,"end_character":60},"updated":"2017-12-04 22:07:15.000000000","message":"same as with health-monitor","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"8a83aac3a90d9000c428bd177ceeee2aa5f91649","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _check_attrs(attrs):"},{"line_number":92,"context_line":"        args \u003d [\u0027health-monitor\u0027, \u0027listener\u0027, \u0027loadbalancer\u0027, \u0027member\u0027,"},{"line_number":93,"context_line":"                \u0027listener\u0027, \u0027pool\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not any(arg in attrs for arg in args):"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_8df0b292","line":92,"range":{"start_line":92,"start_character":16,"end_line":92,"end_character":32},"updated":"2017-12-04 22:07:15.000000000","message":"should be with underscore to work. But note that a change here will ruin the error message.","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"25ac3cacbdf737d6fcb41a301e936b2b8ed471b7","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _check_attrs(attrs):"},{"line_number":92,"context_line":"        args \u003d [\u0027health-monitor\u0027, \u0027listener\u0027, \u0027loadbalancer\u0027, \u0027member\u0027,"},{"line_number":93,"context_line":"                \u0027listener\u0027, \u0027pool\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not any(arg in attrs for arg in args):"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_97b2d393","line":92,"range":{"start_line":92,"start_character":46,"end_line":92,"end_character":60},"in_reply_to":"df87a7cf_4d306a57","updated":"2017-12-06 11:22:43.000000000","message":"Done","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"25ac3cacbdf737d6fcb41a301e936b2b8ed471b7","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _check_attrs(attrs):"},{"line_number":92,"context_line":"        args \u003d [\u0027health-monitor\u0027, \u0027listener\u0027, \u0027loadbalancer\u0027, \u0027member\u0027,"},{"line_number":93,"context_line":"                \u0027listener\u0027, \u0027pool\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not any(arg in attrs for arg in args):"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_b7ad9732","line":92,"range":{"start_line":92,"start_character":16,"end_line":92,"end_character":32},"in_reply_to":"df87a7cf_8df0b292","updated":"2017-12-06 11:22:43.000000000","message":"Done","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"8a83aac3a90d9000c428bd177ceeee2aa5f91649","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _check_attrs(attrs):"},{"line_number":92,"context_line":"        args \u003d [\u0027health-monitor\u0027, \u0027listener\u0027, \u0027loadbalancer\u0027, \u0027member\u0027,"},{"line_number":93,"context_line":"                \u0027listener\u0027, \u0027pool\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not any(arg in attrs for arg in args):"},{"line_number":96,"context_line":"            msg \u003d (\u0027Missing required argument. Requires at least one of:%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_edfffe64","line":93,"range":{"start_line":93,"start_character":16,"end_line":93,"end_character":26},"updated":"2017-12-04 22:07:15.000000000","message":"duplicate","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"25ac3cacbdf737d6fcb41a301e936b2b8ed471b7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    @staticmethod"},{"line_number":91,"context_line":"    def _check_attrs(attrs):"},{"line_number":92,"context_line":"        args \u003d [\u0027health-monitor\u0027, \u0027listener\u0027, \u0027loadbalancer\u0027, \u0027member\u0027,"},{"line_number":93,"context_line":"                \u0027listener\u0027, \u0027pool\u0027]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not any(arg in attrs for arg in args):"},{"line_number":96,"context_line":"            msg \u003d (\u0027Missing required argument. Requires at least one of:%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_e3cb8fa2","line":93,"range":{"start_line":93,"start_character":16,"end_line":93,"end_character":26},"in_reply_to":"df87a7cf_edfffe64","updated":"2017-12-06 11:22:43.000000000","message":"Done","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"8a83aac3a90d9000c428bd177ceeee2aa5f91649","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        project_id \u003d attrs.pop(\u0027project_id\u0027)"},{"line_number":155,"context_line":"        body \u003d {\u0027quota\u0027: attrs}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        self.app.client_manager.load_balancer.quota_set(project_id, json\u003dbody)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"class ResetQuota(command.Command):"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_ad557652","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":78},"updated":"2017-12-04 22:07:15.000000000","message":"This returns the new quota.","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"25ac3cacbdf737d6fcb41a301e936b2b8ed471b7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        project_id \u003d attrs.pop(\u0027project_id\u0027)"},{"line_number":155,"context_line":"        body \u003d {\u0027quota\u0027: attrs}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        self.app.client_manager.load_balancer.quota_set(project_id, json\u003dbody)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"class ResetQuota(command.Command):"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_035f93e2","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":78},"in_reply_to":"df87a7cf_ad557652","updated":"2017-12-06 11:22:43.000000000","message":"Done","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"3bca9488fd535ce7dbb38c9a68920e0a52e9ca03","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            project_id\u003dproject_id"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        return (rows, (utils.get_dict_properties(data, rows)))"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class ShowQuotaDefaults(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":18,"id":"df87a7cf_180a6789","line":75,"range":{"start_line":75,"start_character":16,"end_line":75,"end_character":20},"updated":"2017-12-06 18:05:18.000000000","message":"In order to print titles that match the argument names, this should be [arg.replace(\u0027_\u0027, \u0027\u0027) for arg in rows]. same with the rest of the functions that print responses to screen.","commit_id":"6dcd7405bb12fa16ee34720c92bc30fc884714c3"}],"octaviaclient/osc/v2/utils.py":[{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"a3eb29a4b8d902d230984bfd77c3e74e3145068e","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    attr_map \u003d {"},{"line_number":381,"context_line":"        \u0027health_monitor\u0027: (\u0027health_monitor\u0027, int),"},{"line_number":382,"context_line":"        \u0027listener\u0027: (\u0027listener\u0027, int),"},{"line_number":383,"context_line":"        \u0027load_balancer\u0027: (\u0027load_balancer\u0027, int),"},{"line_number":384,"context_line":"        \u0027member\u0027: (\u0027member\u0027, int),"},{"line_number":385,"context_line":"        \u0027pool\u0027: (\u0027pool\u0027, int),"},{"line_number":386,"context_line":"        \u0027project\u0027: ("}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_136873b8","line":383,"range":{"start_line":383,"start_character":8,"end_line":383,"end_character":23},"updated":"2017-11-30 18:12:53.000000000","message":"\u0027loadbalancer\u0027","commit_id":"f71948f065ccde3a0d48f99a3d7e63a905e95836"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1cc848fd63810b54563437a6edb6a2b90b2fdcf5","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    attr_map \u003d {"},{"line_number":381,"context_line":"        \u0027health_monitor\u0027: (\u0027health_monitor\u0027, int),"},{"line_number":382,"context_line":"        \u0027listener\u0027: (\u0027listener\u0027, int),"},{"line_number":383,"context_line":"        \u0027load_balancer\u0027: (\u0027load_balancer\u0027, int),"},{"line_number":384,"context_line":"        \u0027member\u0027: (\u0027member\u0027, int),"},{"line_number":385,"context_line":"        \u0027pool\u0027: (\u0027pool\u0027, int),"},{"line_number":386,"context_line":"        \u0027project\u0027: ("}],"source_content_type":"text/x-python","patch_set":10,"id":"ff82abbf_ead8691f","line":383,"range":{"start_line":383,"start_character":8,"end_line":383,"end_character":23},"in_reply_to":"ff82abbf_136873b8","updated":"2017-11-30 23:06:09.000000000","message":"Done","commit_id":"f71948f065ccde3a0d48f99a3d7e63a905e95836"}],"octaviaclient/tests/unit/osc/v2/test_quota.py":[{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"0335b94d4a68de99ba6c5d679962991fe5aec0c7","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @mock.patch(\u0027octaviaclient.osc.v2.utils.get_quota_attrs\u0027)"},{"line_number":154,"context_line":"    def test_quota_set(self, mock_attrs):"},{"line_number":155,"context_line":"        mock_attrs.return_value \u003d {"},{"line_number":156,"context_line":"            \u0027project_id\u0027: self._qt.project_id,"},{"line_number":157,"context_line":"            \u0027pool\u0027: \u00272\u0027"},{"line_number":158,"context_line":"        }"},{"line_number":159,"context_line":"        arglist \u003d [self._qt.project_id, \u0027--pool\u0027, \u00272\u0027]"},{"line_number":160,"context_line":"        verifylist \u003d ["},{"line_number":161,"context_line":"            (\u0027project\u0027, self._qt.project_id),"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_ed3a9ee5","line":158,"range":{"start_line":155,"start_character":0,"end_line":158,"end_character":9},"updated":"2017-12-04 22:18:10.000000000","message":"Please test separately all possible arguments.","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"25ac3cacbdf737d6fcb41a301e936b2b8ed471b7","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @mock.patch(\u0027octaviaclient.osc.v2.utils.get_quota_attrs\u0027)"},{"line_number":154,"context_line":"    def test_quota_set(self, mock_attrs):"},{"line_number":155,"context_line":"        mock_attrs.return_value \u003d {"},{"line_number":156,"context_line":"            \u0027project_id\u0027: self._qt.project_id,"},{"line_number":157,"context_line":"            \u0027pool\u0027: \u00272\u0027"},{"line_number":158,"context_line":"        }"},{"line_number":159,"context_line":"        arglist \u003d [self._qt.project_id, \u0027--pool\u0027, \u00272\u0027]"},{"line_number":160,"context_line":"        verifylist \u003d ["},{"line_number":161,"context_line":"            (\u0027project\u0027, self._qt.project_id),"}],"source_content_type":"text/x-python","patch_set":11,"id":"df87a7cf_5781ab8e","line":158,"range":{"start_line":155,"start_character":0,"end_line":158,"end_character":9},"in_reply_to":"df87a7cf_ed3a9ee5","updated":"2017-12-06 11:22:43.000000000","message":"testing all possible arguments in one go for now","commit_id":"2f66bcec210915439218a8347e56a76d5b5150c0"}],"releasenotes/notes/add-quota-support-effed2cf2a8c7ad4.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c4319d0ca0c2231f19ecea959362d732afc8652c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Quota client API and OSC support."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * List, show, set, delete quotas"},{"line_number":7,"context_line":"    * Show quota defaults"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff82abbf_204bb484","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":37},"updated":"2017-11-21 18:21:01.000000000","message":"Can we reword this?  This patch does not add an API.\nMaybe \"Octavia quota support for the OpenStack client plugin.\"","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"777c2d3e12424747e8c41f1ce3ea2bae8063c94a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Quota client API and OSC support."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * List, show, set, delete quotas"},{"line_number":7,"context_line":"    * Show quota defaults"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff82abbf_d7f870c5","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":37},"in_reply_to":"ff82abbf_204bb484","updated":"2017-11-22 18:36:27.000000000","message":"Done","commit_id":"304ecbb452e115b2c4a2440bb37b08073d8f4cd7"},{"author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"change_message_id":"41cde54421cf61254f36f1f3a9e17985aa4041ff","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Octavia quota support for the OpenStack client plugin."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * List, show, set, delete quotas"},{"line_number":7,"context_line":"    * Show quota defaults"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_e0c19a55","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":29},"updated":"2017-11-29 13:34:28.000000000","message":"\u0027reset\u0027","commit_id":"cd016709a9857feb02930e4b274f4c54e73cfb06"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"485cd88480c5f8816b90c47df3c85aaa2f24393d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Octavia quota support for the OpenStack client plugin."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * List, show, set, delete quotas"},{"line_number":7,"context_line":"    * Show quota defaults"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff82abbf_0d439643","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":29},"in_reply_to":"ff82abbf_e0c19a55","updated":"2017-11-29 13:55:49.000000000","message":"Done","commit_id":"cd016709a9857feb02930e4b274f4c54e73cfb06"}],"setup.cfg":[{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"aad3d30825cb0ee954848b18eb443c305f2f6628","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    loadbalancer_quota_show \u003d octaviaclient.osc.v2.quota:ShowQuota"},{"line_number":67,"context_line":"    loadbalancer_quota_defaults_show \u003d octaviaclient.osc.v2.quota:ShowQuotaDefaults"},{"line_number":68,"context_line":"    loadbalancer_quota_delete \u003d octaviaclient.osc.v2.quota:DeleteQuota"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[build_sphinx]"},{"line_number":71,"context_line":"source-dir \u003d doc/source"},{"line_number":72,"context_line":"build-dir \u003d doc/build"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1f485f77_c52d9a95","line":69,"updated":"2017-11-19 22:16:11.000000000","message":"Missing SetQuota?\nloadbalancer_quota_set \u003d octaviaclient.osc.v2.quota:SetQuota","commit_id":"a36cb9e11dc77514861192d1dbd96f8a339161db"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"70ea23c14dbe358448a8c809b3a68ac76cc1d71d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    loadbalancer_quota_show \u003d octaviaclient.osc.v2.quota:ShowQuota"},{"line_number":67,"context_line":"    loadbalancer_quota_defaults_show \u003d octaviaclient.osc.v2.quota:ShowQuotaDefaults"},{"line_number":68,"context_line":"    loadbalancer_quota_delete \u003d octaviaclient.osc.v2.quota:DeleteQuota"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[build_sphinx]"},{"line_number":71,"context_line":"source-dir \u003d doc/source"},{"line_number":72,"context_line":"build-dir \u003d doc/build"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"1f485f77_68d23b2a","line":69,"in_reply_to":"1f485f77_c52d9a95","updated":"2017-11-19 22:23:58.000000000","message":"Done","commit_id":"a36cb9e11dc77514861192d1dbd96f8a339161db"}]}