)]}'
{"id":"openstack%2Fpython-octaviaclient~521482","triplet_id":"openstack%2Fpython-octaviaclient~master~Iaf7d251ef4054fa28ef61e02fdebc05c83786e9e","project":"openstack/python-octaviaclient","branch":"master","topic":"attr_underscore_to_hyphen","hashtags":[],"change_id":"Iaf7d251ef4054fa28ef61e02fdebc05c83786e9e","subject":"[WIP]: Attribute names should not use underscore","status":"ABANDONED","created":"2017-11-20 10:27:43.000000000","updated":"2019-02-10 08:23:09.000000000","total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"546c92149b0aa550307ae57296b0b58193928468","_number":521482,"virtual_id_number":521482,"owner":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"date":"2017-11-27 14:16:18.000000000","_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":-1,"date":"2017-11-20 10:46:18.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},{"value":-1,"date":"2017-12-08 16:41:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},{"value":-1,"date":"2017-12-20 23:42:04.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"all":[{"value":-1,"date":"2017-11-20 13:54:11.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"date":"2017-11-30 11:32:12.000000000","_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-20 10:46:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-11-27 14:16:18.000000000","updated_by":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"reviewer":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"state":"REVIEWER"},{"updated":"2017-11-30 11:32:12.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2017-12-08 16:41:43.000000000","updated_by":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"reviewer":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"state":"REVIEWER"},{"updated":"2017-12-20 23:42:04.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"}],"messages":[{"id":"81bc855e200ea65b6af6751f893f7123b8764efe","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2017-11-20 10:27:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6271df8581d25fad1b9bd0ceeca7419919c767f7","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2017-11-20 10:34:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a1cac07c4a3c77ee38eb8322e06eb61c5403ecf8","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2017-11-20 10:35:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3b9068b063e41dfc13e4f18f7a3f980e73f4a52e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-20 10:46:18.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/82/521482/3/check/openstack-tox-pep8/596909e/ : SUCCESS in 5m 02s\n- openstack-tox-py27 http://logs.openstack.org/82/521482/3/check/openstack-tox-py27/cc2b892/ : FAILURE in 4m 51s\n- build-openstack-sphinx-docs http://logs.openstack.org/82/521482/3/check/build-openstack-sphinx-docs/14ee9a6/html/ : SUCCESS in 3m 57s\n- openstack-tox-py35 http://logs.openstack.org/82/521482/3/check/openstack-tox-py35/eb17d25/ : FAILURE in 4m 18s\n- openstackclient-check-plugins http://logs.openstack.org/82/521482/3/check/openstackclient-check-plugins/5a46c48/ : SUCCESS in 5m 14s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"23d5c57081a194cca21525c084bdd6bd547013a7","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2017-11-20 13:54:11.000000000","message":"Patch Set 3: Workflow-1","accounts_in_message":[],"_revision_number":3},{"id":"a7ee05db00167b6b777fac2681e00292f463b02a","author":{"_account_id":25239,"name":"Bar Elharar","email":"bar@redhat.com","username":"belharar"},"date":"2017-11-27 14:16:18.000000000","message":"Patch Set 3:\n\n(5 comments)\n\nplease note that add_argument() has a rather surprising behavior, which is tightly correlated with the first character of the first positional reading. (https://github.com/python/cpython/blob/master/Lib/argparse.py#L1328-L1336)\nOne of the consequences is: Let there be a string Str that starts with an ABC letter, argparse.add_argument(Str, **kwargs) is equivalent to argparse.add_argument(dest\u003dStr, **kwargs)","accounts_in_message":[],"_revision_number":3},{"id":"511512cc35a67b1e0a60c6d90f1d993fe9e94d8e","author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"date":"2017-12-08 16:41:43.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)\n\nWe only need to update optional arguments start with --. But we don\u0027t need to update positional arguments.","accounts_in_message":[],"_revision_number":3},{"id":"d8ff801e9d1cb29db3260d56b5e5ae58af1d577d","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2017-12-20 23:42:04.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"6c9f42d6e21c27507c2306f3909b6371531c7b87","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2019-02-10 08:23:09.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"62c897ef0a9ddfc2f7273ad6df5ff85c1e056c30","revisions":{"8d49f876e8df9299e2e599ebb7e54dfd6d91ff4a":{"kind":"REWORK","_number":1,"created":"2017-11-20 10:27:43.000000000","uploader":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"ref":"refs/changes/82/521482/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/82/521482/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/1"}}},"commit":{"parents":[{"commit":"20920487a4a32493d19bbefed002e21f549a88b1","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/20920487a4a32493d19bbefed002e21f549a88b1"}]}],"author":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2017-11-20 08:58:31.000000000","tz":120},"committer":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2017-11-20 10:26:27.000000000","tz":120},"subject":"[WIP]: Attribute names should not use underscore","message":"[WIP]: Attribute names should not use underscore\n\nThis is a follow up to I336477e723867b5da2a041b441a25a7a611596ee\nAnd as a follow up to:\n\"All long options names shall begin with two dashes (\u0027--\u0027) and use a single\ndash (\u0027-\u0027) internally between words (--like-this). Underscores (\u0027_\u0027)\nshall not be used in option names.\"\n\nSince we already released a client, we would have to play nice and keep\nbackwards compatibility.\n\nChange-Id: Iaf7d251ef4054fa28ef61e02fdebc05c83786e9e\nSource: https://wiki.openstack.org/wiki/OpenStackClient/HumanInterfaceGuidelines#Command_Structure\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/8d49f876e8df9299e2e599ebb7e54dfd6d91ff4a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/8d49f876e8df9299e2e599ebb7e54dfd6d91ff4a"}]},"branch":"refs/heads/master"},"e7dd936930de35b028ced32007d0510ba8dfba2a":{"kind":"REWORK","_number":2,"created":"2017-11-20 10:34:00.000000000","uploader":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"ref":"refs/changes/82/521482/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/82/521482/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/2"}}},"commit":{"parents":[{"commit":"20920487a4a32493d19bbefed002e21f549a88b1","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/20920487a4a32493d19bbefed002e21f549a88b1"}]}],"author":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2017-11-20 08:58:31.000000000","tz":120},"committer":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2017-11-20 10:33:49.000000000","tz":120},"subject":"[WIP]: Attribute names should not use underscore","message":"[WIP]: Attribute names should not use underscore\n\nThis is a follow up to I336477e723867b5da2a041b441a25a7a611596ee\nAnd as a follow up to:\n\"All long options names shall begin with two dashes (\u0027--\u0027) and use a single\ndash (\u0027-\u0027) internally between words (--like-this). Underscores (\u0027_\u0027)\nshall not be used in option names.\"\n\nSince we already released a client, we would have to play nice and keep\nbackwards compatibility.\n\nChange-Id: Iaf7d251ef4054fa28ef61e02fdebc05c83786e9e\nSource: https://wiki.openstack.org/wiki/OpenStackClient/HumanInterfaceGuidelines#Command_Structure\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/e7dd936930de35b028ced32007d0510ba8dfba2a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/e7dd936930de35b028ced32007d0510ba8dfba2a"}]},"branch":"refs/heads/master"},"62c897ef0a9ddfc2f7273ad6df5ff85c1e056c30":{"kind":"REWORK","_number":3,"created":"2017-11-20 10:35:27.000000000","uploader":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"ref":"refs/changes/82/521482/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/82/521482/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/82/521482/3"}}},"commit":{"parents":[{"commit":"20920487a4a32493d19bbefed002e21f549a88b1","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/20920487a4a32493d19bbefed002e21f549a88b1"}]}],"author":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2017-11-20 08:58:31.000000000","tz":120},"committer":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2017-11-20 10:35:19.000000000","tz":120},"subject":"[WIP]: Attribute names should not use underscore","message":"[WIP]: Attribute names should not use underscore\n\nThis is a follow up to I336477e723867b5da2a041b441a25a7a611596ee\nAnd as a follow up to:\n\"All long options names shall begin with two dashes (\u0027--\u0027) and use a single\ndash (\u0027-\u0027) internally between words (--like-this). Underscores (\u0027_\u0027)\nshall not be used in option names.\"\n\nSince we already released a client, we would have to play nice and keep\nbackwards compatibility.\n\nChange-Id: Iaf7d251ef4054fa28ef61e02fdebc05c83786e9e\nSource: https://wiki.openstack.org/wiki/OpenStackClient/HumanInterfaceGuidelines#Command_Structure\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/62c897ef0a9ddfc2f7273ad6df5ff85c1e056c30"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/62c897ef0a9ddfc2f7273ad6df5ff85c1e056c30"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
