)]}'
{"id":"openstack%2Fpython-octaviaclient~530567","triplet_id":"openstack%2Fpython-octaviaclient~master~Ic0380a44749ea9bb506f67d876c3ecb7d363e726","project":"openstack/python-octaviaclient","branch":"master","topic":"unittests_cleanup","hashtags":[],"change_id":"Ic0380a44749ea9bb506f67d876c3ecb7d363e726","subject":"Improve unit testing scalability","status":"MERGED","created":"2017-12-31 04:00:03.000000000","updated":"2018-01-11 20:08:05.000000000","submitted":"2018-01-11 20:08:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"530567-1515701285343-2a1f4ec0","meta_rev_id":"ff20ae53139316748ea370eab85a262ab891c768","_number":530567,"virtual_id_number":530567,"owner":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":2,"date":"2018-01-11 20:08:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"all":[{"value":2,"date":"2018-01-11 19:58:29.000000000","_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":2,"date":"2018-01-10 00:43:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"all":[{"value":1,"date":"2018-01-11 19:58:29.000000000","_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-10 00:43:50.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2018-01-11 19:58:29.000000000","updated_by":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"reviewer":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"state":"REVIEWER"},{"updated":"2018-01-11 20:08:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6d4369558de0cfb986d7ae92285112d389e0c222","author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"date":"2017-12-31 04:00:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e4611e3a5ecc514be8d1535998d2553a3ebe4e9c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-31 04:09:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/67/530567/1/check/openstack-tox-pep8/0b716db/ : SUCCESS in 5m 27s\n- openstack-tox-py27 http://logs.openstack.org/67/530567/1/check/openstack-tox-py27/55da608/ : SUCCESS in 6m 43s\n- build-openstack-sphinx-docs http://logs.openstack.org/67/530567/1/check/build-openstack-sphinx-docs/cbd8257/html/ : SUCCESS in 5m 16s\n- openstack-tox-py35 http://logs.openstack.org/67/530567/1/check/openstack-tox-py35/cff2c06/ : SUCCESS in 6m 05s\n- openstackclient-check-plugins http://logs.openstack.org/67/530567/1/check/openstackclient-check-plugins/3187d37/ : SUCCESS in 8m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"07b0bcdbc886a94609d8c1841af11f17e3f4fd3a","author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"date":"2018-01-04 22:45:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e221632a27934942cd86efe750d703683f6d9346","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-04 23:23:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/67/530567/2/check/openstack-tox-pep8/0729fb6/ : SUCCESS in 36m 03s\n- openstack-tox-py27 http://logs.openstack.org/67/530567/2/check/openstack-tox-py27/1d1dbe6/ : SUCCESS in 4m 43s\n- build-openstack-sphinx-docs http://logs.openstack.org/67/530567/2/check/build-openstack-sphinx-docs/554763c/html/ : SUCCESS in 6m 45s\n- openstack-tox-py35 http://logs.openstack.org/67/530567/2/check/openstack-tox-py35/118066c/ : SUCCESS in 3m 49s\n- openstackclient-check-plugins http://logs.openstack.org/67/530567/2/check/openstackclient-check-plugins/efa59cd/ : SUCCESS in 6m 20s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"450b40132f932430bf86675c5d00f9c90e24a604","author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"date":"2018-01-08 02:51:48.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"60e40f8deac58fe35e47237f70082db7a0fa8a7e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-08 02:57:33.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/67/530567/3/check/openstack-tox-pep8/d71c906/ : SUCCESS in 3m 48s\n- openstack-tox-py27 http://logs.openstack.org/67/530567/3/check/openstack-tox-py27/b8c7b3d/ : SUCCESS in 3m 38s\n- build-openstack-sphinx-docs http://logs.openstack.org/67/530567/3/check/build-openstack-sphinx-docs/f747005/html/ : SUCCESS in 3m 47s\n- openstack-tox-py35 http://logs.openstack.org/67/530567/3/check/openstack-tox-py35/323cfbc/ : SUCCESS in 4m 01s\n- openstackclient-check-plugins http://logs.openstack.org/67/530567/3/check/openstackclient-check-plugins/5b466aa/ : SUCCESS in 4m 53s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d1c032b10ee012ae1e9d9c565fd8515e4f0468eb","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2018-01-10 00:43:50.000000000","message":"Patch Set 3: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":3},{"id":"430bf5eb6a9ac778fac2cd183913bf04780e581e","author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"date":"2018-01-11 19:58:29.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"68abf42761171c4ee08df9609bc1d8747effa87b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-11 19:58:40.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"119934e81fc96f9d2760c4cfa9f8d548e2de9eba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-11 20:08:05.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/67/530567/3/gate/openstack-tox-pep8/5bd2285/ : SUCCESS in 3m 39s\n- openstack-tox-py27 http://logs.openstack.org/67/530567/3/gate/openstack-tox-py27/96ef2cf/ : SUCCESS in 5m 10s\n- build-openstack-sphinx-docs http://logs.openstack.org/67/530567/3/gate/build-openstack-sphinx-docs/cfbbc52/html/ : SUCCESS in 4m 57s\n- openstack-tox-py35 http://logs.openstack.org/67/530567/3/gate/openstack-tox-py35/ae6c4c3/ : SUCCESS in 3m 42s","accounts_in_message":[],"_revision_number":3},{"id":"def10594ee720aa01a073666e363da9522179425","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-11 20:08:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c5bb79c8ecd91a6993a1a293836e71fb31f2bcec","revisions":{"a4f390ea6bf25b336e64664820497a0fd7edc408":{"kind":"REWORK","_number":1,"created":"2017-12-31 04:00:03.000000000","uploader":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"ref":"refs/changes/67/530567/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/67/530567/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/1"}}},"commit":{"parents":[{"commit":"ede853266f2235c5764bce6d41284809d81f0c86","subject":"Code cleanup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/ede853266f2235c5764bce6d41284809d81f0c86"}]}],"author":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2017-12-31 02:59:54.000000000","tz":120},"committer":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2017-12-31 03:59:48.000000000","tz":120},"subject":"Improve unit testing scalability","message":"Improve unit testing scalability\n\nThe use of class members in unittest\u0027s TestCase derivatives\nis discouraged, and the abundance of class members in the\ntesting code base has crippled the ability to add tests.\n\nThis patch addresses the scalability limitations by removing all class\nmembers and relocates them in the relevant setUp function.\n\nChange-Id: Ic0380a44749ea9bb506f67d876c3ecb7d363e726\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/a4f390ea6bf25b336e64664820497a0fd7edc408"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/a4f390ea6bf25b336e64664820497a0fd7edc408"}]},"branch":"refs/heads/master"},"c97231755f5856e60ab55bbf2ee6e019def6751e":{"kind":"REWORK","_number":2,"created":"2018-01-04 22:45:56.000000000","uploader":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"ref":"refs/changes/67/530567/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/67/530567/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/2"}}},"commit":{"parents":[{"commit":"449627cf5ca7bb0e75e9a31ee2bb97f5663a00f2","subject":"Code cleanup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/449627cf5ca7bb0e75e9a31ee2bb97f5663a00f2"}]}],"author":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2017-12-31 02:59:54.000000000","tz":120},"committer":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2018-01-04 22:33:45.000000000","tz":120},"subject":"Improve unit testing scalability","message":"Improve unit testing scalability\n\nThe use of class members in unittest\u0027s TestCase derivatives\nis discouraged, and the abundance of class members in the\ntesting code base has crippled the ability to add tests.\n\nThis patch addresses the scalability limitations by removing all class\nmembers and relocates them in the relevant setUp function.\n\nChange-Id: Ic0380a44749ea9bb506f67d876c3ecb7d363e726\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/c97231755f5856e60ab55bbf2ee6e019def6751e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/c97231755f5856e60ab55bbf2ee6e019def6751e"}]},"branch":"refs/heads/master"},"c5bb79c8ecd91a6993a1a293836e71fb31f2bcec":{"kind":"REWORK","_number":3,"created":"2018-01-08 02:51:48.000000000","uploader":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"ref":"refs/changes/67/530567/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/67/530567/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/67/530567/3"}}},"commit":{"parents":[{"commit":"f06396cb8747792b564226cd49e3f961bd3e9a28","subject":"Code cleanup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/f06396cb8747792b564226cd49e3f961bd3e9a28"}]}],"author":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2017-12-31 02:59:54.000000000","tz":120},"committer":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2018-01-08 02:47:46.000000000","tz":120},"subject":"Improve unit testing scalability","message":"Improve unit testing scalability\n\nThe use of class members in unittest\u0027s TestCase derivatives\nis discouraged, and the abundance of class members in the\ntesting code base has crippled the ability to add tests.\n\nThis patch addresses the scalability limitations by removing all class\nmembers and relocates them in the relevant setUp function.\n\nChange-Id: Ic0380a44749ea9bb506f67d876c3ecb7d363e726\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/c5bb79c8ecd91a6993a1a293836e71fb31f2bcec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/c5bb79c8ecd91a6993a1a293836e71fb31f2bcec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}