)]}'
{"id":"openstack%2Fpython-octaviaclient~533320","triplet_id":"openstack%2Fpython-octaviaclient~master~Ib972bcab11f5b7239d98114364081281d2af2d46","project":"openstack/python-octaviaclient","branch":"master","topic":"533320","hashtags":[],"change_id":"Ib972bcab11f5b7239d98114364081281d2af2d46","subject":"Remove direct dependency on testtools","status":"MERGED","created":"2018-01-12 22:49:02.000000000","updated":"2018-01-17 11:58:37.000000000","submitted":"2018-01-17 11:58:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"533320-1516190317853-da110e64","meta_rev_id":"d1efd7eb33a8a2105adf4f79d75b91cf73905b58","_number":533320,"virtual_id_number":533320,"owner":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":2,"date":"2018-01-17 11:58:37.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"all":[{"value":2,"date":"2018-01-16 11:37:56.000000000","_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},{"value":2,"date":"2018-01-16 11:37:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"all":[{"value":1,"date":"2018-01-16 12:08:32.000000000","_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-15 18:46:11.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2018-01-16 12:08:32.000000000","updated_by":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"reviewer":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"state":"REVIEWER"},{"updated":"2018-01-17 11:58:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7d115c0c00571c08701a6cc7fb9b5e99c85f0025","author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"date":"2018-01-12 22:49:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bb8ca67abc181c0c9882152f613b39b688e2bd86","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2018-01-12 22:59:36.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nPlease give a bit more context so we know why this was done.","accounts_in_message":[],"_revision_number":1},{"id":"9f7763b4b7d83c39b73f788d8ca1eaee79097c0d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 23:12:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/533320/1/check/openstack-tox-pep8/62db282/ : SUCCESS in 4m 38s\n- openstack-tox-py27 http://logs.openstack.org/20/533320/1/check/openstack-tox-py27/b600d22/ : SUCCESS in 5m 56s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/533320/1/check/build-openstack-sphinx-docs/69aa7ea/html/ : SUCCESS in 3m 57s\n- requirements-check http://logs.openstack.org/20/533320/1/check/requirements-check/5bb2142/ : SUCCESS in 3m 53s\n- openstack-tox-py35 http://logs.openstack.org/20/533320/1/check/openstack-tox-py35/0d978f0/ : SUCCESS in 3m 43s\n- openstackclient-check-plugins http://logs.openstack.org/20/533320/1/check/openstackclient-check-plugins/fc87212/ : SUCCESS in 7m 04s (non-voting)\n- build-openstack-releasenotes http://logs.openstack.org/20/533320/1/check/build-openstack-releasenotes/2853b67/html/ : SUCCESS in 4m 21s","accounts_in_message":[],"_revision_number":1},{"id":"e9d22813cb8c8e6b500eebe84834199151c65b67","author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"date":"2018-01-12 23:17:07.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"358ed012675fe880c293425fd1eae19e307ec3cc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-12 23:28:46.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/533320/2/check/openstack-tox-pep8/34c0067/ : SUCCESS in 4m 21s\n- openstack-tox-py27 http://logs.openstack.org/20/533320/2/check/openstack-tox-py27/ac3e316/ : SUCCESS in 4m 35s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/533320/2/check/build-openstack-sphinx-docs/4b456d3/html/ : SUCCESS in 4m 57s\n- requirements-check http://logs.openstack.org/20/533320/2/check/requirements-check/2f76cb3/ : SUCCESS in 3m 34s\n- openstack-tox-py35 http://logs.openstack.org/20/533320/2/check/openstack-tox-py35/525a540/ : SUCCESS in 4m 14s\n- openstackclient-check-plugins http://logs.openstack.org/20/533320/2/check/openstackclient-check-plugins/4304708/ : SUCCESS in 5m 48s (non-voting)\n- build-openstack-releasenotes http://logs.openstack.org/20/533320/2/check/build-openstack-releasenotes/bb472f4/html/ : SUCCESS in 3m 05s","accounts_in_message":[],"_revision_number":2},{"id":"ba88198718bc6673951064c11bd8bc1a1e89314d","author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"date":"2018-01-12 23:34:59.000000000","message":"Patch Set 2:\n\nI didn\u0027t include much context in the commit message, but testtools project seems to be a sinking ship. It has seen its last meaningful update in April, and it breaks functionalities that are natively supported by Python\u0027s unittest standard library package.\nCurrently, we depend on testtools through osc_lib, and I hope it is only a matter of time until osc_lib will fork \u0026 ditch it.","accounts_in_message":[],"_revision_number":2},{"id":"43561d6708c4deb4018ecdb205367c8e52a8b374","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2018-01-15 18:46:11.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"915f532a285b1d3298461d1ed8c24faf5d1b2788","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2018-01-16 10:06:16.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"ad47bda76fdec299bfc4043e3b0c5cd6c55f5ccc","author":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"date":"2018-01-16 11:37:56.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"3415f85928902c461cadcf0c1f1abed4daa8334f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-16 12:07:16.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/533320/3/check/openstack-tox-pep8/8808aec/ : SUCCESS in 5m 08s\n- openstack-tox-py27 http://logs.openstack.org/20/533320/3/check/openstack-tox-py27/9c9bdc1/ : SUCCESS in 4m 38s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/533320/3/check/build-openstack-sphinx-docs/b92b92d/html/ : SUCCESS in 5m 57s\n- requirements-check http://logs.openstack.org/20/533320/3/check/requirements-check/20cd755/ : SUCCESS in 5m 10s\n- openstack-tox-py35 http://logs.openstack.org/20/533320/3/check/openstack-tox-py35/4d72cc5/ : SUCCESS in 4m 58s\n- openstackclient-check-plugins http://logs.openstack.org/20/533320/3/check/openstackclient-check-plugins/9671bc9/ : SUCCESS in 8m 15s (non-voting)\n- build-openstack-releasenotes http://logs.openstack.org/20/533320/3/check/build-openstack-releasenotes/fc7f11c/html/ : SUCCESS in 3m 32s","accounts_in_message":[],"_revision_number":3},{"id":"b021e2543c70ea7bdc0eefdd1997db6afbc45a6d","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2018-01-16 12:08:32.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"c876671a9be2fdeed3b71e26713fc0d3042fa2f0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-17 11:49:21.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"c54a62a88be0bc221507bda1236a49fa3ce4720f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-17 11:58:37.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"2cf401e4af22710c381f28101c656bb677bfd832","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-17 11:58:37.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/20/533320/3/gate/openstack-tox-pep8/363691a/ : SUCCESS in 4m 00s\n- openstack-tox-py27 http://logs.openstack.org/20/533320/3/gate/openstack-tox-py27/fd1982a/ : SUCCESS in 4m 08s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/533320/3/gate/build-openstack-sphinx-docs/3e14ec5/html/ : SUCCESS in 3m 58s\n- requirements-check http://logs.openstack.org/20/533320/3/gate/requirements-check/bf64a3c/ : SUCCESS in 3m 23s\n- openstack-tox-py35 http://logs.openstack.org/20/533320/3/gate/openstack-tox-py35/2667957/ : SUCCESS in 3m 58s\n- build-openstack-releasenotes http://logs.openstack.org/20/533320/3/gate/build-openstack-releasenotes/0219ce3/html/ : SUCCESS in 4m 11s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a62772d87beb6ed025b1101f331543de3cdf966b","revisions":{"92b0239a3a93f19ef161be0b855d3fc4849e7557":{"kind":"REWORK","_number":1,"created":"2018-01-12 22:49:02.000000000","uploader":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"ref":"refs/changes/20/533320/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/20/533320/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/1"}}},"commit":{"parents":[{"commit":"8532e174b184a9f1c067a39bfc530e4f93b25c3b","subject":"Merge \"Update new documentation PTI jobs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/8532e174b184a9f1c067a39bfc530e4f93b25c3b"}]}],"author":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2018-01-12 22:46:41.000000000","tz":120},"committer":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2018-01-12 22:46:41.000000000","tz":120},"subject":"Remove direct dependency on testtools","message":"Remove direct dependency on testtools\n\nChange-Id: Ib972bcab11f5b7239d98114364081281d2af2d46\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/92b0239a3a93f19ef161be0b855d3fc4849e7557"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/92b0239a3a93f19ef161be0b855d3fc4849e7557"}]},"branch":"refs/heads/master"},"88ccb263a35f5dec0555eb8fbb365ae23b547ffb":{"kind":"REWORK","_number":2,"created":"2018-01-12 23:17:07.000000000","uploader":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"ref":"refs/changes/20/533320/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/20/533320/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/2"}}},"commit":{"parents":[{"commit":"a05fd261da455ab7ba4bbf7e2c8f1e775db35377","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/a05fd261da455ab7ba4bbf7e2c8f1e775db35377"}]}],"author":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2018-01-12 22:46:41.000000000","tz":120},"committer":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2018-01-12 23:16:26.000000000","tz":120},"subject":"Remove direct dependency on testtools","message":"Remove direct dependency on testtools\n\nosc_lib is Openstack\u0027s standard for testing utilities\nand in contrast to testtools, it is actively maintained.\n\ntests/utils.py is a zombie file, and better version\nof its content can be found in osc_lib.\n\nChange-Id: Ib972bcab11f5b7239d98114364081281d2af2d46\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/88ccb263a35f5dec0555eb8fbb365ae23b547ffb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/88ccb263a35f5dec0555eb8fbb365ae23b547ffb"}]},"branch":"refs/heads/master"},"a62772d87beb6ed025b1101f331543de3cdf966b":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2018-01-16 11:37:56.000000000","uploader":{"_account_id":27303,"name":"Bar Elharar","email":"elhararb@gmail.com","username":"elhararb"},"ref":"refs/changes/20/533320/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/20/533320/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/20/533320/3"}}},"commit":{"parents":[{"commit":"f13640edb125f3bb1006fb8b4c3eff823fe7cfbb","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/f13640edb125f3bb1006fb8b4c3eff823fe7cfbb"}]}],"author":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2018-01-12 22:46:41.000000000","tz":120},"committer":{"name":"Bar Elharar","email":"elhararb@gmail.com","date":"2018-01-16 11:37:56.000000000","tz":0},"subject":"Remove direct dependency on testtools","message":"Remove direct dependency on testtools\n\nosc_lib is Openstack\u0027s standard for testing utilities\nand in contrast to testtools, it is actively maintained.\n\ntests/utils.py is a zombie file, and better version\nof its content can be found in osc_lib.\n\nChange-Id: Ib972bcab11f5b7239d98114364081281d2af2d46\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/a62772d87beb6ed025b1101f331543de3cdf966b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/a62772d87beb6ed025b1101f331543de3cdf966b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
