)]}'
{"id":"openstack%2Fpython-octaviaclient~580322","triplet_id":"openstack%2Fpython-octaviaclient~master~If48529bd32771aba248f10248d2125279a7464a3","project":"openstack/python-octaviaclient","branch":"master","topic":"story/2002806","hashtags":[],"change_id":"If48529bd32771aba248f10248d2125279a7464a3","subject":"Add some filter options to load balancer list command","status":"MERGED","created":"2018-07-05 08:54:38.000000000","updated":"2018-07-25 23:44:05.000000000","submitted":"2018-07-25 23:44:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"580322-1532562245630-3ebd00cc","meta_rev_id":"dc788f5f9c2bb487402d3d80cfc402257e4f94ea","_number":580322,"virtual_id_number":580322,"owner":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"},{"value":2,"date":"2018-07-25 23:44:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-07-16 11:08:49.000000000","_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"all":[{"value":2,"date":"2018-07-25 23:28:15.000000000","_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"date":"2018-07-16 14:57:56.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":2,"date":"2018-07-25 23:34:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":1,"date":"2018-07-25 23:34:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},{"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-05 09:11:59.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2018-07-08 08:40:47.000000000","updated_by":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"reviewer":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"state":"REVIEWER"},{"updated":"2018-07-16 14:57:56.000000000","updated_by":{"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"},"reviewer":{"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"},"state":"REVIEWER"},{"updated":"2018-07-25 23:28:15.000000000","updated_by":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"reviewer":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"state":"REVIEWER"},{"updated":"2018-07-25 23:34:14.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2018-07-25 23:44:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"528f7ffcab3281cf001b20f6007f52b14ee53182","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-05 08:54:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"232112c7cd1187634e71b7b6d658025f9a3b8684","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-05 09:05:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/22/580322/1/check/openstack-tox-pep8/57da622/ : SUCCESS in 4m 25s\n- openstack-tox-py27 http://logs.openstack.org/22/580322/1/check/openstack-tox-py27/9224764/ : SUCCESS in 5m 10s\n- build-openstack-sphinx-docs http://logs.openstack.org/22/580322/1/check/build-openstack-sphinx-docs/71b8316/html/ : SUCCESS in 5m 56s\n- openstack-tox-py35 http://logs.openstack.org/22/580322/1/check/openstack-tox-py35/9a966c5/ : SUCCESS in 3m 55s\n- openstackclient-check-plugins http://logs.openstack.org/22/580322/1/check/openstackclient-check-plugins/bccaaca/ : SUCCESS in 5m 29s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/22/580322/1/check/openstack-tox-lower-constraints/cfe5c4b/ : SUCCESS in 5m 24s","accounts_in_message":[],"_revision_number":1},{"id":"2ccb82eb5d2f8e1027856237cb8cfd3a92e4b8db","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2018-07-05 09:11:59.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nThank you for picking up the story!\n\nIf possible, please also add support for:\n\n- vip port id\n- provisioning status\n- operating status\n- provider\n\nPlease also include a release note.","accounts_in_message":[],"_revision_number":1},{"id":"5d5457b18b897723de23e3cbebfe5ee20c27fe44","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-06 02:14:45.000000000","message":"Patch Set 1:\n\n(3 comments)\n\n\u003e (3 comments)\n \u003e \n \u003e Thank you for picking up the story!\n \u003e \n \u003e If possible, please also add support for:\n \u003e \n \u003e - vip port id\n \u003e - provisioning status\n \u003e - operating status\n \u003e - provider\n \u003e \n \u003e Please also include a release note.\n\nDone, thanks.","accounts_in_message":[],"_revision_number":1},{"id":"68ad645edb9125f369251e0590fa4da21a6060fa","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-06 02:14:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"01f610709d98cffa8b1548ebb252f03fbefd0705","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-06 02:21:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cbb18799b9b33dccc2a22d3312096f64ad9aa841","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-06 02:32:58.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"3d86c09a33f4b949cb0275eac5e7e0da950c0d97","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-06 02:33:04.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/22/580322/3/check/openstack-tox-pep8/1cb6a1c/ : SUCCESS in 4m 08s\n- openstack-tox-py27 http://logs.openstack.org/22/580322/3/check/openstack-tox-py27/7cf498f/ : SUCCESS in 4m 30s\n- build-openstack-sphinx-docs http://logs.openstack.org/22/580322/3/check/build-openstack-sphinx-docs/610efd1/html/ : SUCCESS in 3m 33s\n- openstack-tox-py35 http://logs.openstack.org/22/580322/3/check/openstack-tox-py35/7fa928a/ : SUCCESS in 5m 31s\n- openstackclient-check-plugins http://logs.openstack.org/22/580322/3/check/openstackclient-check-plugins/2cabff9/ : SUCCESS in 5m 44s (non-voting)\n- build-openstack-releasenotes http://logs.openstack.org/22/580322/3/check/build-openstack-releasenotes/a4cc86e/html/ : SUCCESS in 3m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/580322/3/check/openstack-tox-lower-constraints/ef4c346/ : SUCCESS in 4m 45s","accounts_in_message":[],"_revision_number":3},{"id":"6d6da0c37870b956fa7cade7ba7c86b1100f3bd7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-06 02:42:20.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/22/580322/4/check/openstack-tox-pep8/90b6b01/ : SUCCESS in 4m 56s\n- openstack-tox-py27 http://logs.openstack.org/22/580322/4/check/openstack-tox-py27/ffb9e2f/ : SUCCESS in 4m 31s\n- build-openstack-sphinx-docs http://logs.openstack.org/22/580322/4/check/build-openstack-sphinx-docs/3f77fc9/html/ : SUCCESS in 4m 23s\n- openstack-tox-py35 http://logs.openstack.org/22/580322/4/check/openstack-tox-py35/25c346c/ : SUCCESS in 5m 30s\n- openstackclient-check-plugins http://logs.openstack.org/22/580322/4/check/openstackclient-check-plugins/aa1c2e3/ : SUCCESS in 6m 29s (non-voting)\n- build-openstack-releasenotes http://logs.openstack.org/22/580322/4/check/build-openstack-releasenotes/d7733b9/html/ : SUCCESS in 3m 31s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/580322/4/check/openstack-tox-lower-constraints/8090eec/ : SUCCESS in 5m 50s","accounts_in_message":[],"_revision_number":4},{"id":"b12e25782c42405a13dc7139e423aace31fb3b1c","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2018-07-08 08:40:47.000000000","message":"Patch Set 4: Code-Review-1\n\nThanks so much for picking up this story.\nI have tested this, here are my comments:\n1. It didn\u0027t work for me; I did not see anything about the filter I tried to apply in the request body, see line#46 here[1]. I think you should make some additions to take_action() function here[2].\n\n2. Some filters have well-known choices.\nFor example: --provisioning status choices listed here[3]  and --operating-status choices listed here[4].\nArgparse does support a list of choices for a given parameter, so I would use that to expose the valid choices in our client so typos and wrong entries will get filtered in the client side.  There are few examples for this in the code. See [5][6].\n\nP.S.\nWhen you allow options, those should accept both upper and lower cases (and convert to upper case by the client), for reference see[7].\n\n[1] http://paste.openstack.org/show/725298/\n[2] https://review.openstack.org/#/c/580322/4/octaviaclient/osc/v2/load_balancer.py@250\n[3] https://developer.openstack.org/api-ref/load-balancer/v2/#provisioning-status-codes\n[4] https://developer.openstack.org/api-ref/load-balancer/v2/#operating-status-codes\n[5] https://github.com/openstack/python-octaviaclient/blob/c606a1da7237621edeebc76eb42fe6acbce24b43/octaviaclient/osc/v2/health_monitor.py#L58-L64\n[6] https://github.com/openstack/python-octaviaclient/blob/3c6213ebeb878520496284af3acb3786f3a62c38/octaviaclient/osc/v2/member.py#L128\n[7] https://review.openstack.org/#/c/525791/","accounts_in_message":[],"_revision_number":4},{"id":"65550a20d2cabfb2c443822a757891ee40462c13","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-10 04:02:16.000000000","message":"Patch Set 4:\n\n\u003e Thanks so much for picking up this story.\n \u003e I have tested this, here are my comments:\n \u003e 1. It didn\u0027t work for me; I did not see anything about the filter I\n \u003e tried to apply in the request body, see line#46 here[1]. I think\n \u003e you should make some additions to take_action() function here[2].\n \u003e \n \u003e 2. Some filters have well-known choices.\n \u003e For example: --provisioning status choices listed here[3]  and\n \u003e --operating-status choices listed here[4].\n \u003e Argparse does support a list of choices for a given parameter, so I\n \u003e would use that to expose the valid choices in our client so typos\n \u003e and wrong entries will get filtered in the client side.  There are\n \u003e few examples for this in the code. See [5][6].\n \u003e \n \u003e P.S.\n \u003e When you allow options, those should accept both upper and lower\n \u003e cases (and convert to upper case by the client), for reference\n \u003e see[7].\n \u003e \n \u003e [1] http://paste.openstack.org/show/725298/\n \u003e [2] https://review.openstack.org/#/c/580322/4/octaviaclient/osc/v2/load_balancer.py@250\n \u003e [3] https://developer.openstack.org/api-ref/load-balancer/v2/#provisioning-status-codes\n \u003e [4] https://developer.openstack.org/api-ref/load-balancer/v2/#operating-status-codes\n \u003e [5] https://github.com/openstack/python-octaviaclient/blob/c606a1da7237621edeebc76eb42fe6acbce24b43/octaviaclient/osc/v2/health_monitor.py#L58-L64\n \u003e [6] https://github.com/openstack/python-octaviaclient/blob/3c6213ebeb878520496284af3acb3786f3a62c38/octaviaclient/osc/v2/member.py#L128\n \u003e [7] https://review.openstack.org/#/c/525791/\n\nThanks for your review, I will fix these problems in the next patch.","accounts_in_message":[],"_revision_number":4},{"id":"0d0a95cdb2feaeec986ffe75ad9b6fd2f7c047f1","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-10 04:02:22.000000000","message":"Patch Set 4: Workflow-1","accounts_in_message":[],"_revision_number":4},{"id":"6c3e1925f8885f88a93fe8f6163957493f0cd141","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-11 10:07:46.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"9765663f88cf4b5d105f154b4f9918c6960a0741","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-11 10:22:10.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/22/580322/5/check/openstack-tox-pep8/24da0af/ : SUCCESS in 4m 04s\n- openstack-tox-py27 http://logs.openstack.org/22/580322/5/check/openstack-tox-py27/e433877/ : SUCCESS in 4m 46s\n- build-openstack-sphinx-docs http://logs.openstack.org/22/580322/5/check/build-openstack-sphinx-docs/477a382/html/ : SUCCESS in 6m 52s\n- openstack-tox-py35 http://logs.openstack.org/22/580322/5/check/openstack-tox-py35/6ecd217/ : SUCCESS in 3m 57s\n- openstackclient-check-plugins http://logs.openstack.org/22/580322/5/check/openstackclient-check-plugins/255852d/ : SUCCESS in 8m 56s (non-voting)\n- build-openstack-releasenotes http://logs.openstack.org/22/580322/5/check/build-openstack-releasenotes/0b99dcd/html/ : SUCCESS in 4m 13s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/580322/5/check/openstack-tox-lower-constraints/4dc563b/ : SUCCESS in 4m 45s","accounts_in_message":[],"_revision_number":5},{"id":"05eacb7bc7f090d62190fbc0b04500db719d9af1","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-11 11:24:31.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"ab7d4b06646fa8e7d6affa948cc49b6ff6b4569f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-11 11:37:30.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/22/580322/6/check/openstack-tox-pep8/45c4366/ : SUCCESS in 4m 26s\n- openstack-tox-py27 http://logs.openstack.org/22/580322/6/check/openstack-tox-py27/838b9d8/ : SUCCESS in 5m 19s\n- build-openstack-sphinx-docs http://logs.openstack.org/22/580322/6/check/build-openstack-sphinx-docs/f1050c5/html/ : SUCCESS in 6m 09s\n- openstack-tox-py35 http://logs.openstack.org/22/580322/6/check/openstack-tox-py35/28399f7/ : SUCCESS in 6m 36s\n- openstackclient-check-plugins http://logs.openstack.org/22/580322/6/check/openstackclient-check-plugins/a3d5858/ : SUCCESS in 8m 39s (non-voting)\n- build-openstack-releasenotes http://logs.openstack.org/22/580322/6/check/build-openstack-releasenotes/88c13ae/html/ : SUCCESS in 4m 15s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/580322/6/check/openstack-tox-lower-constraints/620bf21/ : SUCCESS in 5m 47s","accounts_in_message":[],"_revision_number":6},{"id":"5505281927e2e7d6dcd81bd634fb8d6c9d3a0ab9","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-12 04:48:14.000000000","message":"Patch Set 6:\n\n\u003e Thanks so much for picking up this story.\n \u003e I have tested this, here are my comments:\n \u003e 1. It didn\u0027t work for me; I did not see anything about the filter I\n \u003e tried to apply in the request body, see line#46 here[1]. I think\n \u003e you should make some additions to take_action() function here[2].\n \u003e \n \u003e 2. Some filters have well-known choices.\n \u003e For example: --provisioning status choices listed here[3]  and\n \u003e --operating-status choices listed here[4].\n \u003e Argparse does support a list of choices for a given parameter, so I\n \u003e would use that to expose the valid choices in our client so typos\n \u003e and wrong entries will get filtered in the client side.  There are\n \u003e few examples for this in the code. See [5][6].\n \u003e \n \u003e P.S.\n \u003e When you allow options, those should accept both upper and lower\n \u003e cases (and convert to upper case by the client), for reference\n \u003e see[7].\n \u003e \n \u003e [1] http://paste.openstack.org/show/725298/\n \u003e [2] https://review.openstack.org/#/c/580322/4/octaviaclient/osc/v2/load_balancer.py@250\n \u003e [3] https://developer.openstack.org/api-ref/load-balancer/v2/#provisioning-status-codes\n \u003e [4] https://developer.openstack.org/api-ref/load-balancer/v2/#operating-status-codes\n \u003e [5] https://github.com/openstack/python-octaviaclient/blob/c606a1da7237621edeebc76eb42fe6acbce24b43/octaviaclient/osc/v2/health_monitor.py#L58-L64\n \u003e [6] https://github.com/openstack/python-octaviaclient/blob/3c6213ebeb878520496284af3acb3786f3a62c38/octaviaclient/osc/v2/member.py#L128\n \u003e [7] https://review.openstack.org/#/c/525791/\n\nHello, Nir, I had tested the code, now the \u0027operating-status\u0027, \u0027provisioning-status\u0027 and \u0027provider\u0027 parameters also can \nfilter the load balancer list:)","accounts_in_message":[],"_revision_number":6},{"id":"1e5142ad4dcb953aded2ed159059ae98a07c6458","author":{"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"},"date":"2018-07-16 07:23:03.000000000","message":"Patch Set 6: Code-Review-1\n\nhi yanpuqing, I test this patch.\nBut in my environment, it doesn\u0027t work with  \"--vip-network-id\" and \"--vip-subnet-id\" see here http://paste.openstack.org/show/725981/","accounts_in_message":[],"_revision_number":6},{"id":"9016a08fbe50b61d709dd2a59384fdf1533a911b","author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"date":"2018-07-16 11:08:49.000000000","message":"Patch Set 6:\n\n\u003e hi yanpuqing, I test this patch.\n \u003e But in my environment, it doesn\u0027t work with  \"--vip-network-id\" and\n \u003e \"--vip-subnet-id\" see here http://paste.openstack.org/show/725981/\n\nHello, I tested it again for \"--vip-network-id\" and \"--vip-subnet-id\", it was work in my environment:)\nCould you mind to check your code， there should be \"list_networks\", not \"list_subnets\"[1]\n\n[1] https://github.com/openstack/python-octaviaclient/blob/23ed033a676229a47d122a40a413da965c97c235/octaviaclient/osc/v2/utils.py#L152","accounts_in_message":[],"_revision_number":6},{"id":"66d7bf2c07e1caaf64566610d153c942bdcd7a6d","author":{"_account_id":25653,"name":"xuchaochao","email":"chao2xu@foxmail.com","username":"chaochao.xu"},"date":"2018-07-16 14:57:56.000000000","message":"Patch Set 6: -Code-Review\n\nSorry, It may be my mistake.\nMy envionment is devstack, and I also check code is not wrong.\nBut I find each option witch is related to neutronclient can not work.\nMaybe neutronclient has some problems in my envionment","accounts_in_message":[],"_revision_number":6},{"id":"f9f3e39a4f5da7726d84fc813a7e3d07626884c9","author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"date":"2018-07-25 23:28:15.000000000","message":"Patch Set 6: Code-Review+2\n\nI am not sure if other projects do the same but we can filter by parameters which are not shown in the result which fells awkward (e.g. --operating-status)","accounts_in_message":[],"_revision_number":6},{"id":"ecaaee6587ed3f5c6ecd6ae4ed6b72aa1948aeea","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2018-07-25 23:34:14.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":6},{"id":"0f93bccfb7cbacbc576a4c657f6a9a0e13a04c9e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 23:34:26.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"9b83cbc3ef7e63520f293aeaec44079104d9475d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 23:44:05.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/22/580322/6/gate/openstack-tox-pep8/33b10ca/ : SUCCESS in 4m 48s\n- openstack-tox-py27 http://logs.openstack.org/22/580322/6/gate/openstack-tox-py27/ec0b6aa/ : SUCCESS in 6m 05s\n- build-openstack-sphinx-docs http://logs.openstack.org/22/580322/6/gate/build-openstack-sphinx-docs/3bad3c0/html/ : SUCCESS in 6m 31s\n- openstack-tox-py35 http://logs.openstack.org/22/580322/6/gate/openstack-tox-py35/3cadec8/ : SUCCESS in 4m 44s\n- build-openstack-releasenotes http://logs.openstack.org/22/580322/6/gate/build-openstack-releasenotes/be87c96/html/ : SUCCESS in 3m 48s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/580322/6/gate/openstack-tox-lower-constraints/d614f29/ : SUCCESS in 6m 11s","accounts_in_message":[],"_revision_number":6},{"id":"874e1359c75ae5775c1a1edeb0e0b6497d75efae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-25 23:44:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"7a816d4f433bd0bc4720f45d4c15618dbf040ae6","revisions":{"9612c75c3b9e4f6fa11ff1f58b0a6d51d57ee06b":{"kind":"REWORK","_number":1,"created":"2018-07-05 08:54:38.000000000","uploader":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"ref":"refs/changes/22/580322/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/22/580322/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/1"}}},"commit":{"parents":[{"commit":"234b3e82ce8966708ec876a02f41ec45b915da35","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/234b3e82ce8966708ec876a02f41ec45b915da35"}]}],"author":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-05 08:45:11.000000000","tz":0},"committer":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-05 08:54:37.000000000","tz":0},"subject":"Add some filter options to load balancer list command","message":"Add some filter options to load balancer list command\n\nThis patch adds the following options: \u0027--vip-network-id\u0027,\n\u0027--vip-subnet-id\u0027, \u0027--vip-qos-policy-id\u0027 to load balancer list\ncommand.\n\nChange-Id: If48529bd32771aba248f10248d2125279a7464a3\nTask: 22717\nStory: 2002806\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/9612c75c3b9e4f6fa11ff1f58b0a6d51d57ee06b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/9612c75c3b9e4f6fa11ff1f58b0a6d51d57ee06b"}]},"branch":"refs/heads/master"},"ca50a16494a92e78bf481575a31145110979e5c5":{"kind":"REWORK","_number":2,"created":"2018-07-06 02:14:57.000000000","uploader":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"ref":"refs/changes/22/580322/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/22/580322/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/2"}}},"commit":{"parents":[{"commit":"234b3e82ce8966708ec876a02f41ec45b915da35","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/234b3e82ce8966708ec876a02f41ec45b915da35"}]}],"author":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-05 08:45:11.000000000","tz":0},"committer":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-06 02:12:37.000000000","tz":0},"subject":":Add some filter options to load balancer list command","message":":Add some filter options to load balancer list command\n\nThis patch adds the following options: \u0027--vip-network-id\u0027,\n\u0027--vip-subnet-id\u0027, \u0027--vip-qos-policy-id\u0027 to load balancer list\ncommand.\n\nChange-Id: If48529bd32771aba248f10248d2125279a7464a3\nTask: 22717\nStory: 2002806\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/ca50a16494a92e78bf481575a31145110979e5c5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/ca50a16494a92e78bf481575a31145110979e5c5"}]},"branch":"refs/heads/master"},"995043d5ec4b700dc041a9c1bbe572bb38bbe789":{"kind":"REWORK","_number":3,"created":"2018-07-06 02:21:46.000000000","uploader":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"ref":"refs/changes/22/580322/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/22/580322/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/3"}}},"commit":{"parents":[{"commit":"234b3e82ce8966708ec876a02f41ec45b915da35","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/234b3e82ce8966708ec876a02f41ec45b915da35"}]}],"author":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-05 08:45:11.000000000","tz":0},"committer":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-06 02:21:28.000000000","tz":0},"subject":":Add some filter options to load balancer list command","message":":Add some filter options to load balancer list command\n\nThis patch adds the following options: \u0027--vip-network-id\u0027,\n\u0027--vip-subnet-id\u0027, \u0027--vip-qos-policy-id\u0027 to load balancer list\ncommand.\n\nChange-Id: If48529bd32771aba248f10248d2125279a7464a3\nTask: 22717\nStory: 2002806\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/995043d5ec4b700dc041a9c1bbe572bb38bbe789"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/995043d5ec4b700dc041a9c1bbe572bb38bbe789"}]},"branch":"refs/heads/master"},"d4ab9c6713b4bb6fbab0a21f1cbb87096657a0f9":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2018-07-06 02:32:58.000000000","uploader":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"ref":"refs/changes/22/580322/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/22/580322/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/4"}}},"commit":{"parents":[{"commit":"234b3e82ce8966708ec876a02f41ec45b915da35","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/234b3e82ce8966708ec876a02f41ec45b915da35"}]}],"author":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-05 08:45:11.000000000","tz":0},"committer":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-06 02:31:11.000000000","tz":0},"subject":"Add some filter options to load balancer list command","message":"Add some filter options to load balancer list command\n\nThis patch adds the following options: \u0027--vip-network-id\u0027,\n\u0027--vip-subnet-id\u0027, \u0027--vip-qos-policy-id\u0027, \u0027--vip-port-id\u0027,\n\u0027--provisioning-status\u0027, \u0027--operating-status\u0027, \u0027--provider\u0027\nto load balancer list command.\n\nChange-Id: If48529bd32771aba248f10248d2125279a7464a3\nTask: 22717\nStory: 2002806\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/d4ab9c6713b4bb6fbab0a21f1cbb87096657a0f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/d4ab9c6713b4bb6fbab0a21f1cbb87096657a0f9"}]},"branch":"refs/heads/master"},"6c5122302925a5f105e7407dcf2ba6d4d908c8a0":{"kind":"REWORK","_number":5,"created":"2018-07-11 10:07:46.000000000","uploader":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"ref":"refs/changes/22/580322/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/22/580322/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/5"}}},"commit":{"parents":[{"commit":"234b3e82ce8966708ec876a02f41ec45b915da35","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/234b3e82ce8966708ec876a02f41ec45b915da35"}]}],"author":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-05 08:45:11.000000000","tz":0},"committer":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-11 10:07:36.000000000","tz":0},"subject":"Add some filter options to load balancer list command","message":"Add some filter options to load balancer list command\n\nThis patch adds the following options: \u0027--vip-network-id\u0027,\n\u0027--vip-subnet-id\u0027, \u0027--vip-qos-policy-id\u0027, \u0027--vip-port-id\u0027,\n\u0027--provisioning-status\u0027, \u0027--operating-status\u0027, \u0027--provider\u0027\nto load balancer list command.\n\nChange-Id: If48529bd32771aba248f10248d2125279a7464a3\nTask: 22717\nStory: 2002806\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/6c5122302925a5f105e7407dcf2ba6d4d908c8a0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/6c5122302925a5f105e7407dcf2ba6d4d908c8a0"}]},"branch":"refs/heads/master"},"7a816d4f433bd0bc4720f45d4c15618dbf040ae6":{"kind":"REWORK","_number":6,"created":"2018-07-11 11:24:31.000000000","uploader":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"ref":"refs/changes/22/580322/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/22/580322/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/22/580322/6"}}},"commit":{"parents":[{"commit":"234b3e82ce8966708ec876a02f41ec45b915da35","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/234b3e82ce8966708ec876a02f41ec45b915da35"}]}],"author":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-05 08:45:11.000000000","tz":0},"committer":{"name":"yanpuqing","email":"yanpq@awcloud.com","date":"2018-07-11 11:24:21.000000000","tz":0},"subject":"Add some filter options to load balancer list command","message":"Add some filter options to load balancer list command\n\nThis patch adds the following options: \u0027--vip-network-id\u0027,\n\u0027--vip-subnet-id\u0027, \u0027--vip-qos-policy-id\u0027, \u0027--vip-port-id\u0027,\n\u0027--provisioning-status\u0027, \u0027--operating-status\u0027, \u0027--provider\u0027\nto load balancer list command.\n\nChange-Id: If48529bd32771aba248f10248d2125279a7464a3\nTask: 22717\nStory: 2002806\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/7a816d4f433bd0bc4720f45d4c15618dbf040ae6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/7a816d4f433bd0bc4720f45d4c15618dbf040ae6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}