)]}'
{"id":"openstack%2Fpython-octaviaclient~623938","triplet_id":"openstack%2Fpython-octaviaclient~master~Icbfbee1309630782a3c2cf3399a8cf32704e0adf","project":"openstack/python-octaviaclient","branch":"master","topic":"add-compute-flavor","hashtags":[],"change_id":"Icbfbee1309630782a3c2cf3399a8cf32704e0adf","subject":"Add compute_flavor field to amphora","status":"MERGED","created":"2018-12-09 11:57:22.000000000","updated":"2018-12-24 18:36:50.000000000","submitted":"2018-12-24 18:36:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"623938-1545676610467-3c0954c5","meta_rev_id":"455f2c5c5c1ba0c60f9e52e79f9b3252881e756f","_number":623938,"virtual_id_number":623938,"owner":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"date":"2018-12-09 12:04:13.000000000","_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":28377,"name":"Julien Carpentier","email":"carpentier.julien@gmail.com","username":"jiteka"},{"value":0,"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},{"value":2,"date":"2018-12-24 18:36:50.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"all":[{"value":2,"date":"2018-12-11 23:27:56.000000000","_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":2,"date":"2018-12-24 18:27:20.000000000","_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":1,"date":"2018-12-10 13:03:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28377,"name":"Julien Carpentier","email":"carpentier.julien@gmail.com","username":"jiteka"},{"value":1,"date":"2018-12-11 10:37:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":1,"date":"2018-12-24 18:27:20.000000000","_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":28377,"name":"Julien Carpentier","email":"carpentier.julien@gmail.com","username":"jiteka"},{"value":0,"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":28377,"name":"Julien Carpentier","email":"carpentier.julien@gmail.com","username":"jiteka"},{"value":0,"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},{"_account_id":28377,"name":"Julien Carpentier","email":"carpentier.julien@gmail.com","username":"jiteka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-12-10 13:03:51.000000000","updated_by":{"_account_id":28377,"name":"Julien Carpentier","email":"carpentier.julien@gmail.com","username":"jiteka"},"reviewer":{"_account_id":28377,"name":"Julien Carpentier","email":"carpentier.julien@gmail.com","username":"jiteka"},"state":"REVIEWER"},{"updated":"2018-12-11 10:37:28.000000000","updated_by":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"reviewer":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"state":"REVIEWER"},{"updated":"2018-12-11 23:27:56.000000000","updated_by":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"reviewer":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"state":"REVIEWER"},{"updated":"2018-12-24 18:27:20.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2018-12-24 18:36:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"44ccdd1cd2aca37c85bad4599bace0dfbce4d67c","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2018-12-09 11:57:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bd090207808a7e02cd7eedb7cc64157f5214d4b8","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2018-12-09 12:03:29.000000000","message":"Patch Set 1:\n\noutput example: http://paste.openstack.org/show/736868/","accounts_in_message":[],"_revision_number":1},{"id":"bc7d8759fe61f5d27dd65bfa1e9a21270c45a983","author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"date":"2018-12-09 12:04:13.000000000","message":"Patch Set 1:\n\nI intentionally did not add compute flavor to the amphora list output. Let me know if you disagree and think it should be a part of it.","accounts_in_message":[],"_revision_number":1},{"id":"d95e49b625994fdf58813c34d84b45210d9af052","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-09 12:08:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/38/623938/1/check/openstack-tox-cover/5a7354b/cover/ : SUCCESS in 6m 32s\n- openstack-tox-lower-constraints http://logs.openstack.org/38/623938/1/check/openstack-tox-lower-constraints/b789899/ : SUCCESS in 6m 49s\n- openstack-tox-pep8 http://logs.openstack.org/38/623938/1/check/openstack-tox-pep8/f00aeff/ : SUCCESS in 6m 02s\n- openstack-tox-py27 http://logs.openstack.org/38/623938/1/check/openstack-tox-py27/52717ed/ : SUCCESS in 3m 56s\n- openstack-tox-py35 http://logs.openstack.org/38/623938/1/check/openstack-tox-py35/840fba2/ : SUCCESS in 3m 51s\n- openstack-tox-py36 http://logs.openstack.org/38/623938/1/check/openstack-tox-py36/b5264f9/ : SUCCESS in 4m 52s\n- openstackclient-check-plugins http://logs.openstack.org/38/623938/1/check/openstackclient-check-plugins/109b537/ : SUCCESS in 5m 35s (non-voting)\n- openstack-tox-docs http://logs.openstack.org/38/623938/1/check/openstack-tox-docs/1e24d46/html/ : SUCCESS in 4m 28s","accounts_in_message":[],"_revision_number":1},{"id":"1fdd725d44f7ced51fc2ce61f05c2b8069fb9cb7","author":{"_account_id":28377,"name":"Julien Carpentier","email":"carpentier.julien@gmail.com","username":"jiteka"},"date":"2018-12-10 13:03:51.000000000","message":"Patch Set 1: Code-Review+1\n\nI would be more interested having ability to filter by compute_flavor than having them into amphora list output","accounts_in_message":[],"_revision_number":1},{"id":"b44ed8336fc410757e0210a1e693704c1ad76c88","author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"date":"2018-12-11 10:37:28.000000000","message":"Patch Set 1: Code-Review+1\n\nCurrently, the compute flavor of amphora is specified via a configuration file which means the compute flavor is uniform. But, In the future, We may support to specify compute flavor via Octavia provider flavor.","accounts_in_message":[],"_revision_number":1},{"id":"1240541b1fb07cac31fea0ee592bcfd30f8828b8","author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"date":"2018-12-11 23:27:56.000000000","message":"Patch Set 1: Code-Review+2\n\nI still think it\u0027s good info. Operator might change the flavor field in the config but the amps with the old flavor are still present. That is helpful if you need to failover amps (e.g. to evacuate a part of your DC)","accounts_in_message":[],"_revision_number":1},{"id":"b5f0e4497a9425401d66cfe46f42a459e42885a4","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2018-12-24 18:27:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n\u003e I would be more interested having ability to filter by\n \u003e compute_flavor than having them into amphora list output\n\nThis patch adds compute_flavor to the amphora show. It will not be shown by amphora list.","accounts_in_message":[],"_revision_number":1},{"id":"1142d6210354c16649fba1691c2500ff620326e0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-24 18:27:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e486c590870b245dd6365dc2365d05255849291d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-24 18:36:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"045b901cf3cf6ae5f707143de47d801ec5e048fd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-24 18:36:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/38/623938/1/gate/openstack-tox-lower-constraints/aa87524/ : SUCCESS in 3m 36s\n- openstack-tox-pep8 http://logs.openstack.org/38/623938/1/gate/openstack-tox-pep8/7e09911/ : SUCCESS in 3m 27s\n- openstack-tox-py27 http://logs.openstack.org/38/623938/1/gate/openstack-tox-py27/14f34f4/ : SUCCESS in 3m 22s\n- openstack-tox-py35 http://logs.openstack.org/38/623938/1/gate/openstack-tox-py35/00c3bdb/ : SUCCESS in 4m 10s\n- openstack-tox-py36 http://logs.openstack.org/38/623938/1/gate/openstack-tox-py36/3468778/ : SUCCESS in 3m 32s\n- openstack-tox-docs http://logs.openstack.org/38/623938/1/gate/openstack-tox-docs/916c916/html/ : SUCCESS in 3m 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0c2b107d8d16c1f90b57f39e3569a4da78bf74c3","revisions":{"0c2b107d8d16c1f90b57f39e3569a4da78bf74c3":{"kind":"REWORK","_number":1,"created":"2018-12-09 11:57:22.000000000","uploader":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"ref":"refs/changes/38/623938/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/38/623938/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/38/623938/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/38/623938/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/38/623938/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/38/623938/1"}}},"commit":{"parents":[{"commit":"300fd657d6a33b5be472308f37a144ffba584d08","subject":"Add Python 3.6 classifier to setup.cfg","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/300fd657d6a33b5be472308f37a144ffba584d08"}]}],"author":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2018-12-09 11:29:57.000000000","tz":120},"committer":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2018-12-09 11:54:32.000000000","tz":120},"subject":"Add compute_flavor field to amphora","message":"Add compute_flavor field to amphora\n\nStory: 2002896\nTask: 28346\n\nDepends-On: Ib3ca05d816747d08ef7055ec532b81746468cbf9\nChange-Id: Icbfbee1309630782a3c2cf3399a8cf32704e0adf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/0c2b107d8d16c1f90b57f39e3569a4da78bf74c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/0c2b107d8d16c1f90b57f39e3569a4da78bf74c3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}