)]}'
{"id":"openstack%2Fpython-octaviaclient~696947","triplet_id":"openstack%2Fpython-octaviaclient~master~I35aa0bf105c3b59abb2ff775af12198bc0436572","project":"openstack/python-octaviaclient","branch":"master","topic":"696947","hashtags":[],"change_id":"I35aa0bf105c3b59abb2ff775af12198bc0436572","subject":"Fix API breakage due to new exceptions module","status":"MERGED","created":"2019-12-02 19:44:49.000000000","updated":"2019-12-03 01:09:51.000000000","submitted":"2019-12-03 01:08:46.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"696947-1575335327069-c826a830","meta_rev_id":"d78176e7fbe92b36364450d3002128bd5a099fa2","_number":696947,"virtual_id_number":696947,"owner":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-03 01:08:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":2,"date":"2019-12-03 00:47:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-02 21:46:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":1,"date":"2019-12-03 00:47:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-02 20:18:02.000000000","updated_by":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"reviewer":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"state":"REVIEWER"},{"updated":"2019-12-02 21:46:27.000000000","updated_by":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"reviewer":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"state":"REVIEWER"},{"updated":"2019-12-03 00:47:03.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2019-12-03 01:08:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"95d41aa3e74ba642da26581bb5a30a53c4969a7e","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2019-12-02 19:44:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a63a068135f590bba6e459c33df641cda0fd4393","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-12-02 19:50:23.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"920c01d6a2f9a8b65ee3bf10064dd902f3aef0fd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-02 19:55:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e6ef1442172245ceb95572804e31688e : SUCCESS in 3m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3ee3430b4acd4308bec4c3e091d2d45e : SUCCESS in 3m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/05a763bf75564ca0b26f7d3c8e715e7c : SUCCESS in 2m 29s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/fd1daca0625a4a5584915c95c518a436 : SUCCESS in 3m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c9ece62c512c49439a5643811646638b : SUCCESS in 3m 00s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/140f60927e264f2697f3b7f5e1702693 : SUCCESS in 3m 28s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/25710511be914e8ba05b3a2f3d848218 : SUCCESS in 3m 58s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3e0c5a25282f47568f52d753e90d63ce : SUCCESS in 5m 02s","accounts_in_message":[],"_revision_number":1},{"id":"d3d5cb3f2e0dda3cbf3266dcb554dfb129a71962","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2019-12-02 20:05:16.000000000","message":"Patch Set 1:\n\nI looked into it, but debtcollector.moves won\u0027t work. For one thing, it only emits the deprecation warning when an instance is instantiated (which consumers of this lib will almost never do). But more importantly, the class returned as the \u0027old\u0027 one is actually a subclass, so the actual exceptions.OctaviaClientException will never match in an \"except octavia.OctaviaClientException:\" clause, which is how consumers of this lib will actually use it.","accounts_in_message":[],"_revision_number":1},{"id":"6c7aae0c4ec7cf69870f5c3ff7fee302bcc29cae","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-12-02 20:09:09.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nAlright, I guess we do this.","accounts_in_message":[],"_revision_number":1},{"id":"1c405e44117a0377a5e11da1f765fb2f2957bf82","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2019-12-02 20:10:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6fa2748ccbb5b9429bd88a6bf18a4f67d2cc00f9","author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"date":"2019-12-02 20:18:02.000000000","message":"Patch Set 1: Backport-Candidate-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"033f560cc28c2dd010e539af7e1855f311564a3b","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-12-02 20:21:08.000000000","message":"Patch Set 1: Code-Review-1\n\nYeah, ok, tests run in 5 minutes anyway. Just fix it. :D","accounts_in_message":[],"_revision_number":1},{"id":"2d7faa5e2669f01cea1ff6bce072af7d2974d057","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-12-02 21:33:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"45fd2e1aeb806e695bb25844b017ccaee2feaa3d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-02 21:40:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/88ba4f025f4e4e7ca213b9d2fd4e14f4 : SUCCESS in 4m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0e6f555e24c8416694d4a777ea3af9fc : SUCCESS in 3m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/728b207875e141f18d081a0cc22ab80d : SUCCESS in 3m 03s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d77b7a328dd34f919735f12884233a8d : SUCCESS in 3m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/720e73693aa7426a9c31d62932d39413 : SUCCESS in 3m 32s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/645dd878f8f849a9b6b94eafc47c9726 : SUCCESS in 3m 23s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/6d1c47a484d64327bd4664141747fe64 : SUCCESS in 5m 05s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ebe53284d5f4095b98467dd6b33edcf : SUCCESS in 5m 58s","accounts_in_message":[],"_revision_number":2},{"id":"c7ee0660de5ca96f9ea6c1af180fca8da8dd437d","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-12-02 21:46:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"40d8ddb2c39df01cc6a108181c9d4d05f780e3ed","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-12-03 00:47:03.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"d54904f1a09f0fd0c576bf85f2db403b21a3694a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-03 00:47:15.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9b3588891813f65655e8537d96fbc7702d3a94b6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-03 01:08:46.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/27da8758800b405cbd5336688244ea8f : SUCCESS in 4m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6da2fb05a13d458dbcba3c957a6b533f : SUCCESS in 3m 00s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/24579508bea9433ba273f6747fd3b6d6 : SUCCESS in 3m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1b4bf6cf59164dafb66ac6f5a7c632cd : SUCCESS in 4m 04s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/52f6e75abfaa4a93a83d56c699bd2add : SUCCESS in 5m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7d53b058c205403485f2c979ba8bec06 : SUCCESS in 7m 28s","accounts_in_message":[],"_revision_number":2},{"id":"4c84031e0f651341eb48c4223b0d0793ff30af3e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-03 01:08:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"471ca6aad5015fadab6ec19010b299f76725d9e7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-03 01:09:51.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fbd2cb51dc9b43eab6e4ec937a5a4376 : SUCCESS in 50s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"400a3a73e015e4c72c1a5610eecf237bf290e584","revisions":{"f89e47772519d838f397613c139f969aa93116e9":{"kind":"REWORK","_number":1,"created":"2019-12-02 19:44:49.000000000","uploader":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"ref":"refs/changes/47/696947/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/47/696947/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/47/696947/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/47/696947/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/47/696947/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/47/696947/1"}}},"commit":{"parents":[{"commit":"deaa37820c00ade1224d77f792302b5974fadd52","subject":"Merge \"Add \"--wait\" functionality\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/deaa37820c00ade1224d77f792302b5974fadd52"}]}],"author":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2019-12-02 19:36:30.000000000","tz":-300},"committer":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2019-12-02 19:44:32.000000000","tz":-300},"subject":"Fix API breakage due to new exceptions module","message":"Fix API breakage due to new exceptions module\n\nThe commit ae244fcf25188f38c28870238e648e765a2e3adf broke API consumers\nby moving the OctaviaClientException to a different module. Ensure it\nremains available in its previous location by importing it by name.\n\nChange-Id: I35aa0bf105c3b59abb2ff775af12198bc0436572\nStory: #2006970\nTask: 37698\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/f89e47772519d838f397613c139f969aa93116e9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/f89e47772519d838f397613c139f969aa93116e9"}]},"branch":"refs/heads/master"},"400a3a73e015e4c72c1a5610eecf237bf290e584":{"kind":"REWORK","_number":2,"created":"2019-12-02 21:33:12.000000000","uploader":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"ref":"refs/changes/47/696947/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-octaviaclient","ref":"refs/changes/47/696947/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/47/696947/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/47/696947/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-octaviaclient refs/changes/47/696947/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-octaviaclient refs/changes/47/696947/2"}}},"commit":{"parents":[{"commit":"deaa37820c00ade1224d77f792302b5974fadd52","subject":"Merge \"Add \"--wait\" functionality\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/deaa37820c00ade1224d77f792302b5974fadd52"}]}],"author":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2019-12-02 19:36:30.000000000","tz":-300},"committer":{"name":"Adam Harwell","email":"flux.adam@gmail.com","date":"2019-12-02 21:32:09.000000000","tz":-480},"subject":"Fix API breakage due to new exceptions module","message":"Fix API breakage due to new exceptions module\n\nThe commit ae244fcf25188f38c28870238e648e765a2e3adf broke API consumers\nby moving the OctaviaClientException to a different module. Ensure it\nremains available in its previous location by importing it by name.\n\nChange-Id: I35aa0bf105c3b59abb2ff775af12198bc0436572\nStory: #2006970\nTask: 37698\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/400a3a73e015e4c72c1a5610eecf237bf290e584"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-octaviaclient/commit/400a3a73e015e4c72c1a5610eecf237bf290e584"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}