)]}'
{"octaviaclient/api/v2/octavia.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"1f98c02ba8ba54238de5fe7f2270de6e7ef6585e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            code \u003d None"},{"line_number":37,"context_line":"            message \u003d \u0027Unknown Error\u0027"},{"line_number":38,"context_line":"            request_id \u003d \"n/a\""},{"line_number":39,"context_line":"            if e.request_id:"},{"line_number":40,"context_line":"                request_id \u003d e.request_id"},{"line_number":41,"context_line":"            if hasattr(e, \u0027response\u0027):"},{"line_number":42,"context_line":"                code \u003d e.response.status_code"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_10c3b78a","line":39,"updated":"2020-03-10 21:27:04.000000000","message":"should this be a hasattr(e, \u0027request_id\u0027)?","commit_id":"153a36943e5bc4e486827379167270859fc0bb65"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b754352b68ea202385cfc68b24f89ae09bd0b7be","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                try:"},{"line_number":44,"context_line":"                    message \u003d e.response.json().get("},{"line_number":45,"context_line":"                        \u0027faultstring\u0027,"},{"line_number":46,"context_line":"                        _status_dict.get(code, \u0027Unknown Error\u0027))"},{"line_number":47,"context_line":"                except Exception:"},{"line_number":48,"context_line":"                    message \u003d _status_dict.get(code, \u0027Unknown Error\u0027)"},{"line_number":49,"context_line":"            elif (isinstance(e, osc_exc.ClientException)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_3026f369","line":46,"updated":"2020-03-10 21:28:46.000000000","message":"Same as below.","commit_id":"153a36943e5bc4e486827379167270859fc0bb65"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"1f98c02ba8ba54238de5fe7f2270de6e7ef6585e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                        \u0027faultstring\u0027,"},{"line_number":46,"context_line":"                        _status_dict.get(code, \u0027Unknown Error\u0027))"},{"line_number":47,"context_line":"                except Exception:"},{"line_number":48,"context_line":"                    message \u003d _status_dict.get(code, \u0027Unknown Error\u0027)"},{"line_number":49,"context_line":"            elif (isinstance(e, osc_exc.ClientException)"},{"line_number":50,"context_line":"                    and e.code !\u003d e.http_status):"},{"line_number":51,"context_line":"                # cover https://review.opendev.org/675328 case"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_d04d1f3b","line":48,"updated":"2020-03-10 21:27:04.000000000","message":"Shouldn\u0027t this use `message` (itself) as the default, which is already set to \"Unknown Error\"? :D\nSince it can\u0027t be set to anything else yet without this being called...\nOtherwise I don\u0027t even see a reason to set it, not seeing a code patch where it\u0027s actually used before being set again (though I am fairly tired so could be wrong).","commit_id":"153a36943e5bc4e486827379167270859fc0bb65"}]}
