)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aa2b82532cb05737197df3f644712b305a3c745e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7ff64cfe_048e73e4","updated":"2023-08-21 08:01:48.000000000","message":"LGTM except the help strings\nTested in devstack.","commit_id":"751fa9913e7d137a529fa11788509ddc1620ee39"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8127771ce12e09505f6eef87c8e5697a92ab967b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"240a94d9_70c48144","updated":"2023-08-24 06:29:20.000000000","message":"Feature patch merged","commit_id":"15a8d741243ada386dccc901052e71b5e6f1b731"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23e79f7428f8876cd7999965574ce8faf5450f28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"efb85db4_a8210929","updated":"2023-08-22 20:51:14.000000000","message":"One comment that can be added in a follow up patch.","commit_id":"15a8d741243ada386dccc901052e71b5e6f1b731"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"0b0c339cc5bebc899290bdaacf8d3df3a1f6edbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"60de7714_683686a8","updated":"2023-08-23 13:13:54.000000000","message":"W-1 until the feature is merged in Octavia","commit_id":"15a8d741243ada386dccc901052e71b5e6f1b731"}],"octaviaclient/osc/v2/listener.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"aa2b82532cb05737197df3f644712b305a3c745e","unresolved":true,"context_lines":[{"line_number":215,"context_line":"            \u0027--hsts-include-subdomains\u0027,"},{"line_number":216,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":217,"context_line":"            dest\u003d\u0027hsts_include_subdomains\u0027,"},{"line_number":218,"context_line":"            help\u003d\"Defines whether the includeSubDomains directive should be \""},{"line_number":219,"context_line":"                 \"added to the Strict-Transport-Security HTTP response \""},{"line_number":220,"context_line":"                 \"header.\""},{"line_number":221,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"9c334522_fec63e2d","line":218,"range":{"start_line":218,"start_character":18,"end_line":218,"end_character":25},"updated":"2023-08-21 08:01:48.000000000","message":"(this line and bellow)\nDefine? (to be consistent with the other parameters)","commit_id":"751fa9913e7d137a529fa11788509ddc1620ee39"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"e938e53ea8a07e46902a4739ebb0c37da81e9b08","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            \u0027--hsts-include-subdomains\u0027,"},{"line_number":216,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":217,"context_line":"            dest\u003d\u0027hsts_include_subdomains\u0027,"},{"line_number":218,"context_line":"            help\u003d\"Defines whether the includeSubDomains directive should be \""},{"line_number":219,"context_line":"                 \"added to the Strict-Transport-Security HTTP response \""},{"line_number":220,"context_line":"                 \"header.\""},{"line_number":221,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"32c36d3b_ef940da7","line":218,"range":{"start_line":218,"start_character":18,"end_line":218,"end_character":25},"in_reply_to":"9c334522_fec63e2d","updated":"2023-08-22 11:06:07.000000000","message":"Done","commit_id":"751fa9913e7d137a529fa11788509ddc1620ee39"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"23e79f7428f8876cd7999965574ce8faf5450f28","unresolved":true,"context_lines":[{"line_number":212,"context_line":"                 \"Security (HSTS) for the TLS-terminated listener.\""},{"line_number":213,"context_line":"        )"},{"line_number":214,"context_line":"        parser.add_argument("},{"line_number":215,"context_line":"            \u0027--hsts-include-subdomains\u0027,"},{"line_number":216,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":217,"context_line":"            dest\u003d\u0027hsts_include_subdomains\u0027,"},{"line_number":218,"context_line":"            help\u003d\"Define whether the includeSubDomains directive should be \""}],"source_content_type":"text/x-python","patch_set":12,"id":"cdc744a7_d2804eaa","line":215,"updated":"2023-08-22 20:51:14.000000000","message":"You could update the validate method to check that someone isn\u0027t trying to specify the optional parameters when they do not provide hsts-max-age.\nhttps://github.com/openstack/python-octaviaclient/blob/master/octaviaclient/osc/v2/validate.py#L59","commit_id":"15a8d741243ada386dccc901052e71b5e6f1b731"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"5da9a8ae3e415e8cd9220055d43f2a4c632e1c9a","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                 \"Security (HSTS) for the TLS-terminated listener.\""},{"line_number":213,"context_line":"        )"},{"line_number":214,"context_line":"        parser.add_argument("},{"line_number":215,"context_line":"            \u0027--hsts-include-subdomains\u0027,"},{"line_number":216,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":217,"context_line":"            dest\u003d\u0027hsts_include_subdomains\u0027,"},{"line_number":218,"context_line":"            help\u003d\"Define whether the includeSubDomains directive should be \""}],"source_content_type":"text/x-python","patch_set":12,"id":"67501f9e_85119399","line":215,"in_reply_to":"cdc744a7_d2804eaa","updated":"2023-08-23 11:51:54.000000000","message":"Done in follow up patch in patch chain.","commit_id":"15a8d741243ada386dccc901052e71b5e6f1b731"}]}