)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2a1ca858851a4e35fadef7493788c29f1de2343d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cddd5224_31324bf0","updated":"2026-08-12 15:15:51.000000000","message":"This will also need a requirements bump once the openstacksdk change merges and is released.","commit_id":"99d7040fb8a7c251e6f6c4c30c7f7d278e320bb3"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"eab605c7dba239de7e50489ddf15de4bc326c731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1e8b0240_30a2f510","in_reply_to":"cddd5224_31324bf0","updated":"2026-08-14 05:13:16.000000000","message":"I agree with you. I\u0027d like to do the bump as a follow-up, since the openstacksdk change hasn\u0027t merged yet and there\u0027s no version to pin.\n\nThis patch doesn\u0027t need it at runtime -- NetworkIPAvailability sets _allow_unknown_attrs_in_body, so the attribute passes through on 4.16.0 too, and the unit tests pass against both.\n\nThe dependency also runs the other way: the openstacksdk change fails osc-tox-*-tips without this patch\u0027s updated test expectations. I\u0027ve dropped the Depends-On here and added it on the openstacksdk side, so this one merges first.","commit_id":"99d7040fb8a7c251e6f6c4c30c7f7d278e320bb3"}],"openstackclient/network/v2/ip_availability.py":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"dc70f96c5eb88bff987cc047430651421689d71c","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    The attribute is only present when the \u0027network-ip-availability-details\u0027"},{"line_number":59,"context_line":"    extension is enabled, so fall back to an empty value."},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":"    details \u003d getattr(item, \u0027ip_availability_details\u0027, None) or {}"},{"line_number":62,"context_line":"    return details.get(field, \u0027\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9123c187_387b4b9c","line":61,"updated":"2026-08-12 14:25:15.000000000","message":"```suggestion\n    details \u003d getattr(item, \u0027ip_availability_details\u0027) or {}\n```\n\nDon\u0027t need the explicit `None`","commit_id":"99d7040fb8a7c251e6f6c4c30c7f7d278e320bb3"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"f7b4294ff5153cd05fd75bbb77019bafcc181a31","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    The attribute is only present when the \u0027network-ip-availability-details\u0027"},{"line_number":59,"context_line":"    extension is enabled, so fall back to an empty value."},{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":"    details \u003d getattr(item, \u0027ip_availability_details\u0027, None) or {}"},{"line_number":62,"context_line":"    return details.get(field, \u0027\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e2abc9cd_d0dfc63c","line":61,"in_reply_to":"9123c187_387b4b9c","updated":"2026-08-14 05:11:59.000000000","message":"Thank you for the comment. I\u0027d like to keep the default for now.\n\nrequirements allows openstacksdk\u003e\u003d4.16.0, where the attribute is not declared yet, so getattr() without a default raises AttributeError whenever the network-ip-availability-details extension is not enabled.\n\nOnce the SDK change is released and requirements is bumped, I\u0027ll drop it and use `item.ip_availability_details or {}` instead.","commit_id":"99d7040fb8a7c251e6f6c4c30c7f7d278e320bb3"}]}
