)]}'
{"id":"openstack%2Fpython-openstackclient~1010170","triplet_id":"openstack%2Fpython-openstackclient~master~Iedf8aca33e87078557daa8de1dd7591d42a2d37a","project":"openstack/python-openstackclient","branch":"master","attention_set":{},"removed_from_attention_set":{"35059":{"account":{"_account_id":35059,"name":"Veronika Fisarova","display_name":"vfisarov","email":"vfisarov@redhat.com","username":"vfisarov"},"last_update":"2026-10-13 15:03:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iedf8aca33e87078557daa8de1dd7591d42a2d37a","subject":"Identity: Fix federation protocol create and set SDK args","status":"MERGED","created":"2026-10-13 12:28:02.000000000","updated":"2026-10-13 15:05:53.000000000","submitted":"2026-10-13 15:03:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1010170","meta_rev_id":"a348415648a4022f229eab63e4bcd927f1f4b021","_number":1010170,"virtual_id_number":1010170,"owner":{"_account_id":35059,"name":"Veronika Fisarova","display_name":"vfisarov","email":"vfisarov@redhat.com","username":"vfisarov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-10-13 15:03:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2026-10-13 13:08:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2026-10-13 13:08:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-13 13:08:01.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2026-10-13 13:40:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4918629f54e0aeab560b82862a26737c99468252","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":35059,"name":"Veronika Fisarova","display_name":"vfisarov","email":"vfisarov@redhat.com","username":"vfisarov"},"date":"2026-10-13 12:28:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3fd83f9b9993b57f724c5e50f9e5ddd9a6307098","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-10-13 13:08:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6124eb6bcbded3cea81d3d364379e42f3de7cc57","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-13 13:40:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/677f05323d9e450c9dea2764f410a9f7\n\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/022904d36151433ea42fefaa7f65ef51 : SUCCESS in 5m 38s\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/0814b54f5d2e46c1968815795136af97 : SUCCESS in 4m 49s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/3628d5d9b2c94bdaaee3c789e5bd25ed : SUCCESS in 9m 30s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/83f6121a44014b9c9c13b43cd2f24c60 : SUCCESS in 6m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/207f24f3e7744786bb1c8d351cf97a0f : SUCCESS in 4m 35s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/c67a269b446e449ba7058935e761dfbb : SUCCESS in 3m 40s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/c53272a84eb34fb1bb77ad735298e361 : SUCCESS in 6m 08s\n- openstack-tox-py315 https://zuul.opendev.org/t/openstack/build/431399ca6e3748daba4928a481c7cc73 : SUCCESS in 6m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0fbb76e27a6d4c508fe2f8399e172ff6 : SUCCESS in 5m 55s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/abd4848f80d046f19488217bf6f00b68 : SUCCESS in 8m 57s\n- osc-build-image https://zuul.opendev.org/t/openstack/build/1016f219e28746d99eb2049083973574 : FAILURE in 4m 16s (non-voting)\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/d01318fe958c4cc5abfb822a19ac3ac8 : SUCCESS in 1h 00m 40s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/9d5b09b94dab40dcb200f935be563dc9 : SUCCESS in 1h 09m 12s\n- osc-functional-devstack-cyborg https://zuul.opendev.org/t/openstack/build/49aad71f82be42b78f1e60c3fb5cf845 : SUCCESS in 22m 47s","accounts_in_message":[],"_revision_number":1},{"id":"8b8c4761997159f1b42a57e97e0fc6e9fa083983","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-13 13:40:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e8710a3408a981a583cc3c8204dde9aa7198d370","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-13 15:03:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/11b5e60736c74ce4b395594f3e71316c\n\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/defacfee8977457892876a80881b6f13 : SUCCESS in 5m 30s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/8fe448792a414757923dbfa125ebf8b9 : SUCCESS in 7m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7ce28ea4dd3e431ea5a8cabfbcd049e8 : SUCCESS in 4m 28s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/1fbebc8bc5e4440e99253c0a222db6fe : SUCCESS in 3m 45s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/d23ef007de1446f0ad7e2740ec26c323 : SUCCESS in 3m 53s\n- openstack-tox-py315 https://zuul.opendev.org/t/openstack/build/d289c3f3604e4696962c9f0e69a77725 : SUCCESS in 7m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/96e2560057af4f528977b0b80d3a1490 : SUCCESS in 6m 40s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/34075436e33f45728dcd71d65471cf98 : SUCCESS in 9m 22s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/63eef3f4b8b647ba9621b9ed992e7520 : SUCCESS in 1h 09m 08s","accounts_in_message":[],"_revision_number":1},{"id":"31d976ef4488a655e351f99dd1f68f5d7a06675a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-13 15:03:51.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"a348415648a4022f229eab63e4bcd927f1f4b021","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-13 15:05:53.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a2d6b86d7e6d4f81bda5e0426528bad7\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/05f7930ad4864f2883e99482ed963959 : SUCCESS in 46s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ee7b27b322754d1fb1633db1d96f4083 : SUCCESS in 1m 13s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"56bc1f9e1392d823fa59bf083dbab85fb4911f0c","revisions":{"56bc1f9e1392d823fa59bf083dbab85fb4911f0c":{"kind":"REWORK","_number":1,"created":"2026-10-13 12:28:02.000000000","uploader":{"_account_id":35059,"name":"Veronika Fisarova","display_name":"vfisarov","email":"vfisarov@redhat.com","username":"vfisarov"},"ref":"refs/changes/70/1010170/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/70/1010170/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/70/1010170/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/70/1010170/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/70/1010170/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/70/1010170/1"}}},"commit":{"parents":[{"commit":"912ce8ff2d836106a93f7ec90ddf38a08c4a61cd","subject":"Merge \"typing: Enable stricter checks\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/912ce8ff2d836106a93f7ec90ddf38a08c4a61cd"}]}],"author":{"name":"Veronika Fisarova","email":"vfisarov@redhat.com","date":"2026-10-13 12:22:52.000000000","tz":120},"committer":{"name":"Veronika Fisarova","email":"vfisarov@redhat.com","date":"2026-10-13 12:22:52.000000000","tz":120},"subject":"Identity: Fix federation protocol create and set SDK args","message":"Identity: Fix federation protocol create and set SDK args\n\nThe migration of federation protocol commands to SDK\n(I4f1303b7b6c7ea2e67e5770745db060f08ba7761 / d1359947) passed the\nprotocol identifier as name\u003d on create. openstacksdk\u0027s\nFederationProtocol maps name to Body(\u0027id\u0027), but Resource.id also maps\nto the same body key, so name\u003d is silently dropped when constructing\nthe resource. PUT create then fails with \"Request requires an ID but\nnone was found\".\n\nThe same migration called update_federation_protocol with idp_id\u003d and\nname\u003d kwargs instead of the required idp and protocol parameters, so\nset fails with a TypeError before any API request.\n\nPass id\u003d on create and idp\u003d/protocol\u003d on set, matching sibling\nidentity provider, mapping, and service provider commands.\n\nChange-Id: Iedf8aca33e87078557daa8de1dd7591d42a2d37a\nSigned-off-by: Veronika Fisarova \u003cvfisarov@redhat.com\u003e\nCo-authored-by: Cursor \u003ccursoragent@cursor.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/56bc1f9e1392d823fa59bf083dbab85fb4911f0c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/56bc1f9e1392d823fa59bf083dbab85fb4911f0c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
