)]}'
{"openstackclient/identity/v3/endpoint.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"9f936c45ff4c604b3033b1caa790212ba365d653","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        if (not parsed_args.interface and not parsed_args.url"},{"line_number":186,"context_line":"                and not parsed_args.service and not parsed_args.region"},{"line_number":187,"context_line":"                and \u0027enabled\u0027 not in parsed_args):"},{"line_number":188,"context_line":"            sys.stdout.write(\"Endpoint not updated, no arguments present\")"},{"line_number":189,"context_line":"            return"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_2306f51c","line":187,"updated":"2014-08-07 17:10:51.000000000","message":"This change causes the entire test to always be False as \u0027enabled\u0027 is always part of parsed_args.  test_endpoint_set_no_options() is incomplete and did not detect the case where this test would be True.\n\nThis is one of the reasons I want to handle enable/disable pairs the long way like this: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/v1/image.py#L145\n\nThe current handling can not detect when neither option is on the command line as it can not tell the difference from the default (True) and --enabled being present (also True).","commit_id":"512c5bcf257233684fa9aee2383611254e96fbdd"}],"openstackclient/tests/identity/v3/test_endpoint.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"97bf8425e9ce91c43ae38d609ac865bc38917ff3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        # Get the command object to test"},{"line_number":54,"context_line":"        self.cmd \u003d endpoint.CreateEndpoint(self.app, None)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_endpoint_create_on_options(self):"},{"line_number":57,"context_line":"        arglist \u003d ["},{"line_number":58,"context_line":"            identity_fakes.service_id,"},{"line_number":59,"context_line":"            identity_fakes.endpoint_interface,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_2d5ea979","line":56,"updated":"2014-08-01 16:05:48.000000000","message":"Is this supposed to be _create_no_options?","commit_id":"0fbf601bb990d39029ad70a1055bbc8f8f698c6c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"97bf8425e9ce91c43ae38d609ac865bc38917ff3","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        # Get the command object to test"},{"line_number":295,"context_line":"        self.cmd \u003d endpoint.ListEndpoint(self.app, None)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_endpoint_list_on_options(self):"},{"line_number":298,"context_line":"        arglist \u003d []"},{"line_number":299,"context_line":"        verifylist \u003d []"},{"line_number":300,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8dd095c9","line":297,"updated":"2014-08-01 16:05:48.000000000","message":"Again, _no_ here?","commit_id":"0fbf601bb990d39029ad70a1055bbc8f8f698c6c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"9f936c45ff4c604b3033b1caa790212ba365d653","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        result \u003d self.cmd.run(parsed_args)"},{"line_number":359,"context_line":"        self.assertEqual(result, 0)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def test_endpoint_set_interface(self):"},{"line_number":362,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d1542224","line":359,"updated":"2014-08-07 17:10:51.000000000","message":"This test is incomplete.  With the included patch to identity.v3.endpoint.SetEndpoint() it should fail and doesn\u0027t.  That change causes the check for no options to always fail as \u0027enabled\u0027 is always part of parsed_args.","commit_id":"512c5bcf257233684fa9aee2383611254e96fbdd"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"9f936c45ff4c604b3033b1caa790212ba365d653","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        ]"},{"line_number":366,"context_line":"        verifylist \u003d ["},{"line_number":367,"context_line":"            (\u0027interface\u0027, \u0027public\u0027),"},{"line_number":368,"context_line":"            (\u0027enabled\u0027, True),"},{"line_number":369,"context_line":"            (\u0027endpoint\u0027, identity_fakes.endpoint_id),"},{"line_number":370,"context_line":"        ]"},{"line_number":371,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_11769a0c","line":368,"updated":"2014-08-07 17:10:51.000000000","message":"Why do you have --enabled here?","commit_id":"512c5bcf257233684fa9aee2383611254e96fbdd"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"d9650a4356d2b7306fc34302f71e110abfd2668f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            identity_fakes.service_type,"},{"line_number":97,"context_line":"            identity_fakes.endpoint_url,"},{"line_number":98,"context_line":"        )"},{"line_number":99,"context_line":"        self.assertEqual(data, datalist)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_endpoint_create_region(self):"},{"line_number":102,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac7a964_9f769fd7","line":99,"updated":"2014-08-13 23:03:37.000000000","message":"assertion order here, should be datalist, data, probably for some others as well","commit_id":"0cf0d33a71f0cdb550b3645b1a78c54c14f159df"}]}