)]}'
{"id":"openstack%2Fpython-openstackclient~112458","triplet_id":"openstack%2Fpython-openstackclient~master~I06f727ffa8d37afe1a1191c36574887fecc7a733","project":"openstack/python-openstackclient","branch":"master","topic":"wh","hashtags":[],"change_id":"I06f727ffa8d37afe1a1191c36574887fecc7a733","subject":"test_find_resource fails if run alone","status":"MERGED","created":"2014-08-07 03:22:06.000000000","updated":"2014-08-07 22:07:56.000000000","submitted":"2014-08-07 22:07:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"012f6346df760ac5c8645840f4b96d347396e656","_number":112458,"virtual_id_number":112458,"owner":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2014-08-07 22:07:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2014-08-07 21:10:04.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-08-07 20:40:51.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":1,"date":"2014-08-07 21:10:04.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-07 14:00:55.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2014-08-07 20:40:51.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-08-07 21:10:04.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2014-08-07 22:07:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7f9abfe011d729c41ab1578cd3e322afb2d789c1","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-08-07 03:22:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"56536b6b375999432f6a74eeecf674ad7b02f66c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-07 03:22:07.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"94eb7b7540849e08af1e5e30d048268e8b2241b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-07 04:21:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/58/112458/1/check/gate-python-openstackclient-pep8/e40cb96 : SUCCESS in 3m 28s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/58/112458/1/check/gate-python-openstackclient-docs/c1473d2/doc/build/html/ : SUCCESS in 3m 44s\n- gate-python-openstackclient-python26 http://logs.openstack.org/58/112458/1/check/gate-python-openstackclient-python26/60fb7cd : SUCCESS in 3m 32s\n- gate-python-openstackclient-python27 http://logs.openstack.org/58/112458/1/check/gate-python-openstackclient-python27/1adf984 : SUCCESS in 3m 35s\n- gate-python-openstackclient-python33 http://logs.openstack.org/58/112458/1/check/gate-python-openstackclient-python33/ca94d0f : SUCCESS in 5m 45s\n- check-tempest-dsvm-full http://logs.openstack.org/58/112458/1/check/check-tempest-dsvm-full/447d391 : SUCCESS in 50m 44s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/58/112458/1/check/check-tempest-dsvm-postgres-full/871d2cf : SUCCESS in 52m 16s\n- check-tempest-dsvm-neutron http://logs.openstack.org/58/112458/1/check/check-tempest-dsvm-neutron/b130632 : SUCCESS in 56m 41s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/58/112458/1/check/check-tempest-dsvm-neutron-heat-slow/83a62e0 : SUCCESS in 25m 28s\n- check-grenade-dsvm http://logs.openstack.org/58/112458/1/check/check-grenade-dsvm/43b61b1 : SUCCESS in 44m 35s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/58/112458/1/check/check-tempest-dsvm-full-havana/31e9e3c : SUCCESS in 32m 33s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/58/112458/1/check/check-tempest-dsvm-neutron-havana/5f6dff7 : SUCCESS in 34m 32s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/58/112458/1/check/check-tempest-dsvm-full-icehouse/053240f : SUCCESS in 48m 08s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/58/112458/1/check/check-tempest-dsvm-neutron-icehouse/6be502f : SUCCESS in 55m 29s","accounts_in_message":[],"_revision_number":1},{"id":"3cabe11f8da39ece77b33e48a0615a2a214cc5ff","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-08-07 14:00:55.000000000","message":"Patch Set 1: Code-Review-1\n\nI was thinking if you import openstack.volume.client into the test, it would pass.  Unfortunately, I can\u0027t reproduce the problem.","accounts_in_message":[],"_revision_number":1},{"id":"9d2fdde114b41b9ec505ca3e5279ebf390761d7f","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-08-07 16:08:09.000000000","message":"Patch Set 1: Code-Review+2\n\nI was able to reproduce the problem, and confirm that this patch fixes the issue. I was also able to perform CRUD operations on volume, so I\u0027m OK with this patch.","accounts_in_message":[],"_revision_number":1},{"id":"5700898266ea9e453cd2a99ca00bab291d6c0018","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-08-07 16:09:23.000000000","message":"Patch Set 1:\n\nI just didn\u0027t like volume stuff in common utils.  seems wrong.","accounts_in_message":[],"_revision_number":1},{"id":"b0d12c929792f3436a0a887f0504e96f4317a883","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-07 16:44:10.000000000","message":"Patch Set 1: Code-Review-1\n\nI\u0027m with Terry here, this is the wrong hack for the problem (moving a hack is still a hack).\n\nIf the issue is in the test then fix the test?  It works as part of the suite but not by itself so there is a test problem somewhere.  It may be more than just loading openstackclient.volume.client, or duplicating the monkey patch in the test.\n\nSteve, I was able to fix this with just an import:\n\n  from openstackclient.common import exceptions\n  from openstackclient.common import utils\n  from openstackclient.tests import utils as test_utils\n +from openstackclient.volume import client","accounts_in_message":[],"_revision_number":1},{"id":"e80bc1b2f3a4223e2f5671d89161e3c2a841ad8e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-07 16:45:35.000000000","message":"Patch Set 1:\n\nI should add that pep8 needs to be told to ignore that import as it is unused otherwise:\n\n  from openstackclient.volume import client  # noqa","accounts_in_message":[],"_revision_number":1},{"id":"199b2296c5e37addc9191f1ffbc168f4acb017ee","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-08-07 17:24:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e174662ee8cd185d5c491764d9bfcb6125a570f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-07 17:24:30.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"5d0d338f0db884fd3a162e79c2d744f5531489ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-07 19:22:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/58/112458/2/check/gate-python-openstackclient-pep8/c8716c7 : SUCCESS in 3m 02s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/58/112458/2/check/gate-python-openstackclient-docs/2707f69/doc/build/html/ : SUCCESS in 3m 50s\n- gate-python-openstackclient-python26 http://logs.openstack.org/58/112458/2/check/gate-python-openstackclient-python26/c49b35d : SUCCESS in 4m 03s\n- gate-python-openstackclient-python27 http://logs.openstack.org/58/112458/2/check/gate-python-openstackclient-python27/000e64a : SUCCESS in 3m 11s\n- gate-python-openstackclient-python33 http://logs.openstack.org/58/112458/2/check/gate-python-openstackclient-python33/511df08 : SUCCESS in 6m 23s\n- check-tempest-dsvm-full http://logs.openstack.org/58/112458/2/check/check-tempest-dsvm-full/9b0033c : SUCCESS in 51m 33s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/58/112458/2/check/check-tempest-dsvm-postgres-full/84208f6 : SUCCESS in 54m 10s\n- check-tempest-dsvm-neutron http://logs.openstack.org/58/112458/2/check/check-tempest-dsvm-neutron/d0a9818 : SUCCESS in 1h 00m 48s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/58/112458/2/check/check-tempest-dsvm-neutron-heat-slow/5063ac7 : SUCCESS in 23m 09s\n- check-grenade-dsvm http://logs.openstack.org/58/112458/2/check/check-grenade-dsvm/36f5bb1 : SUCCESS in 42m 23s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/58/112458/2/check/check-tempest-dsvm-full-havana/002f31c : FAILURE in 42m 41s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/58/112458/2/check/check-tempest-dsvm-neutron-havana/6ebb1b9 : SUCCESS in 34m 31s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/58/112458/2/check/check-tempest-dsvm-full-icehouse/8dd2ffb : SUCCESS in 48m 57s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/58/112458/2/check/check-tempest-dsvm-neutron-icehouse/0777812 : SUCCESS in 51m 55s","accounts_in_message":[],"_revision_number":2},{"id":"e3f6e04ecf3b0850d3b38545666a4fc6915b26a2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-07 20:40:51.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks Steve","accounts_in_message":[],"_revision_number":2},{"id":"52276149e72b9b43cb6f9aee1e1fae95953af8c4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-08-07 21:10:04.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\ngonna pull the trigger, thanks for the suggested fix","accounts_in_message":[],"_revision_number":2},{"id":"e54ddbcec92966a376c4f11252af2f483d686790","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-07 21:10:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"137f3350551b059fa6ae6cde6749e179bcd199ae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-07 22:07:56.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"7389e2d710028de8c54bcebc476ca2072af19a05","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-07 22:07:56.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded.\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/58/112458/2/gate/gate-python-openstackclient-docs/2e8bff5/doc/build/html/ : SUCCESS in 3m 50s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/58/112458/2/gate/gate-python-openstackclient-pep8/82aaa80 : SUCCESS in 3m 25s\n- gate-python-openstackclient-python26 http://logs.openstack.org/58/112458/2/gate/gate-python-openstackclient-python26/8e78747 : SUCCESS in 2m 44s\n- gate-python-openstackclient-python27 http://logs.openstack.org/58/112458/2/gate/gate-python-openstackclient-python27/3561045 : SUCCESS in 2m 51s\n- gate-python-openstackclient-python33 http://logs.openstack.org/58/112458/2/gate/gate-python-openstackclient-python33/e0192f1 : SUCCESS in 5m 52s\n- gate-tempest-dsvm-full http://logs.openstack.org/58/112458/2/gate/gate-tempest-dsvm-full/ef83356 : SUCCESS in 50m 10s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/58/112458/2/gate/gate-tempest-dsvm-postgres-full/d3dd542 : SUCCESS in 54m 05s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/58/112458/2/gate/gate-tempest-dsvm-neutron/45fa866 : SUCCESS in 56m 43s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/58/112458/2/gate/gate-tempest-dsvm-neutron-heat-slow/cc45c70 : SUCCESS in 25m 44s\n- gate-grenade-dsvm http://logs.openstack.org/58/112458/2/gate/gate-grenade-dsvm/5bb6e44 : SUCCESS in 34m 31s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ddb7e18974964abbe3fc50dab47ab55286a7328c","revisions":{"d956f59dfb22b25f19aeb6f85dbdf506ec76376b":{"kind":"REWORK","_number":1,"created":"2014-08-07 03:22:06.000000000","uploader":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"ref":"refs/changes/58/112458/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/58/112458/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/112458/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/112458/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/112458/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/58/112458/1"}}},"commit":{"parents":[{"commit":"b5001e4b213ef92f31e418203f7e7deeb5e305c0","subject":"Use oslosphinx to generate documentation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b5001e4b213ef92f31e418203f7e7deeb5e305c0"}]}],"author":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2014-08-07 03:14:00.000000000","tz":480},"committer":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2014-08-07 03:14:00.000000000","tz":480},"subject":"it will fail if test test_find_resource singly","message":"it will fail if test test_find_resource singly\n\nCurrently, we set \u0027NAME_ATTR\u0027 attribute for Volume and Snapshot\nclass in volume.client.py. When we test test_find_resource singly,\nthe Volume and Snapshot class do not have \u0027NAME_ATTR\u0027 attribute since\nwe will not import volume.client. Therefor the test will fail if we\ntest test_find_resource singly.\n\nChange-Id: I06f727ffa8d37afe1a1191c36574887fecc7a733\nCloses-Bug: #1353788\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d956f59dfb22b25f19aeb6f85dbdf506ec76376b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d956f59dfb22b25f19aeb6f85dbdf506ec76376b"}]},"branch":"refs/heads/master"},"ddb7e18974964abbe3fc50dab47ab55286a7328c":{"kind":"REWORK","_number":2,"created":"2014-08-07 17:24:29.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/58/112458/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/58/112458/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/112458/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/112458/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/58/112458/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/58/112458/2"}}},"commit":{"parents":[{"commit":"b5001e4b213ef92f31e418203f7e7deeb5e305c0","subject":"Use oslosphinx to generate documentation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b5001e4b213ef92f31e418203f7e7deeb5e305c0"}]}],"author":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2014-08-07 03:14:00.000000000","tz":480},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2014-08-07 17:22:25.000000000","tz":-240},"subject":"test_find_resource fails if run alone","message":"test_find_resource fails if run alone\n\nCurrently, we set \u0027NAME_ATTR\u0027 attribute for Volume and Snapshot\nclass in volume.client.py. When we test test_find_resource alone,\nthe Volume and Snapshot class do not have \u0027NAME_ATTR\u0027 attribute since\nwe do not import volume.client, which causes the tests to fail.\n\nChange-Id: I06f727ffa8d37afe1a1191c36574887fecc7a733\nCloses-Bug: #1353788\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ddb7e18974964abbe3fc50dab47ab55286a7328c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ddb7e18974964abbe3fc50dab47ab55286a7328c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}