)]}'
{"id":"openstack%2Fpython-openstackclient~114643","triplet_id":"openstack%2Fpython-openstackclient~master~I5c574307ce4d48d23e6c2d848b14874a437dda99","project":"openstack/python-openstackclient","branch":"master","topic":"bp/neutron","hashtags":[],"change_id":"I5c574307ce4d48d23e6c2d848b14874a437dda99","subject":"Network port CRUD","status":"ABANDONED","created":"2014-08-15 19:42:53.000000000","updated":"2014-10-21 12:27:19.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c26a81b5632b3fad0633c5100a1d4c8300ea119","_number":114643,"virtual_id_number":114643,"owner":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2014-08-26 13:53:55.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2014-08-15 21:10:39.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-08-22 04:35:31.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"date":"2014-08-27 19:11:29.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-15 21:10:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-08-22 04:35:31.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-08-27 19:11:29.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"}],"messages":[{"id":"660d09dba99ddb90c636aa0e2c72a6fc0e50c6b0","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-08-15 19:42:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c4147f86dc85f3ca7833c123545ee3b612074649","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-15 19:52:30.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"df0bbf1e357317fada70eda9388e9f873c1e0624","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-15 21:10:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/43/114643/1/check/gate-python-openstackclient-pep8/44ab9bd : SUCCESS in 2m 57s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/43/114643/1/check/gate-python-openstackclient-docs/f2d5226/doc/build/html/ : SUCCESS in 4m 14s\n- gate-python-openstackclient-python26 http://logs.openstack.org/43/114643/1/check/gate-python-openstackclient-python26/b4c4829 : SUCCESS in 2m 18s\n- gate-python-openstackclient-python27 http://logs.openstack.org/43/114643/1/check/gate-python-openstackclient-python27/125b761 : SUCCESS in 2m 40s\n- gate-python-openstackclient-python33 http://logs.openstack.org/43/114643/1/check/gate-python-openstackclient-python33/6443bdf : SUCCESS in 6m 34s\n- check-tempest-dsvm-full http://logs.openstack.org/43/114643/1/check/check-tempest-dsvm-full/0d2365e : SUCCESS in 38m 50s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/43/114643/1/check/check-tempest-dsvm-postgres-full/83da024 : SUCCESS in 42m 18s\n- check-tempest-dsvm-neutron http://logs.openstack.org/43/114643/1/check/check-tempest-dsvm-neutron/bc425eb : SUCCESS in 59m 01s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/43/114643/1/check/check-tempest-dsvm-neutron-full/4b48590 : SUCCESS in 1h 04m 25s (non-voting)\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/43/114643/1/check/check-tempest-dsvm-neutron-heat-slow/479d3b3 : SUCCESS in 22m 50s\n- check-grenade-dsvm http://logs.openstack.org/43/114643/1/check/check-grenade-dsvm/8b1872a : SUCCESS in 38m 07s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/43/114643/1/check/check-tempest-dsvm-full-havana/4111765 : FAILURE in 11m 11s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/43/114643/1/check/check-tempest-dsvm-neutron-havana/7d5ff12 : FAILURE in 11m 50s (non-voting)\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/43/114643/1/check/check-tempest-dsvm-full-icehouse/537a250 : SUCCESS in 49m 14s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/43/114643/1/check/check-tempest-dsvm-neutron-icehouse/ed3b25a : SUCCESS in 57m 48s","accounts_in_message":[],"_revision_number":1},{"id":"05ad48eab73355e0b5c38f9f984fe38b7c799413","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-22 04:35:31.000000000","message":"Patch Set 1:\n\nWhy do the network commands always have to be different?\n\nThe KeyValueAppendAction is nice, but it doesn\u0027t provide the same user experience.  Now to specify more than one of a thing users have to remember which ones use multiple occurrences of an option and which ones use a single option with a singe comma-delimited value.  OSC is not going to do that.","accounts_in_message":[],"_revision_number":1},{"id":"fc422decd650fdfa6e63c75957c01266e376a0f8","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-08-26 13:53:55.000000000","message":"Patch Set 1:\n\nI think this is unique to have an array of dicts to populate and I don\u0027t think this is a stretch for the user to use this.  Is it that much of a stretch to specify one --fixed-ips subnet\u003d127.0.0.1/24,ip_address\u003d127.0.0.3 or two?  There are lots of places in OSC where the user has to supply key value pairs.  Why not allow the user to repeat them?","accounts_in_message":[],"_revision_number":1},{"id":"64a2912438e2c4a3e1b0dfa776542f381a2a57c0","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-08-26 19:51:26.000000000","message":"Patch Set 1:\n\nTerry, I clearly need to study exactly what is really being specified by the user here.  Nova and Neutron are full of semi-wrong nomenclature that I really do not want to propagate (ex, the use of \u0027CIDR\u0027 as a noun!).\n\nThe example you show: \n\n  --fixed-ips subnet\u003d127.0.0.1/24,ip_address\u003d127.0.0.3 \n\nprobably makes more sense to me as:\n\n  --fixed-ips 127.0.0.3/24\n\nthe mask length is sufficient to be able to calculate the subnet address given the IP address.\n\nI know that is probably not the general reply to using either comma-separated lists or multiple option occurrences, but it is a great example of where we need to spend some effort to produce a clean user interface and hide the nonsense.","accounts_in_message":[],"_revision_number":1},{"id":"a3cc4132b23385b7bb6f9e0c643254c0e15fcd17","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-08-27 18:56:35.000000000","message":"Patch Set 1:\n\nOkay, I made up that example and it is wrong.  The pairs that need to be associated with a port are a subnet_id and a fixed ip address.","accounts_in_message":[],"_revision_number":1},{"id":"dd7b4339b55c93c1b10a58490f5261289945835c","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-08-27 18:57:53.000000000","message":"Patch Set 1:\n\nThe reason I changed it to subnet is so the user could enter subnet name or id.","accounts_in_message":[],"_revision_number":1},{"id":"5c8a823a99d8c1592dd3335f73cc0667795a77e8","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-08-27 19:05:31.000000000","message":"Patch Set 1:\n\nThe only alternative that comes to mind is adding a subcommand where you have to do one of them at a time.  Something like:\n\n    os port add ip fixed \u003csubnet\u003e \u003cipaddress\u003e\n    os port add dhcp option key\u003dvalue key\u003dvalue key\u003dvalue\n\nAs for dhcp options, I\u0027m not sure how you would remove them.  I think the user would have to enter all the options because I don\u0027t think there is a key.\n\n    os port remove ip fixed \u003csubnet\u003e \u003cipaddress\u003e\n    os port remove dhcp option key\u003dvalue key\u003dvalue key\u003dvalue\n\nThe same would have to be done for subnet allocation pools and host routes.  I\u0027m sure there are others.","accounts_in_message":[],"_revision_number":1},{"id":"ea951e8e117e5005525f7703130a16ef9db5515b","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-10-21 12:27:19.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d28efb44997fed19c23d6f36686f531dbc18194f","revisions":{"d28efb44997fed19c23d6f36686f531dbc18194f":{"kind":"REWORK","_number":1,"created":"2014-08-15 19:42:53.000000000","uploader":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"ref":"refs/changes/43/114643/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/43/114643/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/43/114643/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/43/114643/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/43/114643/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/43/114643/1"}}},"commit":{"parents":[{"commit":"19b8605224156c48107541580a264860131b57ab","subject":"a mistake in tests/identity/v3/test_role.py","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/19b8605224156c48107541580a264860131b57ab"}]}],"author":{"name":"Terry Howe","email":"terrylhowe@gmail.com","date":"2014-08-15 19:41:24.000000000","tz":-360},"committer":{"name":"Terry Howe","email":"terrylhowe@gmail.com","date":"2014-08-15 19:41:59.000000000","tz":-360},"subject":"Network port CRUD","message":"Network port CRUD\n\nPort create, delete, list, set and show\n\nChange-Id: I5c574307ce4d48d23e6c2d848b14874a437dda99\nImplements: blueprint neutron\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d28efb44997fed19c23d6f36686f531dbc18194f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d28efb44997fed19c23d6f36686f531dbc18194f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}