)]}'
{"openstackclient/common/utils.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"84c44f23316ec4290aa3bdceea93f7db2231c821","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    except Exception:"},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    kwargs \u003d {}"},{"line_number":53,"context_line":"    if \u0027NAME_ATTR\u0027 in manager.resource_class.__dict__:"},{"line_number":54,"context_line":"        # novaclient does this for oddball resources"},{"line_number":55,"context_line":"        kwargs[manager.resource_class.NAME_ATTR] \u003d name_or_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_462e28fc","side":"PARENT","line":52,"updated":"2014-10-08 20:47:43.000000000","message":"Do we want to do anything different here when kwargs is not None?","commit_id":"0cb204e59b20f25b7a054b411507d6dabbc699ac"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8aaf6383734d9f882c40f5ae3ed882831a61de9e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    except Exception:"},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    kwargs \u003d {}"},{"line_number":53,"context_line":"    if \u0027NAME_ATTR\u0027 in manager.resource_class.__dict__:"},{"line_number":54,"context_line":"        # novaclient does this for oddball resources"},{"line_number":55,"context_line":"        kwargs[manager.resource_class.NAME_ATTR] \u003d name_or_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_e3ef03e7","side":"PARENT","line":52,"in_reply_to":"baa201ad_462e28fc","updated":"2014-10-09 16:32:28.000000000","message":"not exactly sure what you mean, but we can add a check here to make sure we\u0027re not breaking anything.","commit_id":"0cb204e59b20f25b7a054b411507d6dabbc699ac"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"84c44f23316ec4290aa3bdceea93f7db2231c821","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from openstackclient.common import exceptions"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def find_resource(manager, name_or_id, **kwargs):"},{"line_number":30,"context_line":"    \"\"\"Helper for the _find_* methods.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # Try to get entity as integer id"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_e6ce3c59","line":29,"updated":"2014-10-08 20:47:43.000000000","message":"Please expand the docstring to explain how/when kwargs is used here","commit_id":"1923fae7c6f987a72d2c38e43ab1d5b33d0663f8"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8aaf6383734d9f882c40f5ae3ed882831a61de9e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from openstackclient.common import exceptions"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def find_resource(manager, name_or_id, **kwargs):"},{"line_number":30,"context_line":"    \"\"\"Helper for the _find_* methods.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # Try to get entity as integer id"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_031407e7","line":29,"in_reply_to":"baa201ad_e6ce3c59","updated":"2014-10-09 16:32:28.000000000","message":"Done","commit_id":"1923fae7c6f987a72d2c38e43ab1d5b33d0663f8"}],"openstackclient/identity/v3/user.py":[{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"a5c022ee272848ef1eef8a8c785aa303e8f4d949","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        parser.add_argument("},{"line_number":368,"context_line":"            \u0027--domain\u0027,"},{"line_number":369,"context_line":"            metavar\u003d\u0027\u003cdomain\u003e\u0027,"},{"line_number":370,"context_line":"            help\u003d\u0027Domain where user resides (name of ID)\u0027,"},{"line_number":371,"context_line":"        )"},{"line_number":372,"context_line":"        return parser"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_f30b787a","line":370,"updated":"2014-10-08 00:05:06.000000000","message":"\"name or ID\"","commit_id":"efd3da83d4b0d9e65edc10fffb650a045e5f4f94"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b50c36c2eca436fbde8e002c496b47140037854","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        parser.add_argument("},{"line_number":368,"context_line":"            \u0027--domain\u0027,"},{"line_number":369,"context_line":"            metavar\u003d\u0027\u003cdomain\u003e\u0027,"},{"line_number":370,"context_line":"            help\u003d\u0027Domain where user resides (name of ID)\u0027,"},{"line_number":371,"context_line":"        )"},{"line_number":372,"context_line":"        return parser"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_9ff14d6d","line":370,"in_reply_to":"baa201ad_f30b787a","updated":"2014-10-08 05:31:52.000000000","message":"Done","commit_id":"efd3da83d4b0d9e65edc10fffb650a045e5f4f94"},{"author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"change_message_id":"a5c022ee272848ef1eef8a8c785aa303e8f4d949","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        if parsed_args.domain:"},{"line_number":379,"context_line":"            domain \u003d utils.find_resource(identity_client.domains,"},{"line_number":380,"context_line":"                                         parsed_args.domain)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            user \u003d utils.find_resource(identity_client.users,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_3357c059","line":379,"updated":"2014-10-08 00:05:06.000000000","message":"We might want to put a try around this to allow a domain ID to be specified when the requesting user isn\u0027t authorized to perform the \u0027list_domains\u0027 action (see https://review.openstack.org/#/c/126754/).  This would look something like:\n\n    try:\n        domain_id \u003d utils.find_resource(identity_client.domains,\n                                                       parsed_args.domain).id\n    else:\n        domain_id \u003d parsed_args.domain","commit_id":"efd3da83d4b0d9e65edc10fffb650a045e5f4f94"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2b50c36c2eca436fbde8e002c496b47140037854","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        if parsed_args.domain:"},{"line_number":379,"context_line":"            domain \u003d utils.find_resource(identity_client.domains,"},{"line_number":380,"context_line":"                                         parsed_args.domain)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"            user \u003d utils.find_resource(identity_client.users,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_7fdf49d6","line":379,"in_reply_to":"baa201ad_3357c059","updated":"2014-10-08 05:31:52.000000000","message":"Done","commit_id":"efd3da83d4b0d9e65edc10fffb650a045e5f4f94"}]}
