)]}'
{"openstackclient/api/object_store_v1.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"294e8f25e61c87ec861a9fbe5ca131b86a183b69","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        response \u003d self.create("},{"line_number":192,"context_line":"            full_url,"},{"line_number":193,"context_line":"            method\u003d\u0027PUT\u0027,"},{"line_number":194,"context_line":"            data\u003dio.open(object, \u0027rb\u0027),"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":"        url_parts \u003d urlparse(self.endpoint)"},{"line_number":197,"context_line":"        data \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_022116fc","line":194,"updated":"2014-10-13 07:59:12.000000000","message":"when is this fd closed? \nI looked in create method and it looks like it simply passes the file descriptor to the requests method.","commit_id":"67506defa30426983b345e9dc4749a95bca268a5"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"3698ddb3c04048998722bb27bcd6be7620d6e01e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        response \u003d self.create("},{"line_number":192,"context_line":"            full_url,"},{"line_number":193,"context_line":"            method\u003d\u0027PUT\u0027,"},{"line_number":194,"context_line":"            data\u003dio.open(object, \u0027rb\u0027),"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":"        url_parts \u003d urlparse(self.endpoint)"},{"line_number":197,"context_line":"        data \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_14bf89fd","line":194,"in_reply_to":"baa201ad_022116fc","updated":"2014-10-13 14:07:30.000000000","message":"For what it\u0027s worth, requests does not close file objects passed to it, so you should probably be doing:\n\nwith io.open(object, \u0027rb\u0027) as data:\n    response \u003d self.create(\n        full_url,\n        method\u003d\u0027PUT\u0027,\n        data\u003ddata,\n    )","commit_id":"67506defa30426983b345e9dc4749a95bca268a5"}]}