)]}'
{"id":"openstack%2Fpython-openstackclient~127330","triplet_id":"openstack%2Fpython-openstackclient~master~I8c30b41db20af8ecafe67e760e872fc08adec905","project":"openstack/python-openstackclient","branch":"master","topic":"object-test-open","hashtags":[],"change_id":"I8c30b41db20af8ecafe67e760e872fc08adec905","subject":"Update use of open() in object API","status":"MERGED","created":"2014-10-09 20:06:39.000000000","updated":"2014-10-24 06:38:22.000000000","submitted":"2014-10-24 06:38:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"43c45dead79c1b1310222a4a5d6b20b4f9ec60a0","_number":127330,"virtual_id_number":127330,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"date":"2014-10-13 18:42:29.000000000","_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2014-10-24 06:38:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"date":"2014-10-13 15:35:54.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"recommended":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":1,"date":"2014-10-14 06:56:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":2,"date":"2014-10-24 05:40:51.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"value":1,"date":"2014-10-24 05:40:51.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-12 23:12:56.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2014-10-13 14:07:30.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2014-10-13 18:42:29.000000000","updated_by":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"reviewer":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"state":"REVIEWER"},{"updated":"2014-10-24 05:40:51.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2014-10-24 06:38:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d95fcafb96afa5b25521691a07594cd9db5308a8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-09 20:06:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"685026580a7910ed9f9bb4d35cdd5302819bd2ba","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-09 20:17:40.000000000","message":"Patch Set 1: Code-Review+1\n\nlooks good, cc\u0027ing marek so he gets a heads up, I believe we are using open() when creating a mapping","accounts_in_message":[],"_revision_number":1},{"id":"cbc47249882a2bd3379072721db04b97ab2f1b26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-09 21:01:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/30/127330/1/check/gate-python-openstackclient-pep8/86dd7c2 : FAILURE in 1m 18s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/30/127330/1/check/gate-python-openstackclient-docs/e308328/doc/build/html/ : SUCCESS in 50s\n- gate-python-openstackclient-python26 http://logs.openstack.org/30/127330/1/check/gate-python-openstackclient-python26/c50a68a : SUCCESS in 1m 14s\n- gate-python-openstackclient-python27 http://logs.openstack.org/30/127330/1/check/gate-python-openstackclient-python27/21d6fe7 : SUCCESS in 1m 03s\n- gate-python-openstackclient-python33 http://logs.openstack.org/30/127330/1/check/gate-python-openstackclient-python33/ca75263 : FAILURE in 2m 58s\n- check-tempest-dsvm-full http://logs.openstack.org/30/127330/1/check/check-tempest-dsvm-full/27264b5 : SUCCESS in 52m 33s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/30/127330/1/check/check-tempest-dsvm-postgres-full/dcd0e2a : SUCCESS in 47m 16s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/30/127330/1/check/check-tempest-dsvm-neutron-full/55c5d35 : SUCCESS in 53m 34s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/30/127330/1/check/check-tempest-dsvm-neutron-heat-slow/2643a95 : SUCCESS in 19m 10s\n- check-grenade-dsvm http://logs.openstack.org/30/127330/1/check/check-grenade-dsvm/1a193b4 : SUCCESS in 44m 02s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/30/127330/1/check/check-tempest-dsvm-full-icehouse/ec377e0 : SUCCESS in 50m 24s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/30/127330/1/check/check-tempest-dsvm-neutron-icehouse/2ed4a68 : FAILURE in 12m 58s\n- check-osc-dsvm-functional http://logs.openstack.org/30/127330/1/check/check-osc-dsvm-functional/15fc5dc : SUCCESS in 16m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"47d19224b5a72df36e6f6365c1fc22c17d313db4","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2014-10-10 14:20:57.000000000","message":"Patch Set 1:\n\nhttp://mock.readthedocs.org/en/latest/helpers.html#mock-open doesn\u0027t seem that painful for one test. Further, it could probably be abstracted to a decorator if needed for more than one test.","accounts_in_message":[],"_revision_number":1},{"id":"9180984f235aa789ec6216d7562370a3561e6b25","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-11 03:01:26.000000000","message":"Patch Set 1:\n\nIan, I\u0027ve got at least 4 more commands that use it with a handful of tests each.  Plus the functional tests.  After more than two hours trying to make it work cleanly, I took this route.  I\u0027m all ears for mocking __builtin__.open directly","accounts_in_message":[],"_revision_number":1},{"id":"ca8aacbe8cdecb2484e0427a7a6270d91c9743ab","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-11 03:01:35.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"9546fd58f9588826b63d153cc15d47a0b6ef9f0f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-11 03:11:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"782950efafbf19db23a5936b08f8fdbac8957803","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-11 03:12:22.000000000","message":"Patch Set 2:\n\nAaaaaaaand this is what I get for missing the py33 failure...so maybe mocking io.open would be easier, I\u0027m going to check this for my sanity then try that...","accounts_in_message":[],"_revision_number":2},{"id":"c5d04b182d51f7eb73f1fbf83ace5f9466f14c27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-11 04:18:30.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/30/127330/2/check/gate-python-openstackclient-pep8/acb95d6 : FAILURE in 54s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/30/127330/2/check/gate-python-openstackclient-docs/badfcb5/doc/build/html/ : SUCCESS in 49s\n- gate-python-openstackclient-python26 http://logs.openstack.org/30/127330/2/check/gate-python-openstackclient-python26/2da83ab : SUCCESS in 1m 07s\n- gate-python-openstackclient-python27 http://logs.openstack.org/30/127330/2/check/gate-python-openstackclient-python27/af7842a : SUCCESS in 49s\n- gate-python-openstackclient-python33 http://logs.openstack.org/30/127330/2/check/gate-python-openstackclient-python33/911c97a : SUCCESS in 2m 46s\n- check-tempest-dsvm-full http://logs.openstack.org/30/127330/2/check/check-tempest-dsvm-full/b46834b : SUCCESS in 54m 05s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/30/127330/2/check/check-tempest-dsvm-postgres-full/de1eb53 : SUCCESS in 59m 20s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/30/127330/2/check/check-tempest-dsvm-neutron-full/71662b9 : SUCCESS in 1h 07m 15s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/30/127330/2/check/check-tempest-dsvm-neutron-heat-slow/19fd1be : SUCCESS in 18m 02s\n- check-grenade-dsvm http://logs.openstack.org/30/127330/2/check/check-grenade-dsvm/e439848 : SUCCESS in 45m 58s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/30/127330/2/check/check-tempest-dsvm-full-icehouse/ef9ff30 : SUCCESS in 50m 07s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/30/127330/2/check/check-tempest-dsvm-neutron-icehouse/0fe6f01 : FAILURE in 11m 32s\n- check-osc-dsvm-functional http://logs.openstack.org/30/127330/2/check/check-osc-dsvm-functional/f4f8be8 : SUCCESS in 15m 30s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"cd65a60def6fb8d1d88223367029235c8387cd02","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-10-11 04:18:43.000000000","message":"Patch Set 2:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- check-tempest-dsvm-neutron-icehouse: https://bugs.launchpad.net/bugs/1379201\n- gate-python-openstackclient-pep8: unrecognized error\n\nSome of the tests failed in a way that we did not understand. Please help us classify these issues so that they can be part of Elastic Recheck http://status.openstack.org/elastic-recheck/\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":2},{"id":"4bbcd0842fc0fdc27fa3623f9809766179e13dc8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-12 22:04:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0d71251e58315b314bb7b60de66ae720e0186962","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-12 22:05:48.000000000","message":"Patch Set 3:\n\nSo, yeah, io.open is the future...now","accounts_in_message":[],"_revision_number":3},{"id":"bd0f0dd1242a4983b796a1400e91b6643219e298","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-12 23:12:44.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-pep8/00c1268 : SUCCESS in 1m 02s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/30/127330/3/check/gate-python-openstackclient-docs/dee7fc6/doc/build/html/ : SUCCESS in 54s\n- gate-python-openstackclient-python26 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-python26/5454828 : SUCCESS in 55s\n- gate-python-openstackclient-python27 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-python27/a60a94c : SUCCESS in 56s\n- gate-python-openstackclient-python33 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-python33/dbdb1b7 : SUCCESS in 2m 44s\n- check-tempest-dsvm-full http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-full/5888f59 : SUCCESS in 50m 07s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-postgres-full/8b626c6 : SUCCESS in 48m 46s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-neutron-full/2605cd4 : SUCCESS in 1h 08m 06s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-neutron-heat-slow/602b8b9 : SUCCESS in 21m 12s\n- check-grenade-dsvm http://logs.openstack.org/30/127330/3/check/check-grenade-dsvm/9eced74 : SUCCESS in 44m 58s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-full-icehouse/42795f1 : SUCCESS in 49m 44s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-neutron-icehouse/4a74e48 : FAILURE in 10m 17s\n- check-osc-dsvm-functional http://logs.openstack.org/30/127330/3/check/check-osc-dsvm-functional/44fcd6a : SUCCESS in 16m 19s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"bba297b6879e0a4a203fc2f28224074dead5cf9e","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-10-12 23:12:56.000000000","message":"Patch Set 3:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- check-tempest-dsvm-neutron-icehouse: https://bugs.launchpad.net/bugs/1379201\n\nIf you believe we\u0027ve correctly identified the failure, feel free to leave a \u0027recheck\u0027 comment to run the tests again.\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":3},{"id":"fd2c9bfb586ba2785b7c25557ecc71fee0032bb7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-13 01:00:12.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"18c86b8d97d16cbfc4d5f9ac1807bcfe02ca322a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-13 02:07:50.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-pep8/086ee17 : SUCCESS in 50s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/30/127330/3/check/gate-python-openstackclient-docs/84482f9/doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-openstackclient-python26 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-python26/b6d510a : SUCCESS in 1m 18s\n- gate-python-openstackclient-python27 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-python27/723afbe : SUCCESS in 1m 01s\n- gate-python-openstackclient-python33 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-python33/6fe5cbc : SUCCESS in 2m 49s\n- check-tempest-dsvm-full http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-full/896139c : SUCCESS in 53m 43s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-postgres-full/5162dc7 : SUCCESS in 1h 00m 52s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-neutron-full/832828a : SUCCESS in 52m 03s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-neutron-heat-slow/a1c8b56 : SUCCESS in 18m 06s\n- check-grenade-dsvm http://logs.openstack.org/30/127330/3/check/check-grenade-dsvm/d21ea3d : SUCCESS in 50m 04s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-full-icehouse/6cf50f3 : SUCCESS in 49m 09s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-neutron-icehouse/9f712ca : FAILURE in 11m 58s\n- check-osc-dsvm-functional http://logs.openstack.org/30/127330/3/check/check-osc-dsvm-functional/c4b87d3 : SUCCESS in 16m 08s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"ed20f32d74e3ba8c960bf4d3bfbf7e3c1cc4a934","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-10-13 02:08:01.000000000","message":"Patch Set 3:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- check-tempest-dsvm-neutron-icehouse: https://bugs.launchpad.net/bugs/1379201\n\nIf you believe we\u0027ve correctly identified the failure, feel free to leave a \u0027recheck\u0027 comment to run the tests again.\nFor more details on this and other bugs, please see http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":3},{"id":"a62f2b2c7a84e74d70ac819c34af31d73ac3d525","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-13 03:58:12.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"f2d32b4a72ea0ddf4883a82ea651494bcb2f6d4d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-13 04:59:50.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded.\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-pep8/7445c1c : SUCCESS in 50s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/30/127330/3/check/gate-python-openstackclient-docs/b935981/doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-openstackclient-python26 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-python26/7ac2626 : SUCCESS in 1m 00s\n- gate-python-openstackclient-python27 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-python27/783a49d : SUCCESS in 52s\n- gate-python-openstackclient-python33 http://logs.openstack.org/30/127330/3/check/gate-python-openstackclient-python33/54e744b : SUCCESS in 3m 39s\n- check-tempest-dsvm-full http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-full/15c7302 : SUCCESS in 52m 05s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-postgres-full/4e0ac13 : SUCCESS in 46m 18s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-neutron-full/d2004e8 : SUCCESS in 1h 00m 55s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-neutron-heat-slow/544f307 : SUCCESS in 18m 36s\n- check-grenade-dsvm http://logs.openstack.org/30/127330/3/check/check-grenade-dsvm/31f639f : SUCCESS in 49m 11s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-full-icehouse/0543da6 : SUCCESS in 50m 45s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/30/127330/3/check/check-tempest-dsvm-neutron-icehouse/aeb0ddd : SUCCESS in 57m 36s\n- check-osc-dsvm-functional http://logs.openstack.org/30/127330/3/check/check-osc-dsvm-functional/df4aa68 : SUCCESS in 16m 14s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"294e8f25e61c87ec861a9fbe5ca131b86a183b69","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2014-10-13 07:59:12.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nIf the file descriptor is being closed somewhere behind the scenes it\u0027d be good to add some docs. If it is not we might have a bug in openstackclient.","accounts_in_message":[],"_revision_number":3},{"id":"3698ddb3c04048998722bb27bcd6be7620d6e01e","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2014-10-13 14:07:30.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nI agree with Marek, that file descriptor should be closed. Not everyone is using CPython (which will close it after the refcount hits 0 and garbage collects it). In fact there\u0027s an open bug on dateutil that causes serious problems on PyPy because it relies on exactly that behaviour.","accounts_in_message":[],"_revision_number":3},{"id":"9639e64b7d61a6b5d1e5662a9fc92495e15cdb09","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-13 15:34:46.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1460180ffa1361adbd57a57078a7a7210a9ea28d","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-13 15:35:54.000000000","message":"Patch Set 4:\n\nThanks guys, we have this problem in a couple of places...","accounts_in_message":[],"_revision_number":4},{"id":"aba371bd240efb58ab543207fc6c4ef26ffdbd72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-13 17:18:32.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/30/127330/4/check/gate-python-openstackclient-pep8/5ea2967 : SUCCESS in 1m 11s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/30/127330/4/check/gate-python-openstackclient-docs/7b088da/doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-openstackclient-python26 http://logs.openstack.org/30/127330/4/check/gate-python-openstackclient-python26/7d91369 : SUCCESS in 1m 08s\n- gate-python-openstackclient-python27 http://logs.openstack.org/30/127330/4/check/gate-python-openstackclient-python27/3f09834 : SUCCESS in 1m 02s\n- gate-python-openstackclient-python33 http://logs.openstack.org/30/127330/4/check/gate-python-openstackclient-python33/ca21ef6 : SUCCESS in 2m 40s\n- check-tempest-dsvm-full http://logs.openstack.org/30/127330/4/check/check-tempest-dsvm-full/0c95576 : SUCCESS in 53m 51s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/30/127330/4/check/check-tempest-dsvm-postgres-full/e32ca9c : SUCCESS in 1h 00m 55s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/30/127330/4/check/check-tempest-dsvm-neutron-full/1f612d5 : SUCCESS in 1h 07m 43s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/30/127330/4/check/check-tempest-dsvm-neutron-heat-slow/7aa7a73 : SUCCESS in 21m 56s\n- check-grenade-dsvm http://logs.openstack.org/30/127330/4/check/check-grenade-dsvm/4736779 : SUCCESS in 48m 15s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/30/127330/4/check/check-tempest-dsvm-full-icehouse/2944e09 : SUCCESS in 54m 30s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/30/127330/4/check/check-tempest-dsvm-neutron-icehouse/d6a2a40 : SUCCESS in 58m 32s\n- check-osc-dsvm-functional http://logs.openstack.org/30/127330/4/check/check-osc-dsvm-functional/a417821 : SUCCESS in 16m 47s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"b64951dac785412d69e2b980d26e3288310f85ff","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2014-10-13 18:42:29.000000000","message":"Patch Set 4:\n\nDean, since we are touching this piece of code - don\u0027t you want cover at least most typical Python exceptions? What if IOError is raised? It will print ugly stacktrace, won\u0027t it? \nMaybe it\u0027d be better to wrap it somehow so we print error more consciously?","accounts_in_message":[],"_revision_number":4},{"id":"75682601fc16086d7391a308248edc580c640df3","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-13 19:10:24.000000000","message":"Patch Set 4:\n\nMarek, this is an API method, the handling of exceptions is left to the app, which in this case is openstackclient.object.v1.object:CreateObject.  However, it doesn\u0027t need to handle it as the app-level handler prints a mostly-sane error message:\n\n  $ os object create qaz not.a.file\n  ERROR: openstack [Errno 2] No such file or directory: \u0027not.a.file\u0027","accounts_in_message":[],"_revision_number":4},{"id":"e6f73eb740db8a79c3dd7ee8925d9198a072074c","author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"date":"2014-10-14 06:56:22.000000000","message":"Patch Set 4: Code-Review+1\n\nYeah, you are right.","accounts_in_message":[],"_revision_number":4},{"id":"17206707a805b1da8421864488d0dd235314c44f","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-24 05:40:51.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"21f2f920921381a66f55775411f19c8772ad1501","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-24 05:41:00.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"e88ee751878218fc64e6e065587e80fd45ac9843","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-24 06:38:22.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/30/127330/4/gate/gate-python-openstackclient-docs/8ece6b8/doc/build/html/ : SUCCESS in 57s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/30/127330/4/gate/gate-python-openstackclient-pep8/ce89d97 : SUCCESS in 1m 18s\n- gate-python-openstackclient-python27 http://logs.openstack.org/30/127330/4/gate/gate-python-openstackclient-python27/da4ec91 : SUCCESS in 1m 10s\n- gate-python-openstackclient-python33 http://logs.openstack.org/30/127330/4/gate/gate-python-openstackclient-python33/4f443d2 : SUCCESS in 2m 48s\n- gate-tempest-dsvm-full http://logs.openstack.org/30/127330/4/gate/gate-tempest-dsvm-full/aab6905 : SUCCESS in 44m 41s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/30/127330/4/gate/gate-tempest-dsvm-postgres-full/8a3904e : SUCCESS in 45m 49s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/30/127330/4/gate/gate-tempest-dsvm-neutron-full/4936f41 : SUCCESS in 57m 09s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/30/127330/4/gate/gate-tempest-dsvm-neutron-heat-slow/63518e8 : SUCCESS in 19m 30s\n- gate-grenade-dsvm http://logs.openstack.org/30/127330/4/gate/gate-grenade-dsvm/ad02509 : SUCCESS in 48m 15s\n- gate-python-openstackclient-python26 http://logs.openstack.org/30/127330/4/gate/gate-python-openstackclient-python26/8e808d1 : SUCCESS in 1m 05s\n- gate-osc-dsvm-functional http://logs.openstack.org/30/127330/4/gate/gate-osc-dsvm-functional/657213e : SUCCESS in 16m 04s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"dd80276b6a482927d8ebd9317c68dd3d0f71d84c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-24 06:38:22.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"bcf4b3caece9edc6a04be3ce59697301e48ad34a","revisions":{"bd450d4430aaf82701b76f11016881197287232f":{"kind":"REWORK","_number":1,"created":"2014-10-09 20:06:39.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/30/127330/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/30/127330/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/1"}}},"commit":{"parents":[{"commit":"d87868720ee4c6de60f7a2870f2667112cfb7232","subject":"Merge \"Pass in domain and project as positional args, not kwargs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d87868720ee4c6de60f7a2870f2667112cfb7232"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-09 04:22:24.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-09 19:22:36.000000000","tz":-300},"subject":"Wrap builtin open() so it can be mocked","message":"Wrap builtin open() so it can be mocked\n\nMocking the builtin open() function is painful so we wrap it to\nsimplify testing methods like object_create().\n\nPreviously tests simply relied on files that were present in the\nrepository to run tests using open().  Change the filenames to ensure\nthat no longer happens.\n\nrequests_mock doesn\u0027t have a way to match against the request body for\nPUT/POST; an attempt to add a new Matcher to do that worked but it\nneeds to subclass the currently private adapter._Matcher class or\nduplicate most of its functionality.\n\nChange-Id: I8c30b41db20af8ecafe67e760e872fc08adec905\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bd450d4430aaf82701b76f11016881197287232f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bd450d4430aaf82701b76f11016881197287232f"}]},"branch":"refs/heads/master"},"d0d7be148f737b08ac0982483a3aa1fa474b0299":{"kind":"REWORK","_number":2,"created":"2014-10-11 03:11:11.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/30/127330/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/30/127330/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/2"}}},"commit":{"parents":[{"commit":"d87868720ee4c6de60f7a2870f2667112cfb7232","subject":"Merge \"Pass in domain and project as positional args, not kwargs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d87868720ee4c6de60f7a2870f2667112cfb7232"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-09 04:22:24.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-11 03:10:57.000000000","tz":-300},"subject":"Wrap builtin open() so it can be mocked","message":"Wrap builtin open() so it can be mocked\n\nMocking the builtin open() function is painful so we wrap it to\nsimplify testing methods like object_create().\n\nPreviously tests simply relied on files that were present in the\nrepository to run tests using open().  Change the filenames to ensure\nthat no longer happens.\n\nrequests_mock doesn\u0027t have a way to match against the request body for\nPUT/POST; an attempt to add a new Matcher to do that worked but it\nneeds to subclass the currently private adapter._Matcher class or\nduplicate most of its functionality.\n\nChange-Id: I8c30b41db20af8ecafe67e760e872fc08adec905\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d0d7be148f737b08ac0982483a3aa1fa474b0299"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d0d7be148f737b08ac0982483a3aa1fa474b0299"}]},"branch":"refs/heads/master"},"67506defa30426983b345e9dc4749a95bca268a5":{"kind":"REWORK","_number":3,"created":"2014-10-12 22:04:35.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/30/127330/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/30/127330/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/3"}}},"commit":{"parents":[{"commit":"49c74229b4073b1572357b074e78e2c4674632e7","subject":"Merge \"Mark identity v2 resources for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/49c74229b4073b1572357b074e78e2c4674632e7"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-09 04:22:24.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-12 22:03:23.000000000","tz":-300},"subject":"Update use of open() in object API","message":"Update use of open() in object API\n\n* Switch to use io.open() for py3 compatibility and simpler testing.\n* Open files in \u0027rb\u0027 mode to avoid translation on Windows\n\nPreviously tests simply relied on files that were present in the\nrepository to run tests using open().  Change the filenames to ensure\nthat no longer happens.\n\nrequests_mock doesn\u0027t have a way to match against the request body for\nPUT/POST; an attempt to add a new Matcher to do that worked but it\nneeds to subclass the currently private adapter._Matcher class or\nduplicate most of its functionality.\n\nChange-Id: I8c30b41db20af8ecafe67e760e872fc08adec905\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/67506defa30426983b345e9dc4749a95bca268a5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/67506defa30426983b345e9dc4749a95bca268a5"}]},"branch":"refs/heads/master"},"bcf4b3caece9edc6a04be3ce59697301e48ad34a":{"kind":"REWORK","_number":4,"created":"2014-10-13 15:34:46.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/30/127330/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/30/127330/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/30/127330/4"}}},"commit":{"parents":[{"commit":"49c74229b4073b1572357b074e78e2c4674632e7","subject":"Merge \"Mark identity v2 resources for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/49c74229b4073b1572357b074e78e2c4674632e7"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-09 04:22:24.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-13 15:34:11.000000000","tz":-300},"subject":"Update use of open() in object API","message":"Update use of open() in object API\n\n* Switch to use io.open() for py3 compatibility and simpler testing.\n* Open files in \u0027rb\u0027 mode to avoid translation on Windows\n\nPreviously tests simply relied on files that were present in the\nrepository to run tests using open().  Change the filenames to ensure\nthat no longer happens.\n\nrequests_mock doesn\u0027t have a way to match against the request body for\nPUT/POST; an attempt to add a new Matcher to do that worked but it\nneeds to subclass the currently private adapter._Matcher class or\nduplicate most of its functionality.\n\nChange-Id: I8c30b41db20af8ecafe67e760e872fc08adec905\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bcf4b3caece9edc6a04be3ce59697301e48ad34a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bcf4b3caece9edc6a04be3ce59697301e48ad34a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}