)]}'
{"id":"openstack%2Fpython-openstackclient~128109","triplet_id":"openstack%2Fpython-openstackclient~master~I1658b0caa2d6af17308149cb52196ee28266ddf2","project":"openstack/python-openstackclient","branch":"master","topic":"server-create-open","hashtags":[],"change_id":"I1658b0caa2d6af17308149cb52196ee28266ddf2","subject":"Close files on server create, add tests","status":"MERGED","created":"2014-10-13 21:47:43.000000000","updated":"2014-10-24 16:12:07.000000000","submitted":"2014-10-24 16:12:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9c672525ae0e85e5d2169ae13caabbe987faf686","_number":128109,"virtual_id_number":128109,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2014-10-24 16:12:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2014-10-24 05:46:11.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-10-24 15:04:20.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-10-24 15:04:20.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-24 05:46:11.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2014-10-24 16:12:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f533548ee1943f9f576a154dbc2f2bbe8e5eb82f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-13 21:47:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e94173eda9ab4e467f0a3e9dbb4afaf3cb99c3a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-13 22:54:42.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/09/128109/1/check/gate-python-openstackclient-pep8/7b7b09c : SUCCESS in 1m 04s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/09/128109/1/check/gate-python-openstackclient-docs/ba0e038/doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-python26 http://logs.openstack.org/09/128109/1/check/gate-python-openstackclient-python26/6c308c8 : SUCCESS in 1m 05s\n- gate-python-openstackclient-python27 http://logs.openstack.org/09/128109/1/check/gate-python-openstackclient-python27/1fc2ba3 : SUCCESS in 1m 04s\n- gate-python-openstackclient-python33 http://logs.openstack.org/09/128109/1/check/gate-python-openstackclient-python33/6b29b83 : SUCCESS in 2m 50s\n- check-tempest-dsvm-full http://logs.openstack.org/09/128109/1/check/check-tempest-dsvm-full/b643dab : FAILURE in 56m 54s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/09/128109/1/check/check-tempest-dsvm-postgres-full/bcc68dc : SUCCESS in 55m 08s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/09/128109/1/check/check-tempest-dsvm-neutron-full/97f6c85 : SUCCESS in 1h 06m 53s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/09/128109/1/check/check-tempest-dsvm-neutron-heat-slow/1c10dde : SUCCESS in 22m 43s\n- check-grenade-dsvm http://logs.openstack.org/09/128109/1/check/check-grenade-dsvm/ec68eff : SUCCESS in 51m 12s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/09/128109/1/check/check-tempest-dsvm-full-icehouse/f4e553e : SUCCESS in 54m 04s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/09/128109/1/check/check-tempest-dsvm-neutron-icehouse/6a75ec1 : SUCCESS in 54m 07s\n- check-osc-dsvm-functional http://logs.openstack.org/09/128109/1/check/check-osc-dsvm-functional/5fed041 : SUCCESS in 16m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"aa512333eb0e90fd694438a740fc4aa7fd7a6a93","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-14 20:46:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f7fd427603f881ada36a40bd0f8d436d270f85be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-14 22:09:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/09/128109/2/check/gate-python-openstackclient-pep8/d4a2e81 : SUCCESS in 1m 17s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/09/128109/2/check/gate-python-openstackclient-docs/f94e401/doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-openstackclient-python26 http://logs.openstack.org/09/128109/2/check/gate-python-openstackclient-python26/7529bcf : SUCCESS in 1m 06s\n- gate-python-openstackclient-python27 http://logs.openstack.org/09/128109/2/check/gate-python-openstackclient-python27/dbf1862 : SUCCESS in 51s\n- gate-python-openstackclient-python33 http://logs.openstack.org/09/128109/2/check/gate-python-openstackclient-python33/b3e39ea : SUCCESS in 2m 46s\n- check-tempest-dsvm-full http://logs.openstack.org/09/128109/2/check/check-tempest-dsvm-full/dcbf144 : SUCCESS in 55m 16s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/09/128109/2/check/check-tempest-dsvm-postgres-full/1580099 : SUCCESS in 55m 29s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/09/128109/2/check/check-tempest-dsvm-neutron-full/0544a49 : SUCCESS in 1h 06m 09s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/09/128109/2/check/check-tempest-dsvm-neutron-heat-slow/690160f : SUCCESS in 22m 32s\n- check-grenade-dsvm http://logs.openstack.org/09/128109/2/check/check-grenade-dsvm/17f9b77 : SUCCESS in 50m 27s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/09/128109/2/check/check-tempest-dsvm-full-icehouse/88a6459 : SUCCESS in 51m 08s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/09/128109/2/check/check-tempest-dsvm-neutron-icehouse/8fa87cc : SUCCESS in 55m 20s\n- check-osc-dsvm-functional http://logs.openstack.org/09/128109/2/check/check-osc-dsvm-functional/7261770 : SUCCESS in 14m 29s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c2acb582f53e8ea7e0a193f832fa51b8ee68f2b3","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-24 05:46:11.000000000","message":"Patch Set 2: Code-Review+2\n\ncalling: if hasattr(file, \u0027close\u0027): seems like a weird way to do things, but it works.","accounts_in_message":[],"_revision_number":2},{"id":"1cf6fce99ac5072e97c3ade7292cd36a030793a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-24 15:04:20.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"73426925405d72ffebc63a39cd7d28b0ad7e778e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-24 15:04:20.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nSteve, hasattr() is a defensive move because those are either file objects or strings, which of course can\u0027t be closed.","accounts_in_message":[],"_revision_number":2},{"id":"6ded9675a6ba8f8d4ba1a8ad0903ac67af354203","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-24 16:12:06.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/09/128109/2/gate/gate-python-openstackclient-docs/af76126/doc/build/html/ : SUCCESS in 1m 43s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/09/128109/2/gate/gate-python-openstackclient-pep8/b8555fb : SUCCESS in 56s\n- gate-python-openstackclient-python27 http://logs.openstack.org/09/128109/2/gate/gate-python-openstackclient-python27/abd5faf : SUCCESS in 1m 18s\n- gate-python-openstackclient-python33 http://logs.openstack.org/09/128109/2/gate/gate-python-openstackclient-python33/6cca24a : SUCCESS in 2m 53s\n- gate-tempest-dsvm-full http://logs.openstack.org/09/128109/2/gate/gate-tempest-dsvm-full/99d5684 : SUCCESS in 54m 00s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/09/128109/2/gate/gate-tempest-dsvm-postgres-full/f3956d9 : SUCCESS in 53m 46s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/09/128109/2/gate/gate-tempest-dsvm-neutron-full/a97f6c5 : SUCCESS in 1h 01m 09s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/09/128109/2/gate/gate-tempest-dsvm-neutron-heat-slow/c1a8a95 : SUCCESS in 26m 23s\n- gate-grenade-dsvm http://logs.openstack.org/09/128109/2/gate/gate-grenade-dsvm/2f32419 : SUCCESS in 49m 19s\n- gate-python-openstackclient-python26 http://logs.openstack.org/09/128109/2/gate/gate-python-openstackclient-python26/fdf767b : SUCCESS in 1m 05s\n- gate-osc-dsvm-functional http://logs.openstack.org/09/128109/2/gate/gate-osc-dsvm-functional/9b3900e : SUCCESS in 19m 37s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1aee05322900c15e8a2b12f9742856174ff8999f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-24 16:12:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"89217a6557e16872ac1af0e305ac09886a9e1255","revisions":{"4a0e77a8ab54b0cf0e003ea2765b40a3134c6622":{"kind":"REWORK","_number":1,"created":"2014-10-13 21:47:43.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/09/128109/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/09/128109/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/128109/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/128109/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/128109/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/09/128109/1"}}},"commit":{"parents":[{"commit":"36212c43d880d0eaeb3df271cccb314802bf3372","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/36212c43d880d0eaeb3df271cccb314802bf3372"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-13 21:30:38.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-13 21:39:12.000000000","tz":-300},"subject":"Close files on server create, add tests","message":"Close files on server create, add tests\n\nThe files opened for the --files and --user-data options were never\nclosed, potentially leaking memory in a long-running client.\n\nAdd a couple of basic tests for server create.\n\nChange-Id: I1658b0caa2d6af17308149cb52196ee28266ddf2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4a0e77a8ab54b0cf0e003ea2765b40a3134c6622"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4a0e77a8ab54b0cf0e003ea2765b40a3134c6622"}]},"branch":"refs/heads/master"},"89217a6557e16872ac1af0e305ac09886a9e1255":{"kind":"REWORK","_number":2,"created":"2014-10-14 20:46:12.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/09/128109/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/09/128109/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/128109/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/128109/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/128109/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/09/128109/2"}}},"commit":{"parents":[{"commit":"36212c43d880d0eaeb3df271cccb314802bf3372","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/36212c43d880d0eaeb3df271cccb314802bf3372"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-13 21:30:38.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-14 20:45:20.000000000","tz":-300},"subject":"Close files on server create, add tests","message":"Close files on server create, add tests\n\nThe files opened for the --files and --user-data options were never\nclosed, potentially leaking memory in a long-running client. Close\nthem if they are file objects.\n\nAdd a couple of basic tests for server create.\n\nChange-Id: I1658b0caa2d6af17308149cb52196ee28266ddf2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/89217a6557e16872ac1af0e305ac09886a9e1255"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/89217a6557e16872ac1af0e305ac09886a9e1255"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}