)]}'
{"id":"openstack%2Fpython-openstackclient~129537","triplet_id":"openstack%2Fpython-openstackclient~master~I0536a690bc173be38af08a2e4443115532041efd","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1383083","hashtags":[],"change_id":"I0536a690bc173be38af08a2e4443115532041efd","subject":"only generate one clientmanager instance in interactive mode","status":"MERGED","created":"2014-10-20 07:35:43.000000000","updated":"2014-10-21 06:00:32.000000000","submitted":"2014-10-21 06:00:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8cd9b601abf51f95e5fc3fc581e247455c10cb62","_number":129537,"virtual_id_number":129537,"owner":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2014-10-20 14:00:08.000000000","_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2014-10-21 06:00:32.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-10-20 14:44:53.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2014-10-21 01:00:38.000000000","_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":2,"date":"2014-10-20 19:02:01.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-10-21 02:44:36.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-10-21 02:44:36.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-20 14:00:08.000000000","updated_by":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"reviewer":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"state":"REVIEWER"},{"updated":"2014-10-20 19:02:01.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2014-10-21 02:44:36.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-10-21 06:00:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"86d53769d2e048d137ef144bab022c51eae78aa1","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-20 07:35:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d3dbfe536d93c20dc00bf5d54c47c5b800dd120c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-20 08:53:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/37/129537/1/check/gate-python-openstackclient-pep8/4c77f1a : SUCCESS in 1m 08s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/37/129537/1/check/gate-python-openstackclient-docs/75fdf94/doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-openstackclient-python26 http://logs.openstack.org/37/129537/1/check/gate-python-openstackclient-python26/683c94f : SUCCESS in 1m 04s\n- gate-python-openstackclient-python27 http://logs.openstack.org/37/129537/1/check/gate-python-openstackclient-python27/604d479 : SUCCESS in 1m 15s\n- gate-python-openstackclient-python33 http://logs.openstack.org/37/129537/1/check/gate-python-openstackclient-python33/a560493 : SUCCESS in 3m 40s\n- check-tempest-dsvm-full http://logs.openstack.org/37/129537/1/check/check-tempest-dsvm-full/852832a : SUCCESS in 42m 41s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/37/129537/1/check/check-tempest-dsvm-postgres-full/9ae15da : SUCCESS in 55m 51s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/37/129537/1/check/check-tempest-dsvm-neutron-full/9593492 : SUCCESS in 1h 08m 48s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/37/129537/1/check/check-tempest-dsvm-neutron-heat-slow/8dd5b44 : SUCCESS in 20m 09s\n- check-grenade-dsvm http://logs.openstack.org/37/129537/1/check/check-grenade-dsvm/145ab03 : SUCCESS in 50m 16s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/37/129537/1/check/check-tempest-dsvm-full-icehouse/3cc712d : SUCCESS in 52m 17s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/37/129537/1/check/check-tempest-dsvm-neutron-icehouse/fcc6462 : SUCCESS in 57m 42s\n- check-osc-dsvm-functional http://logs.openstack.org/37/129537/1/check/check-osc-dsvm-functional/a711a48 : FAILURE in 16m 09s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"98594b4ae3b42a19fcc4d01a107018e9136971be","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2014-10-20 14:00:08.000000000","message":"Patch Set 1:\n\nI realize this is the client, but in theory this could be considered a public API that you\u0027re changing in a backwards incompatible way. I agree the new name is better, but why not make a new method `initialize_clientmanager` with the conditional early return that then defaults to calling `authenticate_user` if the `client_manager` isn\u0027t already initialized? People could then still call `authenticate_user` with the old behaviour (if they\u0027re relying on it) and you could have the same behaviour that I agree is more desirable for interactive mode.\n\nI\u0027m new to the project so feel free to ignore me if we\u0027re not concerned with what would seem like a public API.","accounts_in_message":[],"_revision_number":1},{"id":"d52efa62798aa3842a6ec31865464fbb3fd97aec","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-20 14:44:53.000000000","message":"Patch Set 1:\n\nIan, I would consider the ClientManager itself to be our high-level API (see https://review.openstack.org/#/c/127873/3/examples/osc-lib.py,unified), if/when there is one.  shell.py is just that, the shell that sets up OSC.  I\u0027m in the midst of cleaning up that interface, and to be honest, I don\u0027t know anything about these patches that are changing the auth and clientmanager creation.  Not that they\u0027re bad, but uncoordinated with the work I am doing ATM and at times conflicting with it.  The problems being addressed are real, but they are painting a house that still needs siding replaced...","accounts_in_message":[],"_revision_number":1},{"id":"26b771e082d6480975bb47fa91a0b55d788e156d","author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"date":"2014-10-20 14:50:53.000000000","message":"Patch Set 1:\n\nDean, that\u0027s enlightening. I\u0027ve just been bitten by stuff like this more than I\u0027d like to admit. I\u0027ve had high level public APIs that people bypass and then complain when changes like this are made. Neither the module, class, nor method name indicate that this isn\u0027t meant to be used by the public, which is why I asked. Thanks for clearing that up","accounts_in_message":[],"_revision_number":1},{"id":"fe39eb2a94c76ef310bfd303d677bfd6a62c02d5","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-20 19:02:01.000000000","message":"Patch Set 1: Code-Review+2\n\ni think this makes sense","accounts_in_message":[],"_revision_number":1},{"id":"95360e3f1a948b9ea8b1840c73c3a9daca5d8f87","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-20 23:49:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nSo all that really needed to happen here is to remove the interact() method as it does nothing else after removing the authenticate_user() call.\n\nMost of this is going to be removed soon anyway as authenticate_user() is cleaned out due to the impending auth plugin cleanup.","accounts_in_message":[],"_revision_number":1},{"id":"1018ee2015776d6429995c7f2e7647f349bcc77c","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-21 01:00:38.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nHi, Dean Troyer.\n\nI think interact method can be still left. Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"9f8f5b492f61e41f7dc2328e23f7edaf7acec356","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-21 02:44:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"0293a8b9a86cf8ceb0670e89f78259f3089b09c4","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-21 02:44:36.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"363655e861581ba8ae5091188271d84cec15fd2a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-21 06:00:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"5d3679a22e7bbf8bc5fce70e8189dcdcf76c0a66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-21 06:00:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/37/129537/1/gate/gate-python-openstackclient-docs/e7873aa/doc/build/html/ : SUCCESS in 1m 18s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/37/129537/1/gate/gate-python-openstackclient-pep8/b1693af : SUCCESS in 1m 10s\n- gate-python-openstackclient-python26 http://logs.openstack.org/37/129537/1/gate/gate-python-openstackclient-python26/4426328 : SUCCESS in 1m 05s\n- gate-python-openstackclient-python27 http://logs.openstack.org/37/129537/1/gate/gate-python-openstackclient-python27/a3d2569 : SUCCESS in 59s\n- gate-python-openstackclient-python33 http://logs.openstack.org/37/129537/1/gate/gate-python-openstackclient-python33/1abd0c6 : SUCCESS in 2m 37s\n- gate-tempest-dsvm-full http://logs.openstack.org/37/129537/1/gate/gate-tempest-dsvm-full/9e46678 : SUCCESS in 51m 40s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/37/129537/1/gate/gate-tempest-dsvm-postgres-full/2ffe308 : SUCCESS in 52m 38s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/37/129537/1/gate/gate-tempest-dsvm-neutron-full/2795ec0 : SUCCESS in 52m 27s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/37/129537/1/gate/gate-tempest-dsvm-neutron-heat-slow/e7ed6e5 : SUCCESS in 20m 43s\n- gate-grenade-dsvm http://logs.openstack.org/37/129537/1/gate/gate-grenade-dsvm/b09bad0 : SUCCESS in 50m 48s\n- gate-osc-dsvm-functional http://logs.openstack.org/37/129537/1/gate/gate-osc-dsvm-functional/446e69c : FAILURE in 15m 55s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f600c0eafbf9aff23b6efa1c7b94797a25873b99","revisions":{"f600c0eafbf9aff23b6efa1c7b94797a25873b99":{"kind":"REWORK","_number":1,"created":"2014-10-20 07:35:43.000000000","uploader":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"ref":"refs/changes/37/129537/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/37/129537/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/37/129537/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/37/129537/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/37/129537/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/37/129537/1"}}},"commit":{"parents":[{"commit":"2166d7d3afbbdc1659e4cffdb7bcd890cd00ec19","subject":"Remove ClientManager._service_catalog","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2166d7d3afbbdc1659e4cffdb7bcd890cd00ec19"}]}],"author":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2014-10-20 07:29:53.000000000","tz":480},"committer":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2014-10-20 07:29:53.000000000","tz":480},"subject":"only generate one clientmanager instance in interactive mode","message":"only generate one clientmanager instance in interactive mode\n\nCurrently, we repeated to generate clientmanager instance when run\ncommand in interactive mode. This should be avoided.\n\nChange-Id: I0536a690bc173be38af08a2e4443115532041efd\nCloses-Bug: #1383083\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f600c0eafbf9aff23b6efa1c7b94797a25873b99"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f600c0eafbf9aff23b6efa1c7b94797a25873b99"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}