)]}'
{"id":"openstack%2Fpython-openstackclient~129778","triplet_id":"openstack%2Fpython-openstackclient~master~I9fdec9144c4c84f65aed1cf91ce41fe1895089b2","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1355838","hashtags":[],"change_id":"I9fdec9144c4c84f65aed1cf91ce41fe1895089b2","subject":"Clean up shell authentication","status":"MERGED","created":"2014-10-21 04:15:31.000000000","updated":"2014-10-22 20:04:29.000000000","submitted":"2014-10-22 20:04:28.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"55ada2058a84730cc6e1ab75951b8af4dfc7098d","_number":129778,"virtual_id_number":129778,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2014-10-22 04:46:40.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2014-10-22 20:04:28.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-10-22 04:39:51.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2014-10-22 06:52:17.000000000","_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2014-10-22 07:33:13.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-10-22 19:08:45.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":-1,"date":"2014-10-22 07:54:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-10-22 19:08:45.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-10-22 04:46:40.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2014-10-22 06:52:17.000000000","updated_by":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"reviewer":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"state":"REVIEWER"},{"updated":"2014-10-22 20:04:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"32cea2bb8ecf493fa894b87daf22ed46862e33d7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-21 04:15:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a9eac320e814a470fd9ddacdfbe9a8eb8e0c8305","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-21 04:50:40.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)\n\nit works, and well.","accounts_in_message":[],"_revision_number":1},{"id":"eca9e0d261ab9ccc576906c9808a8e32d98d4ff2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-21 05:28:11.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"8df8d481f5c869c134fcc8fa7c083224976d2376","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-21 20:25:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/78/129778/1/check/gate-python-openstackclient-pep8/5d4be67 : SUCCESS in 1m 14s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/78/129778/1/check/gate-python-openstackclient-docs/b6ff899/doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-openstackclient-python26 http://logs.openstack.org/78/129778/1/check/gate-python-openstackclient-python26/dfd9fdd : SUCCESS in 1m 05s\n- gate-python-openstackclient-python27 http://logs.openstack.org/78/129778/1/check/gate-python-openstackclient-python27/b1b1496 : SUCCESS in 1m 15s\n- gate-python-openstackclient-python33 http://logs.openstack.org/78/129778/1/check/gate-python-openstackclient-python33/ce57a41 : SUCCESS in 3m 42s\n- check-tempest-dsvm-full http://logs.openstack.org/78/129778/1/check/check-tempest-dsvm-full/cc07fc1 : SUCCESS in 58m 26s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/78/129778/1/check/check-tempest-dsvm-postgres-full/5ce8c45 : SUCCESS in 51m 57s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/78/129778/1/check/check-tempest-dsvm-neutron-full/74ac858 : SUCCESS in 1h 04m 20s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/78/129778/1/check/check-tempest-dsvm-neutron-heat-slow/11879e6 : SUCCESS in 20m 16s\n- check-grenade-dsvm http://logs.openstack.org/78/129778/1/check/check-grenade-dsvm/efb86aa : SUCCESS in 54m 10s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/78/129778/1/check/check-tempest-dsvm-full-icehouse/0138163 : SUCCESS in 47m 55s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/78/129778/1/check/check-tempest-dsvm-neutron-icehouse/b8fe91d : SUCCESS in 56m 47s\n- check-osc-dsvm-functional http://logs.openstack.org/78/129778/1/check/check-osc-dsvm-functional/5fc9775 : FAILURE in 17m 15s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8eedb4368f4b993ae903feb15045922e11092d93","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-22 02:02:44.000000000","message":"Patch Set 1:\n\nI think it is no longer as friendly as before.\n\nIf I just type openstack, it give me a message as follow:\n\nopenstack\nERROR: openstack Could not figure out which authentication method to use, please set --os-auth-plugin\n\nAnd then I try to add --os-auth-plugin option(I inputed the password when it prompted me to input password):\n\nopenstack --os-auth-plugin password\nPassword: \nERROR: openstack \n\nIf I add --os-username option like before:\n\nopenstack --os-username nova\nPassword: \nERROR: openstack","accounts_in_message":[],"_revision_number":1},{"id":"0fe0c81b7e8dbcbcd70ed305cd746ad945c21119","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-22 02:18:11.000000000","message":"Patch Set 1:\n\nThe error message in the last comment is not clear enough. They should be:\n\nopenstack\n\nERROR: openstack Could not figure out which authentication method to use, please set --os-auth-plugin\n\n\nopenstack --os-auth-plugin password\n\nPassword: \n\nERROR: openstack\n\n\nopenstack --os-username nova\n\nPassword: \n\nERROR: openstack","accounts_in_message":[],"_revision_number":1},{"id":"ce533813a8e2f6bbc413aa0f731fb035105a451a","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-22 02:38:30.000000000","message":"Patch Set 1:\n\nFrom your commit message, you want to fix this bug: https://bugs.launchpad.net/python-openstackclient/+bug/1355838 in this patch, right? But it seems to not work.","accounts_in_message":[],"_revision_number":1},{"id":"cd6601aae8ac35630add536a532d46cd24d638ff","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-22 04:38:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"25522568fe801a70d7ce735e78a91b1df9ee7372","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-22 04:39:51.000000000","message":"Patch Set 2:\n\n@wanghong, I did miss setting up the auth_ref properly.  And that --os-aut-ref error message could use improvement, such as listing the recognized values based on available plugins.\n\nRegarding your auth errors, what is in your environment when you do that?  I have not been able to duplicate that scenario.","accounts_in_message":[],"_revision_number":2},{"id":"3745ba07d8e623210dc1f8fcf011a2c35d7a4843","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-22 04:46:40.000000000","message":"Patch Set 2:\n\n@wanghong, that\u0027s funny, I tried it out, and the interactive shell worked fine. I tried with OS_PASSWORD set, and it didn\u0027t ask. Then i tried without OS_PASSWORD and i was prompted.","accounts_in_message":[],"_revision_number":2},{"id":"9b3e7781bd5d344b9517a24c85b22c7973d9314e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-22 05:37:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/78/129778/2/check/gate-python-openstackclient-pep8/fa0b950 : SUCCESS in 53s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/78/129778/2/check/gate-python-openstackclient-docs/9775c87/doc/build/html/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python27 http://logs.openstack.org/78/129778/2/check/gate-python-openstackclient-python27/8755810 : SUCCESS in 50s\n- gate-python-openstackclient-python33 http://logs.openstack.org/78/129778/2/check/gate-python-openstackclient-python33/5289a21 : SUCCESS in 2m 28s\n- check-tempest-dsvm-full http://logs.openstack.org/78/129778/2/check/check-tempest-dsvm-full/dc22fe8 : SUCCESS in 58m 44s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/78/129778/2/check/check-tempest-dsvm-postgres-full/43838db : SUCCESS in 47m 21s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/78/129778/2/check/check-tempest-dsvm-neutron-full/13dfb5d : SUCCESS in 55m 07s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/78/129778/2/check/check-tempest-dsvm-neutron-heat-slow/7ffba1c : SUCCESS in 21m 22s\n- check-grenade-dsvm http://logs.openstack.org/78/129778/2/check/check-grenade-dsvm/aa72a28 : SUCCESS in 50m 38s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/78/129778/2/check/check-tempest-dsvm-full-icehouse/a703cf8 : SUCCESS in 57m 08s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/78/129778/2/check/check-tempest-dsvm-neutron-icehouse/2efc9c5 : SUCCESS in 54m 49s\n- gate-python-openstackclient-python26 http://logs.openstack.org/78/129778/2/check/gate-python-openstackclient-python26/5f8151f : SUCCESS in 1m 07s\n- check-osc-dsvm-functional http://logs.openstack.org/78/129778/2/check/check-osc-dsvm-functional/a91150e : SUCCESS in 16m 12s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"275879fb8e3ad09f00a36bc4ab452305484dc677","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-22 06:52:17.000000000","message":"Patch Set 2:\n\n@Steve Martinelli, Dean Troyer\n\nI did not set any environment. The tip message without this patch is as follow:\nopenstack\n\nERROR: openstackclient.shell Exception raised: You must provide a username via either --os-username or env[OS_USERNAME]\n\nopenstack --os-username nova\n\nPassword: \n\nERROR: openstackclient.shell Exception raised: You must provide an auth url via either --os-auth-url or via env[OS_AUTH_URL]\n\nopenstack --os-username nova --os-auth-url http://127.0.0.1:353857/v2.0\n\nPassword: \n\n(openstack)\n\nIf I am a newer, I can set my environment step by step.","accounts_in_message":[],"_revision_number":2},{"id":"0a0fa619232428bada92d82248c551a4d93772f5","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-22 06:57:42.000000000","message":"Patch Set 2:\n\nI try again:\n\nopenstack\n\nERROR: openstack Could not figure out which authentication method to use, please set --os-auth-plugin\n\n----------------------------------------\n\nopenstack --os-username nova\n\nPassword: \n\n(openstack) user list\n\nERROR: openstack\n\nI think in this case I need to find some help...","accounts_in_message":[],"_revision_number":2},{"id":"dd76555229868a888384e238e27c1dac5d7f3536","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-22 07:32:19.000000000","message":"Patch Set 2:\n\nHere\u0027s what i do:\n\n  steve:python-openstackclient$ git review -d 129778\n  steve:python-openstackclient$ python tools/install_venv.py\n  steve:python-openstackclient$ source .venv/bin/activate\n  steve:python-openstackclient$ python setup.py develop\n\nEnvironment variables from devstack\n\n  (.venv)steve:python-openstackclient$ env | grep OS\n  OS_REGION_NAME\u003dRegionOne\n  OS_IDENTITY_API_VERSION\u003d2.0\n  OS_PASSWORD\u003dopenstack\n  OS_AUTH_URL\u003dhttp://10.0.2.15:5000/v2.0\n  OS_USERNAME\u003dadmin\n  OS_TENANT_NAME\u003dadmin\n  OS_VOLUME_API_VERSION\u003d2\n\nTest with OS_PASSWORD set\n\n  (.venv)steve:python-openstackclient$ openstack\n  (openstack) user list\n  +----------------------------------+----------------+\n  | ID                               | Name           |\n  +----------------------------------+----------------+\n  | 98d644ef009549bf872c79d1f3d3e192 | admin          |\n  | 9b3e8da4bb7f444a9a7626b9ef2983fc | demo           |\n\n  (openstack) exit\n\nTest with OS_PASSWORD not set and password correct\n\n  (.venv)steve:python-openstackclient$ unset OS_PASSWORD\n  (.venv)steve:python-openstackclient$ openstack\n  Password: \n  (openstack) user list\n  +----------------------------------+----------------+\n  | ID                               | Name           |\n  +----------------------------------+----------------+\n  | 98d644ef009549bf872c79d1f3d3e192 | admin          |\n  | 9b3e8da4bb7f444a9a7626b9ef2983fc | demo           |\n\n  (openstack) exit\n\nBad password\n\n  (.venv)steve:python-openstackclient$ openstack\n  Password: \n  (openstack) user list\n  ERROR: openstack Authentication failure: Invalid user / password (Disable debug mode to suppress these details.) (HTTP 401)\n\nAnd to exit venv\n\n  (.venv)steve:python-openstackclient$ deactivate","accounts_in_message":[],"_revision_number":2},{"id":"e61760021e8d22bafcd475958d9643e8aba4b4cd","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2014-10-22 07:33:13.000000000","message":"Patch Set 2: Code-Review+2\n\n@wanghong not sure whats going on with your environment, but i\u0027m still +2 on this change.","accounts_in_message":[],"_revision_number":2},{"id":"e39e4f284add3e28960483b4070d68404f7657d7","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-22 07:53:16.000000000","message":"Patch Set 2:\n\n@Steve Martinelli.\n\nI means we don\u0027t do these two steps:\n\npython tools/install_venv.py\n\nsource .venv/bin/activate","accounts_in_message":[],"_revision_number":2},{"id":"02990e1470bf33e5a212b4cfb608392a10cbde77","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2014-10-22 07:54:47.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2b25febb8c93402b5a292a06cecaf84ae3bb84c0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-22 19:08:45.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"44ae652aa0f8ca4f7303b9529204a22d39fb9f7b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-10-22 19:08:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e2c79f520bc3e556ceef595080eb1d404d1df0b8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-22 20:04:28.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/78/129778/2/gate/gate-python-openstackclient-docs/f5db423/doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/78/129778/2/gate/gate-python-openstackclient-pep8/61b93ff : SUCCESS in 1m 11s\n- gate-python-openstackclient-python27 http://logs.openstack.org/78/129778/2/gate/gate-python-openstackclient-python27/c0bd1ba : SUCCESS in 55s\n- gate-python-openstackclient-python33 http://logs.openstack.org/78/129778/2/gate/gate-python-openstackclient-python33/eda9b07 : SUCCESS in 2m 49s\n- gate-tempest-dsvm-full http://logs.openstack.org/78/129778/2/gate/gate-tempest-dsvm-full/a68bef9 : SUCCESS in 55m 30s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/78/129778/2/gate/gate-tempest-dsvm-postgres-full/656e850 : SUCCESS in 55m 09s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/78/129778/2/gate/gate-tempest-dsvm-neutron-full/27dbf96 : SUCCESS in 51m 06s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/78/129778/2/gate/gate-tempest-dsvm-neutron-heat-slow/30e149e : SUCCESS in 18m 52s\n- gate-grenade-dsvm http://logs.openstack.org/78/129778/2/gate/gate-grenade-dsvm/68a555e : SUCCESS in 52m 32s\n- gate-python-openstackclient-python26 http://logs.openstack.org/78/129778/2/gate/gate-python-openstackclient-python26/ffa47c3 : SUCCESS in 1m 17s\n- gate-osc-dsvm-functional http://logs.openstack.org/78/129778/2/gate/gate-osc-dsvm-functional/b8a389c : SUCCESS in 12m 37s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"660574e89ea668369e7d44d6b37937cd806aadd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-10-22 20:04:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e063246b97a7f31a47aca0a5eb36d571f5df7236","revisions":{"9f74ac874d6558b3275c13dd829b59d84d7a6188":{"kind":"REWORK","_number":1,"created":"2014-10-21 04:15:31.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/78/129778/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/78/129778/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/129778/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/129778/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/129778/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/78/129778/1"}}},"commit":{"parents":[{"commit":"f600c0eafbf9aff23b6efa1c7b94797a25873b99","subject":"only generate one clientmanager instance in interactive mode","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f600c0eafbf9aff23b6efa1c7b94797a25873b99"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-20 23:53:10.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-21 04:06:23.000000000","tz":-300},"subject":"Clean up shell authentication","message":"Clean up shell authentication\n\n* Remove the auth option checks as the auth plugins will validate\n  their own options\n* Move the initialization of client_manager to the end of\n  initialize_app() so it is always called.  Note that no attempts\n  to actually authenticate occur until the first use of one of the\n  client attributes in client_manager.  This leaves\n  initialize_clientmanager() (formerly uathenticate_user()) empty\n  so remove it.\n* Remove interact() as the client_manager has already been created\n  And there is nothing left.\n* prepare_to_run_command() is reduced to trigger an authentication\n  attempt for the best_effort auth commands, currently the only\n  one is \u0027complete\u0027.\n* Add prompt_for_password() to ask the user to enter a password\n  when necessary.  Passed to ClientManager in a new kward pw_func.\n\nChange-Id: I9fdec9144c4c84f65aed1cf91ce41fe1895089b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9f74ac874d6558b3275c13dd829b59d84d7a6188"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9f74ac874d6558b3275c13dd829b59d84d7a6188"}]},"branch":"refs/heads/master"},"e063246b97a7f31a47aca0a5eb36d571f5df7236":{"kind":"REWORK","_number":2,"created":"2014-10-22 04:38:01.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/78/129778/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/78/129778/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/129778/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/129778/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/78/129778/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/78/129778/2"}}},"commit":{"parents":[{"commit":"f600c0eafbf9aff23b6efa1c7b94797a25873b99","subject":"only generate one clientmanager instance in interactive mode","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f600c0eafbf9aff23b6efa1c7b94797a25873b99"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-20 23:53:10.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-10-22 04:16:16.000000000","tz":-300},"subject":"Clean up shell authentication","message":"Clean up shell authentication\n\n* Remove the auth option checks as the auth plugins will validate\n  their own options\n* Move the initialization of client_manager to the end of\n  initialize_app() so it is always called.  Note that no attempts\n  to actually authenticate occur until the first use of one of the\n  client attributes in client_manager.  This leaves\n  initialize_clientmanager() (formerly uathenticate_user()) empty\n  so remove it.\n* Remove interact() as the client_manager has already been created\n  And there is nothing left.\n* prepare_to_run_command() is reduced to trigger an authentication\n  attempt for the best_effort auth commands, currently the only\n  one is \u0027complete\u0027.\n* Add prompt_for_password() to ask the user to enter a password\n  when necessary.  Passed to ClientManager in a new kward pw_func.\n\nBug: 1355838\nChange-Id: I9fdec9144c4c84f65aed1cf91ce41fe1895089b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e063246b97a7f31a47aca0a5eb36d571f5df7236"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e063246b97a7f31a47aca0a5eb36d571f5df7236"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
