)]}'
{"openstackclient/api/auth.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d1526017ebbaa53d947aa84e83c1e9b1395714c9","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if self._record_timings:"},{"line_number":48,"context_line":"            self.timing_data.append((\"%s %s\" % (method, resp.url),"},{"line_number":49,"context_line":"                                     start,"},{"line_number":50,"context_line":"                                     time.time()))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_21c8bb21","line":49,"updated":"2014-11-12 22:56:50.000000000","message":"Is there a reason that the timing data is stored as a tuple with start and end instead of using the elapsed attribute on the response?","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"fadcd0f313b035ee069d74f9342d9ec3996aed71","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if self._record_timings:"},{"line_number":48,"context_line":"            self.timing_data.append((\"%s %s\" % (method, resp.url),"},{"line_number":49,"context_line":"                                     start,"},{"line_number":50,"context_line":"                                     time.time()))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_75706072","line":49,"in_reply_to":"5a890539_21c8bb21","updated":"2014-11-16 22:21:51.000000000","message":"purely because this is the way that the existing clients used to work and so there are assumptions throughout OSC that expect it to work like this. \n\nI think it\u0027s dumb, but using that would be part of a different refactor i think.","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d1526017ebbaa53d947aa84e83c1e9b1395714c9","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            if not password:"},{"line_number":197,"context_line":"                raise exc.CommandError("},{"line_number":198,"context_line":"                    \"You must provide a password via\""},{"line_number":199,"context_line":"                    \" either --os-password, or env[OS_PASSWORD], \""},{"line_number":200,"context_line":"                    \" or prompted response\")"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"            mutual_exclusion_count \u003d sum((bool(project_id or project_name),"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_41f22770","line":199,"updated":"2014-11-12 22:56:50.000000000","message":"Extra space at the end","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d1526017ebbaa53d947aa84e83c1e9b1395714c9","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            #         \"You must provide authentication scope as a project \""},{"line_number":214,"context_line":"            #         \"or a domain via --os-project-id or env[OS_PROJECT_ID]\""},{"line_number":215,"context_line":"            #         \" --os-project-name or env[OS_PROJECT_NAME],\""},{"line_number":216,"context_line":"            #         \" --os-domain-id or env[OS_DOMAIN_ID], or\""},{"line_number":217,"context_line":"            #         \" --os-domain-name or env[OS_DOMAIN_NAME], or\""},{"line_number":218,"context_line":"            #         \" --os-trust-id or env[OS_TRUST_ID].\")"},{"line_number":219,"context_line":"            if mutual_exclusion_count \u003e 1:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_61e9e37f","line":216,"updated":"2014-11-12 22:56:50.000000000","message":"Can this block be removed? If not, can you add a NOTE or TODO regarding it?","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"}],"openstackclient/common/clientmanager.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d1526017ebbaa53d947aa84e83c1e9b1395714c9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        :param session:"},{"line_number":57,"context_line":"            The session to communicate with the clients."},{"line_number":58,"context_line":"        :param api_version:"},{"line_number":59,"context_line":"            Dict of API versions: key is API name, value is the version"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self._region_name \u003d region_name"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_61a00344","line":59,"updated":"2014-11-12 22:56:50.000000000","message":"Can you add parameters for region_name and timing?","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d1526017ebbaa53d947aa84e83c1e9b1395714c9","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self._region_name \u003d region_name"},{"line_number":63,"context_line":"        self._api_version \u003d api_version"},{"line_number":64,"context_line":"        # self._auth_ref \u003d None"},{"line_number":65,"context_line":"        self.timing \u003d timing"},{"line_number":66,"context_line":"        self.session \u003d session"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_41c067e0","line":64,"updated":"2014-11-12 22:56:50.000000000","message":"If we don\u0027t need self._auth_ref can we just remove this altogether?","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"}],"openstackclient/common/timing.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d1526017ebbaa53d947aa84e83c1e9b1395714c9","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        results \u003d []"},{"line_number":35,"context_line":"        total \u003d 0.0"},{"line_number":36,"context_line":"        for url, start, end in self.app.session.timing_data:"},{"line_number":37,"context_line":"            seconds \u003d end - start"},{"line_number":38,"context_line":"            total +\u003d seconds"},{"line_number":39,"context_line":"            results.append((url, seconds))"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_017d7fb1","line":36,"updated":"2014-11-12 22:56:50.000000000","message":"Requests already handles this. At least for Juno\u0027s clients we should be able to use the elapsed attribute since requests added it in 1.2.0 and the minimum version for Juno was 1.2.3. I\u0027d have to check Icehouse to ensure we can support those clients though.","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"fadcd0f313b035ee069d74f9342d9ec3996aed71","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        results \u003d []"},{"line_number":35,"context_line":"        total \u003d 0.0"},{"line_number":36,"context_line":"        for url, start, end in self.app.session.timing_data:"},{"line_number":37,"context_line":"            seconds \u003d end - start"},{"line_number":38,"context_line":"            total +\u003d seconds"},{"line_number":39,"context_line":"            results.append((url, seconds))"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_35125809","line":36,"in_reply_to":"5a890539_017d7fb1","updated":"2014-11-16 22:21:51.000000000","message":"requests handles it on a per request elapsed time basis right? we would still require the ksc session object to copy the elapsed time from the request and store it in a list?\n\n(also i think it\u0027s part of a different refactor)","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"}],"openstackclient/tests/test_shell.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d1526017ebbaa53d947aa84e83c1e9b1395714c9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                                 default_args.get(\"auth_plugin\"))"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"            # self.assertEqual(_shell.options.os_trust_id,"},{"line_number":116,"context_line":"            #                  default_args[\"trust_id\"])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _assert_token_auth(self, cmd_options, default_args):"},{"line_number":119,"context_line":"        with mock.patch(\"openstackclient.shell.OpenStackShell.initialize_app\","}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_09a045f3","line":116,"updated":"2014-11-12 22:56:50.000000000","message":"Can we just remove this if it\u0027s commented out?","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"d1526017ebbaa53d947aa84e83c1e9b1395714c9","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    #     }"},{"line_number":270,"context_line":"    #     self._assert_password_auth(flag, kwargs)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    # def test_only_auth_plugin_flow(self):"},{"line_number":273,"context_line":"    #     flag \u003d \"--os-auth-type \" + \"v2password\""},{"line_number":274,"context_line":"    #     kwargs \u003d {"},{"line_number":275,"context_line":"    #         \"auth_plugin\": DEFAULT_AUTH_PLUGIN"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a890539_29a7c10d","line":272,"updated":"2014-11-12 22:56:50.000000000","message":"Remove these too?","commit_id":"d26e04539d5fbedf8bd9c7e1b9f8cc1ccc2c79fc"}]}