)]}'
{"examples/common.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"ba649925fb75fac6f21d4092054c33d7bcbf918d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \u0027--os-default-domain\u0027,"},{"line_number":107,"context_line":"        metavar\u003d\u0027\u003cauth-domain\u003e\u0027,"},{"line_number":108,"context_line":"        default\u003d\u0027default\u0027,"},{"line_number":109,"context_line":"        help\u003d\u0027Default domain ID, default\u003ddefault (Env: OS_DEFAULT_DOMAIN)\u0027,"},{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":"    verify_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":112,"context_line":"    verify_group.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_7c2bcc94","line":109,"updated":"2015-01-16 16:37:24.000000000","message":"does the default argument already get pulled into the help?","commit_id":"1d75edb1678e42a36879245c6ebac69c14a5f965"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"673e0dcce39b0b0762372e3555f4052156972e33","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \u0027--os-default-domain\u0027,"},{"line_number":107,"context_line":"        metavar\u003d\u0027\u003cauth-domain\u003e\u0027,"},{"line_number":108,"context_line":"        default\u003d\u0027default\u0027,"},{"line_number":109,"context_line":"        help\u003d\u0027Default domain ID, default\u003ddefault (Env: OS_DEFAULT_DOMAIN)\u0027,"},{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":"    verify_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":112,"context_line":"    verify_group.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_c154d4c7","line":109,"in_reply_to":"3a961159_7c2bcc94","updated":"2015-01-16 18:56:06.000000000","message":"If you mean from openstackclient.shell, no, this is a parallel stripped-down example of doing the same thing.","commit_id":"1d75edb1678e42a36879245c6ebac69c14a5f965"}],"openstackclient/common/clientmanager.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"40c7dc2e6a21cefc2fac98ce13aa5360fd98e51c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # to \u0027Default\u0027 for better usability."},{"line_number":104,"context_line":"        if (not self._auth_params.get(\u0027project_domain_id\u0027) and"},{"line_number":105,"context_line":"            not self._auth_params.get(\u0027project_domain_name\u0027)):"},{"line_number":106,"context_line":"            self._auth_params[\u0027project_domain_id\u0027] \u003d \u0027Default\u0027"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        # NOTE(stevemar): If PROJECT_DOMAIN_ID or PROJECT_DOMAIN_NAME is present,"},{"line_number":109,"context_line":"        # then do not change the behaviour. Otherwise, set the PROJECT_DOMAIN_ID"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_d33e55b7","line":106,"updated":"2014-11-18 14:18:45.000000000","message":"Last I looked, \u0027default\u0027 was what Keystone uses for default_domain_id.  If the spec doesn\u0027t say otherwise I think that might be safer.","commit_id":"3e7bdfdd294d2e1658d73f8af3bfb9a8c93e92af"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"baa8c1e2c54a9983ae43ddcd974e5c3b4bf7c944","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.timing \u003d auth_options.timing"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # NOTE(stevemar): If USER_DOMAIN_ID or USER_DOMAIN_NAME is present,"},{"line_number":102,"context_line":"        # then do not change the behaviour. Otherwise, set the USER_DOMAIN_ID"},{"line_number":103,"context_line":"        # to \u0027Default\u0027 for better usability."},{"line_number":104,"context_line":"        if (self._api_version.get(\u0027identity\u0027) \u003d\u003d \u00273\u0027 and"},{"line_number":105,"context_line":"            \u0027project_domain_id\u0027 in self._auth_params and"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_143b919c","line":102,"updated":"2015-01-16 05:10:33.000000000","message":"the comment got switched,  this comment seems for the second block related to user_domain_id ;)","commit_id":"7a8e4092a303f8ca31bbfee9b6720d899fcb6145"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b6beeac18e6b88f46a3fdc004926b7c351fa4171","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        self.timing \u003d auth_options.timing"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # NOTE(stevemar): If USER_DOMAIN_ID or USER_DOMAIN_NAME is present,"},{"line_number":102,"context_line":"        # then do not change the behaviour. Otherwise, set the USER_DOMAIN_ID"},{"line_number":103,"context_line":"        # to \u0027Default\u0027 for better usability."},{"line_number":104,"context_line":"        if (self._api_version.get(\u0027identity\u0027) \u003d\u003d \u00273\u0027 and"},{"line_number":105,"context_line":"            \u0027project_domain_id\u0027 in self._auth_params and"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_d4d2e9fb","line":102,"in_reply_to":"3a961159_143b919c","updated":"2015-01-16 05:29:02.000000000","message":"oops, you are right.","commit_id":"7a8e4092a303f8ca31bbfee9b6720d899fcb6145"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"baa8c1e2c54a9983ae43ddcd974e5c3b4bf7c944","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # to \u0027Default\u0027 for better usability."},{"line_number":104,"context_line":"        if (self._api_version.get(\u0027identity\u0027) \u003d\u003d \u00273\u0027 and"},{"line_number":105,"context_line":"            \u0027project_domain_id\u0027 in self._auth_params and"},{"line_number":106,"context_line":"                \u0027project_domain_name\u0027 in self._auth_params):"},{"line_number":107,"context_line":"            if (not self._auth_params.get(\u0027project_domain_id\u0027) and"},{"line_number":108,"context_line":"                    not self._auth_params.get(\u0027project_domain_name\u0027)):"},{"line_number":109,"context_line":"                self._auth_params[\u0027project_domain_id\u0027] \u003d \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_7472157d","line":106,"updated":"2015-01-16 05:10:33.000000000","message":"these two lines for checking if the key exists in dictionary seems unnecessary.  The means both keys need to be present in the dict?  \n\nJust using the \"not dict.get(\u0027key\u0027)\" should be good enough.","commit_id":"7a8e4092a303f8ca31bbfee9b6720d899fcb6145"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b6beeac18e6b88f46a3fdc004926b7c351fa4171","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        # to \u0027Default\u0027 for better usability."},{"line_number":104,"context_line":"        if (self._api_version.get(\u0027identity\u0027) \u003d\u003d \u00273\u0027 and"},{"line_number":105,"context_line":"            \u0027project_domain_id\u0027 in self._auth_params and"},{"line_number":106,"context_line":"                \u0027project_domain_name\u0027 in self._auth_params):"},{"line_number":107,"context_line":"            if (not self._auth_params.get(\u0027project_domain_id\u0027) and"},{"line_number":108,"context_line":"                    not self._auth_params.get(\u0027project_domain_name\u0027)):"},{"line_number":109,"context_line":"                self._auth_params[\u0027project_domain_id\u0027] \u003d \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_54fef96a","line":106,"in_reply_to":"3a961159_7472157d","updated":"2015-01-16 05:29:02.000000000","message":"Done","commit_id":"7a8e4092a303f8ca31bbfee9b6720d899fcb6145"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"baa8c1e2c54a9983ae43ddcd974e5c3b4bf7c944","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                \u0027project_domain_name\u0027 in self._auth_params):"},{"line_number":107,"context_line":"            if (not self._auth_params.get(\u0027project_domain_id\u0027) and"},{"line_number":108,"context_line":"                    not self._auth_params.get(\u0027project_domain_name\u0027)):"},{"line_number":109,"context_line":"                self._auth_params[\u0027project_domain_id\u0027] \u003d \u0027default\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # NOTE(stevemar): If PROJECT_DOMAIN_ID or PROJECT_DOMAIN_NAME is"},{"line_number":112,"context_line":"        # present, then do not change the behaviour. Otherwise, set the"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_1409d1dc","line":109,"updated":"2015-01-16 05:10:33.000000000","message":"Do we have a constant to store the default domain id?  I am thinking a configuration where the user uses a different default domain id, using a constant make it easier for them to change this.","commit_id":"7a8e4092a303f8ca31bbfee9b6720d899fcb6145"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b6beeac18e6b88f46a3fdc004926b7c351fa4171","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                \u0027project_domain_name\u0027 in self._auth_params):"},{"line_number":107,"context_line":"            if (not self._auth_params.get(\u0027project_domain_id\u0027) and"},{"line_number":108,"context_line":"                    not self._auth_params.get(\u0027project_domain_name\u0027)):"},{"line_number":109,"context_line":"                self._auth_params[\u0027project_domain_id\u0027] \u003d \u0027default\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        # NOTE(stevemar): If PROJECT_DOMAIN_ID or PROJECT_DOMAIN_NAME is"},{"line_number":112,"context_line":"        # present, then do not change the behaviour. Otherwise, set the"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_94f3019e","line":109,"in_reply_to":"3a961159_1409d1dc","updated":"2015-01-16 05:29:02.000000000","message":"good call, we could use the stuff defined here https://github.com/openstack/python-openstackclient/blob/master/openstackclient/shell.py#L221-L229","commit_id":"7a8e4092a303f8ca31bbfee9b6720d899fcb6145"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"baa8c1e2c54a9983ae43ddcd974e5c3b4bf7c944","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        # PROJECT_DOMAIN_ID to \u0027Default\u0027 for better usability."},{"line_number":114,"context_line":"        if (self._api_version.get(\u0027identity\u0027) \u003d\u003d \u00273\u0027 and"},{"line_number":115,"context_line":"            \u0027user_domain_id\u0027 in self._auth_params and"},{"line_number":116,"context_line":"                \u0027user_domain_name\u0027 in self._auth_params):"},{"line_number":117,"context_line":"            if (not self._auth_params.get(\u0027user_domain_id\u0027) and"},{"line_number":118,"context_line":"                    not self._auth_params.get(\u0027user_domain_name\u0027)):"},{"line_number":119,"context_line":"                self._auth_params[\u0027user_domain_id\u0027] \u003d \u0027default\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_340c0dec","line":116,"updated":"2015-01-16 05:10:33.000000000","message":"same comment here","commit_id":"7a8e4092a303f8ca31bbfee9b6720d899fcb6145"}]}