)]}'
{"openstackclient/identity/v2_0/service.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ccaede2542fe7c150156149fb05524ba87930645","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        )"},{"line_number":50,"context_line":"        type_or_name_group.add_argument("},{"line_number":51,"context_line":"            \u0027--name\u0027,"},{"line_number":52,"context_line":"            metavar\u003d\u0027\u003cservice-name\u003e\u0027,"},{"line_number":53,"context_line":"            help\u003d_(\u0027New service name\u0027),"},{"line_number":54,"context_line":"        )"},{"line_number":55,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_cb280e36","line":52,"updated":"2014-12-30 22:51:07.000000000","message":"This should be just \u0027\u003cname\u003e\u0027","commit_id":"1e166a9c50b3fc23bb0a0ae993b39886779047ff"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b1dc56e35e5c8bcb5bbb87083822b14083a1070d","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        type_or_name \u003d parsed_args.type_or_name"},{"line_number":67,"context_line":"        name \u003d parsed_args.name"},{"line_number":68,"context_line":"        type \u003d parsed_args.type"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # If only a single positional is present, it\u0027s a \u003ctype\u003e."},{"line_number":71,"context_line":"        # This is not currently legal so it is considered a new case."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_7738ecd4","line":68,"updated":"2014-12-30 07:43:56.000000000","message":"I can\u0027t remember, but do these get defaulted to None if they are not passed in?\n\nIf not, it might be best to default name and type to None, and check for them in the conditionals.","commit_id":"1e166a9c50b3fc23bb0a0ae993b39886779047ff"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"32ae04f139c4e0a96081f8812daec8f1d36c28a6","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        type_or_name \u003d parsed_args.type_or_name"},{"line_number":67,"context_line":"        name \u003d parsed_args.name"},{"line_number":68,"context_line":"        type \u003d parsed_args.type"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # If only a single positional is present, it\u0027s a \u003ctype\u003e."},{"line_number":71,"context_line":"        # This is not currently legal so it is considered a new case."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_5745b015","line":68,"in_reply_to":"3a961159_7738ecd4","updated":"2014-12-30 08:02:33.000000000","message":"If the args are not passed in, it does get defaulted to None.  The test case actually covers that.","commit_id":"1e166a9c50b3fc23bb0a0ae993b39886779047ff"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b1dc56e35e5c8bcb5bbb87083822b14083a1070d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            type \u003d type_or_name"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        service \u003d identity_client.services.create("},{"line_number":86,"context_line":"            name,"},{"line_number":87,"context_line":"            type,"},{"line_number":88,"context_line":"            parsed_args.description)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_1751680e","line":86,"updated":"2014-12-30 07:43:56.000000000","message":"basically, i\u0027m just wondering what the value of name is here?\n\nif we just sent in 1 positional argument then that\u0027s the type, but we\u0027re passing in the value of parsed_args.name here, as long as it\u0027s None then it\u0027s okay.","commit_id":"1e166a9c50b3fc23bb0a0ae993b39886779047ff"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"32ae04f139c4e0a96081f8812daec8f1d36c28a6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            type \u003d type_or_name"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        service \u003d identity_client.services.create("},{"line_number":86,"context_line":"            name,"},{"line_number":87,"context_line":"            type,"},{"line_number":88,"context_line":"            parsed_args.description)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_d750c0d6","line":86,"in_reply_to":"3a961159_1751680e","updated":"2014-12-30 08:02:33.000000000","message":"Yes, that would be None for the case where passing one argument only. Also, covered in one of the new test case :)","commit_id":"1e166a9c50b3fc23bb0a0ae993b39886779047ff"}]}