)]}'
{"openstackclient/volume/v1/volume.py":[{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"fffc70341ddee2e0712d3b7128c1deb65921b278","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            for attachment in attachments:"},{"line_number":236,"context_line":"                server \u003d attachment[\u0027server_id\u0027]"},{"line_number":237,"context_line":"                if server in server_cache.keys():"},{"line_number":238,"context_line":"                    server \u003d server_cache[server].name"},{"line_number":239,"context_line":"                device \u003d attachment[\u0027device\u0027]"},{"line_number":240,"context_line":"                msg +\u003d \u0027Attached to %s on %s \u0027 % (server, device)"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a0519763","line":238,"updated":"2014-12-23 02:01:59.000000000","message":"I prefer to use server.id, because many servers can have the same name.","commit_id":"71d9c8b5b343011bb0c9d90dab9cb75510d4c618"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"8b2cc2adf8b7f7e9963389d9e62f61a0be739a92","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            for attachment in attachments:"},{"line_number":236,"context_line":"                server \u003d attachment[\u0027server_id\u0027]"},{"line_number":237,"context_line":"                if server in server_cache.keys():"},{"line_number":238,"context_line":"                    server \u003d server_cache[server].name"},{"line_number":239,"context_line":"                device \u003d attachment[\u0027device\u0027]"},{"line_number":240,"context_line":"                msg +\u003d \u0027Attached to %s on %s \u0027 % (server, device)"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_afeb4311","line":238,"in_reply_to":"3a961159_4c6aed1a","updated":"2014-12-23 06:33:30.000000000","message":"Need to see the opinions of others.","commit_id":"71d9c8b5b343011bb0c9d90dab9cb75510d4c618"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"77b254ed4cfcef5482bcd14dee5d31c82bd608a6","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            for attachment in attachments:"},{"line_number":236,"context_line":"                server \u003d attachment[\u0027server_id\u0027]"},{"line_number":237,"context_line":"                if server in server_cache.keys():"},{"line_number":238,"context_line":"                    server \u003d server_cache[server].name"},{"line_number":239,"context_line":"                device \u003d attachment[\u0027device\u0027]"},{"line_number":240,"context_line":"                msg +\u003d \u0027Attached to %s on %s \u0027 % (server, device)"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_013a2e34","line":238,"in_reply_to":"3a961159_62395ba3","updated":"2014-12-26 08:30:30.000000000","message":"maybe, that does like a good idea for the future, but out of scope for this patch :)","commit_id":"71d9c8b5b343011bb0c9d90dab9cb75510d4c618"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"de3234f457aeff7cb6fdd09e0e493ecb8ecd9004","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            for attachment in attachments:"},{"line_number":236,"context_line":"                server \u003d attachment[\u0027server_id\u0027]"},{"line_number":237,"context_line":"                if server in server_cache.keys():"},{"line_number":238,"context_line":"                    server \u003d server_cache[server].name"},{"line_number":239,"context_line":"                device \u003d attachment[\u0027device\u0027]"},{"line_number":240,"context_line":"                msg +\u003d \u0027Attached to %s on %s \u0027 % (server, device)"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4c6aed1a","line":238,"in_reply_to":"3a961159_a0519763","updated":"2014-12-23 05:54:59.000000000","message":"I did it this way because I noticed that\u0027s how it was in Horizon. So I\u0027m undecided on this one, I think from a UX perspective showing the name is nicer. \n\nNote that if the cache fails, the ID appears anyway.","commit_id":"71d9c8b5b343011bb0c9d90dab9cb75510d4c618"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"da0327788c29479227ed1f4cc3d3bfff8217f5b6","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            for attachment in attachments:"},{"line_number":236,"context_line":"                server \u003d attachment[\u0027server_id\u0027]"},{"line_number":237,"context_line":"                if server in server_cache.keys():"},{"line_number":238,"context_line":"                    server \u003d server_cache[server].name"},{"line_number":239,"context_line":"                device \u003d attachment[\u0027device\u0027]"},{"line_number":240,"context_line":"                msg +\u003d \u0027Attached to %s on %s \u0027 % (server, device)"},{"line_number":241,"context_line":"            return msg"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_62395ba3","line":238,"in_reply_to":"3a961159_afeb4311","updated":"2014-12-23 21:50:46.000000000","message":"I really prefer using names, I know they are not unique but in most cases are preferable.  Maybe we need to consider a global -n flag similar to many UNIX commands to display numeric rather than test output?","commit_id":"71d9c8b5b343011bb0c9d90dab9cb75510d4c618"}]}