)]}'
{"id":"openstack%2Fpython-openstackclient~144857","triplet_id":"openstack%2Fpython-openstackclient~master~I3dd686ef02a2e21e2049a49cb55634385c2ecfaf","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1406737","hashtags":[],"change_id":"I3dd686ef02a2e21e2049a49cb55634385c2ecfaf","subject":"Check if service.name available before access","status":"MERGED","created":"2015-01-04 03:36:21.000000000","updated":"2015-01-15 07:34:39.000000000","submitted":"2015-01-15 07:34:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1d859dac57ec61ff1c9586135cd3d462636f63a8","_number":144857,"virtual_id_number":144857,"owner":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-01-04 04:41:37.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-01-15 07:34:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-01-04 22:15:38.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2015-01-04 06:47:44.000000000","_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-01-15 06:42:36.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":2,"date":"2015-01-15 06:46:53.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2015-01-15 06:46:53.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-04 04:41:37.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-01-04 22:15:38.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-01-15 06:46:53.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-01-15 07:34:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a9d09599dc5cbecacf5e41c24ab039d70fc91484","author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"date":"2015-01-04 03:36:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"86d8c655c904616972aa46ba2b28313ba65f8b0a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-04 04:11:39.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/57/144857/1/check/gate-python-openstackclient-python26/4bfc9e2/ : SUCCESS in 1m 11s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/57/144857/1/check/gate-python-openstackclient-pep8/3b6de5d/ : SUCCESS in 58s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/57/144857/1/check/gate-python-openstackclient-docs/96887e4//doc/build/html/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python27 http://logs.openstack.org/57/144857/1/check/gate-python-openstackclient-python27/add929e/ : FAILURE in 1m 24s\n- gate-python-openstackclient-python33 http://logs.openstack.org/57/144857/1/check/gate-python-openstackclient-python33/757f099/ : SUCCESS in 2m 30s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse http://logs.openstack.org/57/144857/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse/334a153/ : SUCCESS in 30m 27s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-juno http://logs.openstack.org/57/144857/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-juno/1c298fa/ : SUCCESS in 35m 16s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/57/144857/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/a2ae8c8/ : SUCCESS in 29m 59s\n- check-osc-dsvm-functional http://logs.openstack.org/57/144857/1/check/check-osc-dsvm-functional/f1e8892/ : SUCCESS in 22m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e53e925a829b90ec5ffaf8c4cff35c1454c3c850","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-01-04 04:41:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e02b9b6b6b32c77fd2a41e989bd79f14a537bf56","author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"date":"2015-01-04 06:47:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4bfcf48b1c2aa4658c3e95f611a36c7078871b4a","author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"date":"2015-01-04 09:14:00.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"3b79f40bf1dd78efa7ca7c56c31bc0119d46a9c3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-04 09:47:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/57/144857/1/check/gate-python-openstackclient-python26/bc7f8bb/ : SUCCESS in 1m 07s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/57/144857/1/check/gate-python-openstackclient-pep8/6dedba7/ : SUCCESS in 1m 07s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/57/144857/1/check/gate-python-openstackclient-docs/84b247b//doc/build/html/ : SUCCESS in 1m 31s\n- gate-python-openstackclient-python27 http://logs.openstack.org/57/144857/1/check/gate-python-openstackclient-python27/89b0a1e/ : SUCCESS in 1m 07s\n- gate-python-openstackclient-python33 http://logs.openstack.org/57/144857/1/check/gate-python-openstackclient-python33/82a4e46/ : SUCCESS in 2m 31s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse http://logs.openstack.org/57/144857/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse/3b50f15/ : SUCCESS in 29m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-juno http://logs.openstack.org/57/144857/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-juno/6d73e2a/ : SUCCESS in 23m 09s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/57/144857/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/72fbddc/ : SUCCESS in 32m 58s\n- check-osc-dsvm-functional http://logs.openstack.org/57/144857/1/check/check-osc-dsvm-functional/b8ef3c3/ : SUCCESS in 14m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e298a2cf0732e93f56003ad7192aa4f8fd9303a9","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-01-04 22:15:38.000000000","message":"Patch Set 1:\n\nActually, this patch may not be needed anymore. \n\nI have a patch up for review to make keystone always return a service name attribute: https://review.openstack.org/#/c/135808/","accounts_in_message":[],"_revision_number":1},{"id":"a756d4ba4a1ae11d30c61003d70c9be5ab4788ba","author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"date":"2015-01-05 03:31:14.000000000","message":"Patch Set 1:\n\n@Lin Hua Cheng, In case that your current patch only handles catalog retrieve, this patch is still needed. Endpoint commands will obtain service directly from backend so the name attribute may be missing.","accounts_in_message":[],"_revision_number":1},{"id":"d2b4f0263ff9133d5b314b544ee890873542a2fd","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-01-15 02:45:04.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n@Zhiyuan: You\u0027re right, this is still needed as the still doesn\u0027t cover all cases.","accounts_in_message":[],"_revision_number":1},{"id":"4d1696ebbc1a42da174477b2e5c021db5fdbe5ac","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-01-15 06:42:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9ab2857841c709e9cf160a73abc2e62dd4268b90","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-15 06:46:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d260e5dfaf5851f729f8c8468e96ffe166796fbe","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-01-15 06:46:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"10fb6f18d020aabddfeaca684323d6ede6c56d89","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-15 07:34:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/57/144857/1/gate/gate-python-openstackclient-python26/c95817c/ : SUCCESS in 1m 15s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/57/144857/1/gate/gate-python-openstackclient-docs/3b4928d//doc/build/html/ : SUCCESS in 1m 56s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/57/144857/1/gate/gate-python-openstackclient-pep8/80bbb9d/ : SUCCESS in 1m 13s\n- gate-python-openstackclient-python27 http://logs.openstack.org/57/144857/1/gate/gate-python-openstackclient-python27/fc3784d/ : SUCCESS in 1m 39s\n- gate-python-openstackclient-python33 http://logs.openstack.org/57/144857/1/gate/gate-python-openstackclient-python33/2a899ed/ : SUCCESS in 2m 33s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/57/144857/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/867a881/ : SUCCESS in 47m 41s\n- gate-osc-dsvm-functional http://logs.openstack.org/57/144857/1/gate/gate-osc-dsvm-functional/a0ba1fb/ : SUCCESS in 17m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0668ecaa42a8246b23614ce963a019c39f55b065","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-15 07:34:39.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"369ae3f9f06c90e8d57b71befa6bc22a843c2f7d","revisions":{"369ae3f9f06c90e8d57b71befa6bc22a843c2f7d":{"kind":"REWORK","_number":1,"created":"2015-01-04 03:36:21.000000000","uploader":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"ref":"refs/changes/57/144857/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/144857/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/144857/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/144857/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/144857/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/144857/1"}}},"commit":{"parents":[{"commit":"cbb26724fccdbbb76913a8f2994768dea3046480","subject":"Merge \"Command docs: group\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cbb26724fccdbbb76913a8f2994768dea3046480"}]}],"author":{"name":"zhiyuan_cai","email":"luckyvega.g@gmail.com","date":"2015-01-04 03:26:18.000000000","tz":480},"committer":{"name":"zhiyuan_cai","email":"luckyvega.g@gmail.com","date":"2015-01-04 03:26:18.000000000","tz":480},"subject":"Check if service.name available before access","message":"Check if service.name available before access\n\nCurrently v3 endpoint commands access service.name directly, while\nname is not a required attribute of service. So if we associate an\nendpoint to a service without name, we will get an AttributeError\nexecuting v3 endpoint commands later. This patch addresses this\nissue by checking if service.name is available before accessing it.\n\nChange-Id: I3dd686ef02a2e21e2049a49cb55634385c2ecfaf\nCloses-Bug: #1406737\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/369ae3f9f06c90e8d57b71befa6bc22a843c2f7d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/369ae3f9f06c90e8d57b71befa6bc22a843c2f7d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}