)]}'
{"id":"openstack%2Fpython-openstackclient~146371","triplet_id":"openstack%2Fpython-openstackclient~master~I9fce66677affa396b6a12afea76e87cab9215a58","project":"openstack/python-openstackclient","branch":"master","topic":"catalog_show","hashtags":[],"change_id":"I9fce66677affa396b6a12afea76e87cab9215a58","subject":"fix some small issues in catalog show","status":"MERGED","created":"2015-01-12 04:54:33.000000000","updated":"2015-01-12 18:14:44.000000000","submitted":"2015-01-12 18:14:44.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d683306ea09cedd6c3a0aa08509742e38eb8ddb6","_number":146371,"virtual_id_number":146371,"owner":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-01-12 18:14:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2015-01-12 06:07:42.000000000","_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-01-12 05:43:35.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-01-12 16:27:54.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-01-12 16:27:54.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-12 05:43:35.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-01-12 16:27:54.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-01-12 18:14:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5f615db221ff0f94f7712a84a417bfb715c4a95b","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2015-01-12 04:54:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8e808f0dcbeb734ad680a85565a87769c978f68a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-12 05:28:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/71/146371/1/check/gate-python-openstackclient-python26/3c03bda/ : SUCCESS in 1m 10s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/71/146371/1/check/gate-python-openstackclient-pep8/0bdac18/ : SUCCESS in 1m 07s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/71/146371/1/check/gate-python-openstackclient-docs/db38506//doc/build/html/ : SUCCESS in 1m 38s\n- gate-python-openstackclient-python27 http://logs.openstack.org/71/146371/1/check/gate-python-openstackclient-python27/dbf6cfd/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-python33 http://logs.openstack.org/71/146371/1/check/gate-python-openstackclient-python33/f1f2aac/ : SUCCESS in 2m 22s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse http://logs.openstack.org/71/146371/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse/a0b755e/ : SUCCESS in 26m 31s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-juno http://logs.openstack.org/71/146371/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-juno/7c8fe50/ : SUCCESS in 27m 33s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/71/146371/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/b4087c6/ : FAILURE in 34m 23s\n- check-osc-dsvm-functional http://logs.openstack.org/71/146371/1/check/check-osc-dsvm-functional/be76396/ : SUCCESS in 17m 12s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a6f68f886c1c83f76863e95f852b6cb26c3eca5b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-01-12 05:43:35.000000000","message":"Patch Set 1: Code-Review+2\n\nadding dtroyer","accounts_in_message":[],"_revision_number":1},{"id":"6b51f923aaadd680ebc276b8c5c0dbb5dd483161","author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"date":"2015-01-12 06:07:42.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"42ac05984f1445d3a225d35bfb1390af1b0b36f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-12 06:48:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/71/146371/1/check/gate-python-openstackclient-python26/f5764fd/ : SUCCESS in 1m 31s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/71/146371/1/check/gate-python-openstackclient-pep8/651b5bc/ : SUCCESS in 1m 25s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/71/146371/1/check/gate-python-openstackclient-docs/ddc62bf//doc/build/html/ : SUCCESS in 2m 06s\n- gate-python-openstackclient-python27 http://logs.openstack.org/71/146371/1/check/gate-python-openstackclient-python27/a8b7ae4/ : SUCCESS in 1m 40s\n- gate-python-openstackclient-python33 http://logs.openstack.org/71/146371/1/check/gate-python-openstackclient-python33/ea7b84d/ : SUCCESS in 2m 16s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse http://logs.openstack.org/71/146371/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse/c936dc7/ : SUCCESS in 25m 57s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-juno http://logs.openstack.org/71/146371/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-juno/08ad23e/ : SUCCESS in 31m 13s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/71/146371/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/3e35965/ : SUCCESS in 34m 35s\n- check-osc-dsvm-functional http://logs.openstack.org/71/146371/1/check/check-osc-dsvm-functional/1999908/ : SUCCESS in 13m 55s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e08cfbac9e0dcf5994730a74fe2f334772c21615","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-01-12 16:27:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c18890c4deb299c7ac9e1be1d3d7f01715342ef8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-12 16:27:55.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d5e718da6cfc57fdf2c48ee869a04c45e8fa075b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-12 18:14:44.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/71/146371/1/gate/gate-python-openstackclient-python26/bb2dcb3/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/71/146371/1/gate/gate-python-openstackclient-docs/759b1fd//doc/build/html/ : SUCCESS in 2m 10s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/71/146371/1/gate/gate-python-openstackclient-pep8/549e998/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-python27 http://logs.openstack.org/71/146371/1/gate/gate-python-openstackclient-python27/58136b4/ : SUCCESS in 1m 23s\n- gate-python-openstackclient-python33 http://logs.openstack.org/71/146371/1/gate/gate-python-openstackclient-python33/b1c2c1e/ : SUCCESS in 2m 27s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/71/146371/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/a519c67/ : SUCCESS in 35m 14s\n- gate-osc-dsvm-functional http://logs.openstack.org/71/146371/1/gate/gate-osc-dsvm-functional/2fd918d/ : SUCCESS in 14m 56s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"633c6c736a4645c648c2fcf980d63608ae758ef3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-12 18:14:44.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a8f60a8aa1c8cbbf0d1384131854a422705e7c78","revisions":{"a8f60a8aa1c8cbbf0d1384131854a422705e7c78":{"kind":"REWORK","_number":1,"created":"2015-01-12 04:54:33.000000000","uploader":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"ref":"refs/changes/71/146371/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/71/146371/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/146371/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/146371/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/71/146371/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/71/146371/1"}}},"commit":{"parents":[{"commit":"d2943d2592b2de98a59c44445c5cd2cc564740da","subject":"Command doc: access token","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d2943d2592b2de98a59c44445c5cd2cc564740da"}]}],"author":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2015-01-12 04:08:43.000000000","tz":480},"committer":{"name":"wanghong","email":"w.wanghong@huawei.com","date":"2015-01-12 04:08:43.000000000","tz":480},"subject":"fix some small issues in catalog show","message":"fix some small issues in catalog show\n\nI think there are three issues we should fix:\n1. wrong indentation of \u0027continue\u0027\n2. currently, name is optional for service, but according to the\n   currrent logic, if a service doesn\u0027t have name attribute we will\n   select it anyway\n3. we always loop all catalogs\n\nChange-Id: I9fce66677affa396b6a12afea76e87cab9215a58\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a8f60a8aa1c8cbbf0d1384131854a422705e7c78"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a8f60a8aa1c8cbbf0d1384131854a422705e7c78"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}