)]}'
{"doc/source/command-objects/volume.rst":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"8022d79fb063e793ab0459ff4f30e7d16fb22da6","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. option:: --size \u003csize\u003e"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    New volume size"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_66728212","line":151,"updated":"2015-01-26 17:58:13.000000000","message":"need units specified","commit_id":"fa79bb4a8077e62f88ba994752ec8059cc257bda"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"da5308ade615127fddbd1db0fd6093cda096286a","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. option:: --size \u003csize\u003e"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    New volume size"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_21a84d8c","line":151,"in_reply_to":"1a930d6b_5cae2499","updated":"2015-01-27 07:09:59.000000000","message":"Done","commit_id":"fa79bb4a8077e62f88ba994752ec8059cc257bda"},{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"b377f998562417825e530f9b558950becfd7ea1d","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. option:: --size \u003csize\u003e"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    New volume size"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a930d6b_5cae2499","line":151,"in_reply_to":"1a930d6b_66728212","updated":"2015-01-27 01:58:01.000000000","message":"++","commit_id":"fa79bb4a8077e62f88ba994752ec8059cc257bda"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f9ddebaf5d975f4a3b01ae83f367170d9d3614ee","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. option:: --size \u003csize\u003e"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    New volume size in GB"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a930d6b_f9c17e80","line":151,"updated":"2015-01-27 18:04:13.000000000","message":"I wonder if it would be more descriptive if we use \"Extend volume size in GB\", would be more obvious to the user that they need to give a size larger than the current one.","commit_id":"49031e4d8547065719b1adab60dc0700155bcf61"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a13a8972674399a2c32f99f525fd29d8a44d1fc3","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. option:: --size \u003csize\u003e"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    New volume size in GB"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa81d914_b06e2095","line":151,"in_reply_to":"1a930d6b_f9c17e80","updated":"2015-01-27 19:15:49.000000000","message":"Done","commit_id":"49031e4d8547065719b1adab60dc0700155bcf61"}],"openstackclient/volume/v1/volume.py":[{"author":{"_account_id":9101,"name":"wanghong","email":"reviewwanghong@126.com","username":"wanghong"},"change_message_id":"b377f998562417825e530f9b558950becfd7ea1d","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        volume \u003d utils.find_resource(volume_client.volumes, parsed_args.volume)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        if parsed_args.size:"},{"line_number":351,"context_line":"            if parsed_args.size \u003c volume.size:"},{"line_number":352,"context_line":"                self.app.log.error(\"Cannot shrink a volume\")"},{"line_number":353,"context_line":"                return"},{"line_number":354,"context_line":"            volume_client.volumes.extend(volume.id, parsed_args.size)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_bcf0e8c9","line":351,"updated":"2015-01-27 01:58:01.000000000","message":"I think this should be \u003c\u003d, and should we check the status of volume? https://github.com/openstack/cinder/blob/master/cinder/volume/api.py","commit_id":"fa79bb4a8077e62f88ba994752ec8059cc257bda"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"da5308ade615127fddbd1db0fd6093cda096286a","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        volume \u003d utils.find_resource(volume_client.volumes, parsed_args.volume)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        if parsed_args.size:"},{"line_number":351,"context_line":"            if parsed_args.size \u003c volume.size:"},{"line_number":352,"context_line":"                self.app.log.error(\"Cannot shrink a volume\")"},{"line_number":353,"context_line":"                return"},{"line_number":354,"context_line":"            volume_client.volumes.extend(volume.id, parsed_args.size)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a930d6b_41b0f9dc","line":351,"in_reply_to":"1a930d6b_bcf0e8c9","updated":"2015-01-27 07:09:59.000000000","message":"i did the first part, the other part is getting into too many combinations, (we could add --force), may as well let the server side error come up","commit_id":"fa79bb4a8077e62f88ba994752ec8059cc257bda"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f9ddebaf5d975f4a3b01ae83f367170d9d3614ee","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        if parsed_args.size:"},{"line_number":351,"context_line":"            if parsed_args.size \u003c\u003d volume.size:"},{"line_number":352,"context_line":"                self.app.log.error(\"Cannot shrink a volume\")"},{"line_number":353,"context_line":"                return"},{"line_number":354,"context_line":"            volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_59bd32d7","line":352,"updated":"2015-01-27 18:04:13.000000000","message":"Since we already have the current size here, it would nice to display it to the user. This way, they know what size to adjust it to.  \n\nSomething like \"New size must be greater than %volume_size GB\".","commit_id":"49031e4d8547065719b1adab60dc0700155bcf61"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a13a8972674399a2c32f99f525fd29d8a44d1fc3","unresolved":false,"context_lines":[{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        if parsed_args.size:"},{"line_number":351,"context_line":"            if parsed_args.size \u003c\u003d volume.size:"},{"line_number":352,"context_line":"                self.app.log.error(\"Cannot shrink a volume\")"},{"line_number":353,"context_line":"                return"},{"line_number":354,"context_line":"            volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_b078e02c","line":352,"in_reply_to":"1a930d6b_59bd32d7","updated":"2015-01-27 19:15:49.000000000","message":"Done","commit_id":"49031e4d8547065719b1adab60dc0700155bcf61"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f9ddebaf5d975f4a3b01ae83f367170d9d3614ee","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            if parsed_args.size \u003c\u003d volume.size:"},{"line_number":352,"context_line":"                self.app.log.error(\"Cannot shrink a volume\")"},{"line_number":353,"context_line":"                return"},{"line_number":354,"context_line":"            volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if parsed_args.property:"},{"line_number":357,"context_line":"            volume_client.volumes.set_metadata(volume.id, parsed_args.property)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a930d6b_99aa3a83","line":354,"updated":"2015-01-27 18:04:13.000000000","message":"What happens if the volume extend causes the quota to get exceeded, not sure if we want to do quota check or have cinder just return an error.","commit_id":"49031e4d8547065719b1adab60dc0700155bcf61"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a13a8972674399a2c32f99f525fd29d8a44d1fc3","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            if parsed_args.size \u003c\u003d volume.size:"},{"line_number":352,"context_line":"                self.app.log.error(\"Cannot shrink a volume\")"},{"line_number":353,"context_line":"                return"},{"line_number":354,"context_line":"            volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if parsed_args.property:"},{"line_number":357,"context_line":"            volume_client.volumes.set_metadata(volume.id, parsed_args.property)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_10a1aca9","line":354,"in_reply_to":"1a930d6b_99aa3a83","updated":"2015-01-27 19:15:49.000000000","message":"file a new bug for this please, and mention checking for status there too.","commit_id":"49031e4d8547065719b1adab60dc0700155bcf61"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"1bae3cd005986cd392f6f99d595663252875754c","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            if parsed_args.size \u003c\u003d volume.size:"},{"line_number":352,"context_line":"                self.app.log.error(\"Cannot shrink a volume\")"},{"line_number":353,"context_line":"                return"},{"line_number":354,"context_line":"            volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if parsed_args.property:"},{"line_number":357,"context_line":"            volume_client.volumes.set_metadata(volume.id, parsed_args.property)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa81d914_f3ed02f1","line":354,"in_reply_to":"fa81d914_10a1aca9","updated":"2015-01-27 19:42:48.000000000","message":"opened: https://bugs.launchpad.net/python-openstackclient/+bug/1415182","commit_id":"49031e4d8547065719b1adab60dc0700155bcf61"}]}