)]}'
{"id":"openstack%2Fpython-openstackclient~152919","triplet_id":"openstack%2Fpython-openstackclient~master~I97fc9dab97d549093cabd965cab0736b2c748084","project":"openstack/python-openstackclient","branch":"master","topic":"novaclient","hashtags":[],"change_id":"I97fc9dab97d549093cabd965cab0736b2c748084","subject":"Remove versioning import of novaclient","status":"ABANDONED","created":"2015-02-04 14:34:04.000000000","updated":"2015-03-04 09:20:55.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"68a9dad1ed76735eddea77226f0bef0b411e36eb","_number":152919,"virtual_id_number":152919,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2015-03-04 04:04:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14485,"name":"Igor Bolotin","email":"igor_bolotin@symantec.com","username":"ibolotin"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14485,"name":"Igor Bolotin","email":"igor_bolotin@symantec.com","username":"ibolotin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14485,"name":"Igor Bolotin","email":"igor_bolotin@symantec.com","username":"ibolotin"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":14485,"name":"Igor Bolotin","email":"igor_bolotin@symantec.com","username":"ibolotin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-02-06 16:08:54.000000000","updated_by":{"_account_id":14485,"name":"Igor Bolotin","email":"igor_bolotin@symantec.com","username":"ibolotin"},"reviewer":{"_account_id":14485,"name":"Igor Bolotin","email":"igor_bolotin@symantec.com","username":"ibolotin"},"state":"REVIEWER"},{"updated":"2015-02-06 22:57:05.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-03-04 04:04:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0b03800bd686d45480cea7f017146da1d09f57a8","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-02-04 14:34:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"738603130e084b43381cb0a129da8ab484a71b0e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 15:21:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/19/152919/1/check/gate-python-openstackclient-python26/2930435/ : SUCCESS in 1m 12s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/19/152919/1/check/gate-python-openstackclient-pep8/c93af5e/ : FAILURE in 1m 08s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/19/152919/1/check/gate-python-openstackclient-docs/6dda1c8//doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-openstackclient-python27 http://logs.openstack.org/19/152919/1/check/gate-python-openstackclient-python27/8b21556/ : SUCCESS in 1m 15s\n- gate-python-openstackclient-python34 http://logs.openstack.org/19/152919/1/check/gate-python-openstackclient-python34/41b1c66/ : SUCCESS in 2m 38s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse http://logs.openstack.org/19/152919/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse/3275957/ : FAILURE in 9m 47s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-juno http://logs.openstack.org/19/152919/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-juno/45033d1/ : SUCCESS in 39m 21s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/19/152919/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/308a46b/ : SUCCESS in 34m 11s\n- check-osc-dsvm-functional http://logs.openstack.org/19/152919/1/check/check-osc-dsvm-functional/5795b89/ : SUCCESS in 17m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d15ea603bfc572a877bb2c63c58addaa6d96bfd6","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-02-04 15:24:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"94ed41d7687189330d092f3dea11d80e3e2c8545","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-04 16:09:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/19/152919/2/check/gate-python-openstackclient-python26/89ba9f3/ : SUCCESS in 1m 09s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/19/152919/2/check/gate-python-openstackclient-pep8/cc376f4/ : SUCCESS in 1m 02s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/19/152919/2/check/gate-python-openstackclient-docs/31f2374//doc/build/html/ : SUCCESS in 2m 11s\n- gate-python-openstackclient-python27 http://logs.openstack.org/19/152919/2/check/gate-python-openstackclient-python27/4e80405/ : SUCCESS in 1m 31s\n- gate-python-openstackclient-python34 http://logs.openstack.org/19/152919/2/check/gate-python-openstackclient-python34/e4fb2e8/ : SUCCESS in 3m 29s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse http://logs.openstack.org/19/152919/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse/9898b35/ : SUCCESS in 25m 58s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-juno http://logs.openstack.org/19/152919/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-juno/171df77/ : SUCCESS in 29m 33s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/19/152919/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/cb19c54/ : SUCCESS in 36m 44s\n- check-osc-dsvm-functional http://logs.openstack.org/19/152919/2/check/check-osc-dsvm-functional/73c43a3/ : SUCCESS in 13m 46s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"880995bafae465b954839f1e824bae6dce680508","author":{"_account_id":14485,"name":"Igor Bolotin","email":"igor_bolotin@symantec.com","username":"ibolotin"},"date":"2015-02-06 16:08:54.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"1d9cf20a752444fa4a5e83cee51dace20fe93127","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-02-06 22:57:05.000000000","message":"Patch Set 2: Code-Review-1\n\nI am not ready to do this, I want clean control over versioning in OSC while novaclient goes through its growing pains.","accounts_in_message":[],"_revision_number":2},{"id":"aafe7bb897a8c06594be44226aa4c4e032e89356","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-02-07 01:07:46.000000000","message":"Patch Set 2:\n\n@Dean, I understand that you want full versioning control, but we should find another way to implement it.\n\nLatest novaclient support a hack for v1.1 which allow to import novaclient.v1_1 module, but someday it will be removed.\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v1_1/__init__.py\n\nAlso, latest novaclient will support compute api microversioning and version parser will be implemented in novaclient.client(you can find some example of it here - https://review.openstack.org/#/c/152569/6/novaclient/client.py ). Do you want to implement the same in OSC?\n\nWhat you think about keep API_VERSIONS dict, but values will be changed to versions, which will be transmitted in novaclient.client.Client? On the one hand, it will allow to continue support api_version\u003d\u003d1, which is no longer maintained in novaclient. On the other hand, this way allows to use common interface of novaclient.","accounts_in_message":[],"_revision_number":2},{"id":"41092bcfb87ee9ddd8ae64f9188eb5d5986b005c","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-02-11 16:27:04.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"18596a01e4d359e72e8b660b786d6392c3d6f5c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-02-11 17:30:53.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-python26 http://logs.openstack.org/19/152919/3/check/gate-python-openstackclient-python26/94ca5fd/ : SUCCESS in 1m 07s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/19/152919/3/check/gate-python-openstackclient-pep8/dfa5168/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/19/152919/3/check/gate-python-openstackclient-docs/694d313//doc/build/html/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-python27 http://logs.openstack.org/19/152919/3/check/gate-python-openstackclient-python27/2e8ccef/ : SUCCESS in 1m 06s\n- gate-python-openstackclient-python34 http://logs.openstack.org/19/152919/3/check/gate-python-openstackclient-python34/9baffa4/ : SUCCESS in 2m 50s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse http://logs.openstack.org/19/152919/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient-icehouse/901d386/ : SUCCESS in 28m 05s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-juno http://logs.openstack.org/19/152919/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient-juno/d67d96d/ : SUCCESS in 24m 49s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/19/152919/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/a8bb1e5/ : SUCCESS in 49m 29s\n- check-osc-dsvm-functional http://logs.openstack.org/19/152919/3/check/check-osc-dsvm-functional/6fa36f2/ : SUCCESS in 18m 52s","accounts_in_message":[],"_revision_number":3},{"id":"5776070d853aefc5e143b3f9b1751ec1db625d64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-04 04:04:31.000000000","message":"Patch Set 3: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"6e73533ac64d800df419d3d75add2a9e4c2ba66d","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2015-03-04 09:20:55.000000000","message":"Abandoned\n\nalready fixed by https://review.openstack.org/#/c/160473/","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0cadc68e3b120baeb3507923d6fa3fb990d82f19","revisions":{"a54b58f40c0ea3bcc440087f7058c1f356d07e23":{"kind":"REWORK","_number":1,"created":"2015-02-04 14:34:04.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/19/152919/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/19/152919/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/1"}}},"commit":{"parents":[{"commit":"0cc3955f0aedab76313aa09edd3f31bb9d08b55d","subject":"tenant_id to project_id in server show","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0cc3955f0aedab76313aa09edd3f31bb9d08b55d"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-02-04 14:30:42.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-02-04 14:33:53.000000000","tz":120},"subject":"Remove versioning import of novaclient","message":"Remove versioning import of novaclient\n\nnovaclient has specific function novaclient.client.get_client_class for\nobtaining client class. This fuction should be used instead of custom\nopemstackclient.common.get_client_class, because several reasons:\n - novaclient will have to change some versioning stuff\n   (see https://review.openstack.org/#/c/149006/ for more details)\n - some api microversioning stuff will vbe implemented there\n\nAlso, since contrib path dependends on version, we should get it based on\nversioned client class or object.\n\nChange-Id: I97fc9dab97d549093cabd965cab0736b2c748084\nCloses-Bug: #1418024\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a54b58f40c0ea3bcc440087f7058c1f356d07e23"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a54b58f40c0ea3bcc440087f7058c1f356d07e23"}]},"branch":"refs/heads/master"},"a20c063d9ae7fa5100045d66dc46c0f9a98e2141":{"kind":"REWORK","_number":2,"created":"2015-02-04 15:24:40.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/19/152919/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/19/152919/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/2"}}},"commit":{"parents":[{"commit":"0cc3955f0aedab76313aa09edd3f31bb9d08b55d","subject":"tenant_id to project_id in server show","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0cc3955f0aedab76313aa09edd3f31bb9d08b55d"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-02-04 14:30:42.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-02-04 15:24:24.000000000","tz":120},"subject":"Remove versioning import of novaclient","message":"Remove versioning import of novaclient\n\nnovaclient has specific function novaclient.client.get_client_class for\nobtaining client class. This fuction should be used instead of custom\nopemstackclient.common.get_client_class, because several reasons:\n - novaclient will have to change some versioning stuff\n   (see https://review.openstack.org/#/c/149006/ for more details)\n - some api microversioning stuff will vbe implemented there\n\nAlso, since contrib path dependends on version, we should get it based on\nversioned client class or object.\n\nChange-Id: I97fc9dab97d549093cabd965cab0736b2c748084\nCloses-Bug: #1418024\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a20c063d9ae7fa5100045d66dc46c0f9a98e2141"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a20c063d9ae7fa5100045d66dc46c0f9a98e2141"}]},"branch":"refs/heads/master"},"0cadc68e3b120baeb3507923d6fa3fb990d82f19":{"kind":"REWORK","_number":3,"created":"2015-02-11 16:27:04.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/19/152919/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/19/152919/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/19/152919/3"}}},"commit":{"parents":[{"commit":"9400effd4b7653045657630e0909b3dc303ec59e","subject":"Merge \"Restrict groups and users from changing domains\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9400effd4b7653045657630e0909b3dc303ec59e"}]}],"author":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-02-04 14:30:42.000000000","tz":120},"committer":{"name":"Andrey Kurilin","email":"akurilin@mirantis.com","date":"2015-02-11 16:27:01.000000000","tz":180},"subject":"Remove versioning import of novaclient","message":"Remove versioning import of novaclient\n\nnovaclient has specific function novaclient.client.get_client_class for\nobtaining client class. This fuction should be used instead of custom\nopemstackclient.common.get_client_class, because several reasons:\n - latest novaclient is not have novaclient.v1_1.client.Client class\n   (see https://review.openstack.org/#/c/149006/ for more details)\n - some api microversioning stuff will be implemented there\n\nAlso, since contrib path dependends on version, we should get it based on\nversioned client class or object.\n\nChange-Id: I97fc9dab97d549093cabd965cab0736b2c748084\nCloses-Bug: #1418024\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0cadc68e3b120baeb3507923d6fa3fb990d82f19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0cadc68e3b120baeb3507923d6fa3fb990d82f19"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}