)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"689e01fe9d42c39ea353e92d3822467a6d61b55c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Include direction users pass in the error msg to help users know"},{"line_number":10,"context_line":"which part of the argument is troublesome."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I796a85fbf40f6ddf544fb52a61f967e1914abdcc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_ca451144","line":11,"updated":"2015-02-11 06:48:14.000000000","message":"report a bug for this change?","commit_id":"e7acad258d4bdda3ce61cb94b174f2a022b2201a"},{"author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"change_message_id":"a5cde9ef374165ddba2dbbcaa40f601ce6d1512b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Include direction users pass in the error msg to help users know"},{"line_number":10,"context_line":"which part of the argument is troublesome."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I796a85fbf40f6ddf544fb52a61f967e1914abdcc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da86d52c_04eb9513","line":11,"in_reply_to":"da86d52c_ca451144","updated":"2015-02-11 12:37:54.000000000","message":"done, have registered one.","commit_id":"e7acad258d4bdda3ce61cb94b174f2a022b2201a"}],"openstackclient/common/utils.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"6ab3d2ce4ceab9ed720ac15b073ffe8a45794f81","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            sort_key, direction \u003d sort_key.split(\u0027:\u0027, 1)"},{"line_number":203,"context_line":"            if direction not in [\u0027asc\u0027, \u0027desc\u0027]:"},{"line_number":204,"context_line":"                if not direction:"},{"line_number":205,"context_line":"                    direction \u003d \"empty string\""},{"line_number":206,"context_line":"                msg \u003d (\"%s is not a valid sort direction, \""},{"line_number":207,"context_line":"                       \"use asc or desc instead\" % direction)"},{"line_number":208,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_f63d6990","line":205,"updated":"2015-02-11 03:05:26.000000000","message":"It is kind of odd that the command line arg says default is asc, but we don\u0027t honor that here.  Is there something I\u0027m missing?","commit_id":"e7acad258d4bdda3ce61cb94b174f2a022b2201a"},{"author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"change_message_id":"8fea6a9c894866005ea3a9add049bd20b82803dc","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            sort_key, direction \u003d sort_key.split(\u0027:\u0027, 1)"},{"line_number":203,"context_line":"            if direction not in [\u0027asc\u0027, \u0027desc\u0027]:"},{"line_number":204,"context_line":"                if not direction:"},{"line_number":205,"context_line":"                    direction \u003d \"empty string\""},{"line_number":206,"context_line":"                msg \u003d (\"%s is not a valid sort direction, \""},{"line_number":207,"context_line":"                       \"use asc or desc instead\" % direction)"},{"line_number":208,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_518abfbf","line":205,"in_reply_to":"da86d52c_f63d6990","updated":"2015-02-11 04:10:52.000000000","message":"This check is for argument \"--sort key:\" which leaves a colon without direction. If users pass \"--sort key\", it\u0027s fine and the default direction will be used.","commit_id":"e7acad258d4bdda3ce61cb94b174f2a022b2201a"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"689e01fe9d42c39ea353e92d3822467a6d61b55c","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                if not direction:"},{"line_number":205,"context_line":"                    direction \u003d \"empty string\""},{"line_number":206,"context_line":"                msg \u003d (\"%s is not a valid sort direction, \""},{"line_number":207,"context_line":"                       \"use asc or desc instead\" % direction)"},{"line_number":208,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":209,"context_line":"            if direction \u003d\u003d \u0027desc\u0027:"},{"line_number":210,"context_line":"                reverse \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_ca2ef18b","line":207,"updated":"2015-02-11 06:48:14.000000000","message":"Maybe mention which sort_key has the wrong direction would be helpful too.","commit_id":"e7acad258d4bdda3ce61cb94b174f2a022b2201a"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4a227069576431ae1b2a9519efe1a10d336fe7a8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            sort_key, direction \u003d sort_key.split(\u0027:\u0027, 1)"},{"line_number":203,"context_line":"            if not sort_key:"},{"line_number":204,"context_line":"                msg \u003d \"empty string is not a valid sort key\""},{"line_number":205,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":206,"context_line":"            if direction not in [\u0027asc\u0027, \u0027desc\u0027]:"},{"line_number":207,"context_line":"                if not direction:"},{"line_number":208,"context_line":"                    direction \u003d \"empty string\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da86d52c_8d287834","line":205,"updated":"2015-02-11 17:35:34.000000000","message":"nice catch","commit_id":"d13023b32a990241a4a0ebb7fb2dab5391c003e3"}]}