)]}'
{"openstackclient/identity/v3/catalog.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"228aacc52b2667cdb66ecc0b02ae637e769d74d1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\"\"\"Identity v3 Service Catalog action implementations\"\"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cliff import lister"},{"line_number":20,"context_line":"from cliff import show"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_287cf082","line":17,"updated":"2015-03-06 19:13:19.000000000","message":"nit: six is a third party lib, it should go with the 2nd group of imports","commit_id":"ea6ab54b1719d2c2d84938b679fa166158050343"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4a7adf59bc5c0e41cab68e5524c7139a690ac5b1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\"\"\"Identity v3 Service Catalog action implementations\"\"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from cliff import lister"},{"line_number":20,"context_line":"from cliff import show"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_5319d0d5","line":17,"in_reply_to":"9a80dd14_287cf082","updated":"2015-03-06 23:29:20.000000000","message":"only in py2","commit_id":"ea6ab54b1719d2c2d84938b679fa166158050343"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"228aacc52b2667cdb66ecc0b02ae637e769d74d1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            if (service.get(\u0027name\u0027) \u003d\u003d parsed_args.service or"},{"line_number":88,"context_line":"                    service.get(\u0027type\u0027) \u003d\u003d parsed_args.service):"},{"line_number":89,"context_line":"                data \u003d service"},{"line_number":90,"context_line":"                data[\u0027endpoints\u0027] \u003d _format_endpoints(data[\u0027endpoints\u0027])"},{"line_number":91,"context_line":"                if \u0027links\u0027 in data:"},{"line_number":92,"context_line":"                    data.pop(\u0027links\u0027)"},{"line_number":93,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_e81578e5","line":90,"updated":"2015-03-06 19:13:19.000000000","message":"not sure about this, but do this modify the data in the service_catalog?","commit_id":"ea6ab54b1719d2c2d84938b679fa166158050343"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4a7adf59bc5c0e41cab68e5524c7139a690ac5b1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            if (service.get(\u0027name\u0027) \u003d\u003d parsed_args.service or"},{"line_number":88,"context_line":"                    service.get(\u0027type\u0027) \u003d\u003d parsed_args.service):"},{"line_number":89,"context_line":"                data \u003d service"},{"line_number":90,"context_line":"                data[\u0027endpoints\u0027] \u003d _format_endpoints(data[\u0027endpoints\u0027])"},{"line_number":91,"context_line":"                if \u0027links\u0027 in data:"},{"line_number":92,"context_line":"                    data.pop(\u0027links\u0027)"},{"line_number":93,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_f31d64bf","line":90,"in_reply_to":"9a80dd14_e81578e5","updated":"2015-03-06 23:29:20.000000000","message":"no, data is locally declared on line 85","commit_id":"ea6ab54b1719d2c2d84938b679fa166158050343"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"d1c13d861ba65623c3030f17b12e13d5975afb31","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            if (service.get(\u0027name\u0027) \u003d\u003d parsed_args.service or"},{"line_number":88,"context_line":"                    service.get(\u0027type\u0027) \u003d\u003d parsed_args.service):"},{"line_number":89,"context_line":"                data \u003d service"},{"line_number":90,"context_line":"                data[\u0027endpoints\u0027] \u003d _format_endpoints(data[\u0027endpoints\u0027])"},{"line_number":91,"context_line":"                if \u0027links\u0027 in data:"},{"line_number":92,"context_line":"                    data.pop(\u0027links\u0027)"},{"line_number":93,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_bc0d7940","line":90,"in_reply_to":"9a80dd14_f31d64bf","updated":"2015-03-06 23:31:49.000000000","message":"but isn\u0027t \"data\" a reference to service and not a copy of it?","commit_id":"ea6ab54b1719d2c2d84938b679fa166158050343"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"228aacc52b2667cdb66ecc0b02ae637e769d74d1","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                data \u003d service"},{"line_number":90,"context_line":"                data[\u0027endpoints\u0027] \u003d _format_endpoints(data[\u0027endpoints\u0027])"},{"line_number":91,"context_line":"                if \u0027links\u0027 in data:"},{"line_number":92,"context_line":"                    data.pop(\u0027links\u0027)"},{"line_number":93,"context_line":"                break"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if not data:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_48af647d","line":92,"updated":"2015-03-06 19:13:19.000000000","message":"and this too","commit_id":"ea6ab54b1719d2c2d84938b679fa166158050343"}]}